review-followup Wave 3 라운드 3(P19): 3-D 공통 유틸 — Sha256·HmacSha256·Backoff·MdcKeys·TenantId, caller 트랜잭션 guard 하나
- shared-contract `Sha256`(약 65벌 흡수, notification `MessageDigestPort` 삭제), `HmacSha256`(서명 헬퍼), `Backoff`("full jitter" 뜻 하나),
`MdcKeys`(gRPC·STOMP에도 상관관계), registry edge application-notification → shared-contract
- application-core `TenantId` 하나로 web·GraphQL tenant 문법 통일, web operation 경로에 tenant 해석(JWT `tenant_id`)
- persistence-jpa `CallerTransaction` 하나(복사본 4벌 + `JpaStreamScope` 흡수), 범위 없는 멱등성·outbox 리포지토리 메서드 제거(E-6b)
- 주입된 `Clock` 우회 제거(objectstorage·websocket·mongo·web stream), GraphQL 오류가 HTTP request id 사용, notification UUIDv7은 uuid-creator
- 호출처 없는 `WebRequestContext`·argument resolver 삭제
- 결함 수정: `WebStreamRegistry` 상한 경합(ORCH-new-3 — bin 하나만 잠그는 lock 안에서 크기 확인, 원자 카운터로 슬롯 예약)
- 현황표: 소유자 결정 33(persistence-notification·fileserver → persistence-jpa edge), 34(id 포트 domain 전환 보류), 35(X2-P2-6b 나머지 보류)
검증: ./gradlew check architectureCheck verifyDependencyLocks verifyPublicPathSnapshot :app-bootstrap:verifyEnvKeys configContractCheck
:app-bootstrap:integrationTest :sample-portfolio:integrationTest :sample-portfolio:systemTest graphql·websocket systemTest
persistence-jpa jpaPlatformContractTest·postgresql{Idempotency,Outbox*}IntegrationTest --continue 통과(695 task)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
4f4bd1fd34
commit
09e2dd63d6
@@ -13,6 +13,7 @@ com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.21.5=runtimeClasspath,t
|
||||
com.fasterxml.jackson:jackson-bom:2.21.5=runtimeClasspath,testRuntimeClasspath
|
||||
com.fasterxml:classmate:1.7.3=runtimeClasspath,testRuntimeClasspath
|
||||
com.github.ben-manes.caffeine:caffeine:3.2.4=annotationProcessor,testAnnotationProcessor
|
||||
com.github.f4b6a3:uuid-creator:6.1.1=runtimeClasspath,testRuntimeClasspath
|
||||
com.github.kevinstern:software-and-algorithms:1.0=annotationProcessor,testAnnotationProcessor
|
||||
com.github.spotbugs:spotbugs-annotations:4.10.2=spotbugs
|
||||
com.github.spotbugs:spotbugs:4.10.2=spotbugs
|
||||
|
||||
-3
@@ -18,7 +18,6 @@ import dev.caskeleton.application.notification.platform.dispatch.DeliveryAttempt
|
||||
import dev.caskeleton.application.notification.platform.dispatch.DispatchOutcomeRecorder;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.DispatchPipeline;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.LeaseRecoveryService;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.MessageDigestPort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationDispatchService;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationIdGeneratorPort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationRequestStorePort;
|
||||
@@ -161,7 +160,6 @@ class NotificationDeliveryConfiguration {
|
||||
NotificationAuditPort audit,
|
||||
TransactionPort transactions,
|
||||
NotificationIdGeneratorPort ids,
|
||||
MessageDigestPort digests,
|
||||
Clock clock) {
|
||||
return new NotificationAdminApplicationService(
|
||||
authorization,
|
||||
@@ -175,7 +173,6 @@ class NotificationDeliveryConfiguration {
|
||||
audit,
|
||||
transactions,
|
||||
ids,
|
||||
digests,
|
||||
clock);
|
||||
}
|
||||
}
|
||||
|
||||
+5
-6
@@ -6,13 +6,12 @@ import dev.caskeleton.application.notification.platform.dispatch.CanonicalNotifi
|
||||
import dev.caskeleton.application.notification.platform.dispatch.ContactPointStorePort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.DeliveryAttemptStorePort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.GetNotificationApplicationUseCase;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.MessageDigestPort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationIdGeneratorPort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationRequestStorePort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.NotificationSubmissionService;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.PlanFingerprint;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.PublishNotificationTemplateApplicationUseCase;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.RecipientDeliveryStorePort;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.RequestFingerprint;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.ScheduleNotificationApplicationUseCase;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.SubmitNotificationApplicationUseCase;
|
||||
import dev.caskeleton.application.notification.platform.dispatch.TenantContextPort;
|
||||
@@ -49,7 +48,7 @@ class NotificationSubmissionConfiguration {
|
||||
RecipientDeliveryStorePort recipients,
|
||||
DeliveryAttemptStorePort attempts,
|
||||
TemplateRegistry templates,
|
||||
RequestFingerprint fingerprints,
|
||||
PlanFingerprint fingerprints,
|
||||
CanonicalNotificationPlanWriter writer,
|
||||
TransactionPort transactions,
|
||||
TenantContextPort tenants,
|
||||
@@ -86,7 +85,7 @@ class NotificationSubmissionConfiguration {
|
||||
ContactPointProtector protector,
|
||||
TenantContextPort tenants,
|
||||
NotificationIdGeneratorPort ids,
|
||||
RequestFingerprint fingerprints,
|
||||
PlanFingerprint fingerprints,
|
||||
TransactionPort transactions,
|
||||
Clock clock,
|
||||
@Value("${ca-skeleton.notification.platform.default-locale:ko-KR}") String defaultLocale) {
|
||||
@@ -111,8 +110,8 @@ class NotificationSubmissionConfiguration {
|
||||
*/
|
||||
@Bean
|
||||
PublishNotificationTemplateUseCase publishNotificationTemplateUseCase(
|
||||
TemplateRegistry templates, MessageDigestPort digests, TransactionPort transactions) {
|
||||
return new PublishNotificationTemplateApplicationUseCase(templates, digests, transactions);
|
||||
TemplateRegistry templates, TransactionPort transactions) {
|
||||
return new PublishNotificationTemplateApplicationUseCase(templates, transactions);
|
||||
}
|
||||
|
||||
@Bean
|
||||
|
||||
Reference in New Issue
Block a user