From 0adb826f0fa774ff6dd62eba24ea325f38906236 Mon Sep 17 00:00:00 2001 From: donghyeon-ka Date: Thu, 12 Nov 2026 02:36:37 +0900 Subject: [PATCH] =?UTF-8?q?chore(format):=20spotless=20=ED=8F=AC=EB=A7=B7?= =?UTF-8?q?=EC=9D=84=20=EB=B0=94=EB=80=90=20=EC=9E=90=EB=B0=94=20=ED=8C=8C?= =?UTF-8?q?=EC=9D=BC=EC=97=90=20=EC=A0=81=EC=9A=A9=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #12의 액추에이터·fileserver·web-advanced 수정 커밋이 긴 주석과 assertion 메시지에 포맷 드리프트를 남겨, runner pr / gradle의 :app-bootstrap:spotlessJavaCheck가 깨졌다. 모듈 시험만 돌리고 포맷 게이트(spotlessCheck)를 건너뛴 탓이다. ./gradlew spotlessApply로 바뀐 3개 파일만 재포맷했다. 이미 push된 커밋이라 force push 금지 → squash 대신 새 커밋으로 올린다. 위험·한계: 포맷만 바뀐다(긴 줄의 줄바꿈). 동작·의미 변화 없음. 검증: spotlessCheck rc=0. 바뀐 3개 모듈 시험 재실행 — ManagementActuatorSecurityContractTest·FileserverAdminControllerRequestBodyValidationTest·WebCodecMapperTest BUILD SUCCESSFUL (1m8s). --- .../web/advanced/codec/WebXmlMapperFactory.java | 15 ++++++++++----- ...rAdminControllerRequestBodyValidationTest.java | 10 +++++----- .../ManagementActuatorSecurityContractTest.java | 12 ++++++++---- 3 files changed, 23 insertions(+), 14 deletions(-) diff --git a/src/adapter/inbound/web-advanced/src/main/java/dev/caskeleton/adapter/inbound/web/advanced/codec/WebXmlMapperFactory.java b/src/adapter/inbound/web-advanced/src/main/java/dev/caskeleton/adapter/inbound/web/advanced/codec/WebXmlMapperFactory.java index f53b752f..8b2c3d68 100644 --- a/src/adapter/inbound/web-advanced/src/main/java/dev/caskeleton/adapter/inbound/web/advanced/codec/WebXmlMapperFactory.java +++ b/src/adapter/inbound/web-advanced/src/main/java/dev/caskeleton/adapter/inbound/web/advanced/codec/WebXmlMapperFactory.java @@ -77,14 +77,19 @@ public final class WebXmlMapperFactory { return XmlMapper.builder(factory) .enable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES) .disable(MapperFeature.ALLOW_COERCION_OF_SCALARS) - // Deliberately NOT the CBOR mapper's withCoercionConfig(String->Fail, Textual Integer->Fail). + // Deliberately NOT the CBOR mapper's withCoercionConfig(String->Fail, Textual + // Integer->Fail). // XML is a textual format: every scalar — a numeric or boolean DTO field included — arrives - // as a String token (5). Forbidding String-shaped input there would reject all - // numeric/boolean binding, and WebCodecMapperTest.xmlRoundTripPreservesWireTypes (which binds + // as a String token (5). Forbidding String-shaped input there would reject + // all + // numeric/boolean binding, and WebCodecMapperTest.xmlRoundTripPreservesWireTypes (which + // binds // `int count`) pins exactly that. The parity a reader might expect with the CBOR profile is - // not a strictness bypass: FAIL_ON_UNKNOWN_PROPERTIES and the SecureXmlInputFactory hardening + // not a strictness bypass: FAIL_ON_UNKNOWN_PROPERTIES and the SecureXmlInputFactory + // hardening // apply here too, @Valid constraints run post-binding on every representation, and binding - // "5"->int is XML's normal semantics, not the type confusion the CBOR lockdown guards against. + // "5"->int is XML's normal semantics, not the type confusion the CBOR lockdown guards + // against. // (W4 red team BE-INPUT-001: the divergence is by design, not an omission.) .build(); } diff --git a/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java b/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java index af9ac0fb..55382dd8 100644 --- a/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java +++ b/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java @@ -15,11 +15,11 @@ import org.springframework.web.bind.annotation.RequestBody; * {@code @Valid}. * *

{@code reconcileOrphans} shipped a {@code @RequestBody} without {@code @Valid}, unlike every - * sibling handler (relocate/force-delete/…). Harmless today because {@code OrphanReconcileHttpRequest} - * declares no Bean Validation constraints — but the moment one is added (a {@code @Min} on the limit, - * a {@code @NotBlank} on the reason), it would be silently ignored, exactly the validation-bypass - * class this template otherwise guards against. This pins the convention for the whole admin plane so - * the gap cannot reopen. + * sibling handler (relocate/force-delete/…). Harmless today because {@code + * OrphanReconcileHttpRequest} declares no Bean Validation constraints — but the moment one is added + * (a {@code @Min} on the limit, a {@code @NotBlank} on the reason), it would be silently ignored, + * exactly the validation-bypass class this template otherwise guards against. This pins the + * convention for the whole admin plane so the gap cannot reopen. */ class FileserverAdminControllerRequestBodyValidationTest { diff --git a/src/bootstrap/app/src/test/java/dev/caskeleton/bootstrap/contract/ManagementActuatorSecurityContractTest.java b/src/bootstrap/app/src/test/java/dev/caskeleton/bootstrap/contract/ManagementActuatorSecurityContractTest.java index d19d0f47..723b8a55 100644 --- a/src/bootstrap/app/src/test/java/dev/caskeleton/bootstrap/contract/ManagementActuatorSecurityContractTest.java +++ b/src/bootstrap/app/src/test/java/dev/caskeleton/bootstrap/contract/ManagementActuatorSecurityContractTest.java @@ -234,20 +234,24 @@ class ManagementActuatorSecurityContractTest { Object address = nested(mgmt, "server", "address"); assertThat(address) - .as("application.yml must pin management.server.address — unset binds all interfaces " - + "(BE-CONFIG-001): health/prometheus/info reachable unauthenticated off-loopback") + .as( + "application.yml must pin management.server.address — unset binds all interfaces " + + "(BE-CONFIG-001): health/prometheus/info reachable unauthenticated off-loopback") .isNotNull(); // Keep it env-driven (${MANAGEMENT_SERVER_ADDRESS:}) so a remote-scrape deployment can // opt in, and require the shipped DEFAULT to be a loopback address. String expr = String.valueOf(address); assertThat(expr) - .as("management.server.address must stay env-driven ${MANAGEMENT_SERVER_ADDRESS:}") + .as( + "management.server.address must stay env-driven ${MANAGEMENT_SERVER_ADDRESS:}") .startsWith("${MANAGEMENT_SERVER_ADDRESS:") .endsWith("}"); String defaultValue = expr.substring(expr.indexOf(':') + 1, expr.length() - 1); assertThat(InetAddress.getByName(defaultValue).isLoopbackAddress()) - .as("management.server.address default must be a loopback address, but was: " + defaultValue) + .as( + "management.server.address default must be a loopback address, but was: " + + defaultValue) .isTrue(); }