review-followup Wave 3 라운드 1(P16): 빌드 게이트 정리 — JPA evidence manifest 폐기, build-tools 제거, API surface를 leaf check로
- 결정 4: JPA evidence·qualification manifest 폐기 → persistence-jpa 테스트, build-tools included build 비움(verifyEnvKeys는 app-bootstrap 태스크, 구현은 build-logic `ca.config-contract`), gRPC release gate 삭제 - 결정 20: API surface 검사를 leaf `check`로, JPA adopter 검사를 `ca.api-surface`로 합침(구현 하나) - 레인 단계 정리(문서 대조 레인은 `mainStage()`), integrationCheck가 입력 없는 레인을 이름과 함께 제외 → 로컬 통과(NEW-16) - release workflow 통합, releaseCheck는 tag 전용, build-logic 비핵심 플러그인 정리, sample을 ArchUnit 대상에 - 보류 4행(B3 변경 모듈만 실행, C 이미지 서명, messaging 카드 검증 이동 2행 — 결정 필요), 남음 2행(O3-5 나머지) - 통합: P17이 옮긴 gRPC release gate 사본 삭제, `grpc-proto-buf`를 release-gate needs에(P17-new-3) 검증: ./gradlew ci verifyDependencyLocks --warning-mode=fail 통과(685 task), mainCheck 통과(268 task), -p optional-platforms ci 통과, -p build-logic test 78건 통과(손상된 TestKit 캐시 삭제 후) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
4fb7943b85
commit
0ed7bc8df7
@@ -57,3 +57,16 @@ dependencies {
|
||||
dependencies {
|
||||
testImplementation libs.archunit.junit5
|
||||
}
|
||||
|
||||
// FileserverDocumentationCoverageTest reads the fileserver documents, the workflows that define the
|
||||
// support-matrix jobs and the fileserver transport sources. They are inputs of `test`, or Gradle
|
||||
// would call it up to date after an edit to any of them — which is the edit it exists to catch.
|
||||
def repositoryRoot = rootProject.projectDir.parentFile
|
||||
tasks.named('test') {
|
||||
inputs.dir(new File(repositoryRoot, 'docs/fileserver')).withPropertyName('fileserverDocuments')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
inputs.dir(new File(repositoryRoot, '.github/workflows')).withPropertyName('workflows')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
inputs.dir(rootProject.file('adapter/inbound/web-fileserver/src/main/java')).withPropertyName('transportSources')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
}
|
||||
|
||||
+10
-2
@@ -209,13 +209,21 @@ class FileserverDocumentationCoverageTest {
|
||||
return jobs;
|
||||
}
|
||||
|
||||
/** Job identifiers across every fileserver workflow, read from the two-space indent level. */
|
||||
/**
|
||||
* Job identifiers across every fileserver workflow and the release workflow (which holds the
|
||||
* certification jobs since review BUILD-계획-B2), read from the two-space indent level.
|
||||
*/
|
||||
private static List<String> definedWorkflowJobs() throws IOException {
|
||||
List<String> jobs = new ArrayList<>();
|
||||
Path workflows = repositoryRoot().resolve(".github/workflows");
|
||||
try (Stream<Path> files = Files.list(workflows)) {
|
||||
for (Path file :
|
||||
files.filter(path -> path.getFileName().toString().startsWith("fileserver-")).toList()) {
|
||||
files
|
||||
.filter(
|
||||
path ->
|
||||
path.getFileName().toString().startsWith("fileserver-")
|
||||
|| path.getFileName().toString().equals("release.yml"))
|
||||
.toList()) {
|
||||
for (String line : Files.readAllLines(file)) {
|
||||
Matcher matcher = WORKFLOW_JOB.matcher(line);
|
||||
if (matcher.matches()) {
|
||||
|
||||
@@ -28,8 +28,14 @@ dependencies {
|
||||
testImplementation project(':adapter:outbound:support')
|
||||
}
|
||||
|
||||
// NotificationEnvironmentRegistryTest compares the shipped settings with the environment registry.
|
||||
tasks.named('test') {
|
||||
inputs.file(new File(rootProject.projectDir.parentFile, 'docs/registries/env-keys.yaml'))
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
// NotificationEnvironmentRegistryTest compares the shipped settings with the environment registry
|
||||
// (docs/registries/env-keys.yaml). A comparison with a repository document, so it runs in this
|
||||
// module's `mainCheck`, not in the pull-request `test` (review 2026-09-24 BUILD-계획-B4-28).
|
||||
strictTestLanes {
|
||||
lane('notificationEnvironmentContractTest') {
|
||||
tag = 'document-contract'
|
||||
description = 'Holds the notification settings to docs/registries/env-keys.yaml.'
|
||||
rejectSkipped = true
|
||||
mainStage()
|
||||
}
|
||||
}
|
||||
|
||||
+2
@@ -10,6 +10,7 @@ import java.util.TreeSet;
|
||||
import java.util.regex.Matcher;
|
||||
import java.util.regex.Pattern;
|
||||
import java.util.stream.Stream;
|
||||
import org.junit.jupiter.api.Tag;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
/**
|
||||
@@ -18,6 +19,7 @@ import org.junit.jupiter.api.Test;
|
||||
* registry lacks is a deployment input nobody documented. The build declares the registry as an
|
||||
* input of {@code test}; the shipped settings are already on the test classpath.
|
||||
*/
|
||||
@Tag("document-contract")
|
||||
class NotificationEnvironmentRegistryTest {
|
||||
|
||||
private static final Path MODULE_DEFAULTS = Path.of("src/main/resources/config/module-defaults");
|
||||
|
||||
Reference in New Issue
Block a user