From 140530607066a4443b28c58bce9401f106cf774a Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 01:32:11 +0900 Subject: [PATCH] =?UTF-8?q?fix(httpclient):=20HTTP/2=20=ED=98=91=EC=83=81?= =?UTF-8?q?=20=EC=8B=9C=ED=97=98=EC=9D=B4=20=EA=B3=B5=EC=9A=A9=20=ED=94=84?= =?UTF-8?q?=EB=A1=9C=ED=95=84=EC=9D=98=20=EC=A7=A7=EC=9D=80=20=EC=97=B0?= =?UTF-8?q?=EA=B2=B0=20=EC=A0=9C=ED=95=9C=EC=97=90=20=EA=B1=B8=EB=A6=AC?= =?UTF-8?q?=EC=A7=80=20=EC=95=8A=EB=8A=94=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제: NegotiatedProtocolContractTest의 JDK transport 시험 둘은 공용 시험 프로필 (연결 500ms, TLS 핸드셰이크 1s)을 그대로 쓴다. 부하가 높을 때 TLS 핸드셰이크와 ALPN이 그 안에 끝나지 않아 HttpConnectTimeoutException으로 실패한다. main push run 93(2026-11-11, spring70CompatibilityTest lane)과 desktop(부하 18~24, 2026-11-08)에서 봤다. 이 시험이 보는 것은 협상된 프로토콜이지 시간 예산이 아니다. 고른 방법: 두 시험만 넉넉한 TimeoutSettings(연결·핸드셰이크·헤더·유휴 10s, 전체 30s)를 쓴다. DNS 값은 플랫폼이 받는 유일한 값인 기본값으로 둔다. 시간 제한을 보는 다른 시험은 공용 프로필 그대로다. 위험·한계: 공용 프로필을 쓰는 다른 실서버 시험도 같은 부하에서 걸릴 수 있다. 관측된 것은 이 시험뿐이라 이것만 고쳤다. 검증: desktop mainCheck, runner main 수동 실행. --- .../NegotiatedProtocolContractTest.java | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/adapter/outbound/httpclient/src/test/java/dev/caskeleton/adapter/outbound/httpclient/contract/NegotiatedProtocolContractTest.java b/src/adapter/outbound/httpclient/src/test/java/dev/caskeleton/adapter/outbound/httpclient/contract/NegotiatedProtocolContractTest.java index 804e6db0..957cde6d 100644 --- a/src/adapter/outbound/httpclient/src/test/java/dev/caskeleton/adapter/outbound/httpclient/contract/NegotiatedProtocolContractTest.java +++ b/src/adapter/outbound/httpclient/src/test/java/dev/caskeleton/adapter/outbound/httpclient/contract/NegotiatedProtocolContractTest.java @@ -8,6 +8,7 @@ import dev.caskeleton.adapter.outbound.httpclient.api.error.HttpConfigurationExc import dev.caskeleton.adapter.outbound.httpclient.jdk.JdkClientFactory; import dev.caskeleton.adapter.outbound.httpclient.profile.ClientProfile; import dev.caskeleton.adapter.outbound.httpclient.profile.HttpProtocol; +import dev.caskeleton.adapter.outbound.httpclient.profile.TimeoutSettings; import dev.caskeleton.adapter.outbound.httpclient.profile.TransportType; import dev.caskeleton.adapter.outbound.httpclient.testkit.ClientProfiles; import dev.caskeleton.adapter.outbound.httpclient.testkit.MockHttpServer; @@ -17,6 +18,7 @@ import dev.caskeleton.adapter.outbound.httpclient.transport.TransportCapabilityV import java.net.http.HttpClient; import java.net.http.HttpRequest; import java.net.http.HttpResponse; +import java.time.Duration; import java.util.Optional; import java.util.Set; import org.junit.jupiter.api.Tag; @@ -36,6 +38,19 @@ import org.junit.jupiter.api.Test; @Tag("httpclient-contract") class NegotiatedProtocolContractTest { + // What these tests measure is the protocol, not a budget. The shared fixture profile allows + // 500 ms to connect and 1 s for the handshake, which a loaded CI runner missed (connect timeout, + // main push 2026-11-11; the desktop too under load 18-24 on 2026-11-08). The DNS budget stays + // the shipped default, the only value the platform accepts for it. + private static final TimeoutSettings OUT_OF_THE_WAY = + new TimeoutSettings( + TimeoutSettings.DEFAULT_DNS, + Duration.ofSeconds(10), + Duration.ofSeconds(10), + Duration.ofSeconds(10), + Duration.ofSeconds(10), + Duration.ofSeconds(30)); + @Test void theJdkTransportNegotiatesHttp2WhenTheProfileAsksForIt() throws Exception { TlsFixture fixture = TlsFixture.trusted(); @@ -44,6 +59,7 @@ class NegotiatedProtocolContractTest { ClientProfile profile = ClientProfiles.builder("h2") .baseUrl(server.uri("/")) + .timeout(OUT_OF_THE_WAY) .transport(TransportType.JDK) .protocols(Set.of(HttpProtocol.HTTP_2, HttpProtocol.HTTP_1_1)) .build(); @@ -70,6 +86,7 @@ class NegotiatedProtocolContractTest { ClientProfile profile = ClientProfiles.builder("h1") .baseUrl(server.uri("/")) + .timeout(OUT_OF_THE_WAY) .transport(TransportType.JDK) .protocols(Set.of(HttpProtocol.HTTP_1_1)) .build();