review-followup Wave 3: 설정 prefix app.* 통일(P20), Wave 3 종료
- 결정 16: `ca-skeleton.*`·`backend.graphql` 등 → `app.*`(APP_* env 키 이름 유지), selector 키 상수 하나(`CapabilitySelectors`), 바인딩만 되던 `streaming-idle` 삭제 - `StrictSettingsBinder`가 env 오타까지 거부 — 모든 capability(graphql·websocket·mongo는 edge 제약으로 파일만 strict), httpclient 리플렉션 `HttpClientEnvironmentKeys` 삭제 - persistence-jpa가 `APP_DATASOURCE_PASSWORD` secret 요구를 기여(bootstrap이 JPA 스위치를 읽지 않음), Redis ACL fixture에서 pub/sub 권한 제거 - 결함 수정: SMTP 설정 env 이름 충돌(P20-new-1), `bindExcept`가 system env까지 filter(P20-new-2), graphql 빈 deployment-mode 메시지(P20-new-6) - 통합: P30과 충돌 11건(P30의 명시적 bean 구조 유지), P30 코드의 옛 키를 app.*로, persistence-jpa 포맷 - 현황표: 소유자 결정 36(persistence-jpa 설정은 플랫폼 키만 app.persistence-jpa.*로, 공유 기능 트리 예외), 재개 문서에 일시 정지 상태 Wave 3 종료 검증: check · ci verifyDependencyLocks --warning-mode=fail(714 task) · mainCheck · architectureCheck verifyPublicPathSnapshot :app-bootstrap:verifyEnvKeys configContractCheck · :app-bootstrap:integrationTest :sample-portfolio:integrationTest :sample-portfolio:systemTest · integrationCheck · -p build-logic test · -p optional-platforms ci · :app-bootstrap:qualificationBootJar releaseCheck 통과 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
8bbf1bf01d
commit
27f23add08
@@ -12,9 +12,9 @@ nothing happens until service code calls it.
|
||||
|
||||
| Capability | How it is turned on | What it adds | Tests |
|
||||
| --- | --- | --- | --- |
|
||||
| MVC virtual threads | `backend.web.advanced.mvc-virtual-threads.enabled=true` (+ admission limit and budgets) | A different scheduling model for **every** request | `MvcAdvancedConfigurationTest`, `VirtualThreadAdmissionTest` |
|
||||
| NDJSON streaming | `backend.web.advanced.ndjson.enabled=true` | Long-lived connections | `MvcStreamingWiringTest`, `WebStreamCoreTest`, `WebStreamDrainTest`, `WebStreamingSoakIT` |
|
||||
| JSON text sequences (RFC 7464) | `backend.web.advanced.json-sequence.enabled=true` | Long-lived connections | as NDJSON |
|
||||
| MVC virtual threads | `app.web.advanced.mvc-virtual-threads.enabled=true` (+ admission limit and budgets) | A different scheduling model for **every** request | `MvcAdvancedConfigurationTest`, `VirtualThreadAdmissionTest` |
|
||||
| NDJSON streaming | `app.web.advanced.ndjson.enabled=true` | Long-lived connections | `MvcStreamingWiringTest`, `WebStreamCoreTest`, `WebStreamDrainTest`, `WebStreamingSoakIT` |
|
||||
| JSON text sequences (RFC 7464) | `app.web.advanced.json-sequence.enabled=true` | Long-lived connections | as NDJSON |
|
||||
| JSON Merge Patch (RFC 7396) | library — `JsonMergePatchApplier` | Partial documents | `JsonMergePatchApplierTest` |
|
||||
| JSON Patch (RFC 6902) | library — `JsonPatchApplier` | Arbitrary pointers | `JsonPatchApplierTest` |
|
||||
| CBOR / XML codecs | library — `WebCborMapperFactory`, `WebXmlMapperFactory`; the backend jar is the service's choice | A second decoder | `WebCodecMapperTest`, `WebCodecSecurityTest` |
|
||||
|
||||
@@ -80,7 +80,7 @@ equivalents in `application-core/idempotency` — `IdempotencyStorePort`, `Idemp
|
||||
`IdempotencyScopeDigest` and `RequestFingerprint` — with two provider stores behind the port:
|
||||
PostgreSQL (`PostgreSqlIdempotencyStore` in `persistence-jpa`) and Redis
|
||||
(`RedisIdempotencyStoreAdapter` in `cache-redis`), selected by
|
||||
`ca-skeleton.capabilities.idempotency.provider`. That is what the design's Tasks 39 and 40 ask for,
|
||||
`app.capabilities.idempotency.provider`. That is what the design's Tasks 39 and 40 ask for,
|
||||
built in the direction the registry permits.
|
||||
|
||||
Implementing the design's SPI literally would have required
|
||||
@@ -141,7 +141,7 @@ answers in the `Envelope` contract, and a caller's operation that is not theirs
|
||||
(`OPERATION_NOT_FOUND`) as one that does not exist. The controller and the three use cases are
|
||||
assembled by `app-bootstrap` `autoconfigure/operation/DurableOperationConfig`, which turns on only
|
||||
when the operation store and the outbox append port exist (the JPA module with
|
||||
`ca-skeleton.outbox.enabled=true`). Submit and cancel need `operation:submit` / `operation:cancel`
|
||||
`app.outbox.enabled=true`). Submit and cancel need `operation:submit` / `operation:cancel`
|
||||
(`security.yml` grants both to the `operation-submit` role).
|
||||
|
||||
The state machine is enforced three times on purpose: in `DurableOperation`'s constructor, in the
|
||||
|
||||
+1
-1
@@ -65,7 +65,7 @@ is one series per resource.
|
||||
## Cross-origin requests fail only in the browser
|
||||
|
||||
The API answers correctly and the browser refuses the response. CORS is `CorsSettings`
|
||||
(`ca-skeleton.cors.*`) applied by `SecurityConfig`. Startup refuses two settings:
|
||||
(`app.cors.*`) applied by `SecurityConfig`. Startup refuses two settings:
|
||||
|
||||
- `APP_SECURITY_CORS_ENABLED=true` with no origin.
|
||||
- `*` in `APP_SECURITY_CORS_ORIGINS` with `APP_SECURITY_CORS_ALLOW_CREDENTIALS=true` — no browser
|
||||
|
||||
@@ -5,7 +5,7 @@ framing exists, but since the WebFlux twin was removed (2026-09-25) nothing on t
|
||||
writes it.
|
||||
|
||||
The writers ship in `adapter:inbound:web-advanced` (opt-in, switched by
|
||||
`backend.web.advanced.ndjson.enabled` / `backend.web.advanced.json-sequence.enabled`); no default
|
||||
`app.web.advanced.ndjson.enabled` / `app.web.advanced.json-sequence.enabled`); no default
|
||||
composition carries them.
|
||||
|
||||
## Three outcomes, not two
|
||||
|
||||
@@ -20,7 +20,7 @@ The profile ships in `adapter:inbound:web-advanced`, which no default compositio
|
||||
that leaf to the service, then two settings — the profile refuses to be constructed with only one:
|
||||
|
||||
```yaml
|
||||
backend:
|
||||
app:
|
||||
web:
|
||||
advanced:
|
||||
mvc-virtual-threads:
|
||||
|
||||
Reference in New Issue
Block a user