diff --git a/scripts/run-compose-runtime-smoke.sh b/scripts/run-compose-runtime-smoke.sh index 9d854e30..5c07ec0d 100755 --- a/scripts/run-compose-runtime-smoke.sh +++ b/scripts/run-compose-runtime-smoke.sh @@ -623,11 +623,22 @@ echo "running ${total} blocking lane(s), zero-skip" # script reported that all six had passed. A wrapper whose own success message is a false green is # worse than no wrapper, and nothing else here would have caught it: the count came from the # contract and the exit status from the one lane that did run. +# +# Each lane runs in a subshell with `set -e` on and its status read afterwards, never as an `if` +# condition. Bash ignores `set -e` for every command run as part of an `if` condition, functions and +# subshells included, so `if ( run_lane ... )` turned every step that relied on it into a step whose +# failure was ignored. The image build was one: a build that failed left the lane to start the +# previous run's image, and all eighteen lanes reported green on code the build had refused +# (2026-11-07). --lane mode calls run_lane directly and was not affected. RAN_LANES=0 while read -r -u 3 lane_json; do [[ -z "${lane_json}" ]] && continue RAN_LANES=$((RAN_LANES + 1)) - if ( trap cleanup_lane EXIT; run_lane "${lane_json}" ); then :; else + set +e + ( set -e; trap cleanup_lane EXIT; run_lane "${lane_json}" ) + lane_status=$? + set -e + if [[ ${lane_status} -ne 0 ]]; then FAILED_LANES+=("$(jq -r '.id' <<<"${lane_json}")") fi done 3<<<"${blocking}"