review-followup Wave 3 라운드 2(P18): outbox canonical 통일, composition 모듈, legacy Kafka seam 삭제

- 결정 7: `LegacyOutboxAppendPort`·legacy 저장 모델·relay·Kafka R0 seam 삭제, 템플릿 JSON encoder(`JsonIntegrationEventEncoder`),
  durable operation·sample 이벤트가 `OutboxAppendPort` + encoder로, persistence-jpa V19(pre-canonical 미발행 row 거부)
- 결정 3: outbox relay·멱등성 executor 조립을 `composition:outbox-relay`·`composition:idempotency`로,
  sample이 복사한 bootstrap 인프라를 `composition:service-runtime`으로(sample `SampleIdempotencyConfig` 복사본 삭제)
- persistence-jpa outbox·멱등성 패키지 feature 기준 이동, messaging outbox·inbox leaf를 reliability / reliability-jdbc-postgresql로
- messaging outbox header를 jsonb로(P18-new-1 — `\`로 끝나는 값이 다음 header를 삼키던 결함)
- 통합(충돌 22건): P25 A-10c(전략 선택 설정 삭제)를 service-runtime `DomainContextConfig`에 적용, P25 startup 예외 통합을
  composition 설정 테스트에, P25 `CommandUseCase.handle` 이름을 PG 통합 테스트에, P15 `EventJson`은 호출자 0이 되어 삭제
- root CLAUDE.md의 legacy seam 문장 수정(P18-new-2)

검증: ./gradlew check architectureCheck verifyDependencyLocks verifyPublicPathSnapshot :app-bootstrap:verifyEnvKeys
configContractCheck :app-bootstrap:integrationTest :sample-portfolio:integrationTest :sample-portfolio:systemTest
persistence-jpa jpaPlatformContractTest·postgresql{Idempotency,OutboxAppendTransactional,OutboxConcurrentRelay,OutboxRowLifecycle}IntegrationTest
:messaging:messaging-reliability-jdbc-postgresql:integrationTest --continue 통과(700 task)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
donghyeon-ka
2026-09-29 12:30:01 +09:00
co-authored by Claude Opus 5.5
parent 25de288ab4
commit 423a29c46f
329 changed files with 6380 additions and 6850 deletions
+24
View File
@@ -422,3 +422,27 @@ web 경로의 `W/`는 `src/adapter/inbound/web/src/main/java/dev/caskeleton/adap
| `GraphQlRequestEnvelopeValidator`·`GraphQlHttpRequestEnvelope` + `GraphQlRequestEnvelopeValidatorTest` | `src/adapter/inbound/graphql/src/main/java/dev/caskeleton/adapter/inbound/graphql/http/` | `4fb7943b` | 요청 경로에서 도달 불가 (J-10d) |
| `MigrationFailedException`·`ProfileMismatchException`·`RequiredAdapterDisabledException`·`StartupValidationException` | `src/adapter/outbound/support/src/main/java/dev/caskeleton/adapter/outbound/support/startup/` | `f2857840^`(= `b7187e1b`) | 역할 없는 subclass (S6-#13) |
| `ExternalRequestUrlResolver`의 forwarded 파싱 + env `APP_NOTIFICATION_PLATFORM_CALLBACK_TRUSTED_PROXIES` | `src/adapter/inbound/web-notification/src/main/java/dev/caskeleton/adapter/inbound/web/notification/platform/callback/ExternalRequestUrlResolver.java` | `d54909c4` | 컨테이너(RemoteIpValve)와 다른 두 번째 신뢰 판단 (I-5b) |
| `LegacyOutboxAppendPort` | `src/application-core/src/main/java/dev/caskeleton/application/outbox/LegacyOutboxAppendPort.java` | `6d27356e` | canonical `OutboxAppendPort`로 통일(결정 7) |
| legacy outbox 모델 `NewOutboxEvent`, `OutboxEvent`, `CanonicalClaimedOutboxEvent`, `OutboxPayloadPolicy` (+ `NewOutboxEventTest`, `OutboxPayloadPolicyTest`) | `src/application-core/src/main/java/dev/caskeleton/application/outbox/` | `6d27356e` | append 모델이 `ValidatedIntegrationEvent` 하나. `ClaimedOutboxEvent`는 sealed 합집합이 아니라 canonical record |
| `LegacyOutboxAppendContract` | `src/application-core/src/testFixtures/java/dev/caskeleton/application/outbox/testkit/LegacyOutboxAppendContract.java` | `6d27356e` | `OutboxAppendContract`로 대체 |
| `CanonicalOutboxAppendAdapter` (+ Activation·단위 테스트) | `src/adapter/outbound/persistence-jpa/src/main/java/dev/caskeleton/adapter/outbound/persistence/outbox/CanonicalOutboxAppendAdapter.java` | `6d27356e` | `OutboxStoreAdapter`가 `OutboxAppendPort`를 직접 구현(트랜잭션 guard 포함) |
| `OutboxEventEntity.payload`·`idempotencyKey` 접근자, claim SQL의 legacy CASE | `src/adapter/outbound/persistence-jpa/src/main/java/dev/caskeleton/adapter/outbound/persistence/outbox/entity/OutboxEventEntity.java`, `PostgreSqlOutboxClaimRepository`, `H2OutboxClaimRepository` | `6d27356e` | canonical 컬럼만 읽고 씀. 컬럼은 V19에서 nullable로 두고 migration은 수정하지 않음 |
| `OutboxCanonicalTransportRequirementValidator` (+ Validator/Composition 테스트) | `src/app-bootstrap/src/main/java/dev/caskeleton/bootstrap/autoconfigure/outbox/OutboxCanonicalTransportRequirementValidator.java` | `6d27356e` | 켜고 끌 canonical 플래그가 없어짐 |
| 설정 키 `ca-skeleton.outbox.canonical-transport-enabled` / env `APP_OUTBOX_CANONICAL_TRANSPORT_ENABLED` | `persistence-jpa.yml`, `docs/registries/env-keys.yaml`, `src/.env.example` | `6d27356e` | 같음 |
| messaging `core/*`: `MessageBroker`, `MessagePublisher`, `OutboundMessage`, `OutboundMessagePublisher`, `DisabledMessagePublisher` (+ `OutboundMessagePublisherTest`) | `src/adapter/outbound/messaging/src/main/java/dev/caskeleton/adapter/outbound/messaging/core/` | `6d27356e` | legacy 발행 경로 삭제. relay는 bridge(`IntegrationEventPublishPort`)만 씀 |
| `OutboxEnvelopeJson` (+ `OutboxCanonicalPublishRoutingTest`) | `src/adapter/outbound/messaging/src/main/java/dev/caskeleton/adapter/outbound/messaging/outbox/OutboxEnvelopeJson.java` | `6d27356e` | envelope은 encoder가 한 번 만들고 bytes 그대로 전달 |
| legacy Kafka seam: `KafkaSender`, `KafkaSenderAutoConfiguration`, `KafkaMessageBroker`, `KafkaAdapterConfig`, `KafkaAdapterSettings`, `BrokerAddress`, `LegacyKafkaMessagingRootAutoConfiguration`, `AutoConfiguration.imports` (+ 테스트 5개) | `src/adapter/outbound/messaging-kafka/src/main/java/dev/caskeleton/adapter/outbound/messaging/kafka/` | `6d27356e` | TLS/SASL 없는 두 번째 producer(X1-#1f, NEW-4a). leaf는 코드 없는 capability 묶음으로 유지 |
| `messaging.yml`의 `kafka.brokers` | `src/adapter/outbound/messaging-kafka/src/main/resources/config/module-defaults/messaging.yml` | `6d27356e` | seam 설정 |
| `WorkLogReservedIntegrationEvent`, `WorkLogReservedIntegrationEventMapper` (+ Mapper 테스트 2개) | `src/sample-portfolio/src/main/java/dev/caskeleton/sample/portfolio/application/event/` | `6d27356e` | `PortfolioEventOutbox` + 계약 `portfolio.worklog.reserved` v1로 대체 |
| `SampleIdempotencyConfig` (executor 복사본) | `src/sample-portfolio/src/main/java/dev/caskeleton/sample/portfolio/bootstrap/idempotency/SampleIdempotencyConfig.java` | `6d27356e` | `composition:idempotency` 사용. Clock·스케줄링만 `SampleSchedulingConfig`로 |
| app-bootstrap `config/capabilities.yml` (이동) | `src/app-bootstrap/src/main/resources/config/capabilities.yml` | `6d27356e` | `composition/idempotency/.../config/module-defaults/idempotency.yml`로 이동 |
| app-bootstrap outbox 조립 `OutboxConfig`·`OutboxSettings`·`OutboxMetrics`·`OutboxRelayScheduler`·`OutboxLeaderElectionToken` (이동) | `src/app-bootstrap/src/main/java/dev/caskeleton/bootstrap/autoconfigure/outbox/` | `6d27356e` | `composition:outbox-relay`로 이동 |
| app-bootstrap 멱등성 조립 `IdempotencyProviderSelectionConfig`·`IdempotencySettings` (이동) | `src/app-bootstrap/src/main/java/dev/caskeleton/bootstrap/autoconfigure/idempotency/` | `6d27356e` | `composition:idempotency`로 이동 |
| app-bootstrap runtime 배선 tracing 6개, metrics 3개, `DomainContextConfig/Settings`, `PseudonymizationConfig`, `PrivacySettings`, `ManagementSecurityConfig` (이동) | `src/app-bootstrap/src/main/java/dev/caskeleton/bootstrap/{autoconfigure/tracing,metrics,concurrency,logging,settings,management/security}/` | `6d27356e` | `composition:service-runtime`으로 이동 |
| sample bootstrap 복사본: `SampleTracingConfig`, `SampleTracingSettings`, `SampleTracingSampleRateResolver`(`staging` 분기), `SampleTracingSamplingEnvironmentPostProcessor`, `SampleMicrometerSpanErrorRecorder`, `SampleMetricsContractConfig`, `SampleDomainContextConfig`, `SamplePseudonymizationConfig`, `SamplePrivacySettings`, `META-INF/spring.factories` | `src/sample-portfolio/src/main/java/dev/caskeleton/sample/portfolio/bootstrap/{tracing,metrics,context,logging,settings}/` | `6d27356e` | 원본과 갈라진 복사본(S6-#7). 공용 모듈 사용 |
| messaging `OutboxRepository.leaseBatch`, 4인자 `claimBatch`, 3인자 `markAmbiguous` | `src/messaging/messaging-reliability-api/src/main/java/dev/caskeleton/messaging/reliability/OutboxRepository.java` | `6d27356e` | main 호출 0. fencing 없는 claim/쓰기 표면(S7-#8) |
| `JdbcOutboxRepository`의 LEASE SQL·`leaseBatch`·`*Unfenced` 4개·`update` helper·손 JSON(`toJson`/`fromJson`/`escape`/`unescape`) | `src/messaging/messaging-outbox-jdbc-postgresql/src/main/java/dev/caskeleton/messaging/outbox/JdbcOutboxRepository.java` | `6d27356e` | 호출 0. 손 JSON reader는 결함(P18-new-1). jsonb 함수로 대체 |
| leaf `messaging-outbox-jdbc-postgresql`, `messaging-inbox-jdbc-postgresql` (코드는 이동) | `src/messaging/messaging-outbox-jdbc-postgresql`, `src/messaging/messaging-inbox-jdbc-postgresql` | `6d27356e` | `messaging-reliability` + `messaging-reliability-jdbc-postgresql`로 재분할(S7-#5b) |
| application-core 테스트 `malformedReportData` | `src/application-core/src/test/java/dev/caskeleton/application/outbox/` (relay 테스트) | `6d27356e` | blank aggregate id를 가진 claim이 canonical 모델에서 만들어질 수 없음 |
| `EventJson`(sample 이벤트 JSON 문자열 조립, P15에서 신설) | `src/sample-portfolio/src/main/java/dev/caskeleton/sample/portfolio/application/event/EventJson.java` | `25de288a` | P18 통합: sample 발행기가 canonical `PortfolioEventOutbox` + encoder로 옮겨 호출자 0 |
| `DomainContextSettings`(`ca-skeleton.domain-context.strategy`, P18이 service-runtime으로 옮긴 사본) | `src/composition/service-runtime/src/main/java/dev/caskeleton/composition/runtime/context/DomainContextSettings.java` | `e1dafd00`(P18 worktree) | P18 통합: P25 A-10c가 전략 선택 설정을 없앰 — `DomainContextConfig`가 `ThreadLocalDomainContextPropagator`를 직접 만든다 |