diff --git a/src/application/objectstorage/src/main/java/dev/caskeleton/application/objectstorage/request/ObjectRequestSupport.java b/src/application/objectstorage/src/main/java/dev/caskeleton/application/objectstorage/request/ObjectRequestSupport.java index 2a25b28e..02b02c77 100644 --- a/src/application/objectstorage/src/main/java/dev/caskeleton/application/objectstorage/request/ObjectRequestSupport.java +++ b/src/application/objectstorage/src/main/java/dev/caskeleton/application/objectstorage/request/ObjectRequestSupport.java @@ -18,8 +18,12 @@ final class ObjectRequestSupport { static Set immutableCapabilities( Set capabilities) { required(capabilities, "capabilities"); - if (capabilities.contains(null)) { - throw new IllegalArgumentException("capabilities must not contain null"); + // Each element, not contains(null): an immutable Set (Set.of, Set.copyOf) throws + // NullPointerException from contains(null) instead of answering false. + for (ObjectCapabilityRequirement capability : capabilities) { + if (capability == null) { + throw new IllegalArgumentException("capabilities must not contain null"); + } } return Set.copyOf(capabilities); } diff --git a/src/application/objectstorage/src/test/java/dev/caskeleton/application/objectstorage/request/ObjectRequestCapabilitiesTest.java b/src/application/objectstorage/src/test/java/dev/caskeleton/application/objectstorage/request/ObjectRequestCapabilitiesTest.java new file mode 100644 index 00000000..5ee9fbbb --- /dev/null +++ b/src/application/objectstorage/src/test/java/dev/caskeleton/application/objectstorage/request/ObjectRequestCapabilitiesTest.java @@ -0,0 +1,77 @@ +package dev.caskeleton.application.objectstorage.request; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.catchThrowable; + +import dev.caskeleton.application.objectstorage.content.CallBudget; +import dev.caskeleton.application.objectstorage.content.CancellationView; +import dev.caskeleton.application.objectstorage.identity.ObjectDestinationId; +import dev.caskeleton.application.objectstorage.identity.ObjectOperationEpoch; +import dev.caskeleton.application.objectstorage.identity.ObjectOperationId; +import dev.caskeleton.application.objectstorage.identity.ObjectOperationKey; +import dev.caskeleton.application.objectstorage.model.ObjectCapabilityRequirement; +import dev.caskeleton.application.objectstorage.model.ObjectContentIdentity; +import dev.caskeleton.application.objectstorage.model.ObjectDigest; +import dev.caskeleton.application.objectstorage.model.ObjectEncryptionRequirement; +import dev.caskeleton.application.objectstorage.model.ObjectMediaType; +import dev.caskeleton.application.objectstorage.model.ObjectPublicationRequirement; +import dev.caskeleton.application.objectstorage.model.ObjectRetentionRequirement; +import java.time.Duration; +import java.util.HashSet; +import java.util.Set; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +/** The capability set a publish or stage request carries. */ +class ObjectRequestCapabilitiesTest { + + @Test + @DisplayName("불변 Set으로 만든 요청도 그 capability를 그대로 담는다") + void anImmutableCapabilitySetIsAccepted() { + // given + Set capabilities = + Set.of(ObjectCapabilityRequirement.IMMUTABLE_CREATE); + + // when + ObjectPublishRequest request = publishRequest(capabilities); + + // then + assertThat(request.capabilityRequirements()) + .containsExactly(ObjectCapabilityRequirement.IMMUTABLE_CREATE); + } + + @Test + @DisplayName("null을 담은 capability Set은 거절한다") + void aCapabilitySetHoldingNullIsRefused() { + // given + Set capabilities = new HashSet<>(); + capabilities.add(ObjectCapabilityRequirement.IMMUTABLE_CREATE); + capabilities.add(null); + + // when + Throwable refused = catchThrowable(() -> publishRequest(capabilities)); + + // then + assertThat(refused) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("capabilities must not contain null"); + } + + private static ObjectPublishRequest publishRequest( + Set capabilities) { + byte[] content = {1, 2, 3}; + return new ObjectPublishRequest( + new ObjectOperationKey( + ObjectDestinationId.of("poster"), + ObjectOperationEpoch.of("epoch-a"), + ObjectOperationId.of("operation-a")), + ObjectMediaType.of("application/octet-stream"), + new ObjectContentIdentity(content.length, ObjectDigest.sha256(content)), + ObjectPublicationRequirement.INTEGRITY_VERIFIED, + ObjectRetentionRequirement.NONE, + ObjectEncryptionRequirement.PROVIDER_MANAGED, + capabilities, + CallBudget.fromNow(Duration.ofMinutes(1)), + CancellationView.never()); + } +}