review-followup Wave 3 라운드 3(P21): messaging 플랫폼 — Kafka 소비(MessageHandler 하나), API 정리
- 결정 10: consume 계약을 `MessageHandler<T>` 하나로, starter-kafka가 consumer 조립(handler bean이 있으면 켜짐, `app.messaging.enabled=false`로 끔). 오프셋은 handler Success(inbox면 트랜잭션 커밋) 뒤 또는 DLQ 쓰기 확인 뒤에만 커밋, auto-commit 금지, `read_committed`, 재시도 소진 → DLQ(없으면 멈춤) — Kafka+PG로 왕복·중복 제거·DLQ 검증 - 미사용 API 타입·Blocking/Reactive/Batch facade·reactor api 노출 삭제, `PublishResult` 정적 factory, `MessagingCapabilities` → EnumSet, API leaf 병합(core-api+schema-api, admin-api+admin-runtime), starter god config 분해, Kafka broker 설정은 starter-kafka로, 등급 용어 정리 - 결함 수정: Retry 응답이 시도 횟수를 세지 않아 partition 정지(P21-new-1), deliveryAttempt 항상 1(P21-new-2) - 통합: app-bootstrap `MessagingPublicSurfaceContractTest` 기대값을 P21 변경에 맞춤, starter-kafka에 `api kafka-clients` 검증: ./gradlew check architectureCheck verifyDependencyLocks :app-bootstrap:verifyEnvKeys :app-bootstrap:integrationTest :sample-portfolio:integrationTest :messaging:messaging-spring-boot-starter:integrationTest :messaging:messaging-reliability-jdbc-postgresql:integrationTest mainCheck --continue 통과(812 task) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
36ba0810c8
commit
486d85a603
+3
-3
@@ -96,7 +96,7 @@ class MessagingPublicSurfaceContractTest {
|
||||
|
||||
assertThat(leaves)
|
||||
.as("a scan that found no leaf would report every violation as absent")
|
||||
.hasSizeGreaterThan(20);
|
||||
.hasSizeGreaterThan(15);
|
||||
assertThat(
|
||||
exposedLibraries(
|
||||
leaves.stream().filter(isNamed("messaging-kafka")).findFirst().orElseThrow()))
|
||||
@@ -123,8 +123,8 @@ class MessagingPublicSurfaceContractTest {
|
||||
assertThat(reachable)
|
||||
.as(
|
||||
"an empty closure would satisfy the assertion below without proving anything; the "
|
||||
+ "metrics registry and the reactive facade are exported on purpose")
|
||||
.contains("io.micrometer:micrometer-core", "io.projectreactor:reactor-core");
|
||||
+ "metrics registry is exported on purpose (the reactive facade was deleted, S7-#9c)")
|
||||
.contains("io.micrometer:micrometer-core");
|
||||
assertThat(reachable)
|
||||
.as(
|
||||
"both adapters were exported, so every adopter compiled against two broker SDKs at "
|
||||
|
||||
Reference in New Issue
Block a user