review-followup Wave 3 라운드 3(P22): Redis runtime·SDK 분리, 좁은 semantic 포트, startup rule, lease fencing 계약
- pub/sub 표면 삭제(G-6b·G-4i — 소비자 0, capability 규칙 3): SDK pub/sub·runtime gateway·PUBSUB lane·env 키 2개 - runtime을 `…cache.redis.runtime`으로(split package 해소), runtime은 소비자가 쓰는 8개 명령(`SemanticRedisCommands`)만, 118개 메서드 gateway는 redis-sdk가 확장. SDK의 blocking·transaction·admin lane은 코드로 조립(env 키 4개 삭제) - EVALSHA+NOSCRIPT 재로드 헬퍼 하나(메시지에만 NOSCRIPT가 온 경우도 재로드 — `LeaseScriptsTest` FAIL→PASS) - startup rule 목록 + runner 하나(환경 검사 8개, exit code·문구 유지), Redis secret 요구는 모듈이 기여, ratelimit 정책을 cache-redis 밖으로, lease fencing 계약 테스트(fake·어댑터·실제 Redis) - 통합: redis-sdk 테스트 2개가 옛 split package 경로를 보던 것 수정(ORCH-new-4) 검증: ./gradlew check architectureCheck verifyDependencyLocks :app-bootstrap:verifyEnvKeys configContractCheck :app-bootstrap:integrationTest :sample-portfolio:integrationTest :sample-portfolio:systemTest --continue 통과(682 task), Redis 7.4 standalone topology lane: runtime 7 · sdk 14 · cache-redis 19, 실패·skip 0 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
486d85a603
commit
4f4bd1fd34
+12
-103
@@ -1207,7 +1207,7 @@ env_keys:
|
||||
# APP_SERVER_FORWARD_HEADERS_STRATEGY=native and server.tomcat.remoteip.internal-proxies.
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_ENABLED
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.enabled (APP_REDIS_ENABLED).
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1295,7 +1295,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:key-version-bounded
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_HOST
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.nodes (APP_REDIS_NODES).
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1311,7 +1311,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:redis-host-required
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_PORT
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.nodes (APP_REDIS_NODES).
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1339,7 +1339,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:redis-password-no-leak
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_TRUST_PEM
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.tls.trust-material-resource.
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1424,7 +1424,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:redis-timeout-bounded
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_MAXIMUM_COMMAND_BYTES
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.limits.max-batch-request-bytes.
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1440,7 +1440,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:redis-command-bytes-bounded
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_MAXIMUM_QUEUED_COMMANDS
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.capacity.maximum-in-flight-commands.
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1456,7 +1456,7 @@ env_keys:
|
||||
required_test: rate-limit-contract:redis-queue-bounded
|
||||
|
||||
- name: APP_RATE_LIMIT_REDIS_MAXIMUM_IN_FLIGHT_BYTES
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisSdkAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# DEPRECATED 2026-08-10: the rate limiter no longer owns a Redis client of its own. One client, built by RedisRuntimeAutoConfiguration, serves every capability, so a second endpoint and a second set of ceilings could only ever disagree with it.
|
||||
# Replaced by: app.redis.capacity.maximum-in-flight-bytes.
|
||||
deprecated_orphaned: true
|
||||
removal_deadline: 2026-11-30
|
||||
@@ -1842,57 +1842,12 @@ env_keys:
|
||||
compatibility_impact: additive
|
||||
required_test: redis-capability:lease-composition
|
||||
|
||||
# --- Redis SDK typed settings (app.redis.*) -------------------------------
|
||||
# Bound only by RedisSdkAutoConfiguration in adapter-outbound-redis-runtime while
|
||||
# --- Redis runtime settings (app.redis.*) ----------------------------------
|
||||
# Bound only by RedisRuntimeAutoConfiguration in adapter-outbound-redis-runtime while
|
||||
# APP_REDIS_ENABLED is true. application.yml does not force these values into Redis-free
|
||||
# deployments; src/.env.example merely documents explicit operator inputs. verifyEnvKeys checks
|
||||
# the registry against the runtime module's configuration metadata.
|
||||
|
||||
- name: APP_REDIS_ADMIN_CREDENTIAL_REFERENCE
|
||||
property: app.redis.admin.credential-reference
|
||||
owner_module: adapter-outbound-redis-runtime
|
||||
type: string
|
||||
default: null
|
||||
allowed_values: null
|
||||
classification: sensitive-config
|
||||
required: false
|
||||
required_when: app.redis.admin.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: nonblank_when_required
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:typed-settings-bound-and-validated
|
||||
|
||||
- name: APP_REDIS_ADMIN_ENABLED
|
||||
property: app.redis.admin.enabled
|
||||
owner_module: adapter-outbound-redis-runtime
|
||||
type: boolean
|
||||
default: false
|
||||
allowed_values: [true, false]
|
||||
classification: public-config
|
||||
required: false
|
||||
required_when: app.redis.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: boolean_strict
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:typed-settings-bound-and-validated
|
||||
|
||||
- name: APP_REDIS_BLOCKING_MAX_CONNECTIONS
|
||||
property: app.redis.blocking.max-connections
|
||||
owner_module: adapter-outbound-redis-runtime
|
||||
type: integer
|
||||
default: 32
|
||||
allowed_values: null
|
||||
classification: public-config
|
||||
required: false
|
||||
required_when: app.redis.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: positive_integer
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:typed-settings-bound-and-validated
|
||||
|
||||
- name: APP_REDIS_DATABASE
|
||||
# Cluster supports database 0 only; a non-zero value fails startup there.
|
||||
property: app.redis.database
|
||||
@@ -2032,24 +1987,8 @@ env_keys:
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:typed-settings-bound-and-validated
|
||||
|
||||
- name: APP_REDIS_TRANSACTION_MAX_CONNECTIONS
|
||||
property: app.redis.transaction.max-connections
|
||||
owner_module: adapter-outbound-redis-runtime
|
||||
type: integer
|
||||
default: 16
|
||||
allowed_values: null
|
||||
classification: public-config
|
||||
required: false
|
||||
required_when: app.redis.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: positive_integer
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:typed-settings-bound-and-validated
|
||||
|
||||
# --- Redis runtime composition settings (app.redis.*) ----------------------
|
||||
# Authentication, Sentinel discovery, TLS, lifecycle, Cluster routing, capacity and
|
||||
# subscription delivery. Same rule as the rest of app.redis.*: bound only while
|
||||
# Authentication, Sentinel discovery, TLS, lifecycle, Cluster routing and capacity. Same rule as the rest of app.redis.*: bound only while
|
||||
# APP_REDIS_ENABLED is true, and deliberately absent from application.yml and .env.
|
||||
|
||||
- name: APP_REDIS_AUTHENTICATION_ADVANCED_CREDENTIAL_REFERENCE
|
||||
@@ -2103,21 +2042,6 @@ env_keys:
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:runtime-composition-binds-and-validates
|
||||
|
||||
- name: APP_REDIS_AUTHENTICATION_PUBSUB_CREDENTIAL_REFERENCE
|
||||
property: app.redis.authentication.pubsub-credential-reference
|
||||
owner_module: adapter-outbound-cache-redis
|
||||
type: string
|
||||
default: null
|
||||
allowed_values: null
|
||||
classification: sensitive-config
|
||||
required: false
|
||||
required_when: app.redis.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: nonblank_when_required
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:runtime-composition-binds-and-validates
|
||||
|
||||
- name: APP_REDIS_CAPACITY_MAXIMUM_IN_FLIGHT_COMMANDS
|
||||
property: app.redis.capacity.maximum-in-flight-commands
|
||||
owner_module: adapter-outbound-cache-redis
|
||||
@@ -2287,21 +2211,6 @@ env_keys:
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:runtime-composition-binds-and-validates
|
||||
|
||||
- name: APP_REDIS_PUBSUB_BUFFER_CAPACITY
|
||||
property: app.redis.pubsub.buffer-capacity
|
||||
owner_module: adapter-outbound-cache-redis
|
||||
type: integer
|
||||
default: 1024
|
||||
allowed_values: null
|
||||
classification: public-config
|
||||
required: false
|
||||
required_when: app.redis.enabled=true
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
validation: positive_integer
|
||||
compatibility_impact: additive
|
||||
required_test: redis-sdk:runtime-composition-binds-and-validates
|
||||
|
||||
- name: APP_REDIS_SENTINEL_CREDENTIAL_REFERENCE
|
||||
property: app.redis.sentinel.credential-reference
|
||||
owner_module: adapter-outbound-cache-redis
|
||||
@@ -2379,8 +2288,8 @@ env_keys:
|
||||
classification: sensitive-config
|
||||
required: false
|
||||
# A relationship between two settings rather than a switch: a client certificate without its
|
||||
# key cannot build a key manager. Enforced in RedisSdkSettings.validate and covered by
|
||||
# RedisSdkSettingsTest, which is where the registry's prose conditions are proven.
|
||||
# key cannot build a key manager. Enforced in RedisRuntimeSettings.validate and covered by
|
||||
# RedisRuntimeSettingsTest, which is where the registry's prose conditions are proven.
|
||||
required_when: app.redis.tls.client-certificate-resource is configured
|
||||
reload_policy: restart-only
|
||||
owner_branch: redis-optionality-and-composition
|
||||
|
||||
@@ -54,6 +54,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.cache.bindings.default=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: feature-secrets-config-source-contract
|
||||
masking_rule: full
|
||||
@@ -78,6 +80,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: dual-read-restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.cache.bindings.default=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: codex-phase-a-ci-recovery
|
||||
masking_rule: full
|
||||
@@ -90,6 +94,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.rate-limit.provider=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-distributed-rate-limit
|
||||
masking_rule: full
|
||||
@@ -114,6 +120,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: dual-read-restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.rate-limit.provider=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-distributed-rate-limit
|
||||
masking_rule: full
|
||||
@@ -126,6 +134,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.security.auth-mode=redis-session
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-production-capability
|
||||
masking_rule: full
|
||||
@@ -150,6 +160,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: dual-read-restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.security.auth-mode=redis-session
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-production-capability
|
||||
masking_rule: full
|
||||
@@ -162,6 +174,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: cold-cutover-restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.idempotency.provider=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-production-capability-completion
|
||||
masking_rule: full
|
||||
@@ -174,6 +188,8 @@ secrets:
|
||||
source: secret-manager
|
||||
rotation_policy: cold-cutover-restart-only
|
||||
prod_default: null
|
||||
# Required with app.redis.enabled=true and this role selected; checked by adapter-outbound-cache-redis RedisProductionSecrets.
|
||||
required_when: ca-skeleton.capabilities.lease.provider=redis
|
||||
dev_sentinel_prefix: __LOCAL_DEV_
|
||||
owner_branch: redis-production-capability-completion
|
||||
masking_rule: full
|
||||
|
||||
Reference in New Issue
Block a user