refactor(platforms)!: gRPC 플랫폼을 별도 repo grpc-library로 옮기고 지운다
템플릿 repo 안에 프로젝트 계층이 아닌 라이브러리가 있었다. gRPC 플랫폼 (src/platforms/grpc, grpc-advanced)과 그것만을 위한 두 번째 Gradle 빌드 (src/platforms/optional-build)는 템플릿 어느 leaf도 쓰지 않는데, registry 9행, workflow job 넷과 단계 하나, build-logic 플러그인 둘, 카탈로그·SpotBugs 항목, 문서 열두 개를 템플릿이 함께 지고 있었다. 소유자 결정(2026-11-07, design-docs repo-structure/README.md 3.5절, 05-library-repos.md Q1~Q17 승인)대로 라이브러리마다 별도 repo로 옮긴다. gRPC는 템플릿 소비자가 없어 먼저 옮기고, 템플릿은 지우기만 한다(Q13). 코드와 이력은 grpc-library repo에 filter-repo로 옮겼다(옮긴 폴더의 트리 해시가 이 기준 커밋 22df3525와 같다). 지운 것: - src/platforms/grpc, grpc-advanced, optional-build(343파일) - registry의 "build": "optional-grpc" 9행 - ci-quality-gates.yml job optional-platforms·grpc-proto-buf와 그 needs, integration-main.yml optional 성능 단계와 job grpc-optional-platform-integration, release.yml job grpc-stable-release-gate와 이미지 job의 needs 한 줄 - build-logic ca.grpc-platform-module·ca.optional-architecture-registry, MainBuild(두 번째 빌드에서 주 빌드를 찾던 것)와 ArchitecturePlugin의 optional 분기. 도구 설정·이미지 목록·registry는 Gradle 루트에서 찾는다 - 카탈로그 protobufPlugin·protobuf-java-grpc·protoc·plugin protobuf(Q14: 채택 전이라 grpc-library 좌표도 넣지 않는다), SpotBugs 제외의 gRPC 줄 - 옮긴 문서: ADR-GRPC 7개, docs/compatibility/(폴더째), gRPC runbook 둘, gRPC 설계서. 리뷰·기록 본문은 고치지 않았다(Q15). 기록 하나의 머리 블록 「현재 정본」만 새 자리를 말하게 했다 - DeveloperExperienceContractTest의 optional 빌드 lane 계약 시험, adopter API 표면 검사의 optional-build 제외 경로 남긴 것: adapter:inbound:grpc(io.grpc를 직접 쓰고 플랫폼을 쓰지 않는다), src/platforms/messaging(다음 분리 작업), registry의 build 칸 지원 (ModuleRegistry, 일반 기능). 살아 있는 문서: README, docs 지도, capability-status, work/delegate· gates·decisions(새 행 「라이브러리 repo」)·defect-patterns· review-criteria(경계 밖 파일을 경로로 읽는 결합을 결함 후보로), manual 04, jpa migration-guide, build-logic AGENTS·README, testkit 주석. 새 docs/work/reference/related-repos.md가 라이브러리 repo 목록과 같이 고치는 법을 둔다. 파생 서비스 안내는 docs/upgrade 3.8절 B-55·B-56. 위험: 파생 서비스가 이 경로를 고쳤으면 수정 대 삭제 충돌이 난다 (tech-log-backend는 플랫폼을 받은 적이 없다, 설계 12절). 분리 직전 커밋 태그 pre-library-split(설계 12.2절)은 이 브랜치 권한 밖이라 달지 않았다. 검증: desktop 게이트 결과는 PR 본문(ci, mainCheck 계열, releaseCheck, compose smoke, 빠른 시작). 문서 검사 셋 rc=0. BREAKING CHANGE: src/platforms/grpc*·optional-build, :grpc:*·:grpc-advanced:* 프로젝트, ca.grpc-platform-module, 카탈로그 protoc·protobuf-java-grpc·plugin protobuf가 없다. 쓰던 서비스는 grpc-library 좌표 com.hyeonworks.grpc로 받는다(docs/upgrade/2026-11-maturity-review.md 3.8절). Refs: design-docs repo-structure/05-library-repos.md 13.1절 1·2단계
This commit is contained in:
@@ -62,70 +62,9 @@ jobs:
|
||||
- name: Refuse a top-level folder outside the allow list
|
||||
run: python3 scripts/check-repo-layout.py
|
||||
|
||||
optional-platforms:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Verify the optional gRPC platform build
|
||||
working-directory: src
|
||||
run: ./gradlew -p platforms/optional-build ci --stacktrace
|
||||
# The optional build's own lane-reachability check: the main build's cannot see these lanes
|
||||
# (review 2026-11-03 RR-06-03).
|
||||
- name: Require every optional-platform strict lane to be in an executed stage
|
||||
working-directory: src
|
||||
run: ./gradlew -p platforms/optional-build :verifyStrictLaneStages --dry-run --stacktrace
|
||||
|
||||
# gRPC schema policy (owner decision 18). protoc compiles src/platforms/grpc/grpc-contract inside
|
||||
# the optional-platforms build above; lint and breaking-change policy belong to Buf, configured by
|
||||
# buf.yaml next to the schema. Buf is a native binary rather than a Maven artifact, so it runs here
|
||||
# and not inside Gradle — and nothing in the repository re-implements its rules.
|
||||
grpc-proto-buf:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
with:
|
||||
# buf breaking reads the baseline schema from Git history.
|
||||
fetch-depth: 0
|
||||
- uses: bufbuild/buf-action@85aebf73123b5c15fd5528aaecbf9129cddf7fa7 # bufbuild/buf-action@v1.6.0
|
||||
with:
|
||||
version: 1.73.0
|
||||
setup_only: true
|
||||
- name: Lint the gRPC schema
|
||||
working-directory: src/platforms/grpc/grpc-contract
|
||||
run: buf lint
|
||||
- name: Refuse a breaking change to the gRPC schema
|
||||
working-directory: src/platforms/grpc/grpc-contract
|
||||
env:
|
||||
# Pull request: the target branch. Push: the commit this push replaced.
|
||||
BASELINE: ${{ github.event_name == 'pull_request' && format('origin/{0}', github.base_ref) || github.event.before }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
baseline_commit="$(git rev-parse --verify --quiet "${BASELINE}^{commit}" || true)"
|
||||
# The module moved from src/grpc to src/platforms/grpc on 2026-11-07. A baseline from
|
||||
# before the move holds it at the old path, and comparing against that path keeps the
|
||||
# breaking check running across the move instead of skipping it once.
|
||||
baseline_dir=""
|
||||
if [[ -n "${baseline_commit}" ]]; then
|
||||
for candidate in src/platforms/grpc/grpc-contract src/grpc/grpc-contract; do
|
||||
if git cat-file -e "${baseline_commit}:${candidate}/buf.yaml" 2>/dev/null; then
|
||||
baseline_dir="${candidate}"
|
||||
break
|
||||
fi
|
||||
done
|
||||
fi
|
||||
if [[ -z "${baseline_dir}" ]]; then
|
||||
# The first change that introduces the module has nothing to be compatible with.
|
||||
echo "::notice::grpc-proto-buf: baseline ${BASELINE} has no grpc-contract/buf.yaml; breaking check skipped."
|
||||
exit 0
|
||||
fi
|
||||
buf breaking --against "../../../../.git#ref=${baseline_commit},subdir=${baseline_dir}"
|
||||
|
||||
release-gate:
|
||||
needs:
|
||||
- quality-gates
|
||||
- optional-platforms
|
||||
- grpc-proto-buf
|
||||
if: always()
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
@@ -134,14 +73,10 @@ jobs:
|
||||
- name: Require every current blocking job to succeed
|
||||
env:
|
||||
QUALITY_RESULT: ${{ needs.quality-gates.result }}
|
||||
OPTIONAL_PLATFORMS_RESULT: ${{ needs.optional-platforms.result }}
|
||||
GRPC_PROTO_BUF_RESULT: ${{ needs.grpc-proto-buf.result }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
for result in \
|
||||
"${QUALITY_RESULT}" \
|
||||
"${OPTIONAL_PLATFORMS_RESULT}" \
|
||||
"${GRPC_PROTO_BUF_RESULT}"; do
|
||||
"${QUALITY_RESULT}"; do
|
||||
if [[ "${result}" != "success" ]]; then
|
||||
echo "::error::release-gate: required job result was ${result}"
|
||||
exit 1
|
||||
|
||||
@@ -202,12 +202,6 @@ jobs:
|
||||
- name: Run every performance-category strict lane
|
||||
working-directory: src
|
||||
run: ./gradlew :performanceCheck --continue --stacktrace
|
||||
# The optional gRPC build's performance lanes (grpcPerformanceTest). A separate build, so a
|
||||
# separate command; its own verifyStrictLaneStages counts this line (review 2026-11-03 RR-06-03).
|
||||
- name: Run every optional-platform performance-category strict lane
|
||||
if: always()
|
||||
working-directory: src
|
||||
run: ./gradlew -p platforms/optional-build performanceCheck --continue --stacktrace
|
||||
- name: Publish the performance lane reports
|
||||
if: always()
|
||||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
||||
@@ -230,35 +224,6 @@ jobs:
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:httpclient:test -Phttp3.tests.enabled=true --stacktrace
|
||||
|
||||
# The optional gRPC platform build declares one strict INTEGRATION lane —
|
||||
# `grpc-operation-ledger-jpa:integrationTest`, which certifies the atomic
|
||||
# `INSERT ... ON CONFLICT DO NOTHING` claim that durable mutation idempotency rests on against a
|
||||
# real PostgreSQL. It was registered in Gradle, listed in `strictTestLanes`, and invoked by
|
||||
# nothing: `-p platforms/optional-build ci` reaches `checkAll`, `qualityCheck` and the dependency
|
||||
# verifier, none of which runs a lane whose category is INTEGRATION, and release.yml's gRPC gate
|
||||
# names only the three grpc-testkit lanes.
|
||||
#
|
||||
# Stage 2 rather than stage 1 for the same reason as every other job in this file: the lane starts
|
||||
# a Testcontainers PostgreSQL, and the pull-request budget is minutes for the whole gate.
|
||||
grpc-optional-platform-integration:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
env:
|
||||
TESTCONTAINERS_REUSE_ENABLE: "false"
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Certify the gRPC operation ledger against real PostgreSQL
|
||||
working-directory: src
|
||||
run: ./gradlew -p platforms/optional-build integrationCheck --stacktrace
|
||||
- name: Publish the optional-platform lane reports
|
||||
if: always()
|
||||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
||||
with:
|
||||
name: grpc-optional-platform-integration-reports
|
||||
path: src/platforms/grpc*/**/build/reports/tests/
|
||||
if-no-files-found: warn
|
||||
|
||||
# Dynamic half of the compose-profile contract. Every blocking lane the matrix declares runs on
|
||||
# main and nightly; a partial lane run is reproduction only and cannot satisfy this job. The count
|
||||
# is not written here on purpose — a number in prose drifts the moment a lane is added, and the
|
||||
|
||||
@@ -108,49 +108,6 @@ jobs:
|
||||
path: src/adapter/inbound/websocket/build/reports/tests/
|
||||
if-no-files-found: error
|
||||
|
||||
# The three gRPC certification lanes. Their tests already run on every pull request — the
|
||||
# `grpc-inprocess`, `grpc-netty` and `grpc-fault` tags are NOT excluded from
|
||||
# `:grpc:grpc-testkit:test` (only `grpc-performance` is), and that task runs inside the root
|
||||
# `check`. So this job adds exactly what the web Advanced lane above adds: the lane
|
||||
# fails closed when its tag selects nothing, which is the one thing a tag-filtered suite inside
|
||||
# `test` cannot tell you. A renamed or deleted @Tag would otherwise leave the in-process,
|
||||
# transport and fault evidence grades claiming coverage that stopped existing.
|
||||
#
|
||||
# Release rather than nightly, for the same reason web-stable-release-gate is: these lanes need no
|
||||
# container and no fixed cadence — grpcNettyContractTest opens an ephemeral socket, not a broker —
|
||||
# so the guard is worth asserting once per tag and is not worth a runner every night.
|
||||
#
|
||||
# The optional build's `releaseCheck` is those hermetic lanes, so a lane added there is here
|
||||
# without a workflow edit. grpcPerformanceTest is deliberately absent: a measurement is not release
|
||||
# evidence on a shared runner. It runs in integration-main.yml's performance-check job (the
|
||||
# optional build's `performanceCheck`).
|
||||
grpc-stable-release-gate:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the gRPC Stable certification lanes
|
||||
working-directory: src
|
||||
run: ./gradlew -p platforms/optional-build releaseCheck --stacktrace
|
||||
# The operation ledger's real-PostgreSQL lane ran only on main and nightly
|
||||
# (integration-main.yml), so a tag could be cut from a main whose ledger lane was red. It needs
|
||||
# Docker, which a release runner has (review 2026-11-01 03-12).
|
||||
- name: Certify the gRPC operation ledger against real PostgreSQL
|
||||
working-directory: src
|
||||
env:
|
||||
TESTCONTAINERS_REUSE_ENABLE: "false"
|
||||
run: ./gradlew -p platforms/optional-build integrationCheck --stacktrace
|
||||
- name: Publish the gRPC release evidence
|
||||
if: always()
|
||||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
||||
with:
|
||||
name: grpc-release-evidence
|
||||
path: |
|
||||
src/platforms/grpc/grpc-testkit/build/reports/tests/
|
||||
src/platforms/grpc/grpc-operation-ledger-jpa/build/reports/tests/
|
||||
if-no-files-found: warn
|
||||
|
||||
# Each gate runs as its own single-line `./gradlew <task>` step so that a failure names the gate
|
||||
# rather than a folded command. The architecture dependency gate that used to end this list is now
|
||||
# architecture-and-surface above; it was the fourth copy of the same invocation.
|
||||
@@ -344,7 +301,6 @@ jobs:
|
||||
- architecture-and-surface
|
||||
- web-stable-release-gate
|
||||
- websocket-stable-release-gate
|
||||
- grpc-stable-release-gate
|
||||
- httpclient-release-gate
|
||||
- httpclient-documentation
|
||||
- jpa-release-promotion
|
||||
|
||||
Reference in New Issue
Block a user