refactor: 리펙토링 진행중 의존성 gradle은 얇게 유지, 각 모듈에서 처리하고 있는 부분에 대해서 리펙토링
This commit is contained in:
@@ -122,10 +122,10 @@ strict evidence validators, generated platform variants, and risk-based review p
|
||||
- [ ] Audit the working-tree diff in order: architecture → spec → quality.
|
||||
- [ ] Fix findings and restart the review chain, up to three loops.
|
||||
|
||||
## Task 7 — LLM Wiki capture
|
||||
## Task 7 — documentation update
|
||||
|
||||
- [ ] Read the LLM Wiki authority and branch-note template.
|
||||
- [ ] Update/create the detached-HEAD branch note with implementation decisions, changed files,
|
||||
- [ ] Read the repository documentation authority and design record template.
|
||||
- [ ] Update/create the detached-HEAD design record with implementation decisions, changed files,
|
||||
verification evidence, failures, and open risks.
|
||||
- [ ] Create/link derived error, interview, or blog-topic raw notes only when supported by the
|
||||
completed work; otherwise record an explicit “none” judgment in the branch note.
|
||||
completed work; otherwise record an explicit “none” judgment in the design record.
|
||||
|
||||
+1
-1
@@ -137,7 +137,7 @@ logging, Logback capture tests, ArchUnit, Gradle Groovy DSL, dependency locking.
|
||||
- [ ] Run `verifyCleanArchitectureDependencies`, dependency evidence reports, and `check`.
|
||||
- [ ] Run required safety greps, `git diff --check`, and `git status --short`; report any skip or
|
||||
remaining risk.
|
||||
- [ ] Hand the exact LLM Wiki capture responsibility and evidence back to the top-level controller;
|
||||
- [ ] Hand the exact documentation update responsibility and evidence back to the top-level controller;
|
||||
do not write the vault from this dispatched scope.
|
||||
|
||||
No step authorizes staging, committing, amending, pushing, public-path changes, CI changes, module
|
||||
|
||||
@@ -1800,29 +1800,24 @@ Expected:
|
||||
- no SLF4J/Spring/Micrometer import remains in application-core;
|
||||
- no agent-created commit exists.
|
||||
|
||||
## Task 9: Required Implementation Evidence and LLM Wiki Capture
|
||||
## Task 9: Required Implementation Evidence and repository documentation Capture
|
||||
|
||||
This task is performed only after production implementation and verification. It is not performed
|
||||
while merely authoring this plan.
|
||||
|
||||
- [ ] **Step 1: Read the Wiki authorities before writing**
|
||||
|
||||
Read:
|
||||
|
||||
```text
|
||||
/home/donghyeon/workspace/ai-tool/llm-wiki-private/AGENTS.md
|
||||
/home/donghyeon/workspace/ai-tool/llm-wiki-private/CLAUDE.md
|
||||
/home/donghyeon/workspace/clean-architecture-backend-template/.agents/plugins/ca-superpowers/rules/llm-wiki-capture.md
|
||||
```
|
||||
|
||||
Expected: all authorities exist after harness recovery and are read in full.
|
||||
|
||||
- [ ] **Step 2: Update the branch note**
|
||||
- [ ] **Step 2: Update the design record**
|
||||
|
||||
Create or update:
|
||||
|
||||
```text
|
||||
/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/main.md
|
||||
```
|
||||
|
||||
Record:
|
||||
@@ -1838,7 +1833,7 @@ Record:
|
||||
- [ ] **Step 3: Make the derived-document judgment explicit**
|
||||
|
||||
Create linked raw error/interview/blog-topic notes only when the completed implementation provides
|
||||
genuine derived material. Otherwise write `추출할 별도 글감 없음` in the branch note's
|
||||
genuine derived material. Otherwise write `추출할 별도 글감 없음` in the design record's
|
||||
`## Cluster / 묶음` section.
|
||||
|
||||
- [ ] **Step 4: Produce the final implementation report**
|
||||
@@ -1849,5 +1844,5 @@ The final response lists:
|
||||
- core architecture and behavior changes;
|
||||
- focused/full verification commands and outcomes;
|
||||
- failed or unrun checks;
|
||||
- Wiki branch-note and derived-note result;
|
||||
- design record and derived-note result;
|
||||
- remaining risks and human-only commit status.
|
||||
|
||||
@@ -1973,6 +1973,6 @@ Expected: only reviewed recovery and CI-control-plane files are present; there a
|
||||
commits. Provide the human owner with the task-packet hash, recovery hash inventory, exact commands
|
||||
and exits, Gitea run links, required-status evidence, failures, and remaining risks.
|
||||
|
||||
The documentation-authoring turn that created this plan does not write to the LLM Wiki. During
|
||||
The documentation-authoring turn that created this plan does not write to the repository documentation. During
|
||||
future implementation, the executing controller follows the root `AGENTS.md` capture policy after
|
||||
all implementation and verification work is complete.
|
||||
|
||||
@@ -77,7 +77,7 @@ production project dependencies against it.
|
||||
- [x] State that focused commands are derived from the owning Gradle path rather than a task
|
||||
packet.
|
||||
- [x] Keep all eight local HARD-STOP meanings, architecture boundaries, human-only git policy,
|
||||
verification discipline, and LLM Wiki capture requirements.
|
||||
verification discipline, and documentation update requirements.
|
||||
- [x] Make the earlier harness documents explicit historical provenance rather than active
|
||||
reconstruction instructions.
|
||||
|
||||
@@ -95,5 +95,5 @@ production project dependencies against it.
|
||||
- [ ] Run a deterministic comparison between registry edges and leaf production project
|
||||
dependencies.
|
||||
- [ ] Run `git diff --check` and `git status --short`.
|
||||
- [ ] Report exact exits, any unavailable checks, LLM Wiki capture outcome, and remaining risks
|
||||
- [ ] Report exact exits, any unavailable checks, documentation update outcome, and remaining risks
|
||||
without claiming the broader Phase A/refactor is complete.
|
||||
|
||||
@@ -113,5 +113,5 @@ jq, lychee.
|
||||
valid Results array.
|
||||
- [ ] Prove no harness call or `.gitea/workflows` shadow was introduced.
|
||||
- [ ] Run `git diff --check` and `git status --short`.
|
||||
- [ ] Capture the work in the required LLM Wiki branch note, including evidence and external
|
||||
- [ ] Capture the work in the required design record, including evidence and external
|
||||
blockers, without claiming server Actions or full Phase A completion.
|
||||
|
||||
@@ -88,7 +88,7 @@ Git operations.
|
||||
- [ ] Run all commands in the design verification section.
|
||||
- [ ] Run `git diff --check` and inspect the complete unstaged/untracked status.
|
||||
- [ ] Request spec and code-quality review; fix all actionable findings.
|
||||
- [ ] Update the mandated LLM Wiki raw branch note and derived raw notes, or record the exact
|
||||
- [ ] Update the mandated repository documentation raw design record and derived raw notes, or record the exact
|
||||
missing-vault blocker.
|
||||
|
||||
## Final review hardening
|
||||
|
||||
@@ -50,7 +50,7 @@ prerequisite, real PostgreSQL task, zero-skip sentinel과 immutable evidence man
|
||||
5. owner-safe idempotency V2, immutable outbox storage V2, polling delivery V2, same-store
|
||||
inbox가 독립 migration stream과 real PostgreSQL concurrency test를 가진다.
|
||||
6. 외부 CDC, replica, tenant/RLS, R3는 토폴로지/evidence 없이 선택하거나 R2로 광고하지 않는다.
|
||||
7. 전체 test/check와 Wiki capture 결과를 기록한다.
|
||||
7. 전체 test/check와 documentation update 결과를 기록한다.
|
||||
|
||||
## 2. 공통 구현 규칙
|
||||
|
||||
@@ -384,15 +384,14 @@ cd src
|
||||
```
|
||||
|
||||
전체 `test`/`check`와 real PostgreSQL task는 해당 phase가 경계를 실제로 변경하거나 required
|
||||
task를 추가한 시점에 실행한다. 실행하지 못한 명령은 이유와 남은 위험을 branch-note와 최종
|
||||
task를 추가한 시점에 실행한다. 실행하지 못한 명령은 이유와 남은 위험을 design record와 최종
|
||||
응답에 기록한다.
|
||||
|
||||
## 10. Wiki capture
|
||||
## 10. documentation update
|
||||
|
||||
각 의미 있는 slice가 끝날 때 실제 vault의 branch-note:
|
||||
각 의미 있는 slice가 끝날 때 실제 vault의 design record:
|
||||
|
||||
```text
|
||||
raw/branch-notes/codex-jpa-production-capability.md
|
||||
```
|
||||
|
||||
에 다음을 누적한다.
|
||||
@@ -450,8 +449,6 @@ canonical 문서는 별도 요청 전 생성하지 않는다.
|
||||
전체 test에서 발견한 sample Flyway 회귀는 independent `V1` stream을 broad
|
||||
`classpath:db/migration`으로 합친 문제와 production/sample `V6` 충돌이었다. sample slice를
|
||||
legacy PostgreSQL location으로 한정하고 disposable poster migration을 `V7`로 이동했다. 세부
|
||||
재현·해결 기록은 Wiki
|
||||
`raw/errors/flyway-independent-stream-broad-root-collision-2026-07-28.md`에 남겼다.
|
||||
|
||||
2026-07-29 completion pass:
|
||||
|
||||
|
||||
@@ -195,7 +195,7 @@ authenticated internal endpoint
|
||||
10. P2에서 v2 claim/send/authority switch를 활성화하지 않는다.
|
||||
11. event/payload/schema/hash/credential/raw header는 log, metric tag, evidence artifact에 넣지
|
||||
않는다.
|
||||
12. 각 Wave exit에서 설계 §0 ledger, card maturity, plan checkbox, LLM Wiki branch-note를 실제
|
||||
12. 각 Wave exit에서 설계 §0 ledger, card maturity, plan checkbox, design record를 실제
|
||||
증거에 맞춰 갱신한다.
|
||||
13. plan surface 밖의 파일이나 타입이 필요하면 조용히 확장하지 않고 이 문서를 먼저 갱신한다.
|
||||
14. 설계와 plan이 충돌하면 구현으로 타협하지 않고 상세 설계를 먼저 수정·재승인한다.
|
||||
@@ -267,7 +267,7 @@ Wave A / P0
|
||||
- `src/adapter/outbound/messaging/src/test/java/dev/caskeleton/adapter/outbound/messaging/MessagingConfigTest.java`
|
||||
|
||||
- [ ] Capture current branch, `git status --short`, design digest, registry edges, dependency graph,
|
||||
migrations and current test counts in the LLM Wiki branch-note.
|
||||
migrations and current test counts in the design record.
|
||||
- [ ] Add characterization assertions for:
|
||||
broker blank → disabled sentinels; broker selected + missing sender → startup failure; broker ID
|
||||
mismatch → failure; sender normal return → legacy `PUBLISHED`; sender exception →
|
||||
@@ -693,7 +693,7 @@ change legacy rows.
|
||||
|
||||
- [ ] Confirm no production leaf imports `dev.caskeleton.sample`.
|
||||
- [ ] Update the design ledger to `P1=IMPLEMENTED_CANDIDATE` only if all Wave B evidence is GREEN.
|
||||
- [ ] Update the LLM Wiki branch-note; record whether a new derived raw document exists or explicitly
|
||||
- [ ] Update the design record; record whether a new derived raw document exists or explicitly
|
||||
record “없음”.
|
||||
|
||||
---
|
||||
@@ -1332,7 +1332,7 @@ cannot be deployed to all nodes, do not proceed to Wave D.
|
||||
|
||||
- [ ] Confirm broker/client/network resources are still 0 and v2 authority has not switched.
|
||||
- [ ] Update the design ledger to `P2=IMPLEMENTED_CANDIDATE` only from actual tests.
|
||||
- [ ] Update the LLM Wiki branch-note and derived-document decision.
|
||||
- [ ] Update the design record and derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -2094,7 +2094,7 @@ target deployment switch or destructively downgrade schema.
|
||||
- [ ] Keep Kafka/security cards at most `implemented-candidate`.
|
||||
- [ ] Update the design ledger to `P3=IMPLEMENTED_CANDIDATE` only after the dark graph and disposable
|
||||
cutover rehearsal pass; target authority is still legacy.
|
||||
- [ ] Update the LLM Wiki branch-note and derived-document decision.
|
||||
- [ ] Update the design record and derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -2544,7 +2544,7 @@ failed evidence or instruct operators to dual-send/raw-update.
|
||||
§0 as `P4=RELEASE_CANDIDATE_QUALIFIED_DEPLOYMENT_NOT_CUT_OVER`; target publication authority
|
||||
and production runtime remain legacy. P5/P6 stay `DESIGNED_NOT_IMPLEMENTED`, P7 stays
|
||||
`OPTIONAL_BACKLOG`.
|
||||
- [ ] Update the branch-note with release-candidate evidence and explicitly state target
|
||||
- [ ] Update the design record with release-candidate evidence and explicitly state target
|
||||
cutover/cleanup are pending. Do not make the final implementation-complete claim.
|
||||
|
||||
**Rollback checkpoint:** if aggregation fails, keep cards `implemented-candidate`, target
|
||||
@@ -2706,7 +2706,7 @@ authority and destructive downgrade are forbidden.
|
||||
|
||||
### Task 26: Complete observation, remove legacy runtime and requalify the cleanup artifact
|
||||
|
||||
**Owner:** all affected leaves + repository-wide verification/Wiki
|
||||
**Owner:** all affected leaves + repository-wide verification
|
||||
**Depends on:** Task 25, reviewed observation window, human cleanup approval
|
||||
|
||||
**Files — delete:**
|
||||
@@ -2848,7 +2848,6 @@ authority and destructive downgrade are forbidden.
|
||||
- `src/build.gradle`
|
||||
- `docs/superpowers/specs/2026-07-28-messaging-production-capability-design.md`
|
||||
- `docs/superpowers/plans/2026-07-28-messaging-first-r2-polling-producer.md`
|
||||
- `/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/main.md` and only genuinely
|
||||
derived raw documents
|
||||
|
||||
- [ ] Observation exit requires the reviewed duration with duplicate anomaly 0, unexpected
|
||||
@@ -2982,7 +2981,7 @@ authority and destructive downgrade are forbidden.
|
||||
- [ ] Keep retained V3 DB columns and canonical compatibility projection until a later forward
|
||||
schema cleanup. Do not drop columns or rewrite history here.
|
||||
- [ ] Re-run the runtime denylist GREEN across production Java, build files, YAML/env and registries;
|
||||
only the exact sample/R0 source allowlist may remain. Explicitly exclude design/spec/plan/Wiki
|
||||
only the exact sample/R0 source allowlist may remain. Explicitly exclude design/spec/plan
|
||||
history from raw-symbol matching: historical documentation is evidence, not an activation
|
||||
surface. Compile success alone is not bean/resource absence evidence. Run the same focused
|
||||
command GREEN; expect forbidden runtime match 0, canonical legacy bean/resource count 0 and
|
||||
@@ -2991,7 +2990,7 @@ authority and destructive downgrade are forbidden.
|
||||
It scans operational runbooks semantically for executable legacy activation keys, commands,
|
||||
dual-relay instructions or rollback-to-legacy actions, while allowing clearly labelled
|
||||
historical facts and “must remain disabled/forbidden” statements. It does not raw-match this
|
||||
plan/spec/branch-note.
|
||||
plan/spec/design record.
|
||||
|
||||
```bash
|
||||
cd src && ./gradlew :app-bootstrap:test \
|
||||
@@ -3078,12 +3077,11 @@ authority and destructive downgrade are forbidden.
|
||||
|
||||
- [ ] Update §0 and card status from the final R2 aggregate only. First R2 may be marked complete
|
||||
only after `verifyMessagingFinalR2Profile` passes; P5/P6/P7 remain unchanged.
|
||||
- [ ] Before final Wiki capture, read the configured vault's `AGENTS.md`, `CLAUDE.md` and relevant
|
||||
- [ ] Before final documentation update, read the configured vault's `AGENTS.md`, `CLAUDE.md` and relevant
|
||||
`rules/`, `.agents/`, `.claude/`, `.codex/` instructions. Resolve the branch with
|
||||
`git branch --show-current`; for this plan's current `main` branch the canonical target is:
|
||||
|
||||
```text
|
||||
/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/main.md
|
||||
```
|
||||
|
||||
Record implementation, files, decisions, exact commands/results/failures, release and rollout
|
||||
@@ -3091,7 +3089,7 @@ authority and destructive downgrade are forbidden.
|
||||
honestly produced; otherwise record “없음”. Canonical vault unavailability is an explicit
|
||||
completion blocker.
|
||||
- [ ] Final handoff lists changed files, behavior, exact verification counts/results, failed/not-run
|
||||
lanes, release/rollout fingerprints, Wiki capture and follow-up risks.
|
||||
lanes, release/rollout fingerprints, documentation update and follow-up risks.
|
||||
|
||||
**Rollback checkpoint:** after cleanup, do not restore legacy code for events already sent by v2.
|
||||
Pause admission, preserve schema/backlog/epoch/audit and forward-fix.
|
||||
@@ -3161,7 +3159,6 @@ Parallel work is allowed only at non-overlapping stable boundaries:
|
||||
| env/registries/runbooks | 23 |
|
||||
| no-skip pre-cutover release artifact + independent review | 24 |
|
||||
| exact-target approved deployment cutover evidence | 25 |
|
||||
| observation exit + legacy cleanup + cleanup-artifact requalification + final Wiki | 26 |
|
||||
|
||||
## 10. Follow-up plans after first R2
|
||||
|
||||
@@ -3199,5 +3196,5 @@ Parallel work is allowed only at non-overlapping stable boundaries:
|
||||
- operator mutation requires auth, expected generation/version, no active claim and immutable audit.
|
||||
- disabled and configured-but-not-ready are different states.
|
||||
- fake/single-node/local evidence cannot be relabelled as production R2.
|
||||
- implementation completion requires exact commands/results and LLM Wiki capture.
|
||||
- implementation completion requires exact commands/results and documentation update.
|
||||
- agent never stages, commits, amends or pushes.
|
||||
|
||||
@@ -186,7 +186,7 @@ SES SNS HTTPS callback
|
||||
않는다. 각 task 시작 전 `git status --short`로 overlap을 다시 확인한다.
|
||||
12. 새 타입이나 파일이 이 계획의 surface 밖에 필요하면 조용히 확장하지 말고 plan을 먼저
|
||||
갱신한다.
|
||||
13. 각 Wave exit에서 LLM Wiki branch-note를 갱신해 files, decisions, commands/results,
|
||||
13. 각 Wave exit에서 design record를 갱신해 files, decisions, commands/results,
|
||||
evidence grade와 blocker를 남긴다. 파생 raw 문서가 없으면 cluster에 “없음”을 명시한다.
|
||||
|
||||
## 6. Stop conditions
|
||||
@@ -241,7 +241,7 @@ SES SNS HTTPS callback
|
||||
`src/app-bootstrap/src/test/java/dev/caskeleton/adapter/outbound/OptionalAdapterBeanGatingTest.java`
|
||||
|
||||
- [x] Record the starting `git status --short`, current branch, registry edges and current provider
|
||||
dependencies in the branch-note.
|
||||
dependencies in the design record.
|
||||
- [x] Re-run the existing R0 behavior without changing it:
|
||||
|
||||
```bash
|
||||
@@ -806,7 +806,7 @@ removing bindings, but these types must remain while compiled consumers exist.
|
||||
- [x] Confirm application bytecode/import scan contains no Spring, JPA, Slack, AWS, JSON or HTTP
|
||||
provider type.
|
||||
- [x] Request an application/transaction boundary review before Wave B.
|
||||
- [x] Update the LLM Wiki branch-note with Wave A evidence and an explicit derived-document decision.
|
||||
- [x] Update the design record with Wave A evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -1041,7 +1041,7 @@ Task 18.
|
||||
httpclient.
|
||||
- [x] Request catalog/template/provider-SPI review.
|
||||
Final independent re-review: Blocker 0 / High 0.
|
||||
- [x] Update the LLM Wiki branch-note with Wave B evidence and an explicit derived-document decision.
|
||||
- [x] Update the design record with Wave B evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -1705,7 +1705,7 @@ and inspect accepted/indeterminate inventory before any code rollback.
|
||||
|
||||
- [ ] Capture PostgreSQL version, container image digest, test seed and fault matrix results.
|
||||
- [ ] Request durability/concurrency/crypto review before provider work.
|
||||
- [ ] Update the LLM Wiki branch-note with Wave C evidence and an explicit derived-document decision.
|
||||
- [ ] Update the design record with Wave C evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -1897,7 +1897,7 @@ references and never replay indeterminate sends automatically.
|
||||
|
||||
- [ ] Record actual loopback request counts and dependency/CVE/license review.
|
||||
- [ ] Request provider protocol review before ingress/composition.
|
||||
- [ ] Update the LLM Wiki branch-note with Wave D evidence and an explicit derived-document decision.
|
||||
- [ ] Update the design record with Wave D evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -2524,7 +2524,7 @@ indeterminate rows, preserve all referenced revisions and prefer forward-fix.
|
||||
```
|
||||
|
||||
- [ ] Request inbound-security, configuration, operations and privacy review.
|
||||
- [ ] Update the LLM Wiki branch-note with Wave E evidence and an explicit derived-document decision.
|
||||
- [ ] Update the design record with Wave E evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -2963,7 +2963,7 @@ route-specific and human-controlled.
|
||||
- [ ] Record the exact local/provider manifest digests, expiry, source/artifact revision and every
|
||||
skipped/not-run lane. Never copy evidence between cards or environments.
|
||||
- [ ] Request independent durability, provider-protocol, ingress-security and operations review.
|
||||
- [ ] Update the LLM Wiki branch-note with Wave F evidence and an explicit derived-document decision.
|
||||
- [ ] Update the design record with Wave F evidence and an explicit derived-document decision.
|
||||
|
||||
---
|
||||
|
||||
@@ -3838,7 +3838,7 @@ observation:**
|
||||
indeterminate. Pause admission, retain schema/revisions and forward-fix unless an exact route inventory
|
||||
proves zero duplicate risk.
|
||||
|
||||
### Task 22: Synchronize truth, run full gates, independent review and LLM Wiki capture
|
||||
### Task 22: Synchronize truth, run full gates, independent review and documentation update
|
||||
|
||||
**Owner:** repository-wide verification/documentation
|
||||
**Depends on:** all preceding tasks required by the selected release scope
|
||||
@@ -3859,7 +3859,7 @@ proves zero duplicate risk.
|
||||
- `src/app-bootstrap/CLAUDE.md`
|
||||
- `docs/runbooks/notification.md`
|
||||
- `docs/runbooks/notification-database-role-bootstrap.md`
|
||||
- LLM Wiki branch-note and only genuinely derived raw documents
|
||||
- design record and only genuinely derived raw documents
|
||||
|
||||
- [ ] Update implementation status from actual source/test/evidence only. Keep every unexecuted
|
||||
provider/load/rotation lane visibly `NOT_QUALIFIED`.
|
||||
@@ -3999,20 +3999,18 @@ proves zero duplicate risk.
|
||||
operational R2 candidate. If sandbox credentials/topology or the human candidate commit are not
|
||||
available, record the blocker and keep the card `NOT_QUALIFIED`; do not reuse pre-cutover
|
||||
evidence.
|
||||
- [ ] Before Wiki capture, read the configured vault's `AGENTS.md`, `CLAUDE.md`, and relevant
|
||||
- [ ] Before documentation update, read the configured vault's `AGENTS.md`, `CLAUDE.md`, and relevant
|
||||
`rules/`, `.agents/`, `.claude/`, `.codex/` instructions. Then update exactly
|
||||
`/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/<branch-name>.md` with
|
||||
implementation, files, decisions, commands/results/failures, evidence grade and remaining
|
||||
risks.
|
||||
- [ ] Add `raw/errors`, `raw/interviews`, `raw/blog-topics` only when honestly derived; link each child
|
||||
upward and the branch-note cluster back to each child. Otherwise record “없음” explicitly.
|
||||
- [ ] Do not mark this task complete if the canonical Wiki path is unavailable; record the precise
|
||||
upward and the design record cluster back to each child. Otherwise record “없음” explicitly.
|
||||
capture blocker.
|
||||
- [ ] A repository-wide gate that cannot run because of environment/tooling/authorization is a
|
||||
recorded blocker, not a pass. State the exact command and residual risk; do not claim Task 22
|
||||
complete.
|
||||
- [ ] Final handoff must list changed files, core behavior, exact verification results, not-run/failed
|
||||
commands, Wiki capture, evidence level and follow-up risks.
|
||||
commands, documentation update, evidence level and follow-up risks.
|
||||
|
||||
**Rollback checkpoint:** documentation must describe the deployed/evidenced truth, not the preferred
|
||||
rollback story. Do not rewrite evidence after a failed rollout.
|
||||
@@ -4062,7 +4060,7 @@ after the shared application contracts are GREEN:
|
||||
| bounded deadlines/concurrency/amplification | 4–7, 11–15, 18–20 |
|
||||
| health/metrics/traces/runbook | 18, 20 |
|
||||
| independent review | 22 |
|
||||
| LLM Wiki capture | 22 |
|
||||
| documentation update | 22 |
|
||||
|
||||
`minimum implementation R2`는 표의 required task가 실제로 GREEN이고 selected exact card의
|
||||
no-skip evidence가 fresh할 때만 사용할 수 있다. 일부 task만 끝났다면 해당 evidence row의
|
||||
|
||||
@@ -3,8 +3,7 @@
|
||||
- 작성일: 2026-07-28
|
||||
- 상태: Batch A–D 및 Batch E pause checkpoint를 main에 통합, Batch E 전체 gate와 R2는 미완료
|
||||
- 범위: 상세 설계 Phase 0–6; Phase 7/R3는 별도 승인 계획
|
||||
- LLM Wiki capture: public vault의
|
||||
`raw/branch-notes/chore-main-worktree-capability-integration.md`에 main 통합 기록 완료
|
||||
- documentation update: public vault의
|
||||
|
||||
> **For agentic workers:** REQUIRED SUB-SKILLS: use
|
||||
> `superpowers:subagent-driven-development` to execute independent tasks,
|
||||
@@ -61,7 +60,6 @@ Batch E의 개별 focused fix 증거는
|
||||
[Batch E pause checkpoint](../../evidence/object-storage/batch-e-pause-checkpoint.md)에 기록됐다.
|
||||
당시 Batch E combined/root gate는 재실행되지 않았으므로 Batch E 전체 완료나 R2를 주장하지
|
||||
않는다. 격리 브랜치에서 잘못 선택했던 private vault 경로 대신, main 통합 작업은 사용자가
|
||||
지정한 public vault의 `raw/branch-notes/chore-main-worktree-capability-integration.md`에
|
||||
캡처했다.
|
||||
|
||||
---
|
||||
@@ -94,7 +92,6 @@ Batch E의 개별 focused fix 증거는
|
||||
10. At every batch boundary, update the implementation-status section in the design and this plan.
|
||||
Do not mark a task complete from code inspection alone.
|
||||
11. Every Batch A–F checkpoint is a meaningful-work capture boundary. Re-read the canonical LLM
|
||||
Wiki instructions, update the branch note and any honest derivatives, or record the exact
|
||||
canonical-vault access block in both this plan and the design before starting the next batch.
|
||||
A final Task 30 capture does not replace these per-batch records.
|
||||
|
||||
@@ -154,7 +151,7 @@ Batch A: Phase 0–1 contract
|
||||
|
||||
Every checkpoint named below has three inseparable outputs: (1) the stated GREEN commands and
|
||||
zero-selected-skip evidence, (2) updated plan/design implementation status and truthful readiness
|
||||
rows, and (3) a canonical LLM Wiki branch-note update or the exact canonical-vault access block.
|
||||
rows, and (3) a canonical design record update or the exact canonical-vault access block.
|
||||
This applies to A at Task 5, B at Task 10, C at Task 16, D at Task 19, E at Task 24, and F at
|
||||
Task 30; a batch is not closed if any output is missing.
|
||||
|
||||
@@ -1766,7 +1763,7 @@ bash ../.github/scripts/verify-gate-matrix.sh
|
||||
|
||||
Expected: PASS after the required MinIO direct lanes have passed with zero selected skips. Re-run
|
||||
`ObjectStorageReadinessRegistryTest` as part of `check`; record both AWS managed/direct lanes as
|
||||
authority-pending, not as passed evidence. Perform the mandatory Batch D status/Wiki capture before
|
||||
authority-pending, not as passed evidence. Perform the mandatory Batch D status/documentation update before
|
||||
Approval Gate A.
|
||||
|
||||
---
|
||||
@@ -3277,7 +3274,7 @@ authorization/rate limiting, or direct API snapshot. A reconciliation row may re
|
||||
the bounded backup/restore qualification passes; retention may reach R2 only when every mandatory
|
||||
Object-Lock/role/negative test above passes.
|
||||
|
||||
### Task 30: Complete documentation, full gates, independent review, and Wiki capture
|
||||
### Task 30: Complete documentation, full gates, independent review, and documentation update
|
||||
|
||||
**Files:**
|
||||
|
||||
@@ -3442,12 +3439,11 @@ Review at least these tracks independently:
|
||||
Resolve every blocker/high (or Critical/Important) finding and rerun affected focused plus full
|
||||
gates.
|
||||
|
||||
- [ ] **Step 6: Capture the required LLM Wiki record**
|
||||
- [ ] **Step 6: Capture the required repository documentation record**
|
||||
|
||||
Before the implementation completion response, read the canonical vault instructions and update:
|
||||
|
||||
```text
|
||||
/home/donghyeon/workspace/ai-tools/llm-wiki/raw/branch-notes/<branch-name>.md
|
||||
```
|
||||
|
||||
Record files, decisions, test commands/results, failures/blocks, evidence grade, and derivative
|
||||
@@ -3457,7 +3453,7 @@ different clone; record the exact block in the plan/design and final response.
|
||||
- [ ] **Step 7: Report exact completion**
|
||||
|
||||
The handoff must list changed files, implementation slices, exact commands/results, failures or
|
||||
unrun protected lanes, Wiki capture, card/provider/profile/evidence tuples, rollback posture, and
|
||||
unrun protected lanes, documentation update, card/provider/profile/evidence tuples, rollback posture, and
|
||||
remaining gates. Never use “Objectstorage R2” as an unqualified completion statement.
|
||||
|
||||
---
|
||||
|
||||
@@ -505,7 +505,7 @@ response-only cut 등 실행 여부가 불확실한 mutation은 `INDETERMINATE`
|
||||
- 성공/실패 모두 exact VM allowlist를 teardown하고 lab resource가 0인지 확인한다. local
|
||||
retain-on-failure opt-in은 명시된 경우만 허용하고 CI에서는 금지한다.
|
||||
|
||||
## Task 12 — CI, runbook, verification와 Wiki capture
|
||||
## Task 12 — CI, runbook, verification와 documentation update
|
||||
|
||||
**CI**
|
||||
|
||||
@@ -532,8 +532,7 @@ cd src
|
||||
**Documentation**
|
||||
|
||||
- capability별 실제 readiness와 남은 R3 한계를 README/spec/runbook에 동기화한다.
|
||||
- 실행 명령, image/config/program digest, 실패/차단을 public LLM Wiki
|
||||
`/home/donghyeon/workspace/ai-tools/llm-wiki/raw/branch-notes/main.md`에
|
||||
- 실행 명령, image/config/program digest, 실패/차단을 public repository documentation
|
||||
기록하고 실제 파생 오류/면접/블로그 raw 문서를 양방향 링크한다.
|
||||
|
||||
**Completion gate**
|
||||
@@ -651,7 +650,7 @@ cd src
|
||||
않는다.
|
||||
- `docs/registries/metrics.yaml`과 runbook을 실제 emitted metric과 동기화한다.
|
||||
|
||||
## Task 17 — Resume final review, readiness truth, verification와 Wiki
|
||||
## Task 17 — Resume final review, readiness truth, verification
|
||||
|
||||
- Task 13–16을 task별 spec/code-quality review한다.
|
||||
- Redis deep design §39/§40을 독립 재검토해 selected/implemented-candidate/not-implemented를 실제
|
||||
@@ -659,4 +658,4 @@ cd src
|
||||
- Sentinel/Cluster/k3s/R3 evidence가 없으면 지원/완료로 표기하지 않는다.
|
||||
- Task 12의 전체 검증을 실행하고 동시 작업의 비-Redis 실패는 소유 파일과 증거를 분리한다.
|
||||
- Redis README/spec/runbook, readiness registry, CI artifact 계약을 동기화한다.
|
||||
- LLM Wiki branch-note와 실제 파생 raw 문서를 양방향 링크로 캡처한다.
|
||||
- design record와 실제 파생 raw 문서를 양방향 링크로 캡처한다.
|
||||
|
||||
@@ -63,7 +63,7 @@ and release-blocked by real protocol evidence without adding them to the default
|
||||
locks, env keys, architecture, public path, wrapper validation, and `git diff --check`.
|
||||
- [ ] Run full `test`/`check` in proportion to the cross-cutting registry/build changes.
|
||||
- [ ] Request independent read-only review; resolve all Critical/Important findings.
|
||||
- [ ] Capture the batch in the LLM Wiki before final completion reporting.
|
||||
- [ ] Capture the batch in the repository documentation before final completion reporting.
|
||||
|
||||
### Explicit P2 Deferral
|
||||
|
||||
|
||||
@@ -88,7 +88,6 @@ schema validator and contract test introduced no SpotBugs finding.
|
||||
- [x] Enforce an exact catalog for every tracked registry, including object-storage readiness.
|
||||
- [ ] Resolve every stable `required_test` ID exactly once and reject dangling mappings.
|
||||
- [ ] Replace the Java runbook stub allowlist with owned, issue-linked, expiring debt data.
|
||||
- [ ] Clarify tracked registry ownership and private-wiki provenance.
|
||||
- [x] Run schema, object-storage readiness, runbook, app-bootstrap, and root checks. The checks
|
||||
exercise the mechanically enforceable catalog/containment rules; the three semantic migrations
|
||||
above remain explicitly blocked on project-owner evidence.
|
||||
@@ -141,7 +140,6 @@ The focused RED failed only because `migration-failed.md` was an unexpected lega
|
||||
After the containment change, the focused Runbook contract passed with 6 tests, zero failures, and
|
||||
zero skips. Fresh verification also passed `:app-bootstrap:spotlessJavaCheck` and
|
||||
`:app-bootstrap:check` (77 tasks; 18 executed, 59 up-to-date). Owner, issue, start/sunset,
|
||||
expiry enforcement, and the private-wiki provenance migration remain deliberately incomplete and
|
||||
the corresponding Batch 5 checkboxes remain open.
|
||||
|
||||
### Batch 5-B/C unresolved semantic migrations audit (2026-08-02)
|
||||
@@ -158,7 +156,6 @@ enabled.
|
||||
The runbook corpus contains 43 stub documents, all with response owner `oncall` but no accountable
|
||||
debt owner, real issue, approved expiry, or bounded debt window. The seven legacy registries contain
|
||||
30 distinct `owner_branch` labels, none resolving to a current local/remote Git ref, while their
|
||||
private-wiki paths are absent from a fresh clone. The repository files are now protected as the
|
||||
tracked artifacts, but current owner IDs, historical-label migration, CODEOWNERS identities,
|
||||
runbook expiry dates, the `INTERNAL_ERROR` reverse-link decision, and the four umbrella-runbook
|
||||
retention decisions require real project-owner input. Placeholder owners, issues, selectors, and
|
||||
@@ -226,7 +223,7 @@ passed, and a fresh repository `check` subsequently passed with the same boundar
|
||||
- [x] Run full Gradle tests/checks and all repository validators.
|
||||
- [x] Request an independent P2 code review, resolve actionable findings, and record semantic
|
||||
blockers separately.
|
||||
- [x] Update the LLM Wiki branch note and any honest derived raw documents.
|
||||
- [x] Update the design record and any honest derived raw documents.
|
||||
|
||||
Fresh aggregate evidence (2026-08-02):
|
||||
|
||||
@@ -245,17 +242,15 @@ Fresh aggregate evidence (2026-08-02):
|
||||
tracked-file assumption audit now reports only four Docker/Testcontainers integration
|
||||
assumptions; no registry or repository-contract assumption remains.
|
||||
|
||||
LLM Wiki capture evidence (2026-08-02): `raw/branch-notes/main.md` records the integrated P1/P2
|
||||
implementation, decisions, validation commands, failures, evidence grades, and unresolved semantic
|
||||
migrations. It links bidirectionally to one resolved error note, one interview-prep note, and one
|
||||
blog-topic note. The vault's targeted structure lint passed all three derived documents. The branch
|
||||
note passed its content, frontmatter, required-section, and wikilink checks but retained one explicit
|
||||
`NAMING_VIOLATION`: repository policy requires `<branch-name>.md` (`main.md`) while the vault naming
|
||||
rule permits only `feature|fix|chore|experiment-` branch-note prefixes. Neither policy was silently
|
||||
rule permits only `feature|fix|chore|experiment-` design record prefixes. Neither policy was silently
|
||||
weakened; the exact conflict is the recorded capture-validation blocker.
|
||||
|
||||
Independent aggregate review evidence (2026-08-02): the first pass reported zero critical,
|
||||
three important, and two minor findings. Wiki capture closed the capture-pending finding; the two
|
||||
three important, and two minor findings. documentation update closed the capture-pending finding; the two
|
||||
remaining important items were reclassified as the three project-semantic blockers already kept
|
||||
open in Batch 5. The two minor code findings were corrected with an exact test-fixture-only
|
||||
GraphQL SpotBugs exclusion and registry-derived scanning of all 18 production leaves in
|
||||
@@ -264,5 +259,4 @@ assumption/upward-directory search in `PortfolioErrorCodeRegistryMappingTest`, r
|
||||
canonical repository-root property, relative Gradle input, and missing-root/symlink-escape
|
||||
fail-closed checks. The re-review found no new code defect; its only completion-evidence concern
|
||||
was a stale SampleRemoval XML, addressed by the final repository `check` after these corrections.
|
||||
The reviewer retained only the Wiki naming-policy disclosure and this Batch 5 checkbox wording as
|
||||
minor documentation findings; both are now explicit here and in the branch note.
|
||||
minor documentation findings; both are now explicit here and in the design record.
|
||||
|
||||
@@ -341,15 +341,13 @@ from the audit inventory
|
||||
./gradlew check --warning-mode=fail --no-daemon --console=plain
|
||||
```
|
||||
|
||||
## Task 10: Fresh repository verification, review, and Wiki capture
|
||||
## Task 10: Fresh repository verification, review, and documentation update
|
||||
|
||||
**Files:**
|
||||
|
||||
- Modify: `docs/superpowers/plans/2026-08-02-warning-zero-build-refactoring.md` only if execution
|
||||
evidence exposes a plan correction.
|
||||
- Modify external Wiki capture:
|
||||
`/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/main.md`
|
||||
and `raw/errors/build-success-warning-debt-2026-08-02.md`.
|
||||
- Modify external documentation update:
|
||||
|
||||
**Steps:**
|
||||
|
||||
@@ -381,7 +379,5 @@ from the audit inventory
|
||||
cases and no qualification source set skipped.
|
||||
6. Dispatch independent code review over behavior fixes, legacy/provider migrations, and
|
||||
Gradle/test-noise gates. Apply only evidence-backed findings and rerun affected/full gates.
|
||||
7. Update the mandatory Wiki branch/error notes with changed files, commands, results, suppression
|
||||
inventory, blocked environment-only qualifications, and evidence grade. Run per-file Wiki lint;
|
||||
retain the known `main.md` naming-policy conflict without weakening either policy.
|
||||
8. Report success only if the clean build is exit zero and the final log is warning/noise clean.
|
||||
|
||||
@@ -100,8 +100,7 @@ Every task in every wave plan implicitly includes this section.
|
||||
dependency edges, and runtime memberships. Never infer them from a document.
|
||||
- Focused tests are derived as `./gradlew <gradle_path>:test --console=plain`, read from that
|
||||
registry.
|
||||
- Non-trivial work ends with an LLM Wiki capture at
|
||||
`/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/<branch-name>.md`
|
||||
- Non-trivial work ends with an documentation update at
|
||||
(`AGENTS.md:79-90`).
|
||||
- All Gradle commands run from `src/`, which is the Gradle root.
|
||||
|
||||
@@ -210,7 +209,7 @@ order; a wave's exit criterion is the entry criterion of the next.
|
||||
| 3 | [wave3-environment-and-infra](2026-08-15-wave3-environment-and-infra.md) | Env-source separation, profileless fail-closed, Compose contract SSOT + both scripts, Keycloak realm, MinIO round trip | The full Compose lane matrix passes zero-skip with evidence |
|
||||
| 4 | [wave4-warning-zero](2026-08-15-wave4-warning-zero.md) | MeterFilter ordering, BeanPostProcessor early-instantiation removal, Flyway warning root cause, IDE suppression narrowing, log/profile agreement | `local`, `dev`, `prod` startup logs contain zero WARN and zero ERROR, with an empty allowlist |
|
||||
| 5 | [wave5-gradle-build-logic](2026-08-15-wave5-gradle-build-logic.md) | `build-logic` included build with eight TestKit-tested convention plugins; duplicated source-set/lane/API-surface machinery removed | Task graph, dependency graph, test selection, and evidence output are byte-identical to the Wave 4 baseline |
|
||||
| 6 | [wave6-final-qualification](2026-08-15-wave6-final-qualification.md) | Full `clean check`, the activation matrix, every environment smoke, doc/metadata drift checks, Wiki capture | Every Definition-of-Done checkbox in spec §13 is ticked with attached evidence |
|
||||
| 6 | [wave6-final-qualification](2026-08-15-wave6-final-qualification.md) | Full `clean check`, the activation matrix, every environment smoke, doc/metadata drift checks, documentation update | Every Definition-of-Done checkbox in spec §13 is ticked with attached evidence |
|
||||
|
||||
### Design patterns (spec §8) — where each one lands
|
||||
|
||||
|
||||
@@ -1583,7 +1583,7 @@ Rules to implement, one test case each:
|
||||
|
||||
**Context (spec §4.3):** `management.endpoint.health.group.readiness.include: readinessState,db` is
|
||||
static while `validate-group-membership: true`. With JPA off there is no `db` contributor and startup
|
||||
fails on a name that cannot resolve. The repository already solves this shape once —
|
||||
fails on a name that cannot resolve. The repository already solves this shape once —
|
||||
`RedisReadinessGroupPostProcessor` appends `redisRequired` from the same predicate that creates the
|
||||
bean, and `application.yml:248-278` explains at length why naming a conditional contributor
|
||||
statically is wrong. `ReadinessGroupContributor` follows that precedent for `db`.
|
||||
|
||||
@@ -30,7 +30,7 @@ Inherited from the index. Wave 6 adds:
|
||||
completion without the verification, or without naming why it could not run, a stop condition.
|
||||
- **No conclusion broader than its evidence** (HARD-STOP 7). "The matrix passed" requires the matrix,
|
||||
not a representative lane.
|
||||
- **The wave ends with the LLM Wiki capture** required by `AGENTS.md:79-90`, or with an explicit
|
||||
- **The wave ends with the documentation update** required by `AGENTS.md:79-90`, or with an explicit
|
||||
reported reason it was blocked.
|
||||
|
||||
---
|
||||
@@ -196,28 +196,23 @@ Walk spec §13 and tick each box **only** with attached evidence. Reproduced her
|
||||
- [ ] Every P0 blocker on a runtime path from the detailed module reviews is either closed or its
|
||||
capability is explicitly inactive/experimental.
|
||||
- [ ] Changed files, commands, results, not-run/blocked items, and evidence grades are captured in the
|
||||
LLM Wiki branch-note.
|
||||
design record.
|
||||
|
||||
## Task 7: LLM Wiki capture
|
||||
## Task 7: documentation update
|
||||
|
||||
Per `AGENTS.md:79-90`:
|
||||
|
||||
- [ ] Create or update
|
||||
`/home/donghyeon/workspace/ai-tool/llm-wiki-private/raw/branch-notes/<branch-name>.md` with the
|
||||
implementation, changed files, decisions, verification commands, failures/blocks, and evidence
|
||||
grades.
|
||||
- [ ] Create derived documents where genuine material exists: `raw/errors/`, `raw/interviews/`,
|
||||
`raw/blog-topics/`. Each links upward via `## Parent`; the branch-note's `## Cluster / 묶음`
|
||||
links back.
|
||||
- [ ] Where no derived document is warranted, record that judgement explicitly ("추출할 별도 글감
|
||||
없음") rather than omitting the section.
|
||||
- [ ] Do not create `wiki/blog/`, `wiki/interview/`, `wiki/portfolio/`, `wiki/concepts/`, or
|
||||
`wiki/projects/` without an explicit canonical extraction request.
|
||||
|
||||
## Task 8: Final report
|
||||
|
||||
Per `AGENTS.md:239-251`, the closing response states: changed files; the core changes; verification
|
||||
commands run; verifications that failed or could not run, with reasons; the Wiki capture result; and
|
||||
commands run; verifications that failed or could not run, with reasons; the documentation update result; and
|
||||
remaining risks or follow-ups.
|
||||
|
||||
- [ ] Explicitly restate what remains **out of scope and not production-ready**, from the index's scope
|
||||
@@ -232,6 +227,6 @@ remaining risks or follow-ups.
|
||||
not-met with its reason.
|
||||
- [ ] `docs/superpowers/plans/evidence/2026-08-15-wave6-final/` holds the output of every command in
|
||||
Tasks 1–4.
|
||||
- [ ] The LLM Wiki branch-note exists and links its derived documents.
|
||||
- [ ] The design record exists and links its derived documents.
|
||||
- [ ] No completion, "all passing", or "production-ready" claim appears anywhere without the command
|
||||
output that supports it.
|
||||
|
||||
@@ -0,0 +1,12 @@
|
||||
# Bootstrap Structured Log Fields — Plan
|
||||
|
||||
- [x] Centralize meter/fallback warning shapes in RuntimeWarnings
|
||||
- [x] Structure fileserver cleanup outcome and retry logs
|
||||
- [x] Structure outbox scheduler catch-all retry log without inventing an error code
|
||||
- [x] Structure distributed-lock lease-expiry warning without promoting lock key to a field
|
||||
- [x] Preserve existing startup and async structured fields
|
||||
- [x] Add behavior test over real Logback events
|
||||
- [x] Add operator-facing log-field dictionary
|
||||
- [x] Run app-bootstrap formatting/full unit/architecture regression
|
||||
- [x] Prove no WARN/ERROR production log remains without structured fields
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,11 @@
|
||||
# Bootstrap Structured Runtime Logging — Plan
|
||||
|
||||
- [x] Add structured fields to FileserverCleanupWorker success/failure logs
|
||||
- [x] Add structured fields to OutboxRelayScheduler unexpected failure log
|
||||
- [x] Add structured fields to MeteredDistributedLockPort lease-expiry warning
|
||||
- [x] Add behavior tests that inspect actual Logback structured arguments
|
||||
- [x] Add bootstrap operational log-field dictionary
|
||||
- [x] Prove direct WARN/ERROR paths are either structured locally or routed through RuntimeWarnings
|
||||
- [x] Run focused logging tests
|
||||
- [x] Run app-bootstrap full test/architecture regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,46 @@
|
||||
# Deployment Composition Reachability Remediation — Plan
|
||||
|
||||
## Stage 0 — global Clock
|
||||
|
||||
- [x] Add RED contract for Boot import discovery of the application Clock auto-configuration
|
||||
- [x] Add RED composition contract for exactly one default Clock and adopter override
|
||||
- [x] Add BootstrapClockAutoConfiguration
|
||||
- [x] Register it in app-bootstrap AutoConfiguration.imports
|
||||
- [x] Remove the idempotency-owned Clock bean
|
||||
- [x] Keep GraphQL standalone conditional fallback
|
||||
- [x] Run focused Clock/import tests
|
||||
- [x] Run app-bootstrap unit/architecture regression
|
||||
|
||||
## Stage 1 — currently unreachable bootstrap capability roots
|
||||
|
||||
- [x] Re-measure each Redis/outbox/lock/idempotency/tracing root against current conditions
|
||||
- [x] Make Redis semantic composition a shipped auto-configuration ordered after Redis SDK
|
||||
- [x] Make outbox composition a shipped auto-configuration preserving outbox.enabled
|
||||
- [x] Make distributed-lock composition a shipped auto-configuration preserving its activation policy
|
||||
- [x] Split idempotency scheduling from unconditional configuration and ship provider/application roots safely
|
||||
- [x] Make tracing composition reachable without creating active tracing when disabled
|
||||
- [x] Prove all-off still has no optional capability workers/adapters
|
||||
- [x] Prove each enabled target is reachable from the shipped composition root
|
||||
|
||||
## Stage 2 — HTTP client structural gating
|
||||
|
||||
- [x] Add HTTP-client auto-configuration package to AUTO_CONFIGURED_PACKAGES
|
||||
- [x] Add shipped-root off/on regression proof
|
||||
- [x] Prove child configurations cannot leak through component scan
|
||||
|
||||
## Stage 3 — recurrence prevention
|
||||
|
||||
- [x] Add generic AutoConfiguration.imports reachability parity
|
||||
- [x] Add optional-root imported-child scan-exclusion parity
|
||||
- [x] Add off-import-filter target-list parity
|
||||
- [x] Add negative fixtures proving the checks fail on missing import, scanned child and stale filter target
|
||||
|
||||
## Regression
|
||||
|
||||
- [x] app-bootstrap test
|
||||
- [x] app-bootstrap architectureTest — PASS after the shared-worktree malformed Javadoc was repaired without changing architecture semantics
|
||||
- [x] app-bootstrap systemTest
|
||||
- [x] affected leaf checks
|
||||
- [x] verifyCleanArchitectureDependencies
|
||||
- [x] sample-portfolio check
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,15 @@
|
||||
# HTTP Client Capability Composition Ownership — Plan
|
||||
|
||||
- [x] Add generic capability startup-validation failure support and reporter coverage
|
||||
- [x] Move StrictSettingsBinder to outbound support without duplicating binding policy
|
||||
- [x] Move HTTP-client settings/binding/env-key ownership to the HTTP-client leaf
|
||||
- [x] Move HTTP-client Spring auto-configuration and actuator ownership to the leaf
|
||||
- [x] Move focused HTTP-client auto-configuration tests to the leaf
|
||||
- [x] Publish HTTP-client root auto-configuration from the leaf JAR
|
||||
- [x] Remove the bootstrap HTTP-client auto-configuration import and production package
|
||||
- [x] Prove disabled capability creates no runtime beans
|
||||
- [x] Prove enabled capability still assembles blocking/reactive client runtime and safety guards
|
||||
- [x] Prove app-bootstrap/src/main has zero HTTP-client capability imports
|
||||
- [x] Run HTTP-client unit/security/integration regression, bootstrap test/architecture regression
|
||||
- [x] Refresh only affected dependency locks
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,26 @@
|
||||
# JPA Capability Composition Ownership — Plan
|
||||
|
||||
- [x] Add package-private leaf Boot roots under the JPA master switch
|
||||
- [x] Move vendor/entity/repository/component import ownership to the leaf root
|
||||
- [x] Add leaf-owned transaction executor and retry runtime composition
|
||||
- [x] Move the existing JPA observation composition factory to the leaf without inventing new activation semantics
|
||||
- [x] Keep OSIV/DDL, datasource/version and migration startup policy in app-bootstrap
|
||||
- [x] Reduce PersistenceJpaRootAutoConfiguration to application startup policy only
|
||||
- [x] Move leaf-owned composition tests to persistence-jpa
|
||||
- [x] Register `autoconfigure` in the JPA package dependency catalog and entity-scan exemption registry
|
||||
- [x] Prove JPA public API surface remains unchanged
|
||||
- [x] Prove persistence-jpa production has zero bootstrap imports
|
||||
- [x] Prove JPA-off structural gating is still rooted at the same master switch
|
||||
- [x] Run persistence-jpa unit/check gates
|
||||
- [x] Run PostgreSQL transaction integration against a real database
|
||||
- [x] Run app-bootstrap test/architecture regression
|
||||
- [x] Dependency-lock review: no coordinate changed, so no lock refresh was required
|
||||
- [x] git diff --check
|
||||
|
||||
## Environment note
|
||||
|
||||
The first PostgreSQL transaction-lane run reached Docker and started Ryuk, but the remote host could
|
||||
not connect back to Ryuk through `172.17.0.1:<mapped-port>`. The fail-closed readiness guard therefore
|
||||
reported Docker unavailable before PostgreSQL creation. The same lane passed with
|
||||
`TESTCONTAINERS_RYUK_DISABLED=true`; this was process-local verification only and did not change the
|
||||
repository's Testcontainers policy.
|
||||
@@ -0,0 +1,11 @@
|
||||
# JPA Runtime Master Switch — Plan
|
||||
|
||||
- [x] Change the focused runtime fixture so normal runtime tests explicitly enable JPA
|
||||
- [x] Add a RED test proving JPA-off contributes no runtime beans
|
||||
- [x] Add the JPA master condition to PersistenceJpaRuntimeConfig
|
||||
- [x] Preserve the existing addons-enabled secondary switch
|
||||
- [x] Add/retain an addons-off test under JPA-on
|
||||
- [x] Run focused persistence-jpa runtime tests
|
||||
- [x] Run persistence-jpa check and public API surface gate
|
||||
- [x] Run app-bootstrap unit/architecture/system composition regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,14 @@
|
||||
# Mongo Health Composition Ownership — Plan
|
||||
|
||||
- [x] Add spring-boot-health to persistence-mongo
|
||||
- [x] Add package-private Mongo Actuator health contributor/config in the leaf
|
||||
- [x] Import leaf health config from MongoRootAutoConfiguration
|
||||
- [x] Move health SPI tests from app-bootstrap to persistence-mongo
|
||||
- [x] Remove bootstrap Mongo production health bridge
|
||||
- [x] Preserve bean name, master switch and override/back-off semantics
|
||||
- [x] Prove Mongo public API surface remains unchanged
|
||||
- [x] Prove app-bootstrap Mongo production ownership is zero
|
||||
- [x] Refresh persistence-mongo dependency lock only
|
||||
- [x] Run persistence-mongo test/check gates
|
||||
- [x] Run app-bootstrap test/architecture regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,25 @@
|
||||
# Notification Capability Composition Ownership — Plan
|
||||
|
||||
- [x] Replace bootstrap StartupFailures dependency in notification secrets with capability startup validation
|
||||
- [x] Move reusable Notification core/runtime/configuration slices to the notification leaf
|
||||
- [x] Keep TransactionPort-bound application/use-case composition in app-bootstrap
|
||||
- [x] Move health/observation support and required actuator dependencies to the leaf
|
||||
- [x] Move leaf-owned notification composition tests to the leaf
|
||||
- [x] Keep cross-layer callback composition evidence in app-bootstrap
|
||||
- [x] Reuse NotificationPlatformAutoConfiguration as the leaf Boot entry point
|
||||
- [x] Keep newly moved internal Spring configuration out of the public API surface
|
||||
- [x] Remove the old bootstrap NotificationRootAutoConfiguration
|
||||
- [x] Update activation/import coverage to capability-owned FQCNs
|
||||
- [x] Prove notification leaf has zero bootstrap imports
|
||||
- [x] Prove notification leaf has zero TransactionPort dependencies
|
||||
- [x] Reduce app-bootstrap Notification production ownership to application composition only
|
||||
- [x] Run notification API/configuration/evidence/check gates
|
||||
- [x] Run app-bootstrap test/architecture regression including NTF-020
|
||||
- [x] Refresh affected dependency locks only
|
||||
- [x] git diff --check
|
||||
|
||||
## Deferred build-inclusion edge
|
||||
|
||||
NotificationApplicationCompositionAutoConfiguration currently imports NotificationDispatchProperties.
|
||||
That single typed runtime-bounds edge is intentionally deferred to the build-inclusion/runtimeOnly
|
||||
phase rather than duplicating the Notification configuration SSOT in app-bootstrap.
|
||||
@@ -72,14 +72,14 @@
|
||||
- [x] `:adapter:outbound:persistence-jpa:check`
|
||||
- [x] focused PostgreSQL migration/outbox integration lane
|
||||
- [x] `:adapter:outbound:messaging:check`
|
||||
- [ ] `:sample-portfolio:check` — blocked by pre-existing `JpaLiveEventReplayAdapter` missing `Duration` wiring; the same 3 `SampleApplicationContextTest` failures reproduce on clean HEAD.
|
||||
- [x] `:sample-portfolio:check`
|
||||
- [x] focused sample outbox regression tests (`PosterEventPublisherTest`, `CreateWorkLogOutboxTest`, `WorkLogUseCasesTest`, `WorkLogAuthorizationContractTest`)
|
||||
- [x] `:app-bootstrap:architectureTest :app-bootstrap:systemTest`
|
||||
- [x] `verifyCleanArchitectureDependencies`
|
||||
- [x] `:app-bootstrap:verifyEnvKeys`
|
||||
- [x] static scans: no platform runtime/Kafka import in canonical bridge
|
||||
- [x] `git diff --check`
|
||||
- [x] no separate LLM Wiki branch-note warranted; spec, plan, module README/CLAUDE and configuration reference carry the implementation decision.
|
||||
- [x] no separate design record warranted; spec, plan, module README/CLAUDE and configuration reference carry the implementation decision.
|
||||
|
||||
## Verification result
|
||||
|
||||
@@ -99,7 +99,8 @@ Passed:
|
||||
- `:app-bootstrap:verifyEnvKeys`
|
||||
- `git diff --check`
|
||||
|
||||
Known unrelated blocker:
|
||||
- full `:sample-portfolio:check` still fails only the 3 previously documented `SampleApplicationContextTest` cases because `JpaLiveEventReplayAdapter` requires an unbound `Duration` bean. This reproduces on clean HEAD and was not introduced by this cutover.
|
||||
Historical blocker resolved:
|
||||
- `:sample-portfolio:check` now passes in full. The earlier `JpaLiveEventReplayAdapter` / `Duration`
|
||||
composition failure is no longer present in the current checkout.
|
||||
|
||||
Publication authority remains `LEGACY_POLLING`; no code path in this slice activates `POLLING_V2`.
|
||||
|
||||
@@ -0,0 +1,35 @@
|
||||
# Outbox V2 Canonical Storage Alignment — Plan
|
||||
|
||||
- [x] Make NewOutboxEventV2 wrap ValidatedIntegrationEvent only
|
||||
- [x] Make ClaimedOutboxDelivery carry ValidatedIntegrationEvent
|
||||
- [x] Add canonical event fixtures/tests in application-core
|
||||
- [x] Add forward-only outbox-storage V2 canonical metadata migration
|
||||
- [x] Add forward-only outbox-polling V2 event-id widening migration
|
||||
- [x] Preserve pre-canonical rows as an explicit all-null compatibility generation
|
||||
- [x] Persist exact envelope BYTEA and canonical metadata in PostgreSqlImmutableOutboxAppendAdapter
|
||||
- [x] Compare duplicate intent using canonical fields/hash without re-encoding
|
||||
- [x] Reconstruct ValidatedIntegrationEvent in PostgreSqlPollingDeliveryAdapter
|
||||
- [x] Fail closed on pre-canonical/partial rows
|
||||
- [x] Update storage/polling PostgreSQL integration tests
|
||||
- [x] Keep LEGACY_POLLING as default/active authority in this slice
|
||||
- [x] Run application-core check
|
||||
- [x] Run persistence-jpa unit/check gates
|
||||
- [x] Run real PostgreSQL outbox storage and polling integration lanes
|
||||
- [x] Run verifyCleanArchitectureDependencies
|
||||
- [x] git diff --check
|
||||
|
||||
## Verification note
|
||||
|
||||
- `:application-core:test`: PASS.
|
||||
- `:application-core:check -x :application-core:spotlessCheck`: PASS. The full application-core
|
||||
Spotless gate remains blocked only by two pre-existing unrelated accumulated test-formatting
|
||||
changes: `ObjectStorageArchitectureContractTest` and `CompiledPackageScanner`; none of the files
|
||||
changed by this slice are reported by Spotless.
|
||||
- `:adapter:outbound:persistence-jpa:check`: PASS.
|
||||
- `:adapter:outbound:persistence-jpa:verifyJpaApiSurface`: PASS; committed public API surface
|
||||
unchanged.
|
||||
- `verifyCleanArchitectureDependencies`: PASS.
|
||||
- Real PostgreSQL storage and polling integration lanes: PASS with process-local
|
||||
`TESTCONTAINERS_RYUK_DISABLED=true` because this remote host cannot connect back to Ryuk. No
|
||||
repository Testcontainers policy was changed.
|
||||
- Publication authority was not switched and no V2 relay bean/scheduler was introduced.
|
||||
@@ -0,0 +1,23 @@
|
||||
# Outbox V2 One-Record Publication Policy — Plan
|
||||
|
||||
- [ ] Add DB event/delivery created-at facts to ClaimedOutboxDelivery
|
||||
- [ ] Project those DB timestamps from PostgreSqlPollingDeliveryAdapter
|
||||
- [ ] Add application-owned publication admission port
|
||||
- [ ] Add immutable retry/deadline policy with bounded jitter
|
||||
- [ ] Add one-record publish command/result
|
||||
- [ ] Add PublishNextOutboxDeliveryUseCase using IntegrationEventPublishPort
|
||||
- [ ] Map exceptional/timeout/interrupted publication to AMBIGUOUS
|
||||
- [ ] Derive deterministic bounded transition OperationId
|
||||
- [ ] Prove no admission means no claim
|
||||
- [ ] Prove no eligible row releases admission without publishing
|
||||
- [ ] Prove CONFIRMED -> PUBLISHED
|
||||
- [ ] Prove AMBIGUOUS -> RETRY_WAIT while budget remains
|
||||
- [ ] Prove AMBIGUOUS -> DEAD when attempt/deadline budget is exhausted
|
||||
- [ ] Prove definite rejection -> DEAD
|
||||
- [ ] Prove transition failures propagate
|
||||
- [ ] Prove one invocation claims at most one record and uses two explicit Tx boundaries
|
||||
- [ ] Keep candidate unwired and LEGACY_POLLING authoritative
|
||||
- [ ] Run focused/full application-core tests
|
||||
- [ ] Run persistence-jpa compile/check regression
|
||||
- [ ] Run clean-architecture dependency verification
|
||||
- [ ] git diff --check
|
||||
@@ -0,0 +1,14 @@
|
||||
# PostgreSQL Idempotency Composition Ownership — Plan
|
||||
|
||||
- [x] Add package-private PostgreSQL idempotency store composition to persistence-jpa
|
||||
- [x] Import that composition through PersistenceJpaAutoConfiguration
|
||||
- [x] Remove concrete PostgreSQL store construction/import from app-bootstrap
|
||||
- [x] Keep V2 executor lifecycle policy in app-bootstrap
|
||||
- [x] Add provider=postgresql -> JPA startup dependency validation
|
||||
- [x] Split leaf store composition tests from bootstrap executor/provider-count tests
|
||||
- [x] Prove JPA public API surface remains unchanged
|
||||
- [x] Prove app-bootstrap idempotency production has zero persistence concrete imports
|
||||
- [x] Run persistence-jpa focused/full unit gates
|
||||
- [x] Run app-bootstrap idempotency and capability-dependency tests
|
||||
- [x] Run app-bootstrap full test/architecture regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,14 @@
|
||||
# Runtime Environment and Tracing SSOT — Plan
|
||||
|
||||
- [x] Make TracingSampleRateResolver depend on RuntimeEnvironment, not string switch literals
|
||||
- [x] Remove the tracing-only staging=10% branch
|
||||
- [x] Remove tracing's profileless -> local fallback
|
||||
- [x] Register tracing sampling gauge only for resolved deployable RuntimeEnvironment
|
||||
- [x] Key GraphQL deployment-mode policy by RuntimeEnvironment
|
||||
- [x] Update tracing resolver/postprocessor/config tests
|
||||
- [x] Update metrics/env/config documentation and tracing contract assertions
|
||||
- [x] Update README profile/tracing wording that still advertises staging
|
||||
- [x] Prove production profile interpretation sites use RuntimeEnvironment
|
||||
- [x] Run focused tracing/capability/contract tests
|
||||
- [x] Run app-bootstrap full test/architecture regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,15 @@
|
||||
# Secret Source Port Ownership — Plan
|
||||
|
||||
- [x] Add application-owned SecretSourcePort under application.outbound
|
||||
- [x] Move EnvironmentSecretSource to adapter:outbound:support
|
||||
- [x] Add application-core dependency to outbound-support
|
||||
- [x] Update bootstrap factory/config/validator and Redis consumers to SecretSourcePort
|
||||
- [x] Remove bootstrap-local SecretSource and EnvironmentSecretSource
|
||||
- [x] Move environment-adapter behavior tests to outbound-support
|
||||
- [x] Keep factory/strategy selection tests in app-bootstrap
|
||||
- [x] Update CompositionRootBoundaryArchitectureTest stale SecretSource rationale
|
||||
- [x] Prove MeteredDistributedLockPort is the only bootstrap application-port implementation
|
||||
- [x] Run application-core, outbound-support, app-bootstrap focused/full tests
|
||||
- [x] Run app-bootstrap architectureTest
|
||||
- [x] Run clean-architecture dependency verification
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,12 @@
|
||||
# Startup Failure Log Context State — Plan
|
||||
|
||||
- [x] Replace static AtomicBoolean with LoggerContext object-map state
|
||||
- [x] Remove clearForTest from production code
|
||||
- [x] Make StartupFailureSpringBootLogFilter read its own context
|
||||
- [x] Rewrite filter tests to use context-scoped marking
|
||||
- [x] Add isolation test proving one LoggerContext does not affect another
|
||||
- [x] Preserve StartupFailures structured logging tests
|
||||
- [x] Prove no static mutable startup-failure state remains
|
||||
- [x] Run focused logging/startup tests
|
||||
- [x] Run app-bootstrap full test/architecture regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,40 @@
|
||||
# Test Architecture Phase 2 Provider Ownership — Implementation Plan
|
||||
|
||||
## Slice A — PostgreSQL migration/idempotency ownership
|
||||
|
||||
- [x] Move shipped INT_LOCK V4→V5 compatibility evidence to persistence-jpa
|
||||
- [x] Replace app-bootstrap PostgreSQL fixture usage with persistence-jpa testkit
|
||||
- [x] Move idempotency unique-scope / real SQLSTATE 23505 evidence to persistence-jpa
|
||||
- [x] Add exact fail-closed readiness lanes for both provider contracts
|
||||
- [x] Refresh locks only where dependency configurations changed
|
||||
- [x] Run focused moved tests and JPA lane tasks
|
||||
- [x] Remove obsolete app-bootstrap copies/support references
|
||||
- [x] Run app-bootstrap integration compile/regression and architecture checks
|
||||
- [x] `git diff --check`
|
||||
|
||||
## Slice B — distributed lock split
|
||||
|
||||
- [x] Separate provider behavior from bootstrap metering/composition assertions
|
||||
- [x] Move PostgreSQL lock-provider behavior to persistence-jpa
|
||||
- [x] Keep only bootstrap enablement/wrapper/composition evidence
|
||||
- [x] Verify both owner and composition lanes
|
||||
|
||||
## Slice C — outbox ownership split
|
||||
|
||||
- [x] Inventory legacy/provider-neutral/composition assertions
|
||||
- [x] Create or reuse application-owned contract fixtures
|
||||
- [x] Move PostgreSQL store/claim/transaction behavior to persistence-jpa
|
||||
- [x] Keep bootstrap publication authority/cutover composition
|
||||
- [x] Reconcile with canonical outbox transport-only cutover plan
|
||||
|
||||
## Slice D — fileserver decomposition
|
||||
|
||||
- [x] Separate local filesystem, JPA metadata, HTTP transport, and assembled journey claims
|
||||
- [x] Add missing leaf-owned provider evidence
|
||||
- [x] Reduce bootstrap round-trip to composition/system evidence only
|
||||
|
||||
## Slice E — remaining provider gaps
|
||||
|
||||
- [x] Add real MongoDB baseline in persistence-mongo
|
||||
- [x] Confirm broker baselines and missing feature transports
|
||||
- [x] Add provider version/topology policy and required fault cases
|
||||
@@ -0,0 +1,14 @@
|
||||
# Test Taxonomy SSOT Alignment — Plan
|
||||
|
||||
- [x] Rewrite TESTING_STRATEGY around TEST / INTEGRATION / SYSTEM / ARCHITECTURE / PERFORMANCE
|
||||
- [x] Define unit, slice and contract as TEST styles rather than lane categories
|
||||
- [x] Define qualification as a gate rather than a test kind
|
||||
- [x] Remove the stale claim that verifyTestSourceSetRegistry still enforces the Markdown table
|
||||
- [x] Remove the duplicated current-state source-set registry from the human SSOT
|
||||
- [x] Document category-vs-source-set separation
|
||||
- [x] Preserve java-test-fixtures as the shared fixture convention
|
||||
- [x] Align lifecycle examples with current root tasks
|
||||
- [x] Verify the five documented category names match TestLaneCategory by inspection/test
|
||||
- [x] Run build-logic strict-lane tests
|
||||
- [x] Run Gradle help/task configuration smoke
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,75 @@
|
||||
# Build / Release Review Remediation Implementation Plan
|
||||
|
||||
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [x]`) syntax for tracking.
|
||||
|
||||
**Goal:** Close the current-tree Build/CI C1, C2 and H6 composition defects.
|
||||
|
||||
**Architecture:** Make repository contract tests derive Docker included-build completeness from
|
||||
`settings.gradle`, and pin architecture workflow invocations to the architecture source-set task.
|
||||
Then change only the workflow/Docker/documentation lines needed to satisfy those contracts.
|
||||
|
||||
**Tech Stack:** Java 21, JUnit 5, AssertJ, Gradle, GitHub Actions YAML, Dockerfile
|
||||
|
||||
**Spec:** `docs/superpowers/specs/2026-09-19-build-release-review-remediation-design.md`
|
||||
|
||||
## Global Constraints
|
||||
|
||||
- Preserve all existing uncommitted changes.
|
||||
- Do not stage, commit, reset, checkout, clean or push.
|
||||
- `settings.gradle` remains the source of truth for included builds.
|
||||
- Architecture tests execute through `:app-bootstrap:architectureTest`.
|
||||
|
||||
## Review Focus
|
||||
|
||||
- A future third `includeBuild` must break Docker contract verification until copied.
|
||||
- Release must not select architecture tests through the TEST source set.
|
||||
- Fileserver PR architecture filtering must still reach the ARCHITECTURE source set.
|
||||
- Docker's first Gradle invocation must still happen under `/build/src`.
|
||||
- Existing deterministic staged-JAR Docker contract must remain unchanged.
|
||||
|
||||
---
|
||||
|
||||
### Task 1: Add failing composition-contract tests
|
||||
|
||||
**Files:**
|
||||
- Modify: `src/app-bootstrap/src/test/java/dev/caskeleton/bootstrap/contract/DeveloperExperienceContractTest.java`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: repository files through the existing `read(...)` helper.
|
||||
- Produces: general included-build and architecture-workflow assertions.
|
||||
|
||||
- [x] Add a test that parses every `includeBuild('...')` from `src/settings.gradle` and requires its complete `COPY` before the first Docker Gradle invocation.
|
||||
- [x] Add a test that checks `release.yml` and `fileserver-pr.yml` architecture package selectors use `:app-bootstrap:architectureTest`.
|
||||
- [x] Run the focused test and confirm it fails for missing `build-tools` COPY and stale `:app-bootstrap:test` workflow commands.
|
||||
|
||||
### Task 2: Fix build/release composition
|
||||
|
||||
**Files:**
|
||||
- Modify: `src/Dockerfile`
|
||||
- Modify: `.github/workflows/release.yml`
|
||||
- Modify: `.github/workflows/fileserver-pr.yml`
|
||||
- Modify: `CLAUDE.md`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: Task 1 contracts.
|
||||
- Produces: release/Docker paths consistent with the actual Gradle source sets and included builds.
|
||||
|
||||
- [x] Copy `build-tools/` before the first Docker Gradle invocation and document the general included-build rule.
|
||||
- [x] Switch architecture selectors in release/fileserver workflows to `:app-bootstrap:architectureTest`.
|
||||
- [x] Update the root developer command to the architecture task.
|
||||
- [x] Re-run the focused contract test and require GREEN.
|
||||
|
||||
### Task 3: Verify and close the wave
|
||||
|
||||
**Files:**
|
||||
- Modify: `docs/reviews/2026-09-19-review-remediation-master.md`
|
||||
- Modify: this plan
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: Task 2 verified repository state.
|
||||
- Produces: durable remediation status.
|
||||
|
||||
- [x] Run `:app-bootstrap:test --tests 'dev.caskeleton.bootstrap.contract.DeveloperExperienceContractTest'`.
|
||||
- [x] Scan workflows for stale architecture-package invocation through `:app-bootstrap:test`.
|
||||
- [x] Run `git diff --check`.
|
||||
- [x] Record C1/C2/H6 as closed with the exact verification evidence.
|
||||
@@ -0,0 +1,12 @@
|
||||
# Capability Dependency Validation Context — Plan
|
||||
|
||||
- [x] Replace raw capability dependency ArrayList with StartupValidationContext
|
||||
- [x] Add requireSatisfied(Environment) as the single failure path
|
||||
- [x] Reduce both startup entry points to requireSatisfied delegation
|
||||
- [x] Preserve violations(Environment) diagnostic API
|
||||
- [x] Add focused typed-failure and multi-violation tests
|
||||
- [x] Prove no manual capability-dependency failure formatting remains
|
||||
- [x] Migrate SecretSourceValidator sentinel/missing accumulation to one ENV_VALIDATION context
|
||||
- [x] Run focused activation tests
|
||||
- [x] Run app-bootstrap full TEST/ARCHITECTURE regressions
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,14 @@
|
||||
# Env Contract Verifier Truth Surface — Plan
|
||||
|
||||
- [x] Add RED test: .env.example presence does not make an untyped Redis key consumed
|
||||
- [x] Add RED test: secondary configuration file participates in registry/required-placeholder checks
|
||||
- [x] Change verifier from one applicationYaml file to a configuration-file collection
|
||||
- [x] Remove envAppKeys from consumer evidence
|
||||
- [x] Include repository main Java/YAML sources, including sample main resources, as consumer evidence
|
||||
- [x] Change VerifyEnvKeysTask to expose ConfigurableFileCollection configurationFiles
|
||||
- [x] Wire application*.yml and config/*.yml in ConfigContractPlugin
|
||||
- [x] Update task descriptions/messages from application.yml to shipped configuration
|
||||
- [x] Run build-tools tests
|
||||
- [x] Run real app-bootstrap verifyEnvKeys and disposition newly visible orphans honestly
|
||||
- [x] Run app-bootstrap verification regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,13 @@
|
||||
# Fileserver Composition Decomposition — Plan
|
||||
|
||||
- [x] Split platform bean families into five package-private concern configurations
|
||||
- [x] Keep FileserverPlatformAutoConfiguration as the sole master-gated entry point
|
||||
- [x] Split storage into four concern configurations behind the existing storage aggregator
|
||||
- [x] Split services into three concern configurations behind the existing service aggregator
|
||||
- [x] Preserve bean method names, conditions and back-off semantics
|
||||
- [x] Prove every Fileserver configuration has <= 8 @Bean methods
|
||||
- [x] Prove extracted child configs are package-private and absent from AutoConfiguration.imports
|
||||
- [x] Run focused Fileserver auto-configuration/runtime tests
|
||||
- [x] Run Fileserver integration composition lane
|
||||
- [x] Run app-bootstrap Spotless/full TEST/ARCHITECTURE/SYSTEM regressions
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,12 @@
|
||||
# Fileserver Verification Read Failure Remediation — Plan
|
||||
|
||||
- [x] Add RED production-reader test: missing staging content must not look like empty content
|
||||
- [x] Add RED coordinator test with shipped requireVerdict=false and production reader
|
||||
- [x] Let staging read failures propagate
|
||||
- [x] Wrap published-channel IOException as runtime failure instead of returning partial bytes
|
||||
- [x] Preserve legitimate zero-byte reads
|
||||
- [x] Update VerificationContentReader/LocalVerificationContentReader documentation
|
||||
- [x] Run focused GREEN tests
|
||||
- [x] Run full fileserver check
|
||||
- [x] git diff --check
|
||||
- [x] Record Notification/Fileserver C2 closure
|
||||
@@ -0,0 +1,15 @@
|
||||
# Mongo Client Runtime Review Remediation — Plan
|
||||
|
||||
- [x] Add RED startup dependency tests for missing Mongo connection source
|
||||
- [x] Add RED runtime customizer test proving typed profile reaches the Boot builder
|
||||
- [x] Refactor MongoClientSettingsFactory so create/customize share one apply path
|
||||
- [x] Register typed-profile MongoClientSettingsBuilderCustomizer when a credential resolver exists
|
||||
- [x] Fail startup when Mongo has neither spring.mongodb.uri nor active-profile uri-secret
|
||||
- [x] Register/document SPRING_MONGODB_URI without making it mandatory for typed-secret deployments
|
||||
- [x] Correct README/CLAUDE to spring.mongodb.*
|
||||
- [x] Extend MongoNamespaceContractTest to Markdown
|
||||
- [x] Run focused GREEN tests
|
||||
- [x] Run persistence-mongo check
|
||||
- [x] Run app-bootstrap verifyEnvKeys and dependency-validator regression
|
||||
- [x] git diff --check
|
||||
- [x] Record Mongo C1/C2 closure in review remediation master
|
||||
@@ -0,0 +1,12 @@
|
||||
# Multi-instance Runtime Contract — Plan
|
||||
|
||||
- [x] Make shipped distributed-lock system proof RED by removing fake sibling coordination beans
|
||||
- [x] Replace the five-name StartupSafetyValidator requirement with the actual distributed-lock contract
|
||||
- [x] Reject a wrong-type distributedLockProvider
|
||||
- [x] Remove fake five-bean unit fixture and test only the typed lock contract
|
||||
- [x] Keep JPA dependency validation for multi-instance mode
|
||||
- [x] Update app-bootstrap README to stop advertising nonexistent coordination beans
|
||||
- [x] Run focused StartupSafetyValidator and shipped distributed-lock system tests
|
||||
- [x] Run persistence-jpa distributed-lock tests
|
||||
- [x] Run app-bootstrap full test/systemTest/architectureTest
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,13 @@
|
||||
# Prod Secret Consumer Alignment — Plan
|
||||
|
||||
- [x] Remove three consumerless secrets from REQUIRED_PROD_SECRETS
|
||||
- [x] Remove their rows from secrets-classification.yaml
|
||||
- [x] Remove APP_SECURITY_JWT_SIGNING_KEY from env-keys.yaml and .env.example
|
||||
- [x] Stop compose runtime smoke from generating the three unused values
|
||||
- [x] Update validator fixtures and sentinel test to use a real required secret
|
||||
- [x] Run SecretSourceValidatorTest
|
||||
- [x] Run SecretsClassificationRegistryTest
|
||||
- [x] Run verifyEnvKeys
|
||||
- [x] Scan the repository for non-review references to the removed keys
|
||||
- [x] Run app-bootstrap regression
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,13 @@
|
||||
# Runtime Profile Access Boundary — Plan
|
||||
|
||||
- [x] Add immutable Spring-aware RuntimeProfileSnapshot
|
||||
- [x] Replace all direct app-bootstrap production getActiveProfiles calls
|
||||
- [x] Preserve tracing, logging, management and validation behavior
|
||||
- [x] Add RuntimeProfileSnapshot unit tests
|
||||
- [x] Add ArchUnit direct-access prohibition
|
||||
- [x] Update shared RuntimeEnvironment documentation to name the Spring bridge
|
||||
- [x] Prove direct production getActiveProfiles callers = 1 (the bridge only)
|
||||
- [x] Run focused profile/tracing/safety tests
|
||||
- [x] Run app-bootstrap full test/architecture regression
|
||||
- [x] Run shared-contract tests
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,9 @@
|
||||
# Startup Order Contract — Plan
|
||||
|
||||
- [x] Add spring.factories-driven EnvironmentPostProcessor ordering test
|
||||
- [x] Prove every registered processor implements Ordered
|
||||
- [x] Pin each shipped processor to its StartupOrder constant
|
||||
- [x] Prove readiness and validator/defaulting bands are strictly ordered
|
||||
- [x] Run focused ordering test
|
||||
- [x] Run app-bootstrap full TEST/ARCHITECTURE regressions
|
||||
- [x] git diff --check
|
||||
@@ -0,0 +1,9 @@
|
||||
# Test Support Ownership Closure — Plan
|
||||
|
||||
- [x] Move AdapterActivationInventory from test to systemTest
|
||||
- [x] Prove no TEST source consumes AdapterActivationInventory
|
||||
- [x] Prove custom testkit publisher/source-set declarations are absent
|
||||
- [x] Preserve taxonomy positive-control fixture placement
|
||||
- [x] Run systemTest compile/focused consumers
|
||||
- [x] Run app-bootstrap TEST and ARCHITECTURE regressions
|
||||
- [x] git diff --check
|
||||
@@ -1,7 +1,7 @@
|
||||
$ ./gradlew check --warning-mode=fail --no-daemon --console=plain (re-run after the SpotBugs fix)
|
||||
run-at: 2026-08-20T01:53:16Z
|
||||
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/9.0.0/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
|
||||
Daemon will be stopped at the end of the build
|
||||
Daemon will be stopped at the end of the build
|
||||
> Task :build-logic:extractPluginRequests UP-TO-DATE
|
||||
> Task :build-logic:generatePluginAdapters UP-TO-DATE
|
||||
> Task :build-logic:compileJava UP-TO-DATE
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
$ ./gradlew clean compileJava compileTestJava --warning-mode=fail --no-daemon --console=plain
|
||||
run-at: 2026-08-20T01:18:16Z
|
||||
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/9.0.0/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
|
||||
Daemon will be stopped at the end of the build
|
||||
Daemon will be stopped at the end of the build
|
||||
> Task :build-logic:extractPluginRequests UP-TO-DATE
|
||||
> Task :build-logic:generatePluginAdapters UP-TO-DATE
|
||||
> Task :build-logic:compileJava UP-TO-DATE
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
$ ./gradlew test --warning-mode=fail --no-daemon --console=plain
|
||||
run-at: 2026-08-20T01:33:26Z
|
||||
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/9.0.0/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
|
||||
Daemon will be stopped at the end of the build
|
||||
Daemon will be stopped at the end of the build
|
||||
> Task :build-logic:extractPluginRequests UP-TO-DATE
|
||||
> Task :build-logic:generatePluginAdapters UP-TO-DATE
|
||||
> Task :build-logic:compileJava UP-TO-DATE
|
||||
|
||||
@@ -410,7 +410,7 @@ untyped field bag, and must never be implemented through the failing outbox brok
|
||||
9. Add source and resolved-classpath purity guards.
|
||||
10. Regenerate dependency locks and update module/runbook documentation.
|
||||
11. Run focused, architecture, dependency, full test, and full check gates.
|
||||
12. Capture implementation evidence in the LLM Wiki as required by repository policy.
|
||||
12. Capture implementation evidence in the repository documentation as required by repository policy.
|
||||
|
||||
## 15. Acceptance Criteria
|
||||
|
||||
|
||||
@@ -52,7 +52,7 @@ It fails because `src/settings.gradle` requires the absent
|
||||
Gradle and CI gates replace harness runtime dependencies for module discovery and dependency
|
||||
policy. Root and module guidance point to the Gradle-owned registry and retain the eight local
|
||||
HARD-STOP meanings, architecture responsibilities, focused-test discipline, human-only git
|
||||
policy, and LLM Wiki capture workflow.
|
||||
policy, and documentation update workflow.
|
||||
|
||||
Acceptance requires successful Gradle `help`, `projects`, and
|
||||
`verifyCleanArchitectureDependencies`, an independent deterministic 19-leaf registry check,
|
||||
|
||||
@@ -127,7 +127,7 @@ An allowed registry edge is permission, not a requirement to declare that edge.
|
||||
- No automatic inclusion of every optional adapter in the production runtime.
|
||||
- No new Mongo business port or second Mongo sample in `sample-portfolio`.
|
||||
- No relocation of the shared ThreadLocal implementation in this change.
|
||||
- No LLM Wiki write as part of this documentation-only design task.
|
||||
- No repository documentation write as part of this documentation-only design task.
|
||||
|
||||
## 6. Target Topology and Registry Policy
|
||||
|
||||
|
||||
@@ -169,5 +169,5 @@ cd src
|
||||
./gradlew verifyPublicPathSnapshot verifyEnvKeys --console=plain
|
||||
```
|
||||
|
||||
Completion requires fresh review, `git diff --check`, and an LLM Wiki branch note or an explicit
|
||||
Completion requires fresh review, `git diff --check`, and an design record or an explicit
|
||||
capture blocker for the mandated exact vault path.
|
||||
|
||||
@@ -6877,7 +6877,7 @@ R2라고 표시하지 않는다.
|
||||
- selected topology/failure/security test;
|
||||
- dependency/architecture/env/public path gate;
|
||||
- runbook/capability card;
|
||||
- LLM Wiki capture.
|
||||
- documentation update.
|
||||
|
||||
### 40.2 Sentinel-first slice 종료 게이트
|
||||
|
||||
|
||||
@@ -6936,7 +6936,7 @@ HTTP capability를 “운영에서 바로 사용 가능” 또는 R2라고 부
|
||||
32. Known gaps는 `not-implemented` card/profile로 fail-closed되고 R2 범위에 포함되지 않는다. Card
|
||||
registry와 compatibility registry가 각각 card/profile maturity의 유일한 SSOT이며 selection은
|
||||
binding/catalog/provider의 exact tuple과 child dependency fingerprints에서만 파생된다.
|
||||
33. LLM Wiki capture와 independent review evidence가 완료된다.
|
||||
33. documentation update와 independent review evidence가 완료된다.
|
||||
|
||||
현재 구현은 위 조건을 충족하지 않는다. 이 문서 완료는 구현 R2 완료가 아니다.
|
||||
|
||||
|
||||
@@ -5439,7 +5439,7 @@ Kafka에 갈 수 있는 시점부터 old/new relay를 동시에 켜는 rollback
|
||||
- base template migration card 확정과 live-data deployment approval gate 명시;
|
||||
- migration/test/runbook/evidence 계획;
|
||||
- unresolved decision이 implementation plan에 숨지 않음;
|
||||
- LLM Wiki capture.
|
||||
- documentation update.
|
||||
|
||||
현재 문서 상태는 사용자 승인에 따라
|
||||
`상세 설계 승인, P0 characterization 및 P1 implementation candidate 완료, P2 이후 미착수`다.
|
||||
@@ -5472,7 +5472,7 @@ Kafka에 갈 수 있는 시점부터 old/new relay를 동시에 켜는 rollback
|
||||
20. descriptor/card/evidence artifact;
|
||||
21. runbook;
|
||||
22. legacy drift/migration;
|
||||
23. Wiki capture.
|
||||
23. documentation update.
|
||||
|
||||
### 31.3 Consumer/inbox complete
|
||||
|
||||
@@ -5559,7 +5559,7 @@ evidence fingerprint/artifact
|
||||
아직 미구현인 card
|
||||
현재 보장과 non-guarantee
|
||||
runbook
|
||||
LLM Wiki capture
|
||||
documentation update
|
||||
남은 위험
|
||||
```
|
||||
|
||||
|
||||
@@ -4718,7 +4718,7 @@ COMPLETE 뒤 reverse가 필요하다면 canonical in-flight/intent backlog/provi
|
||||
- [ ] health/metrics/traces/runbook
|
||||
- [ ] focused/architecture/real-provider/no-skip/privacy evidence
|
||||
- [ ] independent review blocker/high 0
|
||||
- [ ] LLM Wiki capture
|
||||
- [ ] documentation update
|
||||
|
||||
### 34.3 금지할 완료 표현
|
||||
|
||||
@@ -4729,7 +4729,7 @@ COMPLETE 뒤 reverse가 필요하다면 canonical in-flight/intent backlog/provi
|
||||
- optional provider lane skip 상태로 “production ready”;
|
||||
- 한 provider/account/region card로 notification module 전체 R2;
|
||||
- config만 있고 실제 client/consumer가 없는데 “enabled”;
|
||||
- branch-note/검증 없이 “설계/구현 완료”.
|
||||
- design record/검증 없이 “설계/구현 완료”.
|
||||
|
||||
## 35. 운영 runbook 최소 항목
|
||||
|
||||
|
||||
@@ -3,8 +3,7 @@
|
||||
- 작성일: 2026-07-28
|
||||
- 상태: Approval Gate A 승인 반영, Batch A–D 및 Batch E pause checkpoint를 main에 통합, R2 미구현
|
||||
- 독립 재리뷰: 완료 — 아키텍처 및 문서 실행성 blocker 0, high 0
|
||||
- LLM Wiki capture: public vault의
|
||||
`raw/branch-notes/chore-main-worktree-capability-integration.md`에 main 통합 기록 완료
|
||||
- documentation update: public vault의
|
||||
- 기준: Java 21, Spring Boot 4.0.0, Gradle 멀티모듈 Clean Architecture
|
||||
- 대상 leaf: `adapter-outbound-objectstorage`
|
||||
- 현재 구현 수준: provider-neutral kernel + `filesystem-local-dev` managed single R1,
|
||||
@@ -87,7 +86,6 @@
|
||||
|
||||
격리 브랜치에서는 private vault 경로를 잘못 선택해 capture가 차단됐지만, main 통합 작업은
|
||||
사용자가 지정한 public vault의
|
||||
`raw/branch-notes/chore-main-worktree-capability-integration.md`에 캡처했다.
|
||||
|
||||
legacy runtime 범위는 별도로 유지된다.
|
||||
|
||||
@@ -415,7 +413,7 @@ Optional capability 부재를 silent emulation하지 않는다. 요청 시
|
||||
29. provider/card별 증거 없이 module 전체를 R2라고 부르지 않는다.
|
||||
30. readiness는 exact required destination/provider/capability mismatch에서 fail closed한다.
|
||||
31. metric/tag/log에 object key, bucket, tenant/user ID, original filename, content, URL을 넣지 않는다.
|
||||
32. verification과 Wiki capture 또는 명시적 capture 차단 사유 없이 완료를 주장하지 않는다.
|
||||
32. verification과 documentation update 또는 명시적 capture 차단 사유 없이 완료를 주장하지 않는다.
|
||||
|
||||
## 6. 대안 검토
|
||||
|
||||
@@ -4056,7 +4054,7 @@ task에서 임의 결정하지 않는다.
|
||||
- official primary references로 변동 가능한 provider 의미가 뒷받침됨;
|
||||
- 상위 설계에서 dedicated design으로 링크됨;
|
||||
- 독립 리뷰에서 blocker/high가 해소됨;
|
||||
- 문서 검증과 LLM Wiki capture 또는 차단 사유가 기록됨.
|
||||
- 문서 검증과 documentation update 또는 차단 사유가 기록됨.
|
||||
|
||||
### 38.2 Implementation complete
|
||||
|
||||
@@ -4069,7 +4067,7 @@ task에서 임의 결정하지 않는다.
|
||||
- sample workflow migration;
|
||||
- settings/env/secrets/runtime docs;
|
||||
- runbook and observability;
|
||||
- Wiki branch-note;
|
||||
- design record;
|
||||
- human code review.
|
||||
|
||||
### 38.3 R2 complete
|
||||
|
||||
+1
-1
@@ -1052,7 +1052,7 @@ The test-environment implementation is complete only when all of the following h
|
||||
into core contract kits.
|
||||
15. Focused leaf verification, aggregate deterministic/integration checks, candidate smoke, and
|
||||
architecture gates have fresh executable evidence.
|
||||
16. The LLM Wiki branch note records implementation decisions, commands, failures, and evidence
|
||||
16. The design record records implementation decisions, commands, failures, and evidence
|
||||
grade before completion is claimed.
|
||||
|
||||
## 23. Expected implementation impact
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
# Conditional Inbound Transport Boundary Design
|
||||
|
||||
**Date:** 2026-08-02
|
||||
**Status:** approved by the user's instruction to apply the detailed P1/P2 review sequentially
|
||||
**Date:** 2026-08-02
|
||||
**Status:** approved by the user's instruction to apply the detailed P1/P2 review sequentially
|
||||
**Scope:** the opt-in GraphQL, gRPC, and WebSocket leaf modules and their release evidence
|
||||
|
||||
## Context
|
||||
|
||||
@@ -370,7 +370,7 @@ the registry is deliberately updated and its architecture verifier passes.
|
||||
7. Enable blocking compiler, Checkstyle, SpotBugs, and Gradle warning gates.
|
||||
8. Run focused checks, architecture validators, dependency locks, full tests, full check, and the
|
||||
fresh warning-clean build.
|
||||
9. Update the LLM Wiki branch note and the warning-debt error note with resolved evidence or exact
|
||||
9. Update the design record and the warning-debt error note with resolved evidence or exact
|
||||
remaining environmental blockers.
|
||||
|
||||
## Verification Strategy
|
||||
@@ -444,5 +444,5 @@ The work is complete only when:
|
||||
gate-matrix, shell, and diff validators pass.
|
||||
8. The final fresh clean-build log contains no `warning:`, deprecated/unchecked `Note:`, SpotBugs
|
||||
non-zero message, OpenJDK warning, or leaked expected-negative Redis diagnostic.
|
||||
9. LLM Wiki capture records commands, results, resolved warning counts, suppressions, and any
|
||||
9. documentation update records commands, results, resolved warning counts, suppressions, and any
|
||||
environment-only qualification not executed locally.
|
||||
|
||||
@@ -1,8 +1,8 @@
|
||||
# Fileserver Platform 설계서
|
||||
|
||||
**문서 상태:** 설계 확정안
|
||||
**작성 기준일:** 2026-08-07
|
||||
**입력 근거:** `Spring 기반 Fileserver 설계 심층 리서치`
|
||||
**문서 상태:** 설계 확정안
|
||||
**작성 기준일:** 2026-08-07
|
||||
**입력 근거:** `Spring 기반 Fileserver 설계 심층 리서치`
|
||||
**대상 저장소:** Spring 기반 Backend Skeleton
|
||||
|
||||
---
|
||||
|
||||
@@ -1,9 +1,9 @@
|
||||
# HTTP Client Platform 설계서
|
||||
|
||||
**문서 상태:** 구현 기준선 확정
|
||||
**작성 기준일:** 2026-08-08
|
||||
**입력 근거:** `Java/Spring 외부 HTTP Client 플랫폼 설계 심층 리서치`
|
||||
**대상 저장소:** Spring 기반 Backend Skeleton
|
||||
**문서 상태:** 구현 기준선 확정
|
||||
**작성 기준일:** 2026-08-08
|
||||
**입력 근거:** `Java/Spring 외부 HTTP Client 플랫폼 설계 심층 리서치`
|
||||
**대상 저장소:** Spring 기반 Backend Skeleton
|
||||
**문서 목적:** 구현 중 추가 설계 판단이나 반복 질문 없이 공개 API, 전송 엔진, Named Client Profile, 시간 예산, 재시도 안전성, 복원력, 인증, 보안, 관측성, 테스트 및 릴리스 조건을 확정한다.
|
||||
|
||||
---
|
||||
|
||||
@@ -1015,7 +1015,7 @@ graph, test selection과 evidence output이 동일함을 검증한다. settings
|
||||
- all-off, one-on, dependency-error, all-on matrix 실행
|
||||
- local/dev/prod smoke와 HTTP/JWT/GraphQL/infra round trip 실행
|
||||
- generated configuration metadata와 env/docs drift 검증
|
||||
- LLM Wiki branch-note 및 실제 파생 errors/interview/blog raw 문서 캡처
|
||||
- design record 및 실제 파생 errors/interview/blog raw 문서 캡처
|
||||
|
||||
## 12. 검증 매트릭스
|
||||
|
||||
@@ -1153,7 +1153,7 @@ matrix는 `off-local`, `off-dev`, `off-prod`, 각 local adapter lane, `shared-in
|
||||
- [ ] Gradle convention plugin 추출 뒤 task selection, dependency graph와 evidence 의미가 유지된다.
|
||||
- [ ] 세부 모듈 리뷰의 runtime 경로상 P0 blocker가 닫히거나 명시적으로 해당 capability가 계속
|
||||
비활성/experimental 상태다.
|
||||
- [ ] 변경 파일, 명령, 결과, 미실행/차단과 증거 등급이 LLM Wiki branch-note에 캡처된다.
|
||||
- [ ] 변경 파일, 명령, 결과, 미실행/차단과 증거 등급이 design record에 캡처된다.
|
||||
|
||||
## 14. 남은 위험과 구현 경계
|
||||
|
||||
|
||||
@@ -91,7 +91,7 @@ leaf 경계가 아니라 capability별 독립 promotion evidence로 표현되므
|
||||
| D5 | Buf CLI (`bufLint`/`bufBreaking` 등) | 저장소 소유 규칙 엔진 + Gradle verify task | Buf CLI 바이너리가 이 환경에 없다. lint/format/breaking **규칙**을 Java로 구현해 동일 판정을 내리고, CLI는 동일 규칙을 재확인하는 선택 경로로 남긴다 |
|
||||
| D6 | protoc/grpc-java codegen을 빌드에서 실행 | `.proto` 소스 + codegen **정책·descriptor 계약**만 실행, protoc 실행은 명시적 확장점 | 아래 별도 절 |
|
||||
| D7 | `grpc-kotlin`의 `.kt` 소스 | Java 쪽 coroutine/Flow **경계 계약**만 | 저장소에 Kotlin 플러그인·소스셋이 없다. A16의 5개 요구사항 중 4개(스키마 단일 소스, cancellation 전파 계약, backpressure 우회 금지, evidence 타입 보존)는 Java 계약으로 표현 가능하고, Kotlin 툴체인 lane은 `GrpcKotlinCompatibilityGate`가 미충족으로 fail-closed 판정한다 |
|
||||
| D8 | 새 leaf가 곧 런타임 | 신규 leaf 전부 `runtime_memberships: []` (build-only) | `messaging:*`가 처음 착지한 방식과 동일. 런타임 투입은 registry membership 변경 + `verifyRuntimeModuleMembership` 통과가 선행 조건이며, 그것은 별도 결정이다 |
|
||||
| D8 | 새 leaf가 곧 런타임 | 신규 leaf 전부 `build: "optional-grpc"` (main runtime composition은 별도 Gradle edge로 결정) (build-only) | `messaging:*`가 처음 착지한 방식과 동일. 런타임 투입은 registry membership 변경 + `verifyRuntimeModuleMembership` 통과가 선행 조건이며, 그것은 별도 결정이다 |
|
||||
|
||||
### D6 — protoc 실행을 지금 켜지 않는 이유
|
||||
|
||||
|
||||
@@ -0,0 +1,39 @@
|
||||
# Bootstrap Structured Log Fields
|
||||
|
||||
## Goal
|
||||
|
||||
Close BOOT-009 without changing failure classification or log severity.
|
||||
|
||||
The composition root already centralizes startup failures in StartupFailures and runtime warning
|
||||
frames in RuntimeWarnings. The remaining scheduler/decorator log sites must use the same principle:
|
||||
human-readable text may vary, but operator-facing dimensions use stable structured field names.
|
||||
|
||||
## Rules
|
||||
|
||||
- startup failures use `startup.phase`, `error.code` and `error.category`;
|
||||
- a root cause may add `error.root_cause.class` and `error.root_cause.message`;
|
||||
- runtime warnings use `warning.kind` plus bounded context such as `capability`, `operation` or `meter`;
|
||||
- scheduled retry behavior is exposed as `retry.disposition` rather than embedded only in prose;
|
||||
- bounded cleanup counters use `cleanup.*` fields;
|
||||
- asynchronous executor rejection uses `error.code/error.category` plus `executor_name`, `policy` and
|
||||
`queue_size`;
|
||||
- unbounded identifiers must not become structured fields merely for convenience. In particular,
|
||||
distributed-lock keys remain message text and are not emitted as `lock.key`.
|
||||
|
||||
No `error.code` is invented for the outbox scheduler's catch-all failure because that exception may
|
||||
come from claim, status transition, metrics refresh or another relay-cycle concern. It is not
|
||||
necessarily an `OUTBOX_PUBLISH_FAILED` event.
|
||||
|
||||
## Verification
|
||||
|
||||
`BootstrapStructuredRuntimeLoggingTest` captures real Logback events and checks the structured
|
||||
argument set for fileserver cleanup success/failure, outbox relay catch-all retry and lock lease
|
||||
expiry.
|
||||
|
||||
## Verified result
|
||||
|
||||
- BootstrapStructuredRuntimeLoggingTest: PASS;
|
||||
- app-bootstrap Spotless, full test and architectureTest: PASS;
|
||||
- production WARN/ERROR scan found zero candidates without structured kv/v arguments;
|
||||
- docs/observability/log-fields.md is the field-name/cardinality SSOT;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,53 @@
|
||||
# Bootstrap Structured Runtime Logging
|
||||
|
||||
## Goal
|
||||
|
||||
Finish BOOT-009 by removing the remaining unstructured operational log events from app-bootstrap without changing their severity or failure semantics.
|
||||
|
||||
## Existing structured paths
|
||||
|
||||
- StartupFailures owns startup failure ERROR logs with startup.phase, error.code, error.category and bounded root-cause fields.
|
||||
- MigrationStartupRunner emits startup.phase on migration INFO logs.
|
||||
- LoggingAbortPolicy emits error.code, error.category, executor_name, policy and queue_size.
|
||||
- RuntimeWarnings owns metric-unavailable and setting-fallback WARN frames.
|
||||
|
||||
## Remaining paths
|
||||
|
||||
Three runtime paths still emit prose-only warning/error events:
|
||||
|
||||
1. fileserver cleanup batch failure;
|
||||
2. outbox relay scheduler unexpected failure before the next polling tick;
|
||||
3. distributed-lock lease expiry observed during close.
|
||||
|
||||
Fileserver cleanup success also emits counters as prose only, so those bounded counters become structured values while preserving the same plain-text numbers.
|
||||
|
||||
## Field rules
|
||||
|
||||
- capability: stable bounded capability name.
|
||||
- operation: stable bounded operation name.
|
||||
- warning.kind: bounded warning classifier for continuing/degraded behavior.
|
||||
- retry.disposition: bounded description of the already-existing retry behavior.
|
||||
- cleanup.*: bounded numeric batch outcome fields.
|
||||
- Do not invent error.code when the caught exception is broader than one OperationalError.
|
||||
- Do not promote raw lock keys into a structured field; the current human-readable message is kept, while structured fields remain bounded and non-cardinality-amplifying.
|
||||
|
||||
The field dictionary is `docs/observability/log-fields.md`.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- log levels stay unchanged;
|
||||
- exception propagation/swallowing stays unchanged;
|
||||
- retry schedules stay unchanged;
|
||||
- existing human-readable messages remain recognizable;
|
||||
- no business behavior changes.
|
||||
|
||||
## Verified result
|
||||
|
||||
- Fileserver cleanup success/failure events carry bounded structured fields;
|
||||
- outbox relay unexpected failures carry capability, operation and next-tick retry disposition without an invented error code;
|
||||
- distributed-lock lease-expiry warnings carry bounded classification while the raw lock key is not promoted to a structured dimension;
|
||||
- behavior tests inspect actual Logback structured arguments: PASS;
|
||||
- direct app-bootstrap WARN/ERROR inventory reports every event as structured or emitted by the structured warning/failure helpers;
|
||||
- app-bootstrap full test and architectureTest: PASS;
|
||||
- app-bootstrap Spotless: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,43 @@
|
||||
BOOT-001 disposition
|
||||
====================
|
||||
|
||||
Decision: do not apply the historical recommendation to collapse every configuration property under
|
||||
one ca-skeleton.* root.
|
||||
|
||||
Why
|
||||
---
|
||||
Later capability designs intentionally establish multiple canonical prefixes:
|
||||
- app.fileserver for R2 destination/provider composition;
|
||||
- app.fileserver-platform for the HTTP fileserver runtime surface;
|
||||
- app.object-storage for the production object-storage capability;
|
||||
- app.httpclient for the HTTP client platform;
|
||||
- app.messaging for messaging application composition;
|
||||
- app.redis for the Redis SDK/runtime.
|
||||
|
||||
These are not accidental aliases to one bootstrap tree. Moving them under ca-skeleton.* would
|
||||
invalidate newer capability contracts and re-centralize leaf-owned configuration in the application
|
||||
composition root.
|
||||
|
||||
The apparently duplicated areas were checked:
|
||||
- app.fileserver and app.fileserver-platform configure different layers: exact provider/destination
|
||||
composition vs HTTP/runtime policy.
|
||||
- ca-skeleton.persistence-jpa, ca-skeleton.persistence, ca-skeleton.jpa.transaction and
|
||||
app.jpa-platform split master activation, vendor selection, transaction policy and add-on/safety
|
||||
policy.
|
||||
- app.notification is explicitly documented as the R0 legacy route-selection seam, while
|
||||
ca-skeleton.notification.platform is the delivery platform contract.
|
||||
- ca-skeleton.idempotency and ca-skeleton.capabilities.idempotency separate legacy/runtime TTL
|
||||
policy from exact provider selection / owner-safe capability settings during the transition.
|
||||
|
||||
What remains valid from BOOT-001
|
||||
--------------------------------
|
||||
Configuration must still be discoverable and migration-safe:
|
||||
- each capability has one documented canonical prefix for each distinct contract;
|
||||
- legacy aliases are explicit and fail on ambiguous mixed use where migration guards exist;
|
||||
- env keys remain registered and verifyEnvKeys checks that application references and typed
|
||||
properties are registered;
|
||||
- no new prefix may be introduced merely because a class moved package.
|
||||
|
||||
This disposition supersedes only BOOT-001's single-root prescription. It does not declare all
|
||||
legacy seams permanent; app.notification and other migration-only aliases may be removed by their
|
||||
own cutover plans when compatibility windows close.
|
||||
@@ -0,0 +1,231 @@
|
||||
# Deployment Composition Reachability Remediation
|
||||
|
||||
## Goal
|
||||
|
||||
Close the deployment-composition gap identified by the 2026-09-18 tech-lead review without
|
||||
undoing the repository's structural optionality model.
|
||||
|
||||
The governing rule remains:
|
||||
|
||||
- optional capability packages are excluded from broad component scanning;
|
||||
- one auto-configuration root owns each optional capability's reachability;
|
||||
- turning a capability off is a structural fact, not a condition repeated on every child bean.
|
||||
|
||||
This spec applies the review against the current checkout, not blindly against its 11:50Z snapshot.
|
||||
|
||||
## Current-state corrections to the review snapshot
|
||||
|
||||
Already fixed after the review snapshot:
|
||||
|
||||
- JPA leaf composition ownership and master gating;
|
||||
- notification leaf composition ownership;
|
||||
- Mongo health composition ownership;
|
||||
- HTTP client leaf root and AutoConfiguration.imports entry;
|
||||
- PostgreSQL idempotency store ownership;
|
||||
- canonical messaging bridge and outbox transport-only cutover;
|
||||
- RuntimeEnvironment/tracing policy SSOT;
|
||||
- full sample-portfolio check.
|
||||
|
||||
Still present and addressed here:
|
||||
|
||||
1. application-wide Clock is supplied only by optional/dead configurations;
|
||||
2. bootstrap-owned Redis semantic, outbox, distributed-lock, idempotency and tracing composition
|
||||
roots are not all reachable through shipped AutoConfiguration.imports;
|
||||
3. HTTP client child configurations live inside the broad adapter component scan and can be
|
||||
discovered independently of the leaf master switch;
|
||||
4. the repository lacks generic reachability/parity checks that would make those defects hard to
|
||||
reintroduce.
|
||||
|
||||
## Stage 0 — application Clock ownership
|
||||
|
||||
Clock is a cross-capability application infrastructure primitive. It must not be owned by an
|
||||
optional capability merely because that capability happened to need one first.
|
||||
|
||||
Add one always-discoverable bootstrap auto-configuration:
|
||||
|
||||
- package: dev.caskeleton.bootstrap.autoconfigure.common;
|
||||
- class: BootstrapClockAutoConfiguration;
|
||||
- annotation: AutoConfiguration;
|
||||
- bean: Clock.systemUTC();
|
||||
- back-off: ConditionalOnMissingBean(Clock.class);
|
||||
- discovery: registered in app-bootstrap AutoConfiguration.imports.
|
||||
|
||||
Remove the Clock bean from IdempotencyConfig. Keep GraphQL's conditional clock fallback because
|
||||
the GraphQL leaf can be consumed without app-bootstrap; in the shipped application the bootstrap
|
||||
clock wins.
|
||||
|
||||
Required proof:
|
||||
|
||||
- Boot ImportCandidates discovers BootstrapClockAutoConfiguration;
|
||||
- with no adopter Clock, exactly one Clock is created;
|
||||
- an adopter-supplied Clock wins;
|
||||
- idempotency no longer declares a Clock bean.
|
||||
|
||||
## Stage 0 verified result
|
||||
|
||||
- BootstrapClockAutoConfiguration is discoverable through Boot ImportCandidates and the shipped
|
||||
app-bootstrap AutoConfiguration.imports resource.
|
||||
- With no adopter override it supplies exactly one UTC Clock.
|
||||
- An adopter-provided Clock backs the default off.
|
||||
- IdempotencyConfig no longer declares a Clock bean.
|
||||
- GraphQL retains its ConditionalOnMissingBean fallback for standalone leaf use.
|
||||
- app-bootstrap unit and architecture regression passed; Spotless and git diff --check passed.
|
||||
- A production source scan finds exactly one app-bootstrap Clock bean provider: the common
|
||||
auto-configuration.
|
||||
|
||||
## Stage 1 — bootstrap capability roots must be reachable
|
||||
|
||||
After Stage 0, repair only the bootstrap-owned capability composition roots that are still excluded
|
||||
from component scan and unreachable in the shipped application.
|
||||
|
||||
Before each root is registered, preserve its existing master/provider semantics. Do not make an
|
||||
all-off deployment create schedulers, workers, adapters, or settings.
|
||||
|
||||
Expected current targets include Redis semantic composition, outbox, distributed-lock,
|
||||
idempotency application composition/provider selection, and tracing. Each target must be evaluated
|
||||
from current code before registration; where a plain Configuration cannot safely be shipped as a
|
||||
root, introduce or convert to an AutoConfiguration root and keep child configurations behind it.
|
||||
|
||||
Idempotency requires special handling because EnableScheduling currently lives on
|
||||
IdempotencyConfig; scheduling must not become unconditional in an all-off deployment.
|
||||
|
||||
## Stage 2 — HTTP client structural off boundary
|
||||
|
||||
HttpClientPlatformAutoConfiguration is the correct leaf root, but its imported child Configuration
|
||||
classes currently live in a package still scanned by CaSkeletonApplication.
|
||||
|
||||
Add the HTTP-client auto-configuration package to the structural scan-exclusion expression. Do not
|
||||
copy the master condition onto every child; the repository's chosen architecture is one excluded
|
||||
package plus one registered root.
|
||||
|
||||
Required proof:
|
||||
|
||||
- HTTP client off through the real composition root produces no platform beans/settings;
|
||||
- HTTP client on reaches the registered root and its expected graph;
|
||||
- child configurations are not component-scan candidates in the shipped root.
|
||||
|
||||
## Stage 3 — recurrence prevention
|
||||
|
||||
Add generic checks instead of capability-specific memories:
|
||||
|
||||
1. auto-configuration import parity — shipped roots are discoverable through Boot ImportCandidates;
|
||||
2. scan-exclusion parity — configurations imported by structurally optional roots cannot also be
|
||||
independently component-scanned by CaSkeletonApplication;
|
||||
3. off import-filter parity — hard-coded Boot auto-configuration deny lists must be checked against
|
||||
the actual target classes they claim to cover.
|
||||
|
||||
These checks must test deployment reachability, not merely manually supply the configuration under
|
||||
test.
|
||||
|
||||
## Non-goals
|
||||
|
||||
- no POLLING_V2 activation;
|
||||
- no Redis semantic adapter redesign beyond composition reachability;
|
||||
- no global configuration namespace rewrite;
|
||||
- no sample-domain redesign;
|
||||
- no commit, stage or push;
|
||||
- no weakening of structural-off guarantees.
|
||||
|
||||
|
||||
## Stages 1–3 verified result
|
||||
|
||||
### Shipped composition reachability
|
||||
|
||||
The real CaSkeletonApplication composition root is now the verification surface, not a manually
|
||||
supplied ApplicationContextRunner configuration.
|
||||
|
||||
The all-off system case starts successfully and creates none of the optional Redis, HTTP client,
|
||||
outbox relay, distributed-lock decorator, idempotency executor or tracing runtime beans.
|
||||
|
||||
The enabled cases also start from the shipped root:
|
||||
|
||||
- Redis: the SDK root and semantic RedisCapabilitySettings are both reachable while semantic roles
|
||||
remain independently gated.
|
||||
- Tracing: enabling the tracing switch creates exactly one Tracer.
|
||||
- HTTP client: a concrete client definition reaches HttpClientPlatformAutoConfiguration, binds
|
||||
HttpClientPlatformSettings and creates one HttpServiceRegistry.
|
||||
- JDBC idempotency: the repository's official local H2 opt-out path reaches the JPA leaf store,
|
||||
application executor and scheduling processor.
|
||||
- Distributed lock: the H2/JPA path creates the real jdbcDistributedLock and the bootstrap
|
||||
distributedLockProvider. The system safety validator intentionally requires the other
|
||||
multi-instance coordination capabilities as a bundle, so this focused proof supplies only those
|
||||
unrelated sibling bean names while leaving both lock beans real.
|
||||
- Outbox: the H2/JPA path creates the real outbox store and outbox composition. Messaging remains
|
||||
enabled with the shipped Kafka provider path, but the external Kafka producer is replaced by a
|
||||
typed no-op test bean so reachability is not confused with broker/DNS availability. Relay remains
|
||||
explicitly disabled in this composition proof.
|
||||
|
||||
ShippedCompositionHarness now provides key-replacing all-off overrides and a unique in-memory H2
|
||||
helper so the system cases do not depend on duplicate command-line option semantics or shared
|
||||
database state.
|
||||
|
||||
### HTTP client structural off boundary
|
||||
|
||||
The HTTP client auto-configuration package is excluded from the broad application component scan,
|
||||
while HttpClientPlatformAutoConfiguration remains discoverable through its leaf
|
||||
AutoConfiguration.imports. The generic imported-child parity test proves component-scannable
|
||||
children of shipped roots remain behind the structural exclusion.
|
||||
|
||||
### Recurrence prevention and Boot 4 drift found
|
||||
|
||||
The generic parity checks did not merely confirm the current tree; they found real stale hard-coded
|
||||
Spring Boot targets:
|
||||
|
||||
- JPA referenced a non-candidate JpaBaseConfiguration and the old
|
||||
JpaRepositoriesAutoConfiguration name. The filter now targets the current
|
||||
DataJpaRepositoriesAutoConfiguration.
|
||||
- GraphQL used pre-Boot-4 security package names and omitted query-by-example candidates. Its deny
|
||||
list now matches the current Boot 4 GraphQL candidate family.
|
||||
- Messaging still listed the removed Rabbit annotation-driven auto-configuration and did not include
|
||||
Rabbit metrics. The defensive broker filter now matches the current Boot 4 Kafka and AMQP
|
||||
candidate sets.
|
||||
- Mongo already matched its current candidate family and required no production change.
|
||||
|
||||
The messaging adapter deliberately does not add Boot Kafka/AMQP auto-configuration modules to its
|
||||
production runtime. spring-boot-kafka and spring-boot-amqp are test-only dependencies so the
|
||||
optional adopter-compatibility filter can be checked against the actual Boot version. The messaging
|
||||
dependency lock was refreshed only for those test configurations.
|
||||
|
||||
The negative parity fixtures prove that a missing project import, a component-scanned imported child
|
||||
and a stale Boot filter target all fail closed.
|
||||
|
||||
## Verification
|
||||
|
||||
Passed:
|
||||
|
||||
- app-bootstrap test
|
||||
- app-bootstrap systemTest
|
||||
- adapter:inbound:graphql check
|
||||
- adapter:outbound:messaging check
|
||||
- adapter:outbound:httpclient check
|
||||
- verifyCleanArchitectureDependencies
|
||||
- sample-portfolio check
|
||||
- messaging and GraphQL Spotless checks
|
||||
- git diff --check
|
||||
|
||||
app-bootstrap Spotless reports only the pre-existing modified SecretReloadContractTest; the
|
||||
reachability files themselves were formatted with the repository Spotless configuration. The
|
||||
unrelated file was temporarily backed up while formatting and restored byte-for-byte with matching
|
||||
SHA-256 before and after.
|
||||
|
||||
app-bootstrap architectureTest is not a reachability failure. Compilation stops in the pre-existing
|
||||
modified ArchitectureViolationFixtureTest because an earlier edit removed the closing text of a
|
||||
multiline Javadoc code tag, producing four Error Prone UnrecognisedJavadocTag warnings under
|
||||
-Werror. This slice leaves that unrelated worktree change untouched, so the architecture regression
|
||||
remains explicitly unverified rather than being reported as green.
|
||||
|
||||
## 2026-09-19 regression closure
|
||||
|
||||
The previously unverified app-bootstrap architecture regression is now green. The shared-worktree
|
||||
Javadoc syntax error in ArchitectureViolationFixtureTest was repaired without changing any rule.
|
||||
Two genuine violations in the newly added PublishNextOutboxDeliveryUseCase were also corrected:
|
||||
its declared transaction mode now matches the existing REQUIRES_NEW transaction boundary, and the
|
||||
class is proxyable for RequiresPermission.
|
||||
|
||||
Final affected gate:
|
||||
|
||||
- app-bootstrap Spotless: PASS;
|
||||
- app-bootstrap unit test: PASS;
|
||||
- app-bootstrap architectureTest: PASS (178 tests);
|
||||
- direct bootstrap WARN/ERROR structured-field inventory: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,39 @@
|
||||
# HTTP Client Capability Composition Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Move optional HTTP-client Spring composition out of app-bootstrap and into the HTTP-client capability leaf without weakening startup validation, runtime activation, override seams, or test coverage.
|
||||
|
||||
## Target ownership
|
||||
|
||||
### adapter:outbound:support
|
||||
|
||||
Own reusable Spring-capability support that is not specific to one provider:
|
||||
- strict, master-gated settings binding;
|
||||
- a capability startup validation exception that is an IllegalStateException and a Spring Boot ExitCodeGenerator with exit 78.
|
||||
|
||||
The support exception does not know bootstrap internals. app-bootstrap may recognize the generic type in its existing exception reporter and emit the repository-standard structured STARTUP_VALIDATION_FAILED log.
|
||||
|
||||
### adapter:outbound:httpclient
|
||||
|
||||
Own the complete HTTP-client auto-configuration: settings and strict binding, environment-key validation, authentication, TLS/security, resilience, observation, blocking/reactive transport assembly, profile/runtime registry, service/gateway and dynamic-target assembly, actuator endpoint, and startup validation.
|
||||
|
||||
The leaf publishes its root auto-configuration through Boot AutoConfiguration.imports. Runtime activation remains app.httpclient.enabled=true. When absent or false the root auto-configuration creates no client, pool, transport, thread, scheduler, or endpoint.
|
||||
|
||||
### app-bootstrap
|
||||
|
||||
Keep only application-wide startup reporting. It must not import HTTP-client implementation or auto-configuration types after this slice.
|
||||
|
||||
## Compatibility constraints
|
||||
|
||||
- app.httpclient.* keys remain unchanged.
|
||||
- unknown configuration/environment keys continue to fail closed.
|
||||
- enabled-without-clients and unsafe production settings continue to fail startup with the same operator-facing messages.
|
||||
- capability startup configuration errors retain exit code 78 and structured startup reporting.
|
||||
- existing ConditionalOnMissingBean override seams remain.
|
||||
- actuator endpoint remains absent while disabled.
|
||||
- ordinary HTTP-client unit tests remain Docker-free.
|
||||
|
||||
## Build boundary
|
||||
|
||||
This slice moves ownership first. It does not yet flip the app-bootstrap project dependency to runtimeOnly; that belongs to the following build-composition phase after production imports are proven to be zero.
|
||||
@@ -0,0 +1,66 @@
|
||||
# JPA Capability Composition Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Move reusable relational-persistence Spring composition from app-bootstrap into
|
||||
adapter:outbound:persistence-jpa without moving application deployment policy into the adapter and
|
||||
without expanding the JPA public API surface.
|
||||
|
||||
## Final ownership target
|
||||
|
||||
adapter:outbound:persistence-jpa owns:
|
||||
|
||||
- the Boot auto-configuration entry for the relational persistence capability;
|
||||
- always-installed entity/repository/component discovery;
|
||||
- PostgreSQL/H2 vendor selection and vendor beans;
|
||||
- optional Fileserver and Notification JPA persistence registrations under their own switches;
|
||||
- JPA transaction executor and full-transaction retry runtime;
|
||||
- the existing retry/query/transaction observation composition factory (ownership only; this
|
||||
slice does not invent a new persistence-unit configuration key or activate new metrics);
|
||||
- Hibernate provider/runtime-role capability primitives consumed by application management policy.
|
||||
|
||||
app-bootstrap keeps:
|
||||
|
||||
- deployment/profile safety policy such as OSIV and schema mutation refusal;
|
||||
- resolved datasource/version startup validation;
|
||||
- migration startup sequencing;
|
||||
- application-wide database readiness-group contribution;
|
||||
- any application management presentation that intentionally combines deployment policy with
|
||||
persistence facts.
|
||||
|
||||
## Boundary rules
|
||||
|
||||
- The leaf must not depend on app-bootstrap.
|
||||
- A startup/deployment policy is not moved merely because its subject is JPA.
|
||||
- Persistence implementation and provider composition must not be reconstructed in app-bootstrap.
|
||||
- The existing TransactionPort implementation remains leaf-owned; application use cases own when
|
||||
transactions are opened.
|
||||
- New Spring composition classes in the leaf are package-private so verifyJpaApiSurface stays
|
||||
unchanged.
|
||||
- JPA off remains structural: no persistence entities, repositories, provider beans, transaction
|
||||
executors, retry runtime, or observation beans are assembled.
|
||||
|
||||
## Runtime activation
|
||||
|
||||
ca-skeleton.persistence-jpa.enabled remains the capability master switch. The leaf Boot root owns
|
||||
that switch. app-bootstrap startup policy is ordered after the leaf root and uses the same switch.
|
||||
|
||||
## Build boundary
|
||||
|
||||
This phase changes Spring composition ownership only. Whether app-bootstrap can later change the
|
||||
persistence-jpa project edge from implementation to runtimeOnly is evaluated after all application
|
||||
startup-policy compile edges are isolated.
|
||||
|
||||
## Verified result
|
||||
|
||||
- persistence-jpa production imports from app-bootstrap: 0;
|
||||
- public types added by the new `autoconfigure` package: 0;
|
||||
- bootstrap direct construction/import of JPA vendor or transaction/retry implementation: 0;
|
||||
- `verifyJpaApiSurface`: unchanged;
|
||||
- persistence-jpa unit suite: 500 tests, 0 failed;
|
||||
- `:app-bootstrap:test` and `:app-bootstrap:architectureTest`: PASS;
|
||||
- `postgresqlTransactionIntegrationTest`: PASS against real PostgreSQL. The first run failed before
|
||||
PostgreSQL creation because this remote host could not connect back to Testcontainers Ryuk at the
|
||||
mapped host port. Re-running the exact lane with `TESTCONTAINERS_RYUK_DISABLED=true` changed no
|
||||
repository setting and exercised the database assertions successfully;
|
||||
- `git diff --check`: PASS.
|
||||
@@ -0,0 +1,42 @@
|
||||
# JPA Runtime Master Switch
|
||||
|
||||
## Problem
|
||||
|
||||
`PersistenceJpaAutoConfiguration` is gated by `ca-skeleton.persistence-jpa.enabled`, but its sibling
|
||||
`PersistenceJpaRuntimeConfig` is independently listed in Boot auto-configuration imports and only
|
||||
checks `app.jpa-platform.addons-enabled`.
|
||||
|
||||
Because Boot loads both import candidates independently, setting the JPA master switch false can
|
||||
still create provider policy, runtime-role verifier and retry-listener beans from the runtime sibling.
|
||||
|
||||
The current focused test also locks this leak in: it loads `PersistenceJpaRuntimeConfig` without the
|
||||
JPA master switch and expects those beans to exist.
|
||||
|
||||
## Decision
|
||||
|
||||
Both JPA leaf auto-configuration entries must be structurally subordinate to
|
||||
`ca-skeleton.persistence-jpa.enabled=true`.
|
||||
|
||||
`PersistenceJpaRuntimeConfig` keeps its existing secondary `app.jpa-platform.addons-enabled` switch,
|
||||
but the master switch is mandatory and evaluated as the capability ownership boundary.
|
||||
|
||||
Focused tests state the master explicitly:
|
||||
|
||||
- JPA on + addons default/on -> runtime beans exist.
|
||||
- JPA off -> no runtime beans, even when addons would otherwise default on.
|
||||
- JPA on + addons off -> no runtime beans.
|
||||
|
||||
No bootstrap-side workaround or bean-count guard is added. The leaf that publishes the independent
|
||||
Boot import candidate owns its own master condition.
|
||||
|
||||
## Verified result
|
||||
|
||||
- Focused RED reproduced the leak: JPA master off still created runtime beans before the production fix.
|
||||
- `PersistenceJpaRuntimeConfig` now requires `ca-skeleton.persistence-jpa.enabled=true` in addition to the addons switch.
|
||||
- JPA on + addons default/on composes the runtime beans.
|
||||
- JPA off contributes no `HibernateProviderPolicy` or `PostgreSqlRuntimeRoleVerifier`.
|
||||
- JPA on + addons off contributes no runtime beans.
|
||||
- persistence-jpa `check`: PASS.
|
||||
- `verifyJpaApiSurface`: unchanged.
|
||||
- app-bootstrap `test`, `architectureTest` and `systemTest`: PASS.
|
||||
- `git diff --check`: PASS.
|
||||
@@ -0,0 +1,50 @@
|
||||
# Mongo Health Composition Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Finish Mongo's existing leaf-owned Spring composition by moving the Actuator health bridge out of
|
||||
app-bootstrap and into adapter:outbound:persistence-mongo.
|
||||
|
||||
## Basis
|
||||
|
||||
MNG-007 already requires Mongo health to be connected to Spring Boot's HealthContributor SPI from
|
||||
the Mongo composition root. MongoRootAutoConfiguration is already the shipped leaf entry point.
|
||||
Keeping the final SPI bridge in app-bootstrap leaves the capability split across two owners.
|
||||
|
||||
## Ownership
|
||||
|
||||
adapter:outbound:persistence-mongo owns:
|
||||
|
||||
- MongoPlatformHealthIndicator, which computes bounded Mongo health facts;
|
||||
- a package-private Actuator HealthIndicator adapter;
|
||||
- a package-private health configuration imported by MongoRootAutoConfiguration;
|
||||
- the Mongo master switch and conditional registration of the health contributor.
|
||||
|
||||
app-bootstrap owns no Mongo-specific production health bridge after this slice.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- ca-skeleton.persistence-mongo.enabled remains the master switch;
|
||||
- Mongo health semantics do not change: topology mismatch => DOWN, degraded secondary availability
|
||||
remains UP with detail;
|
||||
- the existing bean name mongoPlatformHealthContributor is retained;
|
||||
- ConditionalOnMissingBean remains so adopters may override the contributor;
|
||||
- no new public Mongo API type is introduced;
|
||||
- management endpoint exposure remains controlled by Spring Boot/application Actuator exposure policy.
|
||||
|
||||
## Dependency
|
||||
|
||||
The leaf adds org.springframework.boot:spring-boot-health, the minimal SPI artifact already used by
|
||||
cache-redis and notification. The affected Mongo dependency lock is refreshed only for this
|
||||
coordinate change.
|
||||
|
||||
## Verified result
|
||||
|
||||
- app-bootstrap Mongo production health files: 0;
|
||||
- persistence-mongo production imports from app-bootstrap: 0;
|
||||
- new public Mongo health types: 0;
|
||||
- verifyMongoApiSurface: unchanged;
|
||||
- persistence-mongo check: PASS, including stable-contract and lane gates;
|
||||
- app-bootstrap test and architectureTest: PASS;
|
||||
- verifyDependencyLocks: PASS after refreshing only the Mongo leaf lock for the health SPI dependency;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,63 @@
|
||||
# Notification Capability Composition Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Move reusable Notification provider/runtime Spring composition out of app-bootstrap and into the
|
||||
Notification capability leaf while preserving the existing application transaction boundary,
|
||||
master switch, legacy-route bridge, platform mode, secret validation, workers, metrics, and actuator
|
||||
behavior.
|
||||
|
||||
## Final ownership
|
||||
|
||||
adapter:outbound:notification owns:
|
||||
|
||||
- NotificationPlatformAutoConfiguration as the Boot entry point;
|
||||
- package-private core/runtime configuration slices for codec, secrets, registries, provider
|
||||
assembly, provider policy, runtime dispatch support, workers, and observability;
|
||||
- notification health endpoint and observation convention;
|
||||
- legacy route configuration imports until NTF-INT-004 removes them;
|
||||
- strict notification secret validation through CapabilityStartupValidationException.
|
||||
|
||||
app-bootstrap owns:
|
||||
|
||||
- NotificationApplicationCompositionAutoConfiguration;
|
||||
- construction of transaction-bound application services and inbound use cases;
|
||||
- the Notification admin application service;
|
||||
- NotificationDispatchService and callback/projection services whose transaction boundary is an
|
||||
application decision;
|
||||
- repository-wide startup failure reporting.
|
||||
|
||||
This split is required by NTF-020: TransactionPort and product-level operator/application policy
|
||||
must not move into the outbound Notification adapter merely because Spring composition moved.
|
||||
|
||||
## Runtime activation
|
||||
|
||||
The existing master switch ca-skeleton.notification.platform.enabled remains the root gate.
|
||||
NotificationPlatformAutoConfiguration contributes reusable capability runtime only when enabled.
|
||||
NotificationApplicationCompositionAutoConfiguration is ordered after that leaf auto-configuration
|
||||
and is gated by the same switch.
|
||||
|
||||
## Public API
|
||||
|
||||
The ownership move must not expand the Notification public API. Internal Spring configuration and
|
||||
observation helper types remain package-private. The existing public
|
||||
NotificationPlatformAutoConfiguration is reused as the Boot entry point.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- configuration keys do not change;
|
||||
- provider/mode and worker lifecycle semantics do not change;
|
||||
- secret validation remains fail-closed with exit 78;
|
||||
- health endpoint remains non-sensitive;
|
||||
- existing ConditionalOnMissingBean override seams remain;
|
||||
- current notification evidence/configuration/API gates remain owned by the notification leaf;
|
||||
- the outbound Notification leaf has no TransactionPort dependency.
|
||||
|
||||
## Build boundary
|
||||
|
||||
This phase moves Spring ownership, not build inclusion. One intentional compile-time edge remains
|
||||
from NotificationApplicationCompositionAutoConfiguration to NotificationDispatchProperties, the
|
||||
typed runtime bounds object produced by the leaf. Duplicating its configuration binding in
|
||||
app-bootstrap would create a second SSOT. Removing this final concrete compile edge belongs to the
|
||||
later build-inclusion/runtimeOnly phase, where the selected-capability boundary can be redesigned
|
||||
without duplicating configuration policy.
|
||||
@@ -192,3 +192,18 @@ Required:
|
||||
9. startup rejects canonical transport enabled without `IntegrationEventPublishPort`;
|
||||
10. default-off composition preserves current behavior;
|
||||
11. architecture/dependency checks and `git diff --check` pass.
|
||||
|
||||
## Verified implementation result
|
||||
|
||||
- Canonical append persists exact envelope bytes plus complete canonical metadata in the existing
|
||||
legacy outbox authority.
|
||||
- Claimed rows are split explicitly into legacy and canonical variants; partial canonical rows fail
|
||||
closed.
|
||||
- Legacy claims publish only through the legacy broker path; canonical claims publish only through
|
||||
IntegrationEventPublishPort with exact stored bytes.
|
||||
- Canonical transport remains opt-in and does not create a second scheduler or switch publication
|
||||
authority to POLLING_V2.
|
||||
- application-core, persistence-jpa, messaging, app-bootstrap architecture/system, focused
|
||||
PostgreSQL migration/outbox integration, env-key verification, clean-architecture dependency
|
||||
verification and the full sample-portfolio check pass.
|
||||
- git diff --check passes.
|
||||
|
||||
@@ -0,0 +1,158 @@
|
||||
# Outbox V2 Canonical Storage Alignment
|
||||
|
||||
## Status
|
||||
|
||||
Derived implementation slice from the approved messaging R2 Task 7/8 design and the completed
|
||||
MSG-015 transport-only cutover.
|
||||
|
||||
This slice does not switch publication authority. LEGACY_POLLING remains active and no v2 relay
|
||||
scheduler is composed.
|
||||
|
||||
## Problem
|
||||
|
||||
The current owner-safe v2 storage mechanics are useful, but their immutable event model predates the
|
||||
canonical ValidatedIntegrationEvent contract. NewOutboxEventV2 stores raw strings and a text
|
||||
payload; ClaimedOutboxDelivery returns the same reduced projection. The database has no tenant
|
||||
scope, exact envelope BYTEA, canonical hashes or catalog/binding revisions.
|
||||
|
||||
That shape cannot later publish through the canonical messaging platform without inventing or
|
||||
re-deriving metadata.
|
||||
|
||||
## Application model
|
||||
|
||||
ValidatedIntegrationEvent is the semantic and wire authority.
|
||||
|
||||
NewOutboxEventV2 becomes a narrow receipt/CAS wrapper around one ValidatedIntegrationEvent. It may
|
||||
expose convenience accessors for the existing persistence implementation, but it has no raw payload
|
||||
constructor and cannot represent a non-canonical event.
|
||||
|
||||
ClaimedOutboxDelivery carries OutboxDeliveryOwner plus ValidatedIntegrationEvent. The claim boundary
|
||||
therefore returns exact immutable envelope bytes and all metadata required by the platform bridge.
|
||||
|
||||
## Storage alignment
|
||||
|
||||
Add forward-only outbox-storage/V2 migration. Do not edit V1.
|
||||
|
||||
Existing v2 rows may already exist in test/dev databases, so canonical columns are additive and
|
||||
nullable as one compatibility generation. A row is either pre-canonical (all new canonical columns
|
||||
null) or canonical (all required canonical columns present). Mixed rows are rejected by an
|
||||
all-or-none CHECK.
|
||||
|
||||
Canonical aggregate ordering is tenant-scoped. The V2 migration adds nullable tenant scope to the
|
||||
identity table, keeps a legacy partial unique index for pre-canonical rows, and adds a tenant-aware
|
||||
partial unique index for canonical rows. Canonical event-log rows also reference the complete
|
||||
event/tenant/aggregate identity tuple, so duplicated metadata cannot drift between the identity and
|
||||
event tables.
|
||||
|
||||
Existing columns are retained as compatibility aliases:
|
||||
- event_type = canonical contract ID
|
||||
- event_schema = canonical payload version
|
||||
- aggregate_version = canonical aggregate sequence
|
||||
- event_ordinal = canonical event index
|
||||
- logical_destination = canonical logical destination ID
|
||||
- partition_key = canonical partition key text
|
||||
- payload = strict UTF-8 projection of exact envelope bytes
|
||||
- payload_digest = canonical envelope SHA-256
|
||||
|
||||
New columns:
|
||||
- tenant_scope varchar(96)
|
||||
- envelope_version integer
|
||||
- envelope_bytes bytea
|
||||
- schema_set_hash char(64)
|
||||
- envelope_sha256 char(64)
|
||||
- envelope_schema_hash char(64)
|
||||
- payload_schema_hash char(64)
|
||||
- contract_catalog_revision varchar(96)
|
||||
- destination_binding_revision varchar(96)
|
||||
|
||||
trace_parent remains nullable and unused because the current canonical application model carries no
|
||||
trace context. No trace value is invented.
|
||||
|
||||
Event IDs are widened to 96 characters across storage and polling tables with forward-only V2
|
||||
migrations so the database accepts the canonical EventId grammar.
|
||||
|
||||
## Append behavior
|
||||
|
||||
PostgreSqlImmutableOutboxAppendAdapter persists exact envelopeBytes and all canonical metadata.
|
||||
|
||||
The compatibility text projection is decoded with a strict UTF-8 decoder and must round-trip exactly
|
||||
to the canonical bytes. Failure aborts the caller transaction.
|
||||
|
||||
Duplicate-event equality compares canonical semantic metadata and envelope_sha256; it never
|
||||
re-serializes the envelope.
|
||||
|
||||
If an existing identity points to a pre-canonical row, canonical replay classification fails closed
|
||||
instead of guessing that the old row is the same event.
|
||||
|
||||
## Claim behavior
|
||||
|
||||
PostgreSqlPollingDeliveryAdapter selects the canonical columns and reconstructs one
|
||||
ValidatedIntegrationEvent.
|
||||
|
||||
A pre-canonical or partially canonical row cannot be returned as a canonical delivery. Mapping fails
|
||||
closed, causing the caller-owned claim transaction to roll back.
|
||||
|
||||
No physical topic is persisted or exposed in application.
|
||||
|
||||
## Authority and rollout
|
||||
|
||||
This slice does not:
|
||||
- change outbox_publication_control_v2.active_authority
|
||||
- activate a polling v2 scheduler
|
||||
- create a second publisher
|
||||
- backfill pre-canonical v2 rows
|
||||
- delete the legacy transport/storage path
|
||||
- claim production readiness
|
||||
|
||||
A later cutover slice must prove that no pre-canonical blocking rows remain before switching to
|
||||
POLLING_V2.
|
||||
|
||||
## Verification
|
||||
|
||||
Required:
|
||||
1. application v2 tests prove wrappers cannot represent non-canonical events;
|
||||
2. real PostgreSQL migration proves additive canonical columns, all-or-none shape and 96-char IDs;
|
||||
3. append round-trips exact BYTEA and every canonical field;
|
||||
4. duplicate replay uses canonical identity/hash;
|
||||
5. polling claim reconstructs an equal ValidatedIntegrationEvent;
|
||||
6. pre-canonical claim/replay fails closed;
|
||||
7. publication authority remains LEGACY_POLLING unless an existing test explicitly performs an
|
||||
isolated cutover fixture;
|
||||
8. application-core and persistence-jpa checks pass;
|
||||
9. clean architecture and diff checks pass.
|
||||
|
||||
## Verified result
|
||||
|
||||
- `NewOutboxEventV2` is now only a wrapper over `ValidatedIntegrationEvent`; the old raw payload
|
||||
event model is gone.
|
||||
- `ClaimedOutboxDelivery` carries the exact reconstructed `ValidatedIntegrationEvent`.
|
||||
- Forward-only storage and polling V2 migrations preserve existing V1 history and widen canonical
|
||||
event IDs to 96 characters.
|
||||
- PostgreSQL stores exact envelope `BYTEA`, tenant scope, envelope version, four canonical hashes,
|
||||
contract-catalog revision and destination-binding revision.
|
||||
- Compatibility text is a strict UTF-8 projection of the exact bytes. Invalid UTF-8 fails before
|
||||
the first identity write; a real PostgreSQL test proves no orphan identity is left.
|
||||
- Canonical duplicate classification compares the reconstructed canonical event rather than
|
||||
re-hashing or re-serializing a second model.
|
||||
- Canonical aggregate ordering is tenant-scoped. Canonical event-log rows are linked to the full
|
||||
immutable event/tenant/aggregate identity tuple, so duplicated identity metadata cannot drift.
|
||||
- A 96-character canonical event ID is accepted by storage and polling schema.
|
||||
- Partial canonical rows are rejected by database constraints.
|
||||
- Pre-canonical V2 replay and polling claim fail closed; failed claim mapping rolls the transaction
|
||||
back and leaves delivery state `PENDING`.
|
||||
- The optional-stream lifecycle test proves both normal V2 migration and the cross-stream upgrade
|
||||
order where polling V1 exists before storage V2.
|
||||
- Real PostgreSQL `postgresqlOutboxStorageIntegrationTest` and
|
||||
`postgresqlOutboxPollingIntegrationTest`: PASS. Verification used process-local
|
||||
`TESTCONTAINERS_RYUK_DISABLED=true` only because of the known remote-host Ryuk callback issue.
|
||||
- `:application-core:test`: PASS.
|
||||
- `:application-core:check -x :application-core:spotlessCheck`: PASS. Full application-core
|
||||
Spotless is independently blocked by two pre-existing unrelated test-formatting changes
|
||||
(`ObjectStorageArchitectureContractTest`, `CompiledPackageScanner`); this slice did not rewrite
|
||||
them.
|
||||
- `:adapter:outbound:persistence-jpa:check`: PASS.
|
||||
- `:adapter:outbound:persistence-jpa:verifyJpaApiSurface`: PASS; public API unchanged.
|
||||
- `verifyCleanArchitectureDependencies`: PASS.
|
||||
- The V1 storage bootstrap still seeds `LEGACY_POLLING`; this slice adds no authority switch.
|
||||
`PostgreSqlPollingDeliveryAdapter` has no component/repository/configuration stereotype and no V2
|
||||
scheduler is composed.
|
||||
@@ -0,0 +1,105 @@
|
||||
# Outbox V2 One-Record Publication Policy
|
||||
|
||||
## Status
|
||||
|
||||
Application-policy continuation of the canonical V2 storage candidate. This adapts original R2 Task
|
||||
9 to the newer canonical bridge and the actually implemented V2 delivery state machine.
|
||||
|
||||
This slice is unwired. LEGACY_POLLING remains production authority.
|
||||
|
||||
## Reused canonical contracts
|
||||
|
||||
Do not create a second publication-outcome hierarchy. IntegrationEventPublishPort already returns
|
||||
OutboxPublishOutcome with four provider-neutral states:
|
||||
|
||||
- CONFIRMED
|
||||
- AMBIGUOUS
|
||||
- REJECTED_BEFORE_SEND
|
||||
- REJECTED_AFTER_BROKER
|
||||
|
||||
The V2 delivery database currently supports PENDING, CLAIMED, RETRY_WAIT, PUBLISHED and DEAD.
|
||||
Therefore this slice does not invent HOLD, EXHAUSTED or DELIVERY_RECORDED application states that
|
||||
the persistence candidate cannot represent.
|
||||
|
||||
## One-record sequence
|
||||
|
||||
One command invocation processes at most one record:
|
||||
|
||||
1. acquire a bounded publication admission permit;
|
||||
2. Tx B: claim with batchSize=1;
|
||||
3. if no row exists, release the permit and return NO_DELIVERY;
|
||||
4. publish the exact ValidatedIntegrationEvent outside any database transaction;
|
||||
5. Tx C: perform one owner/version/epoch CAS transition;
|
||||
6. release the admission permit.
|
||||
|
||||
The use case never loops over a batch and never opens REQUIRES_NEW inside a per-row loop.
|
||||
|
||||
## Publication outcome mapping
|
||||
|
||||
- CONFIRMED -> PUBLISHED
|
||||
- AMBIGUOUS -> RETRY_WAIT when retry budget remains; otherwise DEAD
|
||||
- REJECTED_BEFORE_SEND -> DEAD
|
||||
- REJECTED_AFTER_BROKER -> DEAD
|
||||
- synchronous throw, exceptional completion, timeout or interruption while waiting for the
|
||||
CompletionStage -> AMBIGUOUS because acceptance certainty is unknown
|
||||
|
||||
Interruption restores the thread interrupted flag.
|
||||
|
||||
Transition failures are not silently converted to publication failures. The expected successful
|
||||
transition result or ALREADY_APPLIED_SAME_OPERATION is accepted; other CAS outcomes fail closed.
|
||||
|
||||
## Immutable retry budget
|
||||
|
||||
ClaimedOutboxDelivery carries two DB timestamps in addition to the canonical event:
|
||||
|
||||
- eventCreatedAt
|
||||
- deliveryCreatedAt
|
||||
|
||||
Automatic deadline is the earlier of:
|
||||
|
||||
- deliveryCreatedAt + maximumAutomaticPublicationAge
|
||||
- eventCreatedAt + sameEventHorizon
|
||||
|
||||
Age never starts at first_attempt_at.
|
||||
|
||||
Retry policy also owns:
|
||||
|
||||
- maximumAttempts
|
||||
- baseDelay
|
||||
- maximumDelay
|
||||
- full bounded jitter source
|
||||
- publishTimeout
|
||||
- transitionSafetyMargin
|
||||
|
||||
A configured claim lease must exceed publishTimeout + transitionSafetyMargin before the use case
|
||||
claims anything.
|
||||
|
||||
A retry candidate whose next attempt would reach or exceed the immutable deadline becomes DEAD
|
||||
instead.
|
||||
|
||||
## Operation identity
|
||||
|
||||
Tx-C operation IDs are deterministic SHA-256 identities over event ID, publication epoch, attempt,
|
||||
target transition and error code. This stays under OperationId's 128-character limit even when the
|
||||
canonical event ID uses its full 96-character bound, and replaying the same logical transition
|
||||
produces the same operation ID.
|
||||
|
||||
## Admission
|
||||
|
||||
OutboxPublicationAdmissionPort is application-owned. It returns an optional permit; empty means the
|
||||
worker is saturated and must not claim. The concrete bulkhead implementation is deliberately not
|
||||
part of this slice.
|
||||
|
||||
## Rollout boundary
|
||||
|
||||
This slice does not:
|
||||
|
||||
- register a Spring bean or scheduler;
|
||||
- compose PostgreSqlPollingDeliveryAdapter;
|
||||
- activate the polling capability;
|
||||
- change publication authority;
|
||||
- add a second publisher;
|
||||
- claim the V2 protocol is production ready.
|
||||
|
||||
The persistence candidate still needs Task-10-style valid-lease CAS/attempt-journal strengthening
|
||||
before authority cutover.
|
||||
@@ -0,0 +1,52 @@
|
||||
# PostgreSQL Idempotency Composition Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Remove the concrete PostgreSQL owner-safe idempotency store construction from app-bootstrap while
|
||||
keeping provider selection, lifecycle policy, and assembly validation application-owned.
|
||||
|
||||
## Ownership
|
||||
|
||||
adapter:outbound:persistence-jpa owns:
|
||||
|
||||
- construction of PostgreSqlOwnerSafeIdempotencyStore;
|
||||
- the provider=postgresql condition for that concrete store;
|
||||
- reachability only through PersistenceJpaAutoConfiguration, so the JPA master switch remains the
|
||||
structural prerequisite.
|
||||
|
||||
app-bootstrap owns:
|
||||
|
||||
- IdempotencyProviderSettings and the provider selection;
|
||||
- IdempotencySettings TTL/reaper policy;
|
||||
- IdempotencyExecutorV2 lifecycle policy such as processing lease, response codec id, replay/failure
|
||||
retention and policy revision;
|
||||
- bean-count/exclusivity validation across JDBC, Redis and PostgreSQL providers;
|
||||
- startup dependency validation saying both jdbc and postgresql providers require JPA.
|
||||
|
||||
## Boundary
|
||||
|
||||
The leaf configuration exposes only the application-owned IdempotencyStorePortV2 bean. It does not
|
||||
import app-bootstrap settings or construct the application executor. app-bootstrap consumes the port
|
||||
and no longer imports PostgreSqlOwnerSafeIdempotencyStore.
|
||||
|
||||
No new public JPA type is required; the store configuration remains package-private under the
|
||||
existing JPA autoconfigure package.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- provider property and values are unchanged;
|
||||
- provider=postgresql still yields exactly one V2 store and one V2 executor when JPA is enabled;
|
||||
- other providers never receive the PostgreSQL store;
|
||||
- the existing executor policy constants are unchanged;
|
||||
- provider=postgresql with JPA disabled now fails during capability dependency validation rather
|
||||
than reaching a later missing-bean failure.
|
||||
|
||||
## Verified result
|
||||
|
||||
- app-bootstrap idempotency production imports from persistence concrete packages: 0;
|
||||
- persistence-jpa production imports from app-bootstrap: 0;
|
||||
- PostgreSQL store configuration is package-private and contributes only IdempotencyStorePortV2;
|
||||
- provider=postgresql with JPA disabled is rejected by capability dependency validation;
|
||||
- persistence-jpa check and verifyJpaApiSurface: PASS, public API unchanged;
|
||||
- app-bootstrap test and architectureTest: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,59 @@
|
||||
# Runtime Environment and Tracing SSOT
|
||||
|
||||
## Goal
|
||||
|
||||
Finish BOOT-002 by removing the remaining independent runtime-profile vocabularies from tracing and capability validation.
|
||||
|
||||
## Canonical runtime vocabulary
|
||||
|
||||
shared-contract RuntimeEnvironment remains the only shipped runtime-environment vocabulary:
|
||||
|
||||
- local
|
||||
- dev
|
||||
- prod
|
||||
|
||||
The runtime-remediation design explicitly says STAGING is not a shipped runtime environment until a separate runtime environment is introduced. Therefore tracing must not independently advertise staging as a deployable profile.
|
||||
|
||||
## Tracing rule
|
||||
|
||||
TracingSampleRateResolver maps RuntimeEnvironment values, not raw profile strings:
|
||||
|
||||
- PROD -> 0.01
|
||||
- DEV -> 1.0
|
||||
- LOCAL -> 1.0
|
||||
|
||||
A valid APP_TRACING_SAMPLE_RATE override still wins. An unknown/test/profileless context falls back to 1.0 for the resolver, but it is not renamed to local. The shipped application cannot reach profileless tracing because RuntimeEnvironmentProfileValidator runs before tracing defaulting and rejects a missing/unknown runtime profile.
|
||||
|
||||
TracingSamplingRateGauge is registered only when exactly one RuntimeEnvironment resolves. Slice/test contexts without a deployable runtime environment do not emit a misleading runtime-profile gauge.
|
||||
|
||||
## Capability validation
|
||||
|
||||
CapabilityDependencyValidator keys GraphQL deployment-mode policy by RuntimeEnvironment rather than duplicated local/dev/prod string literals.
|
||||
|
||||
## Contract cleanup
|
||||
|
||||
The stale tracing-only staging=10% contract is removed from:
|
||||
|
||||
- tracing tests;
|
||||
- env registry comments;
|
||||
- metrics registry profile allowlist/cardinality;
|
||||
- observability config comments;
|
||||
- README tracing documentation.
|
||||
|
||||
This is a contract correction, not the addition of a new environment. Generic uses of the word staging for deployment pipelines, data staging areas, or migration posture are unrelated and remain unchanged.
|
||||
|
||||
## Verified result
|
||||
|
||||
- RuntimeEnvironment remains the only shipped local/dev/prod runtime vocabulary.
|
||||
- TracingSampleRateResolver derives defaults from RuntimeEnvironment; there is no tracing-only
|
||||
staging branch and profileless/test/unknown callers are not renamed to local.
|
||||
- TracingConfig publishes tracing.sampling.rate only when exactly one deployable
|
||||
RuntimeEnvironment resolves; profileless slice contexts publish no runtime-profile gauge.
|
||||
- CapabilityDependencyValidator keys GraphQL deployment-mode policy by RuntimeEnvironment.
|
||||
- metrics.yaml and env-keys.yaml pin tracing defaults to prod=0.01 and dev/local=1.0 with a
|
||||
three-value profile tag cardinality.
|
||||
- No production path in the reviewed application/fileserver/httpclient/object-storage scope defines
|
||||
its own prod/production vocabulary; profile decisions delegate to RuntimeEnvironment.
|
||||
- Focused RuntimeEnvironment, tracing, GraphQL-policy and distributed-tracing contract tests: PASS.
|
||||
- app-bootstrap Spotless, full test and architectureTest: PASS.
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,64 @@
|
||||
# Secret Source Port Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Finish BOOT-017 by removing the concrete secret-backend adapter implementation from app-bootstrap
|
||||
without introducing an outbound-support -> app-bootstrap dependency.
|
||||
|
||||
## Boundary
|
||||
|
||||
application-core owns:
|
||||
|
||||
- SecretSourcePort in dev.caskeleton.application.outbound;
|
||||
- the framework-free contract: resolve a key to a non-blank optional value.
|
||||
|
||||
adapter:outbound:support owns:
|
||||
|
||||
- EnvironmentSecretSource, the Spring Environment-backed implementation of SecretSourcePort.
|
||||
|
||||
app-bootstrap owns:
|
||||
|
||||
- SecretSourceStrategy and SecretSourceSettings;
|
||||
- SecretSourceFactory, which selects one concrete backend;
|
||||
- SecretSourceConfig and SecretSourceValidator;
|
||||
- startup/deployment policy that decides which backend is selected and which secrets are required.
|
||||
|
||||
## Naming
|
||||
|
||||
The old bootstrap-local SecretSource interface is removed. The application-owned contract is named
|
||||
SecretSourcePort because application-core requires outbound interfaces to use the *Port suffix.
|
||||
|
||||
## Composition rule
|
||||
|
||||
It is valid for app-bootstrap to import EnvironmentSecretSource in SecretSourceFactory: selecting an
|
||||
adapter implementation is composition-root work. It is not valid for a bootstrap class to implement
|
||||
SecretSourcePort itself.
|
||||
|
||||
CompositionRootBoundaryArchitectureTest already enforces the latter for application/domain ports.
|
||||
Its only intentional allowlist remains MeteredDistributedLockPort, the one metering decorator the
|
||||
BOOT-017 review explicitly permits to stay until a second decorator appears.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- ca-skeleton.secret-source.strategy remains unchanged;
|
||||
- ENVIRONMENT remains the shipped default;
|
||||
- a missing or blank environment value still resolves as Optional.empty();
|
||||
- SecretSourceValidator and Redis secret consumers depend only on SecretSourcePort;
|
||||
- no secret value or key behavior changes.
|
||||
|
||||
## Verified result
|
||||
|
||||
- EnvironmentSecretSource exists only in adapter:outbound:support;
|
||||
- the bootstrap-local SecretSource and EnvironmentSecretSource types are removed;
|
||||
- SecretSourcePort is application-owned under application.outbound;
|
||||
- MeteredDistributedLockPort is the only bootstrap production class implementing an application/domain port, matching the review explicit decorator allowlist;
|
||||
- CompositionRootBoundaryArchitectureTest: PASS;
|
||||
- application-core test: PASS;
|
||||
- adapter:outbound:support check: PASS;
|
||||
- app-bootstrap full test and architectureTest: PASS;
|
||||
- verifyCleanArchitectureDependencies: PASS;
|
||||
- git diff --check: PASS.
|
||||
|
||||
### Formatting note
|
||||
|
||||
The repository-wide application-core Spotless check is not globally green because two pre-existing accumulated test changes are unformatted: ObjectStorageArchitectureContractTest and CompiledPackageScanner. SecretSourcePort was not reported as a formatting violation, and this slice did not rewrite those unrelated test files.
|
||||
@@ -0,0 +1,46 @@
|
||||
# Startup Failure Log Context State
|
||||
|
||||
## Goal
|
||||
|
||||
Resolve BOOT-013 by replacing process-global startup-failure logging state with state scoped to the
|
||||
Logback Context that owns the duplicate-suppression TurboFilter.
|
||||
|
||||
## Existing problem
|
||||
|
||||
StartupFailureLogState currently owns a static AtomicBoolean and exposes clearForTest() from
|
||||
production code. The state survives across LoggerContext instances and would make parallel tests or
|
||||
multiple logging contexts interfere with each other.
|
||||
|
||||
## Design
|
||||
|
||||
StartupFailureLogState remains a small bridge because StartupFailures and the Logback TurboFilter
|
||||
live in different packages, but it owns no mutable static state.
|
||||
|
||||
- The marker is stored with Context.putObject under one private stable key.
|
||||
- markStartupFailureReported() resolves the current SLF4J ILoggerFactory and, when it is a Logback
|
||||
LoggerContext, marks that context.
|
||||
- markStartupFailureReported(Context) exists for explicit context-scoped callers/tests.
|
||||
- startupFailureReported(Context) reads only the supplied context.
|
||||
- clearForTest() is removed.
|
||||
- StartupFailureSpringBootLogFilter reads getContext(), so duplicate suppression applies only to the
|
||||
LoggerContext that owns that filter.
|
||||
|
||||
If a non-Logback ILoggerFactory is installed, the canonical structured failure log still emits; only
|
||||
the Logback-specific duplicate suppression marker is naturally unavailable.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- StartupFailures still emits the same structured fields and exception types.
|
||||
- Spring Boot duplicate messages are still denied after the canonical startup failure is emitted.
|
||||
- unrelated loggers/messages remain neutral.
|
||||
- no production test-only reset API remains.
|
||||
|
||||
## Verified result
|
||||
|
||||
- StartupFailureLogState has no mutable static field;
|
||||
- clearForTest is removed from production code;
|
||||
- StartupFailureSpringBootLogFilter reads only its own Logback Context;
|
||||
- a dedicated test proves marking one LoggerContext does not affect another;
|
||||
- existing structured StartupFailures behavior remains green;
|
||||
- app-bootstrap Spotless, full test and architectureTest: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,51 @@
|
||||
# Test Architecture Phase 2 — Provider Ownership
|
||||
|
||||
## Goal
|
||||
|
||||
Close provider-evidence ownership gaps without turning `app-bootstrap` into a provider test project.
|
||||
|
||||
The governing rule is:
|
||||
|
||||
- application-core owns reusable, provider-neutral port contracts;
|
||||
- an adapter leaf owns real-provider semantics for the provider it implements;
|
||||
- app-bootstrap owns assembly, conditional wiring, authority selection, and whole-application composition;
|
||||
- cross-layer journeys remain composition/system evidence only when the claim cannot be decomposed into one provider contract.
|
||||
|
||||
## First bounded slice: PostgreSQL/JPA provider semantics
|
||||
|
||||
The following current app-bootstrap integration tests are provider semantics and move to
|
||||
`adapter:outbound:persistence-jpa`:
|
||||
|
||||
1. `FlywayMigrationCompatibilityContractTest`
|
||||
- claim: an already-applied historical `V4__int_lock.sql` migrates forward through the shipped `V5__int_lock_expired_after.sql` without mutating the historical migration;
|
||||
- owner: PostgreSQL/Flyway persistence provider;
|
||||
- target: `postgresqlIntegrationTest`;
|
||||
- fail-closed lane: exact readiness selector.
|
||||
2. `IdempotencyUniqueScopeContractTest`
|
||||
- claim: the shipped PostgreSQL unique scope produces SQLSTATE 23505 and the persistence translator maps the real driver failure to `DB_UNIQUE_VIOLATION`;
|
||||
- owner: PostgreSQL persistence adapter;
|
||||
- target: `postgresqlIntegrationTest`;
|
||||
- fail-closed lane: exact readiness selector.
|
||||
|
||||
The assertions move without semantic weakening. Bootstrap-specific references are removed from the moved tests. PostgreSQL lifecycle uses the persistence-jpa testkit so Docker absence fails closed instead of producing an approved skip.
|
||||
|
||||
## What remains in app-bootstrap
|
||||
|
||||
`app-bootstrap` may keep Compose/rendering contracts, conditional bean/settings composition, full application boot/system checks, authority/cutover orchestration tests, and thin cross-layer smoke checks after leaf provider contracts exist. It must not be the only owner of PostgreSQL constraint, migration, lock, outbox, broker, cache, or filesystem-provider semantics.
|
||||
|
||||
## Follow-up slices
|
||||
|
||||
1. Distributed lock: real PostgreSQL/Spring Integration lock behavior moves to persistence-jpa; bootstrap keeps bean enablement, metering wrapper, and composition only.
|
||||
2. Legacy outbox: application-core owns reusable provider-neutral contracts, persistence-jpa owns PostgreSQL append/claim/state/transaction semantics, bootstrap keeps publication authority/cutover wiring. Preserve the active messaging/outbox migration plan.
|
||||
3. Fileserver: fileserver owns local filesystem behavior, persistence-jpa owns metadata persistence/migration, inbound web owns transport, bootstrap/system owns only the final assembled journey if still needed.
|
||||
4. MongoDB and broker gaps: add real provider baselines to the owning leaves for enabled production capabilities.
|
||||
|
||||
## Acceptance for each ownership move
|
||||
|
||||
- no production dependency edge is added solely to make a test compile;
|
||||
- moved provider tests live on a provider source set, not ordinary `test`;
|
||||
- Docker/provider absence fails the required lane rather than becoming an approved JUnit skip;
|
||||
- exact selectors or an equally fail-closed discovery rule cover the moved class;
|
||||
- original assertions are preserved unless a stronger provider-owned assertion replaces them;
|
||||
- app-bootstrap loses provider-specific support when no remaining bootstrap test needs it;
|
||||
- focused owner test, bootstrap regression, architecture gate, dependency lock, and `git diff --check` are green.
|
||||
@@ -0,0 +1,74 @@
|
||||
# Test Taxonomy SSOT Alignment
|
||||
|
||||
## Goal
|
||||
|
||||
Close the remaining BOOT-016 drift by aligning the human testing strategy with the test taxonomy that
|
||||
the build now actually enforces.
|
||||
|
||||
## Machine SSOT
|
||||
|
||||
The only test-lane categories are the values of
|
||||
`dev.caskeleton.buildlogic.strictlane.TestLaneCategory`:
|
||||
|
||||
- TEST
|
||||
- INTEGRATION
|
||||
- SYSTEM
|
||||
- ARCHITECTURE
|
||||
- PERFORMANCE
|
||||
|
||||
`StrictTestLaneSpec` exposes one method for each category and category-specific aggregate tasks.
|
||||
|
||||
## Human SSOT
|
||||
|
||||
`docs/testing/TESTING_STRATEGY.md` explains how to choose one of those five categories.
|
||||
|
||||
Terms such as unit, slice and contract are TEST styles, not additional lane categories. They can
|
||||
describe what a TEST-category test is checking without creating another execution taxonomy.
|
||||
|
||||
Qualification is also not a category. It is a repository/CI gate that may aggregate SYSTEM lanes and
|
||||
other verification tasks. A task or workflow containing the word qualification does not create a
|
||||
sixth TestLaneCategory.
|
||||
|
||||
## Source sets
|
||||
|
||||
Category and source-set name are separate concepts.
|
||||
|
||||
- The conventional `src/test` source set is TEST by default.
|
||||
- A strict lane may use an auxiliary source set and declares its category explicitly.
|
||||
- A source-set name such as `postgresqlIntegrationTest` is an implementation detail; its category is
|
||||
the lane declaration, not a Markdown registry.
|
||||
|
||||
## Documentation drift policy
|
||||
|
||||
Do not restore `verifyTestSourceSetRegistry` or another Markdown/Gradle parser.
|
||||
|
||||
The 2026-09-16 verification-surface design deliberately removed current-state documentation parsers:
|
||||
the build enforces executable invariants and conventions, while documentation explains how to apply
|
||||
them. Adding a Markdown table parser again would reverse that later decision.
|
||||
|
||||
## Shared fixtures
|
||||
|
||||
Shared test support uses Gradle `java-test-fixtures`. Test fixtures are support code, not a sixth test
|
||||
category. Consumers declare fixture use explicitly.
|
||||
|
||||
## Lifecycle
|
||||
|
||||
- leaf `check`: local leaf checks and ordinary tests; no infrastructure-wide root traversal;
|
||||
- `integrationCheck`: integration-category strict lanes;
|
||||
- `systemTestCheck`: system-category strict lanes;
|
||||
- `architectureCheck`: architecture-category lanes plus repository architecture checks;
|
||||
- performance-category lanes are explicit/scheduled and are not silently attached to local `check`;
|
||||
- `qualificationCheck`: a gate, currently full system composition plus auxiliary-source style checks;
|
||||
- `ci`: leaf checks plus repository gates and qualification;
|
||||
- `releaseCheck`: `ci` plus release-only provenance/archive/public-path checks.
|
||||
|
||||
## Verified result
|
||||
|
||||
- Documented categories exactly match `TestLaneCategory.values()`: TEST, INTEGRATION, SYSTEM, ARCHITECTURE, PERFORMANCE.
|
||||
- No stale unit/slice/contract/qualification rows remain in the official category table.
|
||||
- Qualification is documented as a gate, not a category.
|
||||
- The removed `verifyTestSourceSetRegistry` is explicitly not restored.
|
||||
- Shared-fixture guidance distinguishes cross-source-set/cross-leaf publication from source-set-local helpers.
|
||||
- `StrictTestLaneConventionTest`: PASS.
|
||||
- Gradle `help` configuration smoke: PASS.
|
||||
- `git diff --check`: PASS.
|
||||
@@ -0,0 +1,50 @@
|
||||
# Build / Release Review Remediation Design
|
||||
|
||||
## Source
|
||||
|
||||
`docs/reviews/2026-09-18-techlead-review/13-build-dependency-ci.md`
|
||||
|
||||
This wave addresses C1, C2 and the same-task-shape portion of H6 after revalidating them against the
|
||||
2026-09-19 working tree.
|
||||
|
||||
## Problem
|
||||
|
||||
1. Architecture tests live in `app-bootstrap/src/architectureTest`, but `release.yml`,
|
||||
`fileserver-pr.yml` and the root `CLAUDE.md` still invoke them through `:app-bootstrap:test`.
|
||||
2. `settings.gradle` includes both `build-logic` and `build-tools`, while the Docker dependency-cache
|
||||
stage copies only `build-logic` before its first Gradle invocation.
|
||||
|
||||
Both are composition defects: individual components exist, but the shipped build/release path does
|
||||
not assemble them correctly.
|
||||
|
||||
## Design
|
||||
|
||||
### Architecture workflow contract
|
||||
|
||||
Any workflow command that selects `dev.caskeleton.bootstrap.architecture.*` must execute
|
||||
`:app-bootstrap:architectureTest`, never `:app-bootstrap:test`.
|
||||
|
||||
The developer documentation must show the same task.
|
||||
|
||||
### Docker included-build contract
|
||||
|
||||
`DeveloperExperienceContractTest` will derive included-build paths from `src/settings.gradle`.
|
||||
Before the Dockerfile's first `./gradlew`, each `includeBuild('<path>')` must have a complete
|
||||
`COPY <path>/ ./<path>/` instruction.
|
||||
|
||||
This is deliberately derived rather than hard-coded to `build-tools`: adding a third included build
|
||||
must fail the contract until the Docker build context stages it.
|
||||
|
||||
## Non-goals
|
||||
|
||||
- No CI topology redesign in this wave.
|
||||
- No releaseCheck/compose-lane changes yet.
|
||||
- No dependency policy changes.
|
||||
- No Git staging/commit operations.
|
||||
|
||||
## Verification
|
||||
|
||||
- focused RED/GREEN `DeveloperExperienceContractTest`;
|
||||
- `:app-bootstrap:test --tests DeveloperExperienceContractTest`;
|
||||
- workflow grep proving no architecture package is invoked through `:app-bootstrap:test`;
|
||||
- `git diff --check`.
|
||||
@@ -0,0 +1,54 @@
|
||||
# Capability Dependency Validation Context
|
||||
|
||||
## Goal
|
||||
|
||||
Close the remaining BOOT-004 exception after StartupValidationContext was introduced. Capability
|
||||
dependency validation still accumulates with a raw ArrayList and two startup entry points repeat the
|
||||
same list-empty-check / message-join / StartupFailures path.
|
||||
|
||||
## Design
|
||||
|
||||
CapabilityDependencyValidator becomes the single owner of this validation flow.
|
||||
|
||||
- dependency rules accumulate into StartupValidationContext opened for ADAPTER_ENABLEMENT;
|
||||
- violations(Environment) remains as a read-only diagnostic/test API and returns the context's copy;
|
||||
- requireSatisfied(Environment) evaluates the same rules and calls failIfViolated once;
|
||||
- CapabilityDependencyEnvironmentValidator and CapabilityDependencyStartupCheck both delegate to
|
||||
requireSatisfied and contain no accumulation or failure formatting.
|
||||
|
||||
GraphQL deployment-mode validation may continue to return a small list from its pure sub-rule;
|
||||
the parent collector absorbs it through rejectAll. The startup phase and typed exception are selected
|
||||
only by StartupValidationContext.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- all existing dependency rule text remains unchanged;
|
||||
- all-off remains valid;
|
||||
- multiple dependency failures are still reported together;
|
||||
- the failure remains REQUIRED_ADAPTER_DISABLED / ADAPTER_ENABLEMENT;
|
||||
- both early EnvironmentPostProcessor startup and ApplicationContextRunner fallback paths keep the
|
||||
same rule set.
|
||||
|
||||
## Final BOOT-004 residual
|
||||
|
||||
The repository-wide residual scan found one additional startup guard still matching the original
|
||||
BOOT-004 pattern: SecretSourceValidator maintained separate offenders and missing ArrayLists and
|
||||
threw after each method. That meant a production deployment with both a local/dev sentinel and a
|
||||
missing required secret reported only the sentinel on the first boot.
|
||||
|
||||
The closure uses one ENV_VALIDATION StartupValidationContext for the whole prod secret contract.
|
||||
Sentinel property names are de-duplicated with a LinkedHashSet because the same key can be enumerated
|
||||
by multiple property sources; that set is discovery/deduplication data, not a failure accumulator.
|
||||
Each discovered sentinel and missing required secret is rejected into the shared validation context,
|
||||
then the validator fails once at the end of the phase.
|
||||
|
||||
## Verified result
|
||||
|
||||
- CapabilityDependencyValidator accumulates through StartupValidationContext and both startup entry points delegate to requireSatisfied;
|
||||
- SecretSourceValidator uses one ENV_VALIDATION context for both sentinel and missing-secret violations;
|
||||
- a focused test proves sentinel and missing required secret are reported in one startup failure;
|
||||
- production raw startup validation ArrayLists with the historical violation variable shapes are 0; the only such accumulator is StartupValidationContext itself;
|
||||
- PostgreSqlTransportSecurityValidator urlSslModes is parsing data, not a startup failure accumulator;
|
||||
- DataSourceRequirement reasons is management/activation-report data and does not throw;
|
||||
- app-bootstrap Spotless, full TEST and full ARCHITECTURE regressions: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,76 @@
|
||||
# Env Contract Verifier Truth Surface
|
||||
|
||||
## Goal
|
||||
|
||||
Close tech-lead H1 and H2 by making verifyEnvKeys distinguish declaration from consumption and by
|
||||
covering the configuration files Spring actually ships.
|
||||
|
||||
## H1: declaration is not consumption
|
||||
|
||||
.env.example is the operator-facing declaration surface. A key being listed there proves that an
|
||||
adopter can discover the key; it does not prove that runtime code reads it.
|
||||
|
||||
Consumer evidence is therefore limited to:
|
||||
|
||||
- APP references in the configuration resources being verified;
|
||||
- APP references in production main sources/configuration resources elsewhere in the repository;
|
||||
- typed configuration properties, which are already handled separately through metadata and do not
|
||||
enter the untyped orphan set.
|
||||
|
||||
The envAppKeys set must not be merged into consumed.
|
||||
|
||||
The existing ownership policy remains:
|
||||
|
||||
- orphaned rows under enforced Redis prefixes fail the task;
|
||||
- orphaned rows outside that owned surface are emitted as warnings until their owning concern
|
||||
removes, wires, or explicitly deprecates them;
|
||||
- deprecated_orphaned remains an explicit transition state, never an automatic escape hatch.
|
||||
|
||||
Sample-portfolio main configuration is valid consumer evidence for repository-level env rows. It is
|
||||
not part of the app-bootstrap shipped-configuration validation surface.
|
||||
|
||||
## H2: all shipped app-bootstrap configuration is verified
|
||||
|
||||
verifyEnvKeys must scan a ConfigurableFileCollection instead of one application.yml file.
|
||||
|
||||
The collection contains:
|
||||
|
||||
- application.yml;
|
||||
- application-local.yml / application-dev.yml / application-prod.yml when present;
|
||||
- every config/*.yml resource shipped by app-bootstrap.
|
||||
|
||||
Required-placeholder and APP-key registry checks operate over the union of these files.
|
||||
|
||||
The current application.yml import list and config directory are one-to-one (15 imported files,
|
||||
15 files). Existing contract tests continue to guard the import topology; verifyEnvKeys owns the
|
||||
environment-key contract across those resources.
|
||||
|
||||
## Consumer-source scan
|
||||
|
||||
The repository consumer scan includes main Java and main YAML resources and excludes generated
|
||||
build output. This lets a registered key used only by the reference sample count as genuinely used
|
||||
without pretending that sample configuration is part of app-bootstrap.
|
||||
|
||||
## Verification
|
||||
|
||||
Unit tests must prove:
|
||||
|
||||
1. an env + registry row with no runtime/config consumer is no longer hidden by .env.example;
|
||||
2. an enforced Redis orphan hard-fails;
|
||||
3. a reference that appears only in a secondary configuration file participates in registry and
|
||||
required-placeholder checks;
|
||||
4. the task exposes configurationFiles as ConfigurableFileCollection.
|
||||
|
||||
Repository verification must then run verifyEnvKeys against the real tree and report any newly
|
||||
visible orphan rows instead of silently treating .env.example as a consumer.
|
||||
|
||||
## Verified result
|
||||
|
||||
- build-tools full test: PASS (63 tests);
|
||||
- .env.example no longer contributes to consumer evidence;
|
||||
- verifyEnvKeys scans application*.yml plus all config/*.yml and repository main Java/YAML consumer sources;
|
||||
- the repaired verifier immediately exposed two real profile-config drift keys, APP_FLYWAY_ENABLED and APP_PERSISTENCE_VENDOR; both are real runtime/developer knobs and are now registered in .env.example and env-keys.yaml;
|
||||
- H1 then exposed seven unconsumed rows. APP_MESSAGING_PRODUCER_ID was a real missing wiring and is now bound in config/messaging.yml; six rows with no production/sample/config/test consumer were removed from .env.example and the registry instead of being falsely deprecated;
|
||||
- final verifyEnvKeys: PASS with 339 env keys, 6 required placeholders, 229 application APP references, 61 typed properties and no orphan warning;
|
||||
- focused messaging/JPA/profile configuration regressions: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,114 @@
|
||||
# Fileserver Composition Decomposition
|
||||
|
||||
## Goal
|
||||
|
||||
Close the remaining BOOT-007 drift in app-bootstrap. Redis already follows the documented
|
||||
composition threshold, but Fileserver still has three configurations above the repository rule:
|
||||
|
||||
- FileserverPlatformAutoConfiguration: 24 @Bean methods;
|
||||
- FileserverStorageConfiguration: 18 @Bean methods;
|
||||
- FileserverServiceConfiguration: 12 @Bean methods.
|
||||
|
||||
The refactor changes composition ownership only. Bean identities, types, conditions, master-switch
|
||||
semantics and application behavior remain unchanged.
|
||||
|
||||
## Master-switch invariant
|
||||
|
||||
FileserverPlatformAutoConfiguration remains the only auto-configuration entry point and the only
|
||||
place carrying the app.fileserver-platform.enabled master condition.
|
||||
|
||||
All newly extracted classes are package-private @Configuration(proxyBeanMethods = false) children
|
||||
reachable only through imports below that gated root. None is component-scanned or registered in
|
||||
AutoConfiguration.imports.
|
||||
|
||||
FileserverStorageConfiguration and FileserverServiceConfiguration remain as zero-bean package-private
|
||||
aggregators so existing composition references remain stable while their internal concerns split.
|
||||
|
||||
## Platform split
|
||||
|
||||
FileserverPlatformAutoConfiguration retains only the strictly gated settings binder and imports:
|
||||
|
||||
- FileserverCorePolicyConfiguration
|
||||
- FileserverWebProperties
|
||||
- TransferExecutorProperties
|
||||
- UploadPolicy
|
||||
- DownloadPolicy
|
||||
- HttpRangeResolver
|
||||
- ConditionalRequestEvaluator
|
||||
- ContentDispositionFactory
|
||||
- FileserverWebAssemblyConfiguration
|
||||
- request context/problem factories
|
||||
- raw/multipart request mappers
|
||||
- MVC conditional/download response helpers
|
||||
- zero-copy eligibility
|
||||
- FileserverNginxConfiguration
|
||||
- delegation properties
|
||||
- internal URI mapper
|
||||
- download strategy
|
||||
- FileserverProtocolConfiguration
|
||||
- TUS properties/parser/checksum verifier under the existing TUS condition
|
||||
- draft12 properties under the existing draft condition
|
||||
- FileserverObservabilityConfiguration
|
||||
- keyed SafeFileFingerprint under the existing consumer condition
|
||||
- Micrometer FileserverMetricsPort under the existing metrics condition
|
||||
|
||||
## Storage split
|
||||
|
||||
FileserverStorageConfiguration becomes an aggregator importing:
|
||||
|
||||
- FileserverLocalStorageCoreConfiguration
|
||||
- local storage properties
|
||||
- schema activation
|
||||
- local probe
|
||||
- blocking content store
|
||||
- FileserverStorageGatewayConfiguration
|
||||
- upload, upload-content, download, copy, cleanup and zero-copy gateways
|
||||
- FileserverStorageOperationsConfiguration
|
||||
- storage health
|
||||
- orphan scan
|
||||
- usage probe
|
||||
- reconciliation probe
|
||||
- FileserverVerificationConfiguration
|
||||
- filename policy
|
||||
- file state machine
|
||||
- verification content reader
|
||||
- verification service
|
||||
|
||||
## Service split
|
||||
|
||||
FileserverServiceConfiguration becomes an aggregator importing:
|
||||
|
||||
- FileserverUploadServiceConfiguration
|
||||
- identifier factory
|
||||
- transfer admission properties/controller
|
||||
- upload/finalize/single-shot services
|
||||
- writer lease coordinator
|
||||
- FileserverDownloadLifecycleConfiguration
|
||||
- download application service
|
||||
- lifecycle service
|
||||
- FileserverMaintenanceServiceConfiguration
|
||||
- cleanup service
|
||||
- reconciliation service
|
||||
- admin service under the existing admin condition
|
||||
|
||||
## Compatibility gates
|
||||
|
||||
- master switch off creates none of the child graph;
|
||||
- master switch on preserves existing bean names/types;
|
||||
- TUS, draft12, metrics/fingerprint and admin sub-feature conditions remain unchanged;
|
||||
- existing FileserverPlatformAutoConfiguration tests continue to compose through the root;
|
||||
- integration composition continues to import only FileserverPlatformAutoConfiguration;
|
||||
- no new public type is introduced;
|
||||
- no configuration in this slice exceeds the documented roughly-eight-bean threshold.
|
||||
|
||||
## Verified result
|
||||
|
||||
- FileserverPlatformAutoConfiguration now declares 1 bean and remains the only Fileserver @AutoConfiguration entry point;
|
||||
- storage and service legacy configuration names remain zero-bean aggregators;
|
||||
- extracted concern configurations are package-private and absent from AutoConfiguration.imports;
|
||||
- every Fileserver production configuration declares at most 7 @Bean methods;
|
||||
- FileserverCompositionArchitectureTest permanently enforces the <= 8 rule and is pinned by ArchRuleDiscoveryContractTest;
|
||||
- focused Fileserver auto-configuration/runtime tests: PASS;
|
||||
- FileserverCompositionIntegrationTest against real PostgreSQL and filesystem: PASS with process-local TESTCONTAINERS_RYUK_DISABLED=true on this remote host;
|
||||
- app-bootstrap Spotless, full TEST, full ARCHITECTURE and full SYSTEM regressions: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,45 @@
|
||||
# Fileserver Verification Read Failure Remediation
|
||||
|
||||
## Source
|
||||
|
||||
`docs/reviews/2026-09-18-techlead-review/09-notification-fileserver.md` Critical C2.
|
||||
|
||||
## Goal
|
||||
|
||||
Make content-verification reads fail closed as RETRY when storage cannot be read, while preserving
|
||||
the legitimate meaning of an actually empty file.
|
||||
|
||||
## Current defect
|
||||
|
||||
`LocalVerificationContentReader` catches storage/read failures and returns an empty byte array.
|
||||
With the shipped `require-media-type-verdict=false`, both MediaTypeVerifier and
|
||||
ScriptableContentPolicy can interpret that synthetic empty prefix as ACCEPT.
|
||||
|
||||
## Design
|
||||
|
||||
- A successful read of a zero-byte object still returns `byte[0]`.
|
||||
- A missing staging object or storage failure is not content and must not be represented as bytes.
|
||||
- `LocalVerificationContentReader` therefore lets runtime storage failures propagate.
|
||||
- Checked IOException while reading a published channel is wrapped as `UncheckedIOException`.
|
||||
- `VerificationCoordinator.runBounded` already maps RuntimeException to
|
||||
`VerificationResult.retry("VERIFIER_UNAVAILABLE")`; that existing boundary remains the failure
|
||||
classifier.
|
||||
- No global default is changed: `require-media-type-verdict=false` may still default an actually
|
||||
readable but unknown media type to application/octet-stream.
|
||||
|
||||
## Verification
|
||||
|
||||
- direct production-reader test distinguishes empty object from missing object;
|
||||
- coordinator test uses the production reader with `requireVerdict=false` and proves missing content
|
||||
returns RETRY, not ACCEPT;
|
||||
- existing verification chain tests remain green;
|
||||
- full fileserver check passes.
|
||||
|
||||
## Verified result
|
||||
|
||||
- real zero-byte staging content still returns an empty prefix;
|
||||
- missing staging content now raises FileNotFoundException instead of synthetic empty content;
|
||||
- published-channel IOException is promoted as UncheckedIOException;
|
||||
- VerificationCoordinator maps read failures to VERIFIER_UNAVAILABLE / RETRY;
|
||||
- shipped require-media-type-verdict=false is covered with the production reader and no longer accepts missing content;
|
||||
- focused verification tests and full fileserver check: PASS.
|
||||
@@ -0,0 +1,81 @@
|
||||
# Mongo Client Runtime Review Remediation
|
||||
|
||||
## Source
|
||||
|
||||
`docs/reviews/2026-09-18-techlead-review/06-persistence-mongo.md` Critical C1/C2.
|
||||
|
||||
## Goal
|
||||
|
||||
Prevent Mongo enablement from silently falling back to the driver's localhost/test defaults and make
|
||||
the typed Mongo platform profile actually configure the `MongoClientSettings` used by Spring Boot.
|
||||
|
||||
## Current architecture constraint
|
||||
|
||||
The current tree supports two legitimate connection-source shapes:
|
||||
|
||||
1. Spring Boot's standard `spring.mongodb.uri` / `SPRING_MONGODB_URI` path.
|
||||
2. A typed platform profile whose `uri-secret` is resolved through a deployment-supplied
|
||||
`MongoCredentialResolver`.
|
||||
|
||||
The original review's unconditional `SPRING_MONGODB_URI` requirement predates the typed secret
|
||||
reference path. Requiring a clear-text URI environment variable even when a profile intentionally
|
||||
uses `secret://...` would regress that security boundary.
|
||||
|
||||
## C1 design — fail closed on missing connection source
|
||||
|
||||
When `ca-skeleton.persistence-mongo.enabled=true`, startup already requires one non-blank
|
||||
`ca-skeleton.persistence-mongo.active-profile`. It will additionally require at least one of:
|
||||
|
||||
- non-blank `spring.mongodb.uri`; or
|
||||
- non-blank `ca-skeleton.persistence-mongo.platform.profiles.<active-profile>.uri-secret`.
|
||||
|
||||
If neither exists, startup fails before Boot can use MongoDB's default localhost/test connection.
|
||||
|
||||
`SPRING_MONGODB_URI` is added to `.env.example` and the env registry as the public standard-URI
|
||||
option. Documentation is corrected to Spring Boot 4's `spring.mongodb.*` namespace. The namespace
|
||||
contract test is expanded to Markdown so operator docs cannot drift back to `spring.data.mongodb.*`.
|
||||
|
||||
## C2 design — typed profile reaches Boot's driver builder
|
||||
|
||||
`MongoClientSettingsFactory` remains the single policy-to-driver mapping. It gains a builder
|
||||
customization entrypoint and both `create()` and Boot wiring use the same private apply method.
|
||||
|
||||
`MongoPlatformAutoConfiguration` contributes a late `MongoClientSettingsBuilderCustomizer` only
|
||||
when a `MongoCredentialResolver` bean exists. If no typed profiles are configured it is a no-op;
|
||||
otherwise it resolves only the selected active profile and applies connection string, UUID
|
||||
representation, socket/server-selection timeouts, pool bounds, TLS and Stable API to the Boot
|
||||
builder.
|
||||
|
||||
The customizer runs at lowest precedence so the typed profile intentionally overrides Boot's
|
||||
generic Mongo settings while observability customizers can still add listeners without changing
|
||||
connection policy.
|
||||
|
||||
## Non-goals
|
||||
|
||||
- Do not ship a secret-store implementation in this template.
|
||||
- Do not make `SPRING_MONGODB_URI` mandatory when a typed `uri-secret` profile is present.
|
||||
- Do not create multiple clients or resolve non-selected profile secrets.
|
||||
- Do not change Mongo's master switch or active-profile contract in this wave.
|
||||
|
||||
## Verification
|
||||
|
||||
- RED/GREEN startup dependency tests for missing/standard/profile connection source;
|
||||
- RED/GREEN Boot customizer test asserting built driver settings;
|
||||
- existing `MongoClientSettingsFactoryTest` remains green;
|
||||
- `MongoNamespaceContractTest` catches stale Markdown namespace;
|
||||
- `:adapter:outbound:persistence-mongo:check`;
|
||||
- `:app-bootstrap:verifyEnvKeys` and focused `CapabilityDependencyValidatorTest`;
|
||||
- `git diff --check`.
|
||||
|
||||
## Verified result
|
||||
|
||||
- Mongo enablement now refuses a missing connection source instead of allowing the driver localhost/test fallback;
|
||||
- standard spring.mongodb.uri and the selected typed profile uri-secret are both supported connection sources;
|
||||
- MongoClientSettingsFactory create/customize share one policy-to-driver apply path;
|
||||
- MongoProfileClientSettingsAutoConfiguration is a package-private client-side Boot entry and applies the typed profile to Boot's real MongoClientSettings.Builder;
|
||||
- no autoconfigure -> client cycle was introduced; MongoModuleBoundaryTest DAG remains green;
|
||||
- operation timeout, socket/server-selection timeouts, pool bounds, TLS and Stable API are asserted on built driver settings;
|
||||
- SPRING_MONGODB_URI is registered as optional sensitive-config and operator docs use Spring Boot 4 spring.mongodb.*;
|
||||
- MongoNamespaceContractTest now covers README/CLAUDE namespace drift;
|
||||
- persistence-mongo full check and verifyMongoApiSurface: PASS;
|
||||
- app-bootstrap dependency-validator/registry tests and verifyEnvKeys: PASS.
|
||||
@@ -0,0 +1,82 @@
|
||||
# Multi-instance Runtime Contract
|
||||
|
||||
## Goal
|
||||
|
||||
Close tech-lead finding C2 without inventing placeholder coordination beans.
|
||||
|
||||
ca-skeleton.runtime.multi-instance-enabled must describe a runtime capability that the shipped
|
||||
composition can actually provide.
|
||||
|
||||
## Current defect
|
||||
|
||||
StartupSafetyValidator treats multi-instance mode as a promise that five named beans exist:
|
||||
|
||||
- distributedLockProvider
|
||||
- cacheStampedeProtection
|
||||
- outboxLeaderElection
|
||||
- distributedRateLimiter
|
||||
- migrationStartupRunner
|
||||
|
||||
Two names have no production definition at all. The unit test hides that by registering five plain
|
||||
Object beans, and the shipped distributed-lock system test had to register unrelated fake siblings
|
||||
just to prove the real JDBC lock composition.
|
||||
|
||||
The list also conflates unrelated concerns:
|
||||
|
||||
- cache refresh coordination is explicitly optional efficiency, not a correctness lock;
|
||||
- edge rate limiting has its own transport/provider activation contract;
|
||||
- outbox owns its own SKIP LOCKED coordination when the outbox capability is enabled;
|
||||
- migration startup is not an instance-coordination provider.
|
||||
|
||||
## Canonical meaning
|
||||
|
||||
multi-instance-enabled=true selects the cross-instance implementation of the application
|
||||
DistributedLockPort.
|
||||
|
||||
Therefore the runtime contract is:
|
||||
|
||||
1. capability dependency validation requires JPA/relational persistence;
|
||||
2. persistence-jpa creates jdbcDistributedLock;
|
||||
3. bootstrap creates the primary distributedLockProvider decorator;
|
||||
4. StartupSafetyValidator verifies that the shipped distributed-lock provider exists and is a
|
||||
DistributedLockPort.
|
||||
|
||||
No other capability is implicitly enabled by this switch.
|
||||
|
||||
Capability-specific distributed guarantees remain capability-specific:
|
||||
|
||||
- Redis edge rate limiting is required only when edge rate limiting is enabled and its provider is
|
||||
selected;
|
||||
- cache refresh coordination remains disabled unless a real CacheRefreshCoordinationPort
|
||||
implementation is explicitly composed in a future slice;
|
||||
- outbox coordination exists only with the outbox capability;
|
||||
- migration startup follows the migration setting.
|
||||
|
||||
## Fail-closed behavior
|
||||
|
||||
When multi-instance mode is enabled but the distributed lock provider is absent or has the wrong
|
||||
type, startup fails through the existing ADAPTER_ENABLEMENT / exit-72 path.
|
||||
|
||||
The validator does not accept arbitrary bean names as evidence for unrelated capabilities.
|
||||
|
||||
## Verification
|
||||
|
||||
- unit: missing/wrong-type distributedLockProvider fails; correct typed provider passes;
|
||||
- system: real shipped H2/JPA composition starts with multi-instance enabled without any fake
|
||||
cache/rate-limit/outbox coordination beans, and exposes both jdbcDistributedLock and the metered
|
||||
distributedLockProvider;
|
||||
- existing JPA-off dependency failure remains;
|
||||
- app-bootstrap unit/system/architecture regressions stay green.
|
||||
|
||||
## Verified result
|
||||
|
||||
- the shipped system proof first failed exactly because the stale five-bean validator still required nonexistent sibling capabilities;
|
||||
- StartupSafetyValidator now validates only the real distributedLockProvider contract and requires the bean to implement DistributedLockPort;
|
||||
- name-only Object placeholders fail closed;
|
||||
- the fake five-bean unit fixture is removed;
|
||||
- the shipped H2/JPA composition starts with multi-instance mode enabled without fake cache, rate-limit, outbox, or migration siblings;
|
||||
- CapabilityDependencyValidator still requires JPA when multi-instance mode is enabled;
|
||||
- persistence-jpa distributed-lock tests: PASS;
|
||||
- app-bootstrap Spotless, full test, full systemTest and architectureTest: PASS;
|
||||
- stale phantom-bean contract scan: 0;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,59 @@
|
||||
# Prod Secret Consumer Alignment
|
||||
|
||||
## Goal
|
||||
|
||||
Close tech-lead H3: production startup must require only secret keys that the shipped runtime
|
||||
actually consumes.
|
||||
|
||||
## Defect
|
||||
|
||||
SecretSourceValidator.REQUIRED_PROD_SECRETS includes three keys with no runtime consumer:
|
||||
|
||||
- APP_SECURITY_JWT_SIGNING_KEY
|
||||
- APP_SECURITY_OAUTH_CLIENT_SECRET
|
||||
- APP_EXTERNAL_API_KEY
|
||||
|
||||
The application is a JWT resource server and verifies tokens through issuer/JWKS discovery; it does
|
||||
not sign JWTs. No shipped OAuth client or generic external API adapter consumes the other two keys.
|
||||
|
||||
Requiring unused credentials inflates the deployment secret surface and allows smoke fixtures to
|
||||
hide the mismatch by injecting random values that have no effect.
|
||||
|
||||
## Decision
|
||||
|
||||
Remove all three unused keys from the unconditional prod-secret contract.
|
||||
|
||||
Alignment must happen in every contract surface:
|
||||
|
||||
- SecretSourceValidator.REQUIRED_PROD_SECRETS;
|
||||
- docs/registries/secrets-classification.yaml;
|
||||
- APP_SECURITY_JWT_SIGNING_KEY in docs/registries/env-keys.yaml and .env.example;
|
||||
- compose runtime smoke generated-secret injection;
|
||||
- SecretSourceValidator tests.
|
||||
|
||||
No replacement consumer is invented.
|
||||
|
||||
The generic sentinel guard remains: any environment property whose value begins with the local-dev
|
||||
sentinel prefix is still forbidden in prod, independent of whether the key is in the required-secret
|
||||
list.
|
||||
|
||||
## Verification
|
||||
|
||||
- the three keys have zero non-review references in the repository;
|
||||
- secret classification registry remains exactly aligned with REQUIRED_PROD_SECRETS;
|
||||
- prod startup succeeds without the three unused keys when actual required secrets are present;
|
||||
- missing real required material still fails closed;
|
||||
- verifyEnvKeys remains green.
|
||||
|
||||
## Verified result
|
||||
|
||||
- APP_SECURITY_JWT_SIGNING_KEY, APP_SECURITY_OAUTH_CLIENT_SECRET and APP_EXTERNAL_API_KEY were removed from the unconditional production secret contract because the shipped runtime has no consumer for them;
|
||||
- APP_SECURITY_JWT_SIGNING_KEY was removed from .env.example and env-keys.yaml;
|
||||
- all three were removed from secrets-classification.yaml;
|
||||
- compose runtime smoke no longer generates dummy values for those keys;
|
||||
- the prod sentinel test now exercises the real APP_DATASOURCE_PASSWORD requirement;
|
||||
- SecretSourceValidatorTest and SecretsClassificationRegistryTest: PASS;
|
||||
- verifyEnvKeys: PASS with no orphan warning;
|
||||
- smoke script syntax: PASS;
|
||||
- app-bootstrap Spotless, full test and architectureTest: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,58 @@
|
||||
# Runtime Profile Access Boundary
|
||||
|
||||
## Goal
|
||||
|
||||
Finish the remaining BOOT-002 requirement: production bootstrap code must not read Spring active
|
||||
profiles ad hoc after the runtime vocabulary has already been centralized in shared-contract
|
||||
RuntimeEnvironment.
|
||||
|
||||
## Boundary
|
||||
|
||||
shared-contract RuntimeEnvironment remains framework-free and owns only vocabulary/semantics:
|
||||
|
||||
- local
|
||||
- dev
|
||||
- prod
|
||||
- profile -> RuntimeEnvironment resolution
|
||||
- production/test interpretation
|
||||
|
||||
app-bootstrap owns one Spring-aware bridge:
|
||||
|
||||
- RuntimeProfileSnapshot.from(Environment)
|
||||
- immutable copy of active profile names
|
||||
- delegation to RuntimeEnvironment for environment resolution and production/test interpretation
|
||||
|
||||
No other app-bootstrap production class calls Environment#getActiveProfiles directly.
|
||||
|
||||
## Why a bootstrap bridge instead of changing RuntimeEnvironment
|
||||
|
||||
shared-contract is deliberately Java-stdlib-only and is also consumed by non-Spring adapter leaves.
|
||||
Making RuntimeEnvironment accept Spring Environment would reverse that boundary. The bridge keeps
|
||||
Spring extraction in the composition root while preserving one vocabulary/decision implementation.
|
||||
|
||||
## Compatibility
|
||||
|
||||
- active profile order is preserved;
|
||||
- supplementary profiles remain visible;
|
||||
- profileless contexts remain empty;
|
||||
- production still means exactly the RuntimeEnvironment.PROD vocabulary;
|
||||
- test remains a test-only profile, not a deployable RuntimeEnvironment;
|
||||
- logging and management surfaces that expose active profiles retain their current string behavior.
|
||||
|
||||
## Enforcement
|
||||
|
||||
Add an ArchUnit rule over app-bootstrap production classes:
|
||||
|
||||
- RuntimeProfileSnapshot is the only class allowed to call Environment#getActiveProfiles;
|
||||
- new direct callers fail architectureTest.
|
||||
|
||||
|
||||
## Verified result
|
||||
|
||||
- app-bootstrap production calls Environment#getActiveProfiles exactly once, inside RuntimeProfileSnapshot;
|
||||
- RuntimeProfileSnapshot focused unit tests: PASS;
|
||||
- RuntimeProfileAccessArchitectureTest: PASS;
|
||||
- ArchRuleDiscoveryContractTest includes and discovers the new rule: PASS;
|
||||
- shared-contract check, including RuntimeEnvironment tests: PASS;
|
||||
- app-bootstrap Spotless, full test and full architectureTest: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,43 @@
|
||||
# Startup Order Contract
|
||||
|
||||
## Goal
|
||||
|
||||
Close BOOT-005 with an executable contract. StartupOrder already centralizes the six
|
||||
EnvironmentPostProcessor positions, but no test currently proves that every spring.factories
|
||||
processor participates in that order or that the intended bands remain strict.
|
||||
|
||||
## Contract
|
||||
|
||||
The six shipped EnvironmentPostProcessors must all implement Ordered and expose the centralized
|
||||
StartupOrder value assigned to their role.
|
||||
|
||||
Readiness contribution runs immediately after ConfigData:
|
||||
|
||||
- READINESS_REDIS = ConfigDataEnvironmentPostProcessor.ORDER + 1
|
||||
- READINESS_DATABASE = ConfigDataEnvironmentPostProcessor.ORDER + 2
|
||||
- Redis precedes database so both append to the readiness group deterministically.
|
||||
|
||||
Fail-closed/defaulting runs at the low-precedence end:
|
||||
|
||||
- MASTER_SWITCH_NORMALISATION
|
||||
- RUNTIME_ENVIRONMENT_PROFILE
|
||||
- CAPABILITY_DEPENDENCY
|
||||
- TRACING_SAMPLING
|
||||
|
||||
and these values are strictly increasing in that order.
|
||||
|
||||
The test reads META-INF/spring.factories rather than keeping a second list of registered processor
|
||||
class names. A newly registered processor therefore enters the contract automatically and fails if
|
||||
it does not implement Ordered.
|
||||
|
||||
The test also pins the expected order for each currently shipped processor so an implementation
|
||||
cannot silently stop using the centralized StartupOrder constants.
|
||||
|
||||
## Verified result
|
||||
|
||||
- StartupOrderContractTest reads app-bootstrap META-INF/spring.factories and proves every registered EnvironmentPostProcessor implements Ordered;
|
||||
- the six shipped processors are pinned to their StartupOrder values;
|
||||
- readiness order is ConfigData+1 then ConfigData+2;
|
||||
- master-switch normalization < runtime environment validation < capability dependency validation < tracing defaulting;
|
||||
- app-bootstrap Spotless, full TEST and full ARCHITECTURE regressions: PASS;
|
||||
- git diff --check: PASS.
|
||||
@@ -0,0 +1,37 @@
|
||||
# Test Support Ownership Closure
|
||||
|
||||
## Goal
|
||||
|
||||
Close the remaining BOOT-015 drift after the repository standardized shared test support on Gradle
|
||||
java-test-fixtures.
|
||||
|
||||
## Current repository rule
|
||||
|
||||
- fixtures shared across leaves or source sets use src/testFixtures/java and explicit fixture classpath edges;
|
||||
- helpers used only inside one source set stay in that source set;
|
||||
- custom testkit publisher/source-set conventions are retired and must not be reintroduced;
|
||||
- architecture taxonomy positive-control fixtures may intentionally live in the source set whose
|
||||
classification they are testing.
|
||||
|
||||
## Remaining app-bootstrap drift
|
||||
|
||||
AdapterActivationInventory is currently declared in src/test but consumed only by two systemTest
|
||||
classes. It is not a TEST helper and no TEST class references it. Publishing it as testFixtures
|
||||
would be unnecessary because it has exactly one consuming lane in the same project.
|
||||
|
||||
Move it into src/systemTest under the same package. This makes ownership match execution category
|
||||
without creating a fixture artifact.
|
||||
|
||||
RepositoryContractResources and FileserverAssemblyFixture remain in src/test because their consumers
|
||||
are in the same TEST source set. PostgreSqlTestContainer remains in integrationTest because its only
|
||||
consumer is integrationTest. TestcontainersUsingFixture remains an intentional taxonomy positive
|
||||
control whose location is part of the architecture test input.
|
||||
|
||||
## Verified result
|
||||
|
||||
- AdapterActivationInventory now lives in systemTest beside its only two consumers;
|
||||
- ordinary TEST consumers of AdapterActivationInventory: 0;
|
||||
- active custom testkit publisher/source-set declarations in Gradle: 0;
|
||||
- the two system consumers pass in the SYSTEM lane;
|
||||
- app-bootstrap Spotless, full TEST and full ARCHITECTURE regressions: PASS;
|
||||
- git diff --check: PASS.
|
||||
Reference in New Issue
Block a user