diff --git a/src/adapter/inbound/web-fileserver/src/main/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminController.java b/src/adapter/inbound/web-fileserver/src/main/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminController.java index 9338f900..4cd3b340 100644 --- a/src/adapter/inbound/web-fileserver/src/main/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminController.java +++ b/src/adapter/inbound/web-fileserver/src/main/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminController.java @@ -113,7 +113,8 @@ public class FileserverAdminController { path = "/internal/fileserver/orphans:reconcile", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE) - public OrphanReconcileReport reconcileOrphans(@RequestBody OrphanReconcileHttpRequest request) { + public OrphanReconcileReport reconcileOrphans( + @Valid @RequestBody OrphanReconcileHttpRequest request) { return reconcileOrphans.handle(toCommand(request, contextFactory.current())); } diff --git a/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java b/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java new file mode 100644 index 00000000..af9ac0fb --- /dev/null +++ b/src/adapter/inbound/web-fileserver/src/test/java/dev/caskeleton/adapter/inbound/web/fileserver/admin/FileserverAdminControllerRequestBodyValidationTest.java @@ -0,0 +1,43 @@ +package dev.caskeleton.adapter.inbound.web.fileserver.admin; + +import static org.assertj.core.api.Assertions.assertThat; + +import jakarta.validation.Valid; +import java.lang.reflect.Method; +import java.lang.reflect.Parameter; +import java.util.ArrayList; +import java.util.List; +import org.junit.jupiter.api.Test; +import org.springframework.web.bind.annotation.RequestBody; + +/** + * W4 red team BE-INPUT-002 — every {@code @RequestBody} on the admin controller must also carry + * {@code @Valid}. + * + *

{@code reconcileOrphans} shipped a {@code @RequestBody} without {@code @Valid}, unlike every + * sibling handler (relocate/force-delete/…). Harmless today because {@code OrphanReconcileHttpRequest} + * declares no Bean Validation constraints — but the moment one is added (a {@code @Min} on the limit, + * a {@code @NotBlank} on the reason), it would be silently ignored, exactly the validation-bypass + * class this template otherwise guards against. This pins the convention for the whole admin plane so + * the gap cannot reopen. + */ +class FileserverAdminControllerRequestBodyValidationTest { + + @Test + void everyRequestBodyParameterAlsoCarriesValid() { + List offenders = new ArrayList<>(); + for (Method method : FileserverAdminController.class.getDeclaredMethods()) { + for (Parameter parameter : method.getParameters()) { + if (parameter.isAnnotationPresent(RequestBody.class) + && !parameter.isAnnotationPresent(Valid.class)) { + offenders.add(method.getName() + "(" + parameter.getType().getSimpleName() + ")"); + } + } + } + assertThat(offenders) + .as( + "admin @RequestBody handlers without @Valid would silently drop any Bean Validation " + + "constraint added to their DTO later (BE-INPUT-002)") + .isEmpty(); + } +}