fix!: 재리뷰가 찾은 결함과 색인에서 빠졌던 발견 5건을 고친다

문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가
Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다.
@SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히
prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고,
GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로
나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역
발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다.

방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를
먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이
기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록,
@SystemInvoked bean은 기동 실패, complete 단계 실패는
IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도
SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도
행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도
내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제
지표(redis.lane.*) 기준으로 고쳤다.

위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이
브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류
디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어
파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은
기동을 막는다. httpclient failure-injection lane의 main 단계 중복
실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다.

검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci
integrationCheck performanceCheck, :performanceCheck, :releaseCheck
(-PgitRevision), verify-compose-profile-contracts(18 lane) 통과.
첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event
id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다.

Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절
BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호
첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드
IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은
static·의존 없음이어야 한다.
This commit is contained in:
DongHyeonka
2026-11-03 23:29:35 +09:00
parent 7ef8d0b4cb
commit bbe944bd3c
406 changed files with 13493 additions and 1656 deletions
+54 -3
View File
@@ -1670,7 +1670,7 @@ env_keys:
required: false
reload_policy: restart-only
owner_branch: redis-production-capability-completion
validation: positive_duration_le_1h
validation: duration_gt_in_flight_retry_after_2s_le_1h
compatibility_impact: additive
required_test: redis-idempotency-contract:processing-lease-bounded
@@ -1806,6 +1806,24 @@ env_keys:
compatibility_impact: additive
required_test: redis-capability:cache-region-composition
- name: APP_CACHE_REDIS_MAXIMUM_SCRIPT_CONNECTIONS
# The cache's own script-lane connections. Separate from APP_REDIS_CAPACITY_MAXIMUM_SCRIPT_CONNECTIONS,
# which idempotency, rate limiting and leases share, so cache fills cannot starve them (review
# 2026-11-03 README section 4, RR-04-02).
property: app.capabilities.cache.maximum-script-connections
owner_module: adapter-outbound-cache-redis
type: integer
default: 4
allowed_values: null
classification: public-config
required: false
required_when: app.capabilities.cache.bindings.default=redis
reload_policy: restart-only
owner_branch: refactor/maturity-review-2026-11
validation: positive_integer
compatibility_impact: additive
required_test: redis-capability:cache-script-lane-separate-from-correctness
- name: APP_IDEMPOTENCY_REDIS_COMMAND_TIMEOUT
# The ceiling on one owner-safe transition.
type: duration
@@ -2000,7 +2018,7 @@ env_keys:
# secret://<acl-account>@<source>/<name> form as the application reference. Unset, scripts run
# as the application account and startup logs a warning saying so. The Compose Redis lanes use
# secret://ca-skeleton-application-advanced@environment/REDIS_LANE_ADVANCED_PASSWORD, a fixture
# account of infra/redis-sdk/acl/all-accounts.acl.
# account of infra/redis-sdk/acl/lane-fixture-accounts.acl.
property: app.redis.authentication.advanced-credential-reference
owner_module: adapter-outbound-cache-redis
type: string
@@ -2043,7 +2061,7 @@ env_keys:
# <name>. Without the account part the client authenticates as `default`, which a hardened
# Redis turns off. The Compose Redis lanes use
# secret://ca-skeleton-application@environment/REDIS_LANE_APPLICATION_PASSWORD, a fixture
# account of infra/redis-sdk/acl/all-accounts.acl.
# account of infra/redis-sdk/acl/lane-fixture-accounts.acl.
property: app.redis.authentication.credential-reference
owner_module: adapter-outbound-cache-redis
type: string
@@ -4043,6 +4061,39 @@ env_keys:
compatibility_impact: behavior-change
required_test: websocket-contract:canonical-property-namespace
- name: APP_OBJECTSTORAGE_ENABLED
# 2026-11-03 RR-06-07: the explicit off the Compose smoke wrapper sets for every lane that is
# not about object storage. It bound by relaxed binding and was in no registry, so the env
# contract could not tell it from an unread name. The module is on when present; absent from
# the build is the ordinary off state.
property: app.object-storage.enabled
owner_module: adapter-outbound-objectstorage
type: boolean
default: true
allowed_values: [true, false]
classification: public-config
required: false
reload_policy: restart-only
owner_branch: refactor/maturity-review-2026-11
validation: boolean
compatibility_impact: none
required_test: off-state-zero-side-effects-and-env-round-trip
- name: APP_GRPC_SERVER_ENABLED
# 2026-11-03 RR-06-07: the explicit off for the gRPC server the Compose lanes set (it replaced
# CASKELETON_GRPC_ENABLED, which nothing read). The module is on when present; absent from the
# build is the ordinary off state.
property: app.grpc.server.enabled
owner_module: adapter-inbound-grpc
type: boolean
default: true
allowed_values: [true, false]
classification: public-config
required: false
reload_policy: restart-only
owner_branch: refactor/maturity-review-2026-11
validation: boolean
compatibility_impact: none
required_test: off-state-zero-side-effects-and-env-round-trip
- name: APP_GRAPHQL_ENABLED
# 2026-09-25 capability packaging: the module is on when present (its own config yml maps
# this key with default true); false is the explicit off. Absent from the build is the
+20 -1
View File
@@ -401,6 +401,9 @@ errors:
# source: docs/web/http-contract.md §2 (2026-11-01 소유자 결정, 리뷰 02-01 대안 A) — 결과 불명. 같은 Idempotency-Key로 Retry-After 뒤 재전송. 새 키 금지.
# 2초 = 기본 processing lease(30s)보다 짧은 고정값. 이전 "client는 polling"(retryable=false)은 조회 엔드포인트가 없어 폐기.
# 값 하나: IdempotencyExecutor.IN_FLIGHT_RETRY_AFTER. processing-lease가 이 값 이하면 기동 실패(재리뷰 RR-02-05).
# behavior-change: retryable false→true는 web Envelope뿐 아니라 gRPC trailer error-retryable(status ABORTED)과
# GraphQL extension retryable에도 나간다(재리뷰 RR-02-06, GrpcStatusMapperTest·GraphQlWireErrorMapperTest가 고정).
- code: IDEMPOTENT_IN_FLIGHT
category: CONFLICT
http_status: 409
@@ -411,7 +414,7 @@ errors:
client_safe_message: "현재 상태에서는 요청을 처리할 수 없습니다."
log_level: INFO
runbook_link: null
compatibility_impact: none
compatibility_impact: behavior-change
required_test: contract-verification:idempotency
# source: feature-rate-limit-idempotency-contract L72 — "fingerprint mismatch (same key + different body) = 422 IDEMPOTENT_REQUEST_MISMATCH"
@@ -442,6 +445,22 @@ errors:
compatibility_impact: additive
required_test: contract-verification:idempotency
# source: 재리뷰 2026-11-03 README 4절 결정, RR-02-03 — action이 돈 뒤 complete 단계에서 저장소가 응답하지 않음.
# 실행 전 거부(IDEMPOTENCY_UNAVAILABLE)와 code로 구분한다. 결과 불명: 같은 키로 재전송하면 서버가 replay·in-flight·
# recovery-required로 판정한다. 새 키 금지. docs/web/http-contract.md §2.
- code: IDEMPOTENCY_COMPLETION_UNKNOWN
category: TRANSIENT_DEPENDENCY
http_status: 503
retryable: true
retry_after_seconds: null
owner_branch: feature-rate-limit-idempotency-contract
owner_layer: application
client_safe_message: "일시적인 오류입니다. 잠시 후 다시 시도해 주세요."
log_level: ERROR
runbook_link: "runbook://idempotency/unavailable"
compatibility_impact: additive
required_test: contract-verification:idempotency
# source: review-followup P15 (X2-P2-2a) — replay cannot decide whether an external effect happened
- code: IDEMPOTENCY_RECOVERY_REQUIRED
category: DATA_INTEGRITY
+116 -202
View File
@@ -349,8 +349,10 @@ metrics:
cardinality_limit: 50
- name: outcome
cardinality_limit: 5
# STALE: the relay's claim was taken over before its result could be written (V17 lease fence).
allowed_values: [PUBLISHED, FAILED, DEAD, IN_FLIGHT, STALE]
# The relay cycle outcomes (OutboxRelayResult.Outcome), not row statuses: IN_FLIGHT is a status
# and is never counted. STALE: the relay's claim was taken over before its result could be
# written (V17 lease fence). RELEASED: a stopping relay gave back a claim it had not used.
allowed_values: [PUBLISHED, FAILED, DEAD, STALE, RELEASED]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
@@ -378,13 +380,14 @@ metrics:
required_test: contract-verification:metrics-cardinality
# source: feature-domain-event-outbox-contract — row status enum + Outbox Defaults attemptCount
# PARKED: an operator held a row that was retried without end (re-review 2026-11-03 RR-05-03).
- name: outbox.pending.size
type: gauge
unit: total
tags:
- name: status
cardinality_limit: 5
allowed_values: [PENDING, IN_FLIGHT, PUBLISHED, FAILED, DEAD]
cardinality_limit: 6
allowed_values: [PENDING, IN_FLIGHT, PUBLISHED, FAILED, DEAD, PARKED]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
@@ -394,6 +397,35 @@ metrics:
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: re-review 2026-11-03 RR-05-03 — a refusal for now and an unanswered publish are retried
# without end; these count the FAILED rows deferred at least 10 times (OutboxMetrics
# LONG_RETRY_DEFERRED_CLAIMS, the publish-failed runbook's §4.1 query) and age the oldest of them.
- name: outbox.retry.long.size
type: gauge
unit: total
tags: []
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p2: "> 0 for 10m (runbook://outbox/publish-failed §4.1)"
owner_branch: feature-domain-event-outbox-contract
log_field_mapping: []
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
- name: outbox.retry.long.age
type: gauge
unit: seconds
tags: []
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p2: "> 3600 (runbook://outbox/publish-failed §4.1)"
owner_branch: feature-domain-event-outbox-contract
log_field_mapping: []
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# === Cache ===
# source: feature-cache-consistency-contract — Decisionized Work Items "cache pattern | cache-aside default"
- name: cache.gets.total
@@ -501,240 +533,122 @@ metrics:
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — closed semantic operation outcomes
- name: redis.capability.operations.total
type: counter
unit: total
tags:
- name: capability
cardinality_limit: 6
allowed_values: [cache, rate_limit, idempotency, efficiency_lease, session, runtime]
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: operation
cardinality_limit: 24
allowed_values:
- lookup
- record
- invalidate
- refresh_claim
- refresh_release
- rate_evaluate
- idempotency_claim
- idempotency_start
- idempotency_renew
- idempotency_complete
- idempotency_fail
- idempotency_release
- idempotency_inspect
- lease_acquire
- lease_inspect
- lease_renew
- lease_release
- session_create
- session_inspect
- session_save
- session_touch
- session_revoke
- session_rotate
- route_command
- name: redis_outcome
cardinality_limit: 15
allowed_values:
- success
- hit
- miss
- denied
- contended
- conflict
- incompatible
- unavailable
- overloaded
- closed
- indeterminate
- stale
- skipped
- tombstoned
- absolute_expired
- name: certainty
cardinality_limit: 3
allowed_values: [definite, not_applied, indeterminate]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p1: "required coordination/session unavailable or indeterminate mutation sustained for 2m"
p2: "optional cache unavailable or overloaded above baseline for 5m"
owner_branch: redis-production-capability
log_field_mapping: [capability, role, operation, redis_outcome, certainty]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — monotonic semantic operation duration
- name: redis.capability.duration.seconds
# === Redis connection lanes ===
# source: review 2026-11-03 RR-04-02 — the cache's conditional writes got their own lane
# (CACHE_SCRIPT) so that cache fills cannot take the SCRIPT lane's connections from idempotency,
# rate limiting and leases. These meters show, per lane, whether that holds. Emitted by
# redis-runtime RedisLaneMetrics for every lane RedisRuntimeOwner pools, only when the context has
# a MeterRegistry. Every counter series is registered at zero at startup.
- name: redis.lane.acquire.wait.seconds
type: timer
unit: seconds
tags:
- name: capability
cardinality_limit: 6
allowed_values: [cache, rate_limit, idempotency, efficiency_lease, session, runtime]
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: operation
cardinality_limit: 24
allowed_values:
- lookup
- record
- invalidate
- refresh_claim
- refresh_release
- rate_evaluate
- idempotency_claim
- idempotency_start
- idempotency_renew
- idempotency_complete
- idempotency_fail
- idempotency_release
- idempotency_inspect
- lease_acquire
- lease_inspect
- lease_renew
- lease_release
- session_create
- session_inspect
- session_save
- session_touch
- session_revoke
- session_rotate
- route_command
- name: redis_outcome
cardinality_limit: 15
allowed_values:
- success
- hit
- miss
- denied
- contended
- conflict
- incompatible
- unavailable
- overloaded
- closed
- indeterminate
- stale
- skipped
- tombstoned
- absolute_expired
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
- name: outcome
cardinality_limit: 2
allowed_values: [admitted, refused]
percentiles: [0.5, 0.9, 0.95, 0.99]
histogram_buckets: slo_driven
alert_severity_thresholds:
p2: "p99 approaches the configured command or caller deadline for 10m"
p2: "SCRIPT admitted p99 > 100ms for 10m (the correctness lane is queueing)"
p3: "CACHE_SCRIPT admitted p99 > 100ms for 30m"
owner_branch: redis-production-capability
log_field_mapping: [capability, role, operation, redis_outcome]
log_field_mapping: [lane, outcome]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — admission rejected before command ownership
- name: redis.capability.admission.rejected.total
- name: redis.lane.acquire.refused.total
type: counter
unit: total
tags:
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: admission
cardinality_limit: 2
allowed_values: [rejected_saturated, rejected_closed]
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
- name: reason
cardinality_limit: 4
allowed_values: [saturated, closing, interrupted, connect_failed]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p1: "required role rejection sustained above zero for 2m"
p2: "optional cache saturation sustained for 5m"
p1: "SCRIPT or REGULAR saturated or connect_failed above zero for 2m while a correctness role is selected"
p2: "CACHE_SCRIPT saturated above baseline for 10m"
owner_branch: redis-production-capability
log_field_mapping: [role, admission]
log_field_mapping: [lane, reason]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — bounded admitted command count observation
- name: redis.capability.inflight.total
- name: redis.lane.connections.opened.total
type: counter
unit: total
tags:
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p3: "opened rate after warm-up above baseline for 15m (reconnect churn against a slow Redis)"
owner_branch: redis-production-capability
log_field_mapping: [lane]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
- name: redis.lane.connections.discarded.total
type: counter
unit: total
tags:
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
- name: reason
cardinality_limit: 2
allowed_values: [invalidated, broken]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p3: "invalidated rate above baseline for 15m (timed-out or failed calls discarding connections)"
owner_branch: redis-production-capability
log_field_mapping: [lane, reason]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
- name: redis.lane.connections.active
type: gauge
unit: total
tags:
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: state
cardinality_limit: 3
allowed_values: [idle, active, saturated]
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p2: "saturated series remains nonzero for 5m"
p2: "SCRIPT active == configured maximum-script-connections for 5m"
owner_branch: redis-production-capability
log_field_mapping: [role, state]
log_field_mapping: [lane]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — observations of exact sanitized RoleHealth
- name: redis.capability.readiness.total
type: counter
- name: redis.lane.connections.pending
type: gauge
unit: total
tags:
- name: capability
cardinality_limit: 5
allowed_values: [cache, rate_limit, idempotency, efficiency_lease, session]
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: state
cardinality_limit: 3
allowed_values: [available, unavailable, overloaded]
- name: reason
cardinality_limit: 11
allowed_values:
- command_unavailable
- route_closed
- semantic_probe_succeeded
- semantic_read_write_failed
- semantic_program_acl_denied
- semantic_program_failed
- server_version_unsupported
- semantic_probe_in_progress
- semantic_observation_stale
- command_saturated
- recent_command_failure
- name: requirement
cardinality_limit: 2
allowed_values: [optional, required]
- name: lane
# The lane's name: REGULAR, SCRIPT (redis-runtime), CACHE_SCRIPT (cache-redis), BLOCKING,
# TRANSACTION, ADMIN (redis-sdk), plus any lane a service composes as a RedisLaneContribution.
cardinality_limit: 12
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p1: "required coordination/session unavailable for 2m"
p2: "optional cache unavailable or overloaded for 5m"
p2: "SCRIPT pending > 0 for 5m"
owner_branch: redis-production-capability
log_field_mapping: [capability, role, state, reason, requirement]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
# source: redis-production-capability Task 16 — bounded router shutdown drain result
- name: redis.capability.lifecycle.drain.total
type: counter
unit: total
tags:
- name: role
cardinality_limit: 3
allowed_values: [cache, coordination, session]
- name: drain_outcome
cardinality_limit: 3
allowed_values: [drained, forced_after_timeout, interrupted]
percentiles: null
histogram_buckets: null
alert_severity_thresholds:
p1: "required role forced_after_timeout or interrupted during shutdown"
p2: "optional cache forced close during shutdown"
owner_branch: redis-production-capability
log_field_mapping: [role, drain_outcome]
log_field_mapping: [lane]
compatibility_impact: additive
required_test: contract-verification:metrics-cardinality
@@ -10,6 +10,9 @@
# (feature-secrets-config-source-contract 2026-05-22: "dev/local sentinel value prefix = __LOCAL_DEV_").
# - prod profile에서 `__LOCAL_DEV_` prefix 발견 시 startup fail
# (feature-secrets-config-source-contract 2026-05-22).
# - prod profile에서 `fixture-` prefix 값(이 저장소에 적힌 lane fixture 비밀번호 — infra/redis-sdk/acl,
# compose lane의 REDIS_LANE_*)도 같은 이유로 startup fail. 어떤 변수 이름이든 검사한다
# (review 2026-11-03 RR-07-04).
# - Masking 기본 = `full_except_last_4` (feature-secrets-config-source-contract 2026-05-22:
# "full mask except last 4 chars for non-secret tokens"). 진짜 secret(password/private key)은 `full`.
# - Naming suffix는 보조 신호 (feature-secrets-config-source-contract: "_TOKEN, _KEY, _PASSWORD").