`./gradlew check` failed on main before this change. Both failures came from the
notification platform and neither was reachable from the graphql merge.
- `application-core:checkstyleMain` — ProviderSubmissionResult switches over
AttemptConfirmation and covers all three constants, so the switch is exhaustive,
but checkstyle's MissingSwitchDefault does not model exhaustive arrow switches.
Add the repository's existing idiom (`default -> throw new IllegalStateException`),
the same shape SwitchNotificationWriterOwnershipCommand and DefaultCleanupService
already use. The branch stays unreachable; it exists to satisfy the linter and to
fail loudly if the enum ever grows a constant.
- `adapter:inbound:web:spotbugsMain` — SPRING_CSRF_PROTECTION_DISABLED x2 on
CallbackMvcSecurityConfiguration. Provider callbacks are inbound webhooks: an
external provider POSTs to /internal/notification/callbacks/**, so it can never
carry a CSRF token, and the chain is SESSION-STATELESS with no ambient cookie auth
for CSRF to protect. Authenticity comes from the provider signature the callback
package verifies (failure -> CallbackValidationException -> 400), not from
permitAll(). Register it in the spotbugs exclude filter scoped to that exact class,
matching the existing narrow-exception style; every other CSRF disable stays
reportable.
Verified on the merged tree by replaying the CI jobs locally:
- quality-gates: `check verifyPublicPathSnapshot verifyDependencyLocks
--warning-mode=fail --no-daemon` -> BUILD SUCCESSFUL (13m47s)
- sample-off, redis-sdk, jpa-candidate-evidence, gate-matrix-lint,
conditionalTransportQualification (graphql 8 / grpc 15 / websocket 5 /
composition 1, zero skips)
- notification-platform architecture gate (CleanArchitectureTest +
NotificationArchitectureTest)
- runtime: `:app-bootstrap:bootRun` against the compose-local database started and
served GET /api/healthcheck 200; actuator/health and /api/worklogs answered 401,
so the authentication boundary is live.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`spotbugsTest` and `spotbugsSampleOffTest` on :app-bootstrap fail on DM_GC in
NotificationObservationTest, which predates this branch — the file arrives from
701ba67 and this branch never touched it. The merge only surfaces it.
The call is intentional and cannot be removed without removing the assertion:
Micrometer holds gauge referents weakly, so a gauge whose source object is
collected reports NaN from then on, and provoking a collection is the only way
to show the notification metrics do not have that defect.
Scoped to the one method by class and method name, per the filter's own rule
that entries be narrow — a System.gc() anywhere else stays reportable.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Snapshot of the in-flight state that already existed, identically, in both
this worktree and the main checkout before this session began: the initial
HTTP Client platform implementation (previously untracked), the redis-lab
removal, and the JPA / object-storage / notification integration work.
Kept separate from this session's HTTP Client review response, which lands
in the following commit, so the two bodies of work stay reviewable apart.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>