From f2269d8c47e595891b28df4c9b96494f69d6a82b Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Sun, 22 Nov 2026 01:36:27 +0900 Subject: [PATCH] =?UTF-8?q?test(fileserver):=20admin=20=EC=9C=A0=EC=8A=A4?= =?UTF-8?q?=EC=BC=80=EC=9D=B4=EC=8A=A4=EA=B0=80=20=EC=9E=90=EA=B8=B0=20?= =?UTF-8?q?=EC=A0=91=EA=B7=BC=20=EC=97=B0=EC=82=B0=EC=9D=84=20=EB=AC=BB?= =?UTF-8?q?=EB=8A=94=EC=A7=80=20=EC=8B=9C=ED=97=98=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit FileOperation은 공개 진입점마다 연산 하나를 묻고 검사 안 하는 연산은 없다고 약속한다. lifecycle·upload 시험에는 그 약속을 보는 시험이 있지만 admin 쪽에는 없다. orphan 적용·upload 정리·reverify·orphan 목록·미완료 upload 목록·runtime capability 조회의 authorize 줄을 지우거나 연산을 바꿔도 :application-fileserver:test가 통과한다. 시험의 FakeFileAccessPolicy는 기본이 허용이고, admin 거절 시험은 storage health와 force delete 둘뿐이다. FileserverAdminUseCasesTest에 시험 셋을 더한다. - everyAdminOperationConsultsItsOwnAccessOperation: admin 패키지의 유스케이스 여덟을 한 번씩 부르고 policy가 받은 연산 순서를 본다. 항목이 말한 여섯에 storage health·force delete를 더해 이름의 「every」가 맞게 했다. 운영 정책은 세 admin 연산을 같은 tier로 묶어 연산을 바꿔도 동작이 같으므로, 순서 단언만이 잘못 물은 연산을 잡는다. - anOrphanApplyWithoutTheSecondAuthorityRemovesNothing: ADMIN_FORCE_DELETE 거절이면 맞는 fingerprint를 보내도 저장소 삭제·quarantine·cleanup queue가 모두 비어 있다. - anUploadCleanupWithoutTheSecondAuthorityClaimsNothing: 같은 거절이면 queue에 있던 요청이 claim되지 않고 그대로 남는다. 정리 서비스는 testkit fake로 조립한 DefaultCleanupService다. 버린 안: web-fileserver controller 시험에서 403을 보기. permission gate가 먼저 403을 내서 이 검사를 증명하지 못한다. 위험·한계: main 코드와 RoleBasedFileAccessPolicy는 바꾸지 않았다. 검증: desktop RED·GREEN은 PR 본문에 둔다. Refs: REV-BE-0034 --- .../admin/FileserverAdminUseCasesTest.java | 133 ++++++++++++++++++ 1 file changed, 133 insertions(+) diff --git a/src/application/fileserver/src/test/java/dev/caskeleton/application/fileserver/admin/FileserverAdminUseCasesTest.java b/src/application/fileserver/src/test/java/dev/caskeleton/application/fileserver/admin/FileserverAdminUseCasesTest.java index ef65f6f9..f427cc3b 100644 --- a/src/application/fileserver/src/test/java/dev/caskeleton/application/fileserver/admin/FileserverAdminUseCasesTest.java +++ b/src/application/fileserver/src/test/java/dev/caskeleton/application/fileserver/admin/FileserverAdminUseCasesTest.java @@ -16,31 +16,43 @@ import dev.caskeleton.application.fileserver.api.security.FileOperation; import dev.caskeleton.application.fileserver.api.transfer.UploadMode; import dev.caskeleton.application.fileserver.cleanup.CleanupRequest; import dev.caskeleton.application.fileserver.cleanup.CleanupType; +import dev.caskeleton.application.fileserver.cleanup.DefaultCleanupService; +import dev.caskeleton.application.fileserver.observability.FileserverMetricsPort; import dev.caskeleton.application.fileserver.observability.SafeFileFingerprint; +import dev.caskeleton.application.fileserver.port.in.CleanupUploadsCommand; import dev.caskeleton.application.fileserver.port.in.ForceDeleteCommand; import dev.caskeleton.application.fileserver.port.in.GetRuntimeCapabilitiesQuery; import dev.caskeleton.application.fileserver.port.in.GetStorageHealthQuery; +import dev.caskeleton.application.fileserver.port.in.ListIncompleteUploadsQuery; +import dev.caskeleton.application.fileserver.port.in.ListOrphansQuery; import dev.caskeleton.application.fileserver.port.in.OrphanReconcileCommand; import dev.caskeleton.application.fileserver.port.in.ReverifyFileCommand; import dev.caskeleton.application.fileserver.testkit.DirectTransactions; import dev.caskeleton.application.fileserver.testkit.FakeAdminPorts; +import dev.caskeleton.application.fileserver.testkit.FakeCleanupContentGateway; import dev.caskeleton.application.fileserver.testkit.FakeFileAccessPolicy; +import dev.caskeleton.application.fileserver.testkit.FakeFileQuotaService; import dev.caskeleton.application.fileserver.testkit.FileserverFixtures; import dev.caskeleton.application.fileserver.testkit.InMemoryCleanupQueue; import dev.caskeleton.application.fileserver.testkit.InMemoryFileMetadataStore; import dev.caskeleton.application.fileserver.testkit.InMemoryUploadSessionStore; import dev.caskeleton.application.fileserver.testkit.ReadyFileFixture; +import dev.caskeleton.application.fileserver.testkit.RecordingQuotaReclaimGateway; import java.nio.charset.StandardCharsets; import java.time.Clock; +import java.time.Duration; import java.time.ZoneOffset; import java.util.List; +import java.util.Optional; import java.util.OptionalLong; +import java.util.Set; import java.util.UUID; import org.junit.jupiter.api.Test; class FileserverAdminUseCasesTest { private static final String DIGEST = "1".repeat(64); + private static final String OTHER_DIGEST = "2".repeat(64); private static final long SIZE = 10; private static final ContentKey ORPHAN_KEY = ContentKey.of("aa/bb/orphan-object-0001"); @@ -74,6 +86,28 @@ class FileserverAdminUseCasesTest { new ForceDeleteFileApplicationUseCase( metadata, sessions, sessions, queue, accessPolicy, audit, new DirectTransactions()); + private final ListOrphansApplicationUseCase listOrphans = + new ListOrphansApplicationUseCase(adminPorts, accessPolicy); + + private final ListIncompleteUploadsApplicationUseCase listIncompleteUploads = + new ListIncompleteUploadsApplicationUseCase( + sessions, accessPolicy, new DirectTransactions(), clock); + + private final CleanupUploadsApplicationUseCase cleanupUploads = + new CleanupUploadsApplicationUseCase( + new DefaultCleanupService( + queue, + new FakeCleanupContentGateway(), + metadata, + sessions, + new RecordingQuotaReclaimGateway(new FakeFileQuotaService()), + Duration.ofMinutes(5), + FileserverMetricsPort.noop(), + new DirectTransactions(), + clock), + accessPolicy, + audit); + @Test void capabilitiesNeverDiscloseAPhysicalRoot() { RuntimeCapabilityReport report = @@ -166,6 +200,62 @@ class FileserverAdminUseCasesTest { assertThat(report.reclaimedBytes()).isEqualTo(100); } + /** Echoed fingerprints are the caller's claim, not authority: denied, nothing leaves storage. */ + @Test + void anOrphanApplyWithoutTheSecondAuthorityRemovesNothing() { + // given + adminPorts.addOrphan(new OrphanObject(ORPHAN_KEY, 100, FileserverFixtures.NOW, "fp-1")); + accessPolicy.deny(FileOperation.ADMIN_FORCE_DELETE); + + // when + Throwable failure = + catchThrowable( + () -> + reconcile.handle( + new OrphanReconcileCommand( + false, + 100, + 1L << 20, + List.of("fp-1"), + "OPERATOR_APPLY", + FileserverFixtures.context()))); + + // then + assertThat(failure) + .isInstanceOf(FileserverException.class) + .hasMessage("operation denied by policy"); + assertThat(List.of(adminPorts.deletedObjectCount(), adminPorts.quarantined(), queue.queued())) + .as("[deleted objects, quarantined keys, queued cleanup]") + .containsExactly(0, Set.of(), List.of()); + } + + /** + * A cleanup batch deletes what the queue names, so refusing it must leave the queue unclaimed. + */ + @Test + void anUploadCleanupWithoutTheSecondAuthorityClaimsNothing() { + // given + CleanupRequest pending = CleanupRequest.forOrphan(ORPHAN_KEY); + queue.enqueue(pending); + accessPolicy.deny(FileOperation.ADMIN_FORCE_DELETE); + + // when + Throwable failure = + catchThrowable( + () -> + cleanupUploads.handle( + CleanupUploadsCommand.requested( + Optional.empty(), Optional.empty(), FileserverFixtures.context()))); + + // then + assertThat(failure) + .isInstanceOf(FileserverException.class) + .hasMessage("operation denied by policy"); + assertThat(List.of(queue.claimSweeps(), queue.queued())) + .as("[claim sweeps, queued cleanup]") + .containsExactly(List.of(), List.of(pending)); + } + @Test void anApplyWithoutFingerprintsCannotEvenBeConstructed() { assertThatThrownBy( @@ -310,6 +400,49 @@ class FileserverAdminUseCasesTest { .satisfies(record -> assertThat(record.actorFingerprint()).isNotEqualTo("user-1")); } + /** + * {@link FileOperation} promises each entry point consults exactly one operation. The fake allows + * everything, so only the order it was asked in shows a dropped check or one that asks for the + * wrong tier; the production policy grouping these tiers together would hide both. + */ + @Test + void everyAdminOperationConsultsItsOwnAccessOperation() { + // given + FileRecord quarantined = quarantinedRecord(); + FileRecord ready = ReadyFileFixture.ready(metadata, SIZE, OTHER_DIGEST); + + // when + callEveryAdminOperationOnce(quarantined.fileId(), ready.fileId()); + + // then + assertThat(accessPolicy.invocations()) + .containsExactly( + FileOperation.ADMIN_READ, // capabilities + FileOperation.ADMIN_READ, // storage health + FileOperation.ADMIN_READ, // orphan listing + FileOperation.ADMIN_READ, // incomplete-upload listing + FileOperation.ADMIN_REVERIFY, // reverify + FileOperation.ADMIN_FORCE_DELETE, // orphan reconcile + FileOperation.ADMIN_FORCE_DELETE, // upload cleanup + FileOperation.ADMIN_FORCE_DELETE); // force delete + } + + /** One call per admin use case, in the order the assertion above names them. */ + private void callEveryAdminOperationOnce(FileId quarantinedFile, FileId readyFile) { + capabilities.handle(new GetRuntimeCapabilitiesQuery(FileserverFixtures.context())); + storageHealth.handle(new GetStorageHealthQuery(FileserverFixtures.context())); + listOrphans.handle(ListOrphansQuery.requested(Optional.empty(), FileserverFixtures.context())); + listIncompleteUploads.handle( + ListIncompleteUploadsQuery.requested(Optional.empty(), FileserverFixtures.context())); + reverify.handle(new ReverifyFileCommand(quarantinedFile, FileserverFixtures.context())); + reconcile.handle(OrphanReconcileCommand.dryRun(100, FileserverFixtures.context())); + cleanupUploads.handle( + CleanupUploadsCommand.requested( + Optional.empty(), Optional.empty(), FileserverFixtures.context())); + forceDelete.handle( + new ForceDeleteCommand(readyFile, "LEGAL_TAKEDOWN_2026_08", FileserverFixtures.context())); + } + private FileRecord quarantinedRecord() { FileRecord verifying = ReadyFileFixture.verifying(metadata, SIZE, DIGEST); return metadata.transition( -- 2.54.0