DongHyeonkaandClaude Opus 5
ef947e5bb0
외부 리뷰("현재 상태를 유지하기 위한 검증이 너무 많고, 그 검증 자체를
다시 검증하는 구조까지 생겼다")를 설계 문서로 정리하고 코드로 반영한다.
설계·판단 근거는 docs/superpowers/specs/2026-09-16-verification-surface-reduction-design.md.
삭제
- .github/ci-gate-matrix.yml(1,025줄) + verify-gate-matrix.sh(568줄):
Gradle task graph와 workflow graph에 이미 있는 정보의 3중 복제
- verify-gradle-wrapper.sh(799줄): workflow 바이트 해시 잠금.
wrapper 검증은 gradle/actions/wrapper-validation(full SHA 핀)에 위임
- DeveloperExperienceContractTest 등의 CI YAML mutation 테스트:
애플리케이션 test suite가 GitHub Actions YAML 파서를 검증하던 계층 역전
- 문서 drift 파서: verifyReadmeCommands, verifyRunbookReferences,
verifyDocumentedLeafCount, verifyTestSourceSetRegistry
- 빈 레지스트리를 지키던 커스텀 YAML 파서: verifyTrivyignore,
verifyQuarantineSunset, flaky-quarantine.yaml
- verifyConfigurationPropertiesProcessor, verifyOneTypePerFile:
각각 ca.spring-config convention과 Checkstyle OneTopLevelClass가 대체
- 정상 입력으로도 성공할 수 없던 messaging always-fail task
- ModuleRegistry의 JSON 필드 집합 정확 일치, sample-portfolio negative guard
이동
- java/quality/spring 공통 설정을 configure(subprojects) 블록에서
ca.java-conventions / ca.quality-conventions / ca.java-library /
ca.spring-library convention plugin으로
- 아키텍처 검증을 ca.architecture로, JPA·messaging qualification을
gradle/qualification/ 아래로, verifyEnvKeys를 :app-bootstrap 소유로
완화
- Git revision은 releaseCheck·아카이브 생성에서만 요구. 일반 빌드는 SNAPSHOT
- SpotBugs/FindSecBugs는 로컬 check에서 빼고 qualityCheck 레인으로
task 계층
- leaf check는 그 leaf만. architectureCheck / qualityCheck /
configContractCheck / integrationCheck / ci / releaseCheck로 이름 분리
CI
- _reusable-gradle.yml 신규. checkout + wrapper validation + JDK/캐시 공통화
- fileserver-release.yml -> fileserver-certification.yml (CD가 아니라 certification)
- GitHub Actions = CI + artifact, Argo CD = CD 경계를 docs/ci-cd/boundary.md로 고정
순증감 +3,274 / -7,483.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
114 lines
4.2 KiB
YAML
114 lines
4.2 KiB
YAML
name: fileserver-pr
|
|
|
|
# Every claim in docs/fileserver/support-matrix.md that says "Stable" is backed by a job here.
|
|
# A support level with no job behind it is a marketing claim, not an engineering one, and
|
|
# DocumentationCoverageTest fails the build when the two drift apart.
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
pull_request:
|
|
paths:
|
|
- 'src/application-core/src/**/fileserver/**'
|
|
- 'src/adapter/inbound/web/src/**/fileserver/**'
|
|
- 'src/adapter/outbound/fileserver/**'
|
|
- 'src/adapter/outbound/persistence-jpa/src/**/fileserver/**'
|
|
- 'src/app-bootstrap/src/**/fileserver/**'
|
|
- 'docs/fileserver/**'
|
|
# The capability is not only its Java files. A change to the bound settings, the shipped
|
|
# environment, the registry that documents it, or the container that has to give it a
|
|
# writable volume changes how it behaves at runtime just as surely — and those were the
|
|
# exact files that could previously ship unverified.
|
|
- 'src/app-bootstrap/src/main/resources/application.yml'
|
|
- 'src/.env'
|
|
- 'docs/registries/env-keys.yaml'
|
|
- 'src/Dockerfile'
|
|
- 'docker-compose.yml'
|
|
- 'infra/fileserver/nginx/**'
|
|
- 'infra/fileserver/kubernetes/**'
|
|
- 'infra/fileserver/nfs/**'
|
|
- '.github/workflows/fileserver-pr.yml'
|
|
# Every Gradle job here installs its toolchain through this composite action, so a change to
|
|
# it changes what this gate runs.
|
|
- '.github/actions/setup-gradle-java/action.yml'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
fileserver-unit-and-architecture:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run the fileserver application and architecture suites
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:application-core:test
|
|
:app-bootstrap:test --tests 'dev.caskeleton.bootstrap.architecture.*' --tests '*Fileserver*'
|
|
--no-daemon
|
|
--stacktrace
|
|
|
|
fileserver-local-ext4-contract:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Certify the local content store against the shared contract
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:adapter:outbound:fileserver:test
|
|
--no-daemon
|
|
--stacktrace
|
|
|
|
fileserver-http-contract:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run the servlet and reactive transport contracts
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:adapter:inbound:web:test
|
|
--no-daemon
|
|
--stacktrace
|
|
|
|
fileserver-security-suite:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run the path, filename, range, and problem-detail hardening suite
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:adapter:inbound:web:test --tests '*FileserverHardeningContractTest'
|
|
:adapter:outbound:fileserver:test --tests '*PhysicalPathResolverTest'
|
|
--no-daemon
|
|
--stacktrace
|
|
|
|
fileserver-bounded-memory:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Prove transfer cost does not scale with file size
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:adapter:outbound:fileserver:test --tests '*LargeFileBoundedMemoryTest'
|
|
:adapter:inbound:web:test --tests '*DataBufferReleaseTest'
|
|
--no-daemon
|
|
--stacktrace
|