문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가 Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다. @SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히 prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고, GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로 나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역 발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다. 방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를 먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이 기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록, @SystemInvoked bean은 기동 실패, complete 단계 실패는 IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도 SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도 행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도 내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제 지표(redis.lane.*) 기준으로 고쳤다. 위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이 브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류 디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어 파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은 기동을 막는다. httpclient failure-injection lane의 main 단계 중복 실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다. 검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci integrationCheck performanceCheck, :performanceCheck, :releaseCheck (-PgitRevision), verify-compose-profile-contracts(18 lane) 통과. 첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다. Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절 BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호 첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드 IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은 static·의존 없음이어야 한다.
90 lines
5.2 KiB
JSON
90 lines
5.2 KiB
JSON
{
|
|
"$comment": [
|
|
"NTF-024 — what each support grade requires, as executable artifacts rather than prose.",
|
|
"A grade in support-matrix.md is a promise about production behaviour. The workflow that was",
|
|
"supposed to back those promises ran a unit subset on PR, a job named 'restart recovery' that",
|
|
"ran no restart, and a provider sandbox job whose entire body was two echo statements behind",
|
|
"continue-on-error. So the strongest claim in the document rested on the weakest evidence in",
|
|
"the pipeline, and nothing connected the two.",
|
|
"NotificationEvidenceVerifierTest reads this file, checks that every claim marked satisfied names",
|
|
"test classes that exist, and refuses a grade whose claims are not all satisfied.",
|
|
"A PostgreSql*ContractTest runs a shared port contract (application-notification testFixtures)",
|
|
"against the JPA store; its cases are the contract's, and the verifier follows the superclass to",
|
|
"find them. Those contracts replaced RecipientClaimContractTest, ProjectionFactDurabilityContractTest",
|
|
"and LateEventBindingContractTest, which ran the adapter's SQL over a bare connection (r3-J)."
|
|
],
|
|
"claims": {
|
|
"durable": {
|
|
"requires": "PostgreSQL migration, CRUD against the real schema, and survival of a restart",
|
|
"status": "satisfied",
|
|
"lane": ":adapter:outbound:persistence-jpa:jpaPlatformContractTest",
|
|
"evidence": [
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlRecipientDeliveryStoreContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlRecipientLeaseStoreContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlDeliveryProjectionStoreContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/ServingStateContractTest.java"
|
|
]
|
|
},
|
|
"multi-worker-safe": {
|
|
"requires": "two workers racing the same claim against a real database, with lease fencing",
|
|
"status": "satisfied",
|
|
"lane": ":adapter:outbound:persistence-jpa:jpaPlatformContractTest",
|
|
"evidence": [
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlRecipientLeaseStoreContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlRecipientDeliveryStoreContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/readiness/PostgreSqlRecipientLeaseFencingIntegrationTest.java"
|
|
]
|
|
},
|
|
"callback-supported": {
|
|
"requires": "signature verification, duplicate suppression, and an event that arrives before its attempt is stored",
|
|
"status": "satisfied",
|
|
"lanes": [
|
|
":adapter:outbound:persistence-jpa:jpaPlatformContractTest",
|
|
":application-notification:test",
|
|
":adapter:outbound:notification:test"
|
|
],
|
|
"evidence": [
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/PostgreSqlProviderEventLedgerContractTest.java",
|
|
"application-notification/src/test/java/dev/caskeleton/application/notification/platform/callback/CallbackIngestionAtomicityTest.java",
|
|
"adapter/outbound/notification/src/test/java/dev/caskeleton/adapter/outbound/notification/platform/provider/ses/SesCallbackContractTest.java"
|
|
]
|
|
},
|
|
"recoverable": {
|
|
"requires": "a process-kill matrix covering each dispatch phase, proving no delivery is lost or duplicated",
|
|
"status": "satisfied",
|
|
"lane": ":adapter:outbound:persistence-jpa:jpaPlatformContractTest",
|
|
"evidence": [
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/notification/WorkerCrashRecoveryContractTest.java",
|
|
"adapter/outbound/persistence-jpa/src/postgresqlIntegrationTest/java/dev/caskeleton/adapter/outbound/persistence/readiness/PostgreSqlNotificationBackgroundPassIntegrationTest.java"
|
|
]
|
|
},
|
|
"provider-wire-qualified": {
|
|
"requires": "a real provider sandbox call producing an immutable, uploaded evidence artifact with a correlation id",
|
|
"status": "unsatisfied",
|
|
"lane": null,
|
|
"evidence": [],
|
|
"gap": "The provider-sandbox job runs two echo statements behind continue-on-error. No request has ever left the process, so no provider protocol is qualified against its real endpoint."
|
|
}
|
|
},
|
|
"grades": {
|
|
"Stable": [
|
|
"durable",
|
|
"multi-worker-safe",
|
|
"callback-supported",
|
|
"recoverable",
|
|
"provider-wire-qualified"
|
|
],
|
|
"Contract implemented / runtime unqualified": [
|
|
"durable",
|
|
"multi-worker-safe",
|
|
"callback-supported"
|
|
],
|
|
"Optional stable": [
|
|
"durable"
|
|
],
|
|
"Extension": [],
|
|
"Experimental": []
|
|
},
|
|
"matrixDocument": "docs/notification/support-matrix.md"
|
|
}
|