문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가 Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다. @SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히 prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고, GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로 나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역 발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다. 방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를 먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이 기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록, @SystemInvoked bean은 기동 실패, complete 단계 실패는 IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도 SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도 행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도 내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제 지표(redis.lane.*) 기준으로 고쳤다. 위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이 브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류 디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어 파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은 기동을 막는다. httpclient failure-injection lane의 main 단계 중복 실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다. 검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci integrationCheck performanceCheck, :performanceCheck, :releaseCheck (-PgitRevision), verify-compose-profile-contracts(18 lane) 통과. 첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다. Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절 BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호 첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드 IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은 static·의존 없음이어야 한다.
284 lines
16 KiB
YAML
284 lines
16 KiB
YAML
name: integration-main
|
|
|
|
# Stage 2: is the merged state healthy.
|
|
#
|
|
# The question this stage answers is different from stage 1's. Stage 1 asks whether a diff is safe
|
|
# and blocks a merge; stage 2 asks whether main is healthy and does not — the merge has already
|
|
# happened. That difference is the point, and it is what lets a control exist without being an
|
|
# obstacle: a gate here still fails loudly, it just fails after the thing it is reporting on.
|
|
#
|
|
# Two kinds of work live here.
|
|
#
|
|
# 1. The lanes that need a machine that is not simultaneously compiling something else — load,
|
|
# abuse, graceful shutdown, TCP fault injection, resource bounds. They were web-nightly.yml and
|
|
# httpclient-nightly.yml, two module-shaped files whose only real difference was the cadence they
|
|
# shared. They now run on every push to main as well as nightly, which is strictly more often
|
|
# than before.
|
|
#
|
|
# 2. The container-backed lanes, run as the root category aggregates `:integrationCheck` and
|
|
# `:performanceCheck` rather than one workflow line per lane. A lane nobody runs is not coverage;
|
|
# it is a file that looks like coverage — and naming lanes here one by one is how fourteen of
|
|
# them came to run nowhere (review 2026-11-01 08-01). The pull-request gate's
|
|
# `verifyStrictLaneStages` now fails when a strict lane is in no stage a workflow executes. They
|
|
# are here rather than in stage 1 because every one of them starts containers or real servers,
|
|
# and the pull-request budget is minutes for the whole gate.
|
|
#
|
|
# What is deliberately NOT here: the web "Advanced capability" nightly lane that used to exist as
|
|
# web-advanced-nightly.yml (websocket-advanced-nightly.yml went with the websocket Advanced code,
|
|
# deleted 2026-09-25). The web leaf's build file says it outright — "They also run inside `test`,
|
|
# deliberately ... excluding them from the PR gate to make this lane look meaningful would mean the
|
|
# PR gate stopped covering a fifth of the leaf" — so `webAdvancedTest` selects tagged tests that
|
|
# `:<leaf>:test` already runs, and `:<leaf>:test` runs inside the root `check` on every pull request
|
|
# and every push to main. The strict lane itself survives in release.yml, where its
|
|
# fail-on-nothing-discovered guard is worth a job.
|
|
|
|
on:
|
|
push:
|
|
branches: ["main"]
|
|
schedule:
|
|
# 03:00 UTC. Late enough that the day's merges are in, early enough that a failure is triaged
|
|
# before the next working day starts.
|
|
- cron: '0 3 * * *'
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: false
|
|
|
|
# The documentation-drift gates that used to run here are gone rather than demoted.
|
|
#
|
|
# They were four hand-written parsers: README shell blocks compared against the Gradle task graph,
|
|
# runbook identifiers compared against every declared Java type, a leaf count written in prose
|
|
# compared against the registry, and a Markdown table compared against the declared source sets.
|
|
# Each was a custom parser for a file format nobody controls, and each made a documentation edit a
|
|
# precondition for a build. A stale sentence is a defect, but it is not one a build can be failed
|
|
# for, and link-check.yml already answers the one documentation question with a stable machine
|
|
# answer: does this link resolve.
|
|
|
|
jobs:
|
|
# The main-branch stage of the Gradle gates (`:mainCheck`): the environment contract, full-boot
|
|
# qualification, the sample web contract, the public-path baseline, the conditional transport
|
|
# lanes, the messaging contract lanes and each leaf's document-contract lanes. API surfaces are
|
|
# in the pull-request `check` (owner decision 20). The rest left the pull-request gate (review
|
|
# 2026-09-24 BUILD, item 12); none of them is deleted.
|
|
main-check:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 60
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- name: Require the committed public-path security baseline
|
|
run: |
|
|
set -euo pipefail
|
|
readonly snapshot='docs/security/public-paths-snapshot.txt'
|
|
if [[ ! -s "${snapshot}" ]] || ! git ls-files --error-unmatch "${snapshot}" >/dev/null 2>&1; then
|
|
echo "::error::${snapshot} is missing, empty or not committed; verifyPublicPathSnapshot must not create its own baseline."
|
|
exit 1
|
|
fi
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run the main-branch stage
|
|
working-directory: src
|
|
# `--continue`: one failed lane (an external image that cannot be pulled, say) must not stop
|
|
# the other main-stage gates from reporting (review 2026-11-01 08-04).
|
|
run: ./gradlew :mainCheck --continue --warning-mode=fail --stacktrace
|
|
|
|
# Storability only: the `--dry-run` below plans `integrationCheck` without running a lane. The
|
|
# lanes run in `integration-check`.
|
|
#
|
|
# Two questions. Can every task in the repository-wide gates be *stored* (a property of the task
|
|
# graph, so `--dry-run` answers it for all of them in seconds)? And is a stored entry *reused* while
|
|
# the build still executes its work (checked on the two core leaves)?
|
|
configuration-cache:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Require every repository-wide gate to be storable
|
|
working-directory: src
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
for gate in ci mainCheck integrationCheck releaseCheck; do
|
|
echo "::group::${gate}"
|
|
./gradlew "${gate}" --dry-run \
|
|
--configuration-cache --configuration-cache-problems=fail --stacktrace
|
|
output="$({ ./gradlew "${gate}" --dry-run \
|
|
--configuration-cache --configuration-cache-problems=fail --stacktrace; } 2>&1)"
|
|
printf '%s\n' "${output}"
|
|
echo '::endgroup::'
|
|
grep -Fq 'Reusing configuration cache.' <<<"${output}" || {
|
|
echo "::error::Gradle did not reuse the configuration cache for ${gate}."
|
|
exit 1
|
|
}
|
|
done
|
|
- name: Store configuration cache for the everyday core build
|
|
working-directory: src
|
|
run: >-
|
|
./gradlew
|
|
:domain-core:check
|
|
:application-core:check
|
|
--configuration-cache
|
|
--configuration-cache-problems=fail
|
|
--stacktrace
|
|
- name: Require configuration-cache reuse
|
|
working-directory: src
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
output="$({ ./gradlew :domain-core:check :application-core:check \
|
|
--configuration-cache --configuration-cache-problems=fail --stacktrace; } 2>&1)"
|
|
printf '%s\n' "${output}"
|
|
grep -Fq 'Reusing configuration cache.' <<<"${output}" || {
|
|
echo '::error::Gradle did not reuse the configuration cache on the second identical build.'
|
|
exit 1
|
|
}
|
|
|
|
# The integration stage: every integration-category strict lane (`:integrationCheck`).
|
|
#
|
|
# This job replaced six jobs that named lanes one by one — the MongoDB lanes, app-bootstrap's
|
|
# Testcontainers lane, the moved messaging/object-storage/sample contracts, six of the
|
|
# persistence-jpa PostgreSQL contracts and the httpclient fault injection. Naming lanes was how
|
|
# eleven persistence-jpa readiness lanes ended up running nowhere: a lane added to Gradle without a
|
|
# workflow line was declared, failed closed, and executed on no machine (review 2026-11-01 08-01).
|
|
# The aggregate is the list now. A lane joins it by declaring `integration()`, and the root
|
|
# `verifyStrictLaneStages` (pull-request gate) fails when a strict lane is in no stage a workflow
|
|
# executes.
|
|
#
|
|
# `--continue` so that one red lane does not hide the others: every failed lane is named in the
|
|
# same run. Lanes that need an input this job does not have (the Redis topology coordinates, the
|
|
# protected AWS sandbox) are `explicitOnly`; the aggregate prints which ones it left out.
|
|
# The container lanes take the build-wide `exclusiveRealServerLane` slot one at a time, so the
|
|
# job's length is the sum of the lanes. Split the aggregate across jobs when it outgrows its
|
|
# timeout rather than going back to naming lanes.
|
|
#
|
|
# Measured length (one local run of `:integrationCheck`, 2026-11-01, 37 lanes, images already
|
|
# pulled, machine load 24): 794 s for the command, of which the lanes' test JVMs took about 624 s
|
|
# in sum — mongoSecurityIntegrationTest 89, jpaPlatformContractTest 104, messagingCertificationTest
|
|
# 70, mongoCompatibilityTest 69, jpaPlatformMigrationTest 66, mongoFailoverTest 59, the eleven JPA
|
|
# readiness lanes 57 together, httpClientFailureInjectionTest 27, sample integrationTest 23,
|
|
# messaging starter integrationTest 21, the rest under 10 each — and the remainder was compilation
|
|
# and container start-up between lanes. A hosted runner adds cold image pulls (about 5 GB
|
|
# uncompressed across the PostgreSQL, MongoDB, Kafka, nginx, httpbin and Toxiproxy images) and a
|
|
# cold Gradle cache; expect 25 to 40 minutes (an estimate, not a measured hosted run). The 240-minute timeout is a ceiling for a hung container, not a budget.
|
|
integration-check:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 240
|
|
env:
|
|
# Reuse would hand the failover lane a replica set another lane had already faulted.
|
|
TESTCONTAINERS_REUSE_ENABLE: "false"
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run every integration-category strict lane
|
|
working-directory: src
|
|
run: ./gradlew :integrationCheck --continue --stacktrace
|
|
- name: Publish the integration lane reports
|
|
if: always()
|
|
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
|
with:
|
|
name: integration-check-reports
|
|
path: src/**/build/reports/tests/
|
|
if-no-files-found: warn
|
|
|
|
# The performance stage: every performance-category strict lane (`:performanceCheck`) — Tomcat and
|
|
# Jetty load, slow-client and graceful shutdown, the Hikari pool contract, the httpclient pool,
|
|
# streaming, retry and rotation bounds, the MongoDB resource budget. They measure behaviour that
|
|
# degrades gradually rather than breaking outright, which is the kind of regression a per-PR gate
|
|
# never catches. This job replaced `web-load-abuse-and-shutdown`, which despite its name ran
|
|
# `:adapter:inbound:web:test` and `webJettyCompatTest` — two lanes the pull-request and main stages
|
|
# already run — and never the load lanes (review 2026-11-01 08-01), and `httpclient-performance`.
|
|
performance-check:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 120
|
|
env:
|
|
# A project property rather than a command-line flag, so the run command stays a plain,
|
|
# verifiable task invocation while the machine-dependent bounds are still asserted.
|
|
GRADLE_OPTS: -Dorg.gradle.project.performance.assertions.enabled=true
|
|
TESTCONTAINERS_REUSE_ENABLE: "false"
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Run every performance-category strict lane
|
|
working-directory: src
|
|
run: ./gradlew :performanceCheck --continue --stacktrace
|
|
# The optional gRPC build's performance lanes (grpcPerformanceTest). A separate build, so a
|
|
# separate command; its own verifyStrictLaneStages counts this line (review 2026-11-03 RR-06-03).
|
|
- name: Run every optional-platform performance-category strict lane
|
|
if: always()
|
|
working-directory: src
|
|
run: ./gradlew -p optional-platforms performanceCheck --continue --stacktrace
|
|
- name: Publish the performance lane reports
|
|
if: always()
|
|
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
|
with:
|
|
name: performance-check-reports
|
|
path: src/**/build/reports/tests/
|
|
if-no-files-found: warn
|
|
|
|
httpclient-http3-experimental:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
# Experimental by design (D-08): the result is reported, never used to block a merge. Registered
|
|
# advisory so that "this job cannot fail the
|
|
# build" is written down rather than inferred from a field two hundred lines into a workflow.
|
|
continue-on-error: true
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Exercise the experimental HTTP/3 opt-in
|
|
working-directory: src
|
|
run: ./gradlew :adapter:outbound:httpclient:test -Phttp3.tests.enabled=true --stacktrace
|
|
|
|
# The optional gRPC platform build declares one strict INTEGRATION lane —
|
|
# `grpc-operation-ledger-jpa:integrationTest`, which certifies the atomic
|
|
# `INSERT ... ON CONFLICT DO NOTHING` claim that durable mutation idempotency rests on against a
|
|
# real PostgreSQL. It was registered in Gradle, listed in `strictTestLanes`, and invoked by
|
|
# nothing: `-p optional-platforms ci` reaches `checkAll`, `qualityCheck` and the dependency
|
|
# verifier, none of which runs a lane whose category is INTEGRATION, and release.yml's gRPC gate
|
|
# names only the three grpc-testkit lanes.
|
|
#
|
|
# Stage 2 rather than stage 1 for the same reason as every other job in this file: the lane starts
|
|
# a Testcontainers PostgreSQL, and the pull-request budget is minutes for the whole gate.
|
|
grpc-optional-platform-integration:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 45
|
|
env:
|
|
TESTCONTAINERS_REUSE_ENABLE: "false"
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Certify the gRPC operation ledger against real PostgreSQL
|
|
working-directory: src
|
|
run: ./gradlew -p optional-platforms integrationCheck --stacktrace
|
|
- name: Publish the optional-platform lane reports
|
|
if: always()
|
|
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
|
with:
|
|
name: grpc-optional-platform-integration-reports
|
|
path: src/optional-platforms/**/build/reports/tests/
|
|
if-no-files-found: warn
|
|
|
|
# Dynamic half of the compose-profile contract. Every blocking lane the matrix declares runs on
|
|
# main and nightly; a partial lane run is reproduction only and cannot satisfy this job. The count
|
|
# is not written here on purpose — a number in prose drifts the moment a lane is added, and the
|
|
# matrix file is the thing this job reads.
|
|
#
|
|
# The lanes boot the qualification image (src/Dockerfile COMPOSITION=qualification: every
|
|
# capability module present). The script selects it; release.yml builds the default image.
|
|
compose-runtime-smoke:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 180
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- name: Run every blocking Compose runtime lane
|
|
run: bash scripts/run-compose-runtime-smoke.sh --matrix src/config/runtime/compose-profile-contracts.json
|
|
- name: Publish sanitized runtime-smoke evidence
|
|
if: always()
|
|
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # actions/upload-artifact@v4.6.2
|
|
with:
|
|
name: compose-runtime-smoke-evidence
|
|
path: src/app-bootstrap/build/evidence/runtime-smoke
|
|
if-no-files-found: warn
|