Files
clean-architecture-backend-…/infra/redis-sdk
DongHyeonka 1885bf8da7 fix!: 2차 재리뷰가 찾은 결함 29건을 고친다
문제: 재리뷰 수정 커밋(bbe944bd)만 다시 본 2차 재리뷰가 Important 7건,
Minor 22건을 찾았다. 결과 불명 503 뒤 같은 키를 다시 보내면 Redis
store가 lease 지난 실행을 넘겨받아 작업을 다시 돌렸다. replay TTL이
lease보다 짧으면 lease 도중 key가 사라져 같은 키가 두 번 실행됐다.
@SystemInvoked 규칙이 매뉴얼 09장의 이벤트 소비 경로까지 막았다. V22가
outbox_event에 가장 강한 잠금을 lock_timeout 없이 걸었다. prod의
fixture- 거부가 HOSTNAME 같은 비밀 아닌 값까지 막았다. 데모 허용 목록의
test·demo 프로필로 sample이 뜨지 않았다. 기동 rule bean의 @Value 필드가
조용히 null이 됐다.

방법: 영역별 4묶음이 test-driven-development 절차로 실패 테스트를
먼저 쓰고 고쳤다. 결정은 재리뷰 README 9.1절이다.
- 두 멱등성 store가 같은 계약을 따른다. lease가 지난 실행 기록은 다시
  돌리지 않고 포기로 표시해 500 RECOVERY_REQUIRED로 답한다. 기록 수명은
  lease + replay TTL이고, replay-ttl < processing-lease면 기동이 실패한다.
- 사용자 transport만 @SystemInvoked use case에 닿지 못한다. 메시지
  handler·scheduler는 새 표시 @SystemCaller(reason)를 달고 use case를
  생성자에서 new로 만든다. 매뉴얼 경로를 테스트로 고정했다.
- 아직 어디에도 적용되지 않은 마이그레이션(V20·V22·알림 V11~V13·sample
  V8_1·grpc V002·V003)에 lock_timeout 5s를 넣고, 텍스트 검사기와 실 PG
  lane을 더했다. 이미 배포된 24개는 동결 목록으로 둔다.
- fixture- 검사는 비밀로 분류된 값만 본다. sample은 local·test·demo에서
  object storage를 끈다. 기동 rule bean에 주입 멤버가 있으면 모든
  프로필에서 기동이 실패한다. 리뷰어가 제안한 "static @Bean 선언 강제"는
  문제없는 등록을 막고 @Value 필드는 통과시켜서 버렸다.
- 이 수정 전에 move된 파일의 쿼터 차이를 찾는 쿼리와 재계산 SQL을
  docs/fileserver/operations.md에 적었다.

위험·한계: lease 뒤 늦게 끝난 첫 시도의 결과는 기록되지 않는다(그 요청도
500). @SystemCaller가 없는 메시지 handler, 주입 멤버가 있는 기동 rule,
working-directory 없이 ./gradlew를 부르는 workflow 명령은 파생 서비스에서
새로 실패하거나 세지지 않는다(업그레이드 안내 B-14~16·B-36·B-39).
spotbugsTestFixtures는 게이트 밖이고 기준 커밋에서도 실패하며, 새 검사기의
정규식 경고 8건이 더해졌다. 실제 CI runner 실행은 확인하지 못했다(Gitea
repo의 Actions가 꺼져 있다).

검증: ci, 두 빌드의 verifyStrictLaneStages --dry-run, mainCheck,
:integrationCheck, -p optional-platforms ci integrationCheck
performanceCheck, :performanceCheck, :releaseCheck(-PgitRevision),
verify-compose-profile-contracts(18 lane) 첫 실행 통과. 쿼터 재계산
SQL은 실 PostgreSQL 16에서 차이 2행 → 0행을 확인했다.

Refs: docs/reviews/2026-11-03-rereview/README.md 9·9.1·10절
BREAKING CHANGE: replay-ttl < processing-lease 설정은 기동 실패, ledger
release가 claim token을 받는다, HttpBodyReadException(IOException 하위)이
본문 실패를 싣는다, 기동 rule·비밀 목록 bean의 주입 멤버 금지,
verifyStrictLaneStages가 workflow 명령의 working-directory로 빌드를 정한다.
2026-11-04 01:47:50 +09:00
..

Redis SDK topology lanes

These lanes exist to answer the questions the deterministic in-memory gateway cannot: how Lettuce actually behaves during a Sentinel promotion, what a Cluster resharding does to an in-flight command, and whether the ACL accounts grant exactly what the SDK issues.

All four have now run on Redis 7.4 and the evidence is recorded in docs/redis/support-matrix.md. .github/workflows/redis-sdk-topology.yml runs the standalone lane on any pull request that touches the Redis leaf, the full supported-version x topology matrix nightly, and the same matrix on demand for a release candidate.

TLS is a lane of that matrix rather than something to wire up by hand. It is tls, not a deployment mode: its shape is standalone and what it qualifies is the transport, so redisTopologyTest maps the lane name to standalone for the tests and keeps the tag filter and the required trust material on the lane.

The TLS lane

tls/compose.yml is the standalone shape with the transport swapped. The plaintext port is turned off entirely (--port 0), which is the only configuration that proves anything: a lane accepting both would let a client that failed to negotiate TLS fall back silently and still pass.

Certificates are generated at start-up into a named volume rather than checked in — a private key in the repository is a private key in the repository, however the file is named — and they last a day, so a stale lane fails visibly instead of drifting.

REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/tls/compose.yml up -d --wait
# The client needs the generated CA; copy it out of the volume first.
docker compose -f infra/redis-sdk/tls/compose.yml cp redis:/tls/ca.crt /tmp/redis-lane-ca.pem
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest \
  -Predis.topology.host=127.0.0.1 -Predis.topology.port=6390 \
  -Predis.topology.mode=tls -Predis.topology.trust-material=/tmp/redis-lane-ca.pem

The lane refuses to run without redis.topology.trust-material. A TLS lane that trusts anything qualifies nothing, so "no CA configured" is an error rather than a client with verification off.

The ACL fixture

acl/lane-fixture-accounts.acl provisions the accounts every lane uses. Two things about it matter, and neither can be written in the file itself — Redis refuses to start if an aclfile contains a comment line, so the whole file is directives and the explanation lives here.

user default off is the first line and is deliberate. Redis ships default enabled and passwordless; while it is on, every restriction in the remaining accounts can be bypassed by simply not authenticating, which makes the fixture decorative. Disabling it is what forces a client — and the compose healthchecks — to pick a named account.

Every named account carries a real password — >fixture-application, >fixture-advanced, and so on. They were nopass, which was the more dangerous kind of wrong: an account that accepts any password made every assertion about authentication pass for the same reason a typo would have, so the lane's coverage of AUTH, rotation and secret wiring was indistinguishable from no coverage. LiveRedisCompositionTest now presents a wrong password on purpose and requires WRONGPASS, which is only a meaningful assertion because the accounts enforce one.

The passwords are fixture values in a throwaway container and are not a deployment template: a real deployment resolves each account's credential through secret:// and never writes one into configuration.

The accounts are also split by role, because that is how the SDK uses them. ca-skeleton-application runs ordinary data commands and cannot execute a script; ca-skeleton-application-advanced holds SCRIPT LOAD and EVALSHA and nothing else needs to. That separation is real rather than decorative: LiveRedisSemanticPortsTest runs the rate limiter without the advanced account and requires it to come back Unavailable.

Running one

Each lane has its own endpoint, because the address a client is given is not the same kind of thing in each topology. Standalone declares a data node; Sentinel declares a sentinel, from which the primary is resolved and re-resolved when it is promoted; Cluster declares any node, from which the rest of the topology is discovered.

# Standalone
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/standalone/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest :adapter:outbound:cache-redis:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=6379 -Predis.topology.mode=standalone

# Sentinel — the port is a sentinel, and the monitored primary has to be named
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/sentinel/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=27010 \
  -Predis.topology.mode=sentinel -Predis.topology.master=skeleton

# Cluster — `up --wait` waits for the `ready` gate, not just for six servers that answer PING.
# Slot assignment finishes after the nodes are healthy, and a client that connects in between sees
# CLUSTERDOWN for reasons that have nothing to do with the SDK.
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/cluster/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest :adapter:outbound:cache-redis:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=7100 -Predis.topology.mode=cluster

Each leaf owns the lanes its tests qualify, and names the classes each lane must run in its build.gradle (redisTopologyLane { requiredClasses ... }). Selecting a mode a leaf does not declare fails instead of running nothing, so run only the leaves listed for the lane:

Lane redis-runtime redis-sdk cache-redis
standalone LiveRedisCompositionTest RedisTopologyContractTest, LiveRedisGuardrailTest LiveRedisSemanticPortsTest, LiveRedisSemanticScriptAclProbeTest
sentinel LiveRedisCompositionTest RedisTopologyContractTest, LiveRedisSentinelPromotionTest —
cluster LiveRedisCompositionTest LiveRedisClusterTest, LiveRedisClusterTransactionTest LiveRedisSemanticPortsTest, LiveRedisSemanticScriptAclProbeTest
tls LiveRedisTlsTest — —

Tear a lane down with docker compose -f infra/redis-sdk/<lane>/compose.yml down -v.

Lane Ports Notes
standalone 6379 bridge network, published port
sentinel primary 7010, replica 7011, sentinels 27010–27012 host network
cluster nodes 7100–7105, bus 17100–17105 host network; ready gates on cluster_state:ok
tls 6390 published port, no plaintext port at all; CA generated per run

Why the Sentinel and Cluster lanes use host networking

Neither topology proxies. Sentinel answers SENTINEL get-master-addr-by-name with the address it monitors and the client dials that itself; a cluster client reads CLUSTER SHARDS and connects to every node it names. On a bridge network those are container-internal addresses, so a client on the host resolves a topology it cannot reach — and after a promotion it resolves a different one it also cannot reach. Sharing the host network namespace makes the address the topology advertises the address the client can use, which is the difference between testing the SDK and testing Docker's network.

That is also why their ports are fixed rather than parameterised: the addresses are written into Sentinel's and the cluster's own configuration at creation time, and a lane whose two halves can disagree fails for reasons that are not the SDK's.

Selection is by lane, not by hand

redisTopologyTest derives its JUnit tag expression from the declared mode: redis-topology & lane-<mode>. A promotion test is meaningless without sentinels and a cross-slot test is meaningless without a cluster, but expressing that as a runtime assumption would turn "the lane was never started" into a green skip. Selecting by tag keeps it fail-closed — what a mode cannot prove is not selected, and what is selected must pass.

The lane also fails closed on its endpoint: selecting redisTopologyTest without host, port, and mode (and redis.topology.master on the Sentinel lane) is an error, never a skip. A topology test that silently passes because it did not connect is worse than no topology test.

min-replicas-to-write on the Sentinel lane

The Sentinel lane sets min-replicas-to-write 1 and min-replicas-max-lag 1, and this is not incidental configuration. Without them the lane measured a promotion in which the superseded primary kept answering +OK for eleven seconds after it had been replaced: 2,086 writes acknowledged to the caller and then discarded, with exactly one command failing. With them the same promotion lost one write and refused 2,020 with NOREPLICAS, which the SDK reports as a definite, non-ambiguous failure a caller can act on.

Any deployment where an acknowledgement is supposed to mean something has to set these. See docs/redis/support-matrix.md for the full record.

ACL accounts

acl/ holds one file per CommandAccess level. They are deliberately narrower than the SDK's own rules, so a mistake in the SDK is still refused by the server — the account is the last boundary and a permit never widens it.

Every lane loads the same file on every data node. Accounts are enforced per node, so "they exist on one node" is not evidence that a topology enforces them.