Files
clean-architecture-backend-…/infra/redis-sdk/README.md
T
DongHyeonka bbe944bd3c fix!: 재리뷰가 찾은 결함과 색인에서 빠졌던 발견 5건을 고친다
문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가
Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다.
@SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히
prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고,
GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로
나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역
발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다.

방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를
먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이
기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록,
@SystemInvoked bean은 기동 실패, complete 단계 실패는
IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도
SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도
행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도
내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제
지표(redis.lane.*) 기준으로 고쳤다.

위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이
브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류
디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어
파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은
기동을 막는다. httpclient failure-injection lane의 main 단계 중복
실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다.

검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci
integrationCheck performanceCheck, :performanceCheck, :releaseCheck
(-PgitRevision), verify-compose-profile-contracts(18 lane) 통과.
첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event
id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다.

Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절
BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호
첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드
IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은
static·의존 없음이어야 한다.
2026-11-03 23:29:35 +09:00

9.6 KiB
Raw Blame History

Redis SDK topology lanes

These lanes exist to answer the questions the deterministic in-memory gateway cannot: how Lettuce actually behaves during a Sentinel promotion, what a Cluster resharding does to an in-flight command, and whether the ACL accounts grant exactly what the SDK issues.

All four have now run on Redis 7.4 and the evidence is recorded in docs/redis/support-matrix.md. .github/workflows/redis-sdk-topology.yml runs the standalone lane on any pull request that touches the Redis leaf, the full supported-version x topology matrix nightly, and the same matrix on demand for a release candidate.

TLS is a lane of that matrix rather than something to wire up by hand. It is tls, not a deployment mode: its shape is standalone and what it qualifies is the transport, so redisTopologyTest maps the lane name to standalone for the tests and keeps the tag filter and the required trust material on the lane.

The TLS lane

tls/compose.yml is the standalone shape with the transport swapped. The plaintext port is turned off entirely (--port 0), which is the only configuration that proves anything: a lane accepting both would let a client that failed to negotiate TLS fall back silently and still pass.

Certificates are generated at start-up into a named volume rather than checked in — a private key in the repository is a private key in the repository, however the file is named — and they last a day, so a stale lane fails visibly instead of drifting.

REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/tls/compose.yml up -d --wait
# The client needs the generated CA; copy it out of the volume first.
docker compose -f infra/redis-sdk/tls/compose.yml cp redis:/tls/ca.crt /tmp/redis-lane-ca.pem
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest \
  -Predis.topology.host=127.0.0.1 -Predis.topology.port=6390 \
  -Predis.topology.mode=tls -Predis.topology.trust-material=/tmp/redis-lane-ca.pem

The lane refuses to run without redis.topology.trust-material. A TLS lane that trusts anything qualifies nothing, so "no CA configured" is an error rather than a client with verification off.

The ACL fixture

acl/lane-fixture-accounts.acl provisions the accounts every lane uses. Two things about it matter, and neither can be written in the file itself — Redis refuses to start if an aclfile contains a comment line, so the whole file is directives and the explanation lives here.

user default off is the first line and is deliberate. Redis ships default enabled and passwordless; while it is on, every restriction in the remaining accounts can be bypassed by simply not authenticating, which makes the fixture decorative. Disabling it is what forces a client — and the compose healthchecks — to pick a named account.

Every named account carries a real password — >fixture-application, >fixture-advanced, and so on. They were nopass, which was the more dangerous kind of wrong: an account that accepts any password made every assertion about authentication pass for the same reason a typo would have, so the lane's coverage of AUTH, rotation and secret wiring was indistinguishable from no coverage. LiveRedisCompositionTest now presents a wrong password on purpose and requires WRONGPASS, which is only a meaningful assertion because the accounts enforce one.

The passwords are fixture values in a throwaway container and are not a deployment template: a real deployment resolves each account's credential through secret:// and never writes one into configuration.

The accounts are also split by role, because that is how the SDK uses them. ca-skeleton-application runs ordinary data commands and cannot execute a script; ca-skeleton-application-advanced holds SCRIPT LOAD and EVALSHA and nothing else needs to. That separation is real rather than decorative: LiveRedisSemanticPortsTest runs the rate limiter without the advanced account and requires it to come back Unavailable.

Running one

Each lane has its own endpoint, because the address a client is given is not the same kind of thing in each topology. Standalone declares a data node; Sentinel declares a sentinel, from which the primary is resolved and re-resolved when it is promoted; Cluster declares any node, from which the rest of the topology is discovered.

# Standalone
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/standalone/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest :adapter:outbound:cache-redis:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=6379 -Predis.topology.mode=standalone

# Sentinel — the port is a sentinel, and the monitored primary has to be named
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/sentinel/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=27010 \
  -Predis.topology.mode=sentinel -Predis.topology.master=skeleton

# Cluster — `up --wait` waits for the `ready` gate, not just for six servers that answer PING.
# Slot assignment finishes after the nodes are healthy, and a client that connects in between sees
# CLUSTERDOWN for reasons that have nothing to do with the SDK.
REDIS_VERSION=7.4 docker compose -f infra/redis-sdk/cluster/compose.yml up -d --wait
cd src && ./gradlew :adapter:outbound:redis-runtime:redisTopologyTest :adapter:outbound:redis-sdk:redisTopologyTest :adapter:outbound:cache-redis:redisTopologyTest \
  -Predis.topology.host=localhost -Predis.topology.port=7100 -Predis.topology.mode=cluster

Each leaf owns the lanes its tests qualify, and names the classes each lane must run in its build.gradle (redisTopologyLane { requiredClasses ... }). Selecting a mode a leaf does not declare fails instead of running nothing, so run only the leaves listed for the lane:

Lane redis-runtime redis-sdk cache-redis
standalone LiveRedisCompositionTest RedisTopologyContractTest, LiveRedisGuardrailTest LiveRedisSemanticPortsTest, LiveRedisSemanticScriptAclProbeTest
sentinel LiveRedisCompositionTest RedisTopologyContractTest, LiveRedisSentinelPromotionTest —
cluster LiveRedisCompositionTest LiveRedisClusterTest, LiveRedisClusterTransactionTest LiveRedisSemanticPortsTest, LiveRedisSemanticScriptAclProbeTest
tls LiveRedisTlsTest — —

Tear a lane down with docker compose -f infra/redis-sdk/<lane>/compose.yml down -v.

Lane Ports Notes
standalone 6379 bridge network, published port
sentinel primary 7010, replica 7011, sentinels 27010–27012 host network
cluster nodes 7100–7105, bus 17100–17105 host network; ready gates on cluster_state:ok
tls 6390 published port, no plaintext port at all; CA generated per run

Why the Sentinel and Cluster lanes use host networking

Neither topology proxies. Sentinel answers SENTINEL get-master-addr-by-name with the address it monitors and the client dials that itself; a cluster client reads CLUSTER SHARDS and connects to every node it names. On a bridge network those are container-internal addresses, so a client on the host resolves a topology it cannot reach — and after a promotion it resolves a different one it also cannot reach. Sharing the host network namespace makes the address the topology advertises the address the client can use, which is the difference between testing the SDK and testing Docker's network.

That is also why their ports are fixed rather than parameterised: the addresses are written into Sentinel's and the cluster's own configuration at creation time, and a lane whose two halves can disagree fails for reasons that are not the SDK's.

Selection is by lane, not by hand

redisTopologyTest derives its JUnit tag expression from the declared mode: redis-topology & lane-<mode>. A promotion test is meaningless without sentinels and a cross-slot test is meaningless without a cluster, but expressing that as a runtime assumption would turn "the lane was never started" into a green skip. Selecting by tag keeps it fail-closed — what a mode cannot prove is not selected, and what is selected must pass.

The lane also fails closed on its endpoint: selecting redisTopologyTest without host, port, and mode (and redis.topology.master on the Sentinel lane) is an error, never a skip. A topology test that silently passes because it did not connect is worse than no topology test.

min-replicas-to-write on the Sentinel lane

The Sentinel lane sets min-replicas-to-write 1 and min-replicas-max-lag 1, and this is not incidental configuration. Without them the lane measured a promotion in which the superseded primary kept answering +OK for eleven seconds after it had been replaced: 2,086 writes acknowledged to the caller and then discarded, with exactly one command failing. With them the same promotion lost one write and refused 2,020 with NOREPLICAS, which the SDK reports as a definite, non-ambiguous failure a caller can act on.

Any deployment where an acknowledgement is supposed to mean something has to set these. See docs/redis/support-matrix.md for the full record.

ACL accounts

acl/ holds one file per CommandAccess level. They are deliberately narrower than the SDK's own rules, so a mistake in the SDK is still refused by the server — the account is the last boundary and a permit never widens it.

Every lane loads the same file on every data node. Accounts are enforced per node, so "they exist on one node" is not evidence that a topology enforces them.