문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가 Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다. @SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히 prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고, GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로 나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역 발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다. 방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를 먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이 기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록, @SystemInvoked bean은 기동 실패, complete 단계 실패는 IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도 SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도 행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도 내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제 지표(redis.lane.*) 기준으로 고쳤다. 위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이 브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류 디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어 파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은 기동을 막는다. httpclient failure-injection lane의 main 단계 중복 실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다. 검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci integrationCheck performanceCheck, :performanceCheck, :releaseCheck (-PgitRevision), verify-compose-profile-contracts(18 lane) 통과. 첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다. Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절 BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호 첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드 IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은 static·의존 없음이어야 한다.
135 lines
5.3 KiB
YAML
135 lines
5.3 KiB
YAML
# Cluster lane. Six nodes: three primaries so cross-slot behaviour is observable at all, and three
|
|
# replicas so a promotion can be forced without losing a shard.
|
|
#
|
|
# Host networking for the same reason as the Sentinel lane, and a sharper one. A cluster client does
|
|
# not talk to one address: it reads `CLUSTER SHARDS`, learns every node's address, and connects to
|
|
# each of them itself. On a bridge those addresses are container-internal, so a client on the host
|
|
# resolves a topology it cannot dial and every redirect points somewhere unreachable. Sharing the
|
|
# host network namespace makes the addresses the cluster advertises the addresses the client can
|
|
# use, which is the difference between testing the SDK and testing Docker's network.
|
|
#
|
|
# Ports are fixed because they are written into the cluster's own configuration at creation time:
|
|
# the node identity a redirect names has to be an address the client can dial.
|
|
#
|
|
# nodes 7100..7105 · cluster bus 17100..17105
|
|
#
|
|
# The ACL file is loaded on every node. The accounts are the deployment's last enforcement boundary
|
|
# and a cluster enforces them per node, so "they exist on one node" is not evidence.
|
|
#
|
|
# min-replicas-to-write is set here for the same reason as on the Sentinel lane. A cluster promotes
|
|
# a replica without asking the client too, so a superseded primary keeps acknowledging writes it
|
|
# will discard on resync — the Sentinel lane measured 2,086 of them in one eleven-second window.
|
|
# Nothing about slot ownership changes that, and this lane was written without the setting at first
|
|
# precisely because the failure mode is easy to think of as Sentinel-specific. It is not.
|
|
x-node: &node
|
|
image: "redis:${REDIS_VERSION:-7.4}"
|
|
network_mode: host
|
|
volumes:
|
|
- ../acl:/etc/redis/acl:ro
|
|
entrypoint:
|
|
- /bin/sh
|
|
- -c
|
|
- |
|
|
exec redis-server \
|
|
--port $$NODE_PORT \
|
|
--cluster-enabled yes \
|
|
--cluster-config-file /tmp/nodes.conf \
|
|
--cluster-node-timeout 2000 \
|
|
--cluster-announce-ip 127.0.0.1 \
|
|
--appendonly no \
|
|
--save '' \
|
|
--min-replicas-to-write 1 \
|
|
--min-replicas-max-lag 1 \
|
|
--masteruser ca-skeleton-replication \
|
|
--masterauth fixture-replication \
|
|
--aclfile /etc/redis/acl/lane-fixture-accounts.acl
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "[ \"$$(redis-cli -p $$NODE_PORT --user ca-skeleton-application --pass fixture-application --no-auth-warning ping)\" = PONG ]"]
|
|
interval: 2s
|
|
timeout: 2s
|
|
retries: 15
|
|
|
|
services:
|
|
node-1:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7100"
|
|
|
|
node-2:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7101"
|
|
|
|
node-3:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7102"
|
|
|
|
node-4:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7103"
|
|
|
|
node-5:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7104"
|
|
|
|
node-6:
|
|
<<: *node
|
|
environment:
|
|
NODE_PORT: "7105"
|
|
|
|
# The cluster is created after every node reports healthy, and the lane is not "up" until every
|
|
# slot is covered. A test that starts before slot assignment finishes sees MOVED and CLUSTERDOWN
|
|
# for reasons that have nothing to do with the SDK.
|
|
init:
|
|
image: "redis:${REDIS_VERSION:-7.4}"
|
|
network_mode: host
|
|
depends_on:
|
|
node-1: {condition: service_healthy}
|
|
node-2: {condition: service_healthy}
|
|
node-3: {condition: service_healthy}
|
|
node-4: {condition: service_healthy}
|
|
node-5: {condition: service_healthy}
|
|
node-6: {condition: service_healthy}
|
|
entrypoint:
|
|
- /bin/sh
|
|
- -c
|
|
- |
|
|
redis-cli --user ca-skeleton-cluster-bootstrap --pass fixture-bootstrap --no-auth-warning \
|
|
--cluster create \
|
|
127.0.0.1:7100 127.0.0.1:7101 127.0.0.1:7102 \
|
|
127.0.0.1:7103 127.0.0.1:7104 127.0.0.1:7105 \
|
|
--cluster-replicas 1 --cluster-yes
|
|
# Authenticated, like every other command against this fixture. The `default` user is off,
|
|
# so an unauthenticated CLUSTER INFO answers NOAUTH — which never matches, so this loop
|
|
# never ended, the helper never exited, and `up --wait` returned on the nodes' own health
|
|
# while slot assignment was still in flight. A lane that reports ready before it can serve
|
|
# a key produces failures that look like SDK defects and are not.
|
|
until redis-cli -p 7100 \
|
|
--user ca-skeleton-cluster-bootstrap --pass fixture-bootstrap --no-auth-warning \
|
|
cluster info | grep -q 'cluster_state:ok'; do sleep 1; done
|
|
echo "cluster ready"
|
|
|
|
# `up --wait` returns when every service is running or healthy, and a one-shot helper is neither
|
|
# for as long as it runs — so the wait ended while slots were still being assigned, and whichever
|
|
# test connected first saw a cluster that could not serve its keys. This gate is a service the
|
|
# wait can see: it cannot become healthy until the cluster reports a fully covered keyspace.
|
|
ready:
|
|
image: "redis:${REDIS_VERSION:-7.4}"
|
|
network_mode: host
|
|
depends_on:
|
|
init: {condition: service_completed_successfully}
|
|
command: ["sleep", "infinity"]
|
|
healthcheck:
|
|
test:
|
|
- CMD-SHELL
|
|
- >-
|
|
[ "$$(redis-cli -p 7100 --user ca-skeleton-cluster-bootstrap
|
|
--pass fixture-bootstrap --no-auth-warning cluster info
|
|
| tr -d '\r' | grep -c '^cluster_state:ok$$')" = 1 ]
|
|
interval: 1s
|
|
timeout: 3s
|
|
retries: 60
|