문제: 성숙도 리뷰 수정을 다시 읽은 재리뷰(Critical 0, 회귀 0)가 Important 27건·Minor 41건을 찾았다. 수정이 새로 만든 결함이 많았다. @SystemInvoked가 권한 규칙의 탈출구가 됐고, 데모 계정 거부가 정확히 prod일 때만 걸렸고, outbox 순서 번호가 업그레이드 때 뒤로 갔고, GraphQL union 아래 복잡도가 0이었고, 서블릿 오류 응답이 success:true로 나갔고, 호출자 deadline이 breaker를 열었다. 원래 리뷰 색인이 06 영역 발견 5건(06-10~14)을 빠뜨려 그동안 처리되지 않았다. 방법: 영역별 7묶음이 test-driven-development 절차로 실패 테스트를 먼저 쓰고 고쳤다. 결정은 재리뷰 README 4절에 적었다: 순서 번호는 V21이 기록한 전역 floor부터, 데모 계정은 local·test·demo 허용 목록, @SystemInvoked bean은 기동 실패, complete 단계 실패는 IDEMPOTENCY_COMPLETION_UNKNOWN(결과 불명), 캐시 조건부 쓰기는 별도 SCRIPT lane, strict lane 정책은 build cache 입력, 끝나지 않는 재시도 행은 원인 코드·지표·PARKED 절차. 레지스트리가 선언만 하고 아무 코드도 내보내지 않던 redis.capability.* 지표 6개는 빼고 runbook을 실제 지표(redis.lane.*) 기준으로 고쳤다. 위험·한계: V21을 V22 없이 직접 고쳤다(어느 배포에도 아직 없음). 이 브랜치의 V21을 적용한 개발 DB는 다시 만들어야 한다. 서블릿 오류 디스패치를 보안 체인이 허용한다. 발행·저장소 포트 시그니처가 바뀌어 파생 서비스 코드가 깨진다. prod에서 fixture-로 시작하는 설정값은 기동을 막는다. httpclient failure-injection lane의 main 단계 중복 실행은 이전 결정대로 남겼다. 실제 CI runner 실행은 확인하지 못했다. 검증: ci, mainCheck, :integrationCheck, -p optional-platforms ci integrationCheck performanceCheck, :performanceCheck, :releaseCheck (-PgitRevision), verify-compose-profile-contracts(18 lane) 통과. 첫 실행의 실패 2건(FindSecBugs 1, sample 동시 생성 테스트의 v4 event id)은 고친 뒤 ci·integrationCheck·mainCheck를 다시 돌려 통과했다. Refs: docs/reviews/2026-11-03-rereview/README.md 3·4·6·7절 BREAKING CHANGE: outbox 발행 포트와 저장소 포트 시그니처, 순서 번호 첫 값(V21 floor 다음), 샘플 데모 계정 프로필 허용 목록, 새 오류 코드 IDEMPOTENCY_COMPLETION_UNKNOWN, prod의 fixture- 값 거부, 기동 rule은 static·의존 없음이어야 한다.
127 lines
5.0 KiB
YAML
127 lines
5.0 KiB
YAML
# Sentinel lane. Three sentinels because a two-sentinel quorum cannot survive losing one, and a
|
|
# failover test that cannot lose a sentinel is not testing failover.
|
|
#
|
|
# Host networking, not a bridge with published ports. Sentinel does not proxy: it answers
|
|
# `SENTINEL get-master-addr-by-name` with the address it monitors, and the client then connects
|
|
# there itself. On a bridge that address is the container's internal IP, which the client on the
|
|
# host cannot reach, so the lane would resolve a primary it can never talk to — and after a
|
|
# promotion it would resolve a different unreachable one. Sharing the host network namespace makes
|
|
# the address Sentinel hands out the same address the client can dial, which is the only thing that
|
|
# makes the promotion observable from outside.
|
|
#
|
|
# Ports are fixed rather than parameterised because Sentinel stores them in its own config: the
|
|
# monitored address has to match what the client is told, and a lane whose two halves can disagree
|
|
# is a lane that fails for reasons that are not the SDK's.
|
|
#
|
|
# primary 7010 · replica 7011 · sentinels 27010 27011 27012
|
|
#
|
|
# The ACL file is loaded on both data nodes. The accounts are the deployment's last enforcement
|
|
# boundary, so "they exist in standalone" is not evidence that they exist in the topology that will
|
|
# actually be run in production.
|
|
#
|
|
# Both data nodes take their entire configuration from one definition, and that is load-bearing
|
|
# rather than tidiness. These two nodes swap roles on every failover, so a setting written only into
|
|
# the one that happens to start as primary silently stops applying the moment the lane does the
|
|
# thing it exists to do. The lane learned this the hard way: min-replicas-to-write was set on the
|
|
# primary only, the first promotion passed, and the second promotion — now writing to the node that
|
|
# never had the setting — discarded 2,099 acknowledged writes.
|
|
x-data-node: &data-node
|
|
image: "redis:${REDIS_VERSION:-7.4}"
|
|
network_mode: host
|
|
volumes:
|
|
- ../acl:/etc/redis/acl:ro
|
|
entrypoint:
|
|
- /bin/sh
|
|
- -c
|
|
# REPLICA_OF is deliberately unquoted: it is either empty or a two-word --replicaof argument.
|
|
#
|
|
# min-replicas-to-write is what stops a superseded primary from acknowledging writes it cannot
|
|
# keep. Without it a promotion silently destroys them — measured here at eleven seconds and two
|
|
# thousand confirmed-then-discarded writes — because Sentinel does not demote the old primary
|
|
# until well after it has promoted the new one. Requiring an in-sync replica turns that window
|
|
# into an explicit NOREPLICAS refusal the caller can see and act on. Any deployment where an
|
|
# acknowledgement is supposed to mean something has to set these.
|
|
- |
|
|
exec redis-server \
|
|
--port $$NODE_PORT \
|
|
$$REPLICA_OF \
|
|
--appendonly no \
|
|
--save '' \
|
|
--min-replicas-to-write 1 \
|
|
--min-replicas-max-lag 1 \
|
|
--masteruser ca-skeleton-replication \
|
|
--masterauth fixture-replication \
|
|
--aclfile /etc/redis/acl/lane-fixture-accounts.acl
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "[ \"$$(redis-cli -p $$NODE_PORT --user ca-skeleton-application --pass fixture-application --no-auth-warning ping)\" = PONG ]"]
|
|
interval: 2s
|
|
timeout: 2s
|
|
retries: 15
|
|
|
|
services:
|
|
primary:
|
|
<<: *data-node
|
|
environment:
|
|
NODE_PORT: "7010"
|
|
REPLICA_OF: ""
|
|
|
|
replica:
|
|
<<: *data-node
|
|
environment:
|
|
NODE_PORT: "7011"
|
|
REPLICA_OF: "--replicaof 127.0.0.1 7010"
|
|
depends_on:
|
|
primary:
|
|
condition: service_healthy
|
|
|
|
sentinel-1: &sentinel
|
|
image: "redis:${REDIS_VERSION:-7.4}"
|
|
network_mode: host
|
|
# The config is written at start-up rather than mounted because Sentinel rewrites its own file
|
|
# when it promotes. A read-only mount would make the first failover fail on a write error, and
|
|
# a shared writable mount would have three sentinels rewriting one file.
|
|
entrypoint:
|
|
- /bin/sh
|
|
- -c
|
|
- |
|
|
cat > /tmp/sentinel.conf <<CONF
|
|
port $$SENTINEL_PORT
|
|
sentinel monitor skeleton 127.0.0.1 7010 2
|
|
sentinel auth-user skeleton ca-skeleton-sentinel
|
|
sentinel auth-pass skeleton fixture-sentinel
|
|
sentinel down-after-milliseconds skeleton 2000
|
|
sentinel failover-timeout skeleton 10000
|
|
sentinel parallel-syncs skeleton 1
|
|
CONF
|
|
exec redis-sentinel /tmp/sentinel.conf
|
|
environment:
|
|
SENTINEL_PORT: "27010"
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "[ \"$$(redis-cli -p 27010 ping)\" = PONG ]"]
|
|
interval: 2s
|
|
timeout: 2s
|
|
retries: 15
|
|
depends_on:
|
|
primary:
|
|
condition: service_healthy
|
|
|
|
sentinel-2:
|
|
<<: *sentinel
|
|
environment:
|
|
SENTINEL_PORT: "27011"
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "[ \"$$(redis-cli -p 27011 ping)\" = PONG ]"]
|
|
interval: 2s
|
|
timeout: 2s
|
|
retries: 15
|
|
|
|
sentinel-3:
|
|
<<: *sentinel
|
|
environment:
|
|
SENTINEL_PORT: "27012"
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "[ \"$$(redis-cli -p 27012 ping)\" = PONG ]"]
|
|
interval: 2s
|
|
timeout: 2s
|
|
retries: 15
|