문제: 2026-11-01 성숙도 리뷰에서 High 21건·P1 25건이 나왔다. 결과를 모르는 일을 "확실함"으로 기록했다(발송 중 죽은 알림 재발송, 커밋 중 끊긴 쓰기를 재시도 가능으로 응답, 재시도 가능한 거부를 DEAD로). 중복을 DB가 아니라 코드 순서로 막았다(정산 job, 포스터 제목). 짝 프론트와 wire 계약이 달랐고(처리 중 409, Envelope null), JWT audience 검증이 기본으로 꺼져 있었고, 트레이스가 나가지 않았고, CI가 strict lane 14개를 한 번도 돌리지 않았다. 방법: 발견마다 실패하는 테스트를 먼저 쓰고 고쳤다. 주요 선택: - 알림 attempt는 처음부터 "시작 여부 모름"으로 쓴다(호출 직전 갱신은 쓰기가 하나 늘어 버림). - 정산 job claim은 lease·fence를 갱신하는 UPDATE 한 문장(처리 전체를 트랜잭션으로 감싸는 안은 외부 호출 동안 잠금을 잡아 버림). - 커밋 단계 연결 끊김은 DB_COMPLETION_UNKNOWN(재시도 불가). - 처리 중 409는 retryable=true + Retry-After: 2, Envelope null 필드는 web Jackson mixin으로 생략(shared-contract는 stdlib only). - 트레이싱은 자체 Tracer를 지우고 Boot 4 tracing·OTLP로. - strict lane을 단계에 연결하고 verifyStrictLaneStages가 고아를 막는다. 발견별 RED·GREEN·버린 대안은 리뷰 README 13절 표에 있다. 위험·한계: JWT 모드는 APP_SECURITY_JWT_AUDIENCE가 없으면 기동하지 않는다. 짝 프론트는 409 retryable과 Envelope 키 규칙을 맞춰야 한다. 이 커밋 시점에는 MinIO 공식 이미지가 사라져 MinIO 2 lane이 실패한다 (다음 커밋에서 대체 이미지로 해결). 검증: ci 통과. mainCheck·integrationCheck는 MinIO 2 lane만 실패(이미지 pull 거부). -p optional-platforms ci integrationCheck, performanceCheck, releaseCheck(-PgitRevision) 통과. Refs: docs/reviews/2026-11-01-maturity-review/README.md 2·13절 BREAKING CHANGE: JWT 모드에서 APP_SECURITY_JWT_AUDIENCE가 필수가 되고 role은 audience client와 realm 것만 읽는다. IDEMPOTENT_IN_FLIGHT가 retryable=true, Retry-After: 2로 바뀌고 Envelope는 null 필드를 보내지 않는다.
145 lines
6.6 KiB
YAML
145 lines
6.6 KiB
YAML
name: ci-quality-gates
|
|
|
|
# The pull-request gate. Everything here blocks a merge.
|
|
#
|
|
# The job list used to include `gate-matrix-lint`, which ran .github/scripts/verify-gate-matrix.sh
|
|
# against .github/ci-gate-matrix.yml: a 1,025-line register of all 107 CI controls, checked for
|
|
# consistency against the Gradle task graph and this workflow by a 568-line shell script, which was
|
|
# itself checked by contract tests in :app-bootstrap. Adding one check meant editing Gradle, a
|
|
# workflow, the matrix, the verifier's expectations and a Java test. The information was already in
|
|
# the task graph and the job graph; the matrix was a third copy that had to be kept equal to both.
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches: ["main"]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
TESTCONTAINERS_REUSE_ENABLE: "false"
|
|
|
|
jobs:
|
|
quality-gates:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Export the live Gradle verification task map
|
|
working-directory: src
|
|
run: ./gradlew tasks --group verification --console=plain > ../verification-tasks.txt
|
|
- name: Upload the Gradle verification task map
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # actions/upload-artifact@v7.0.1
|
|
with:
|
|
name: gradle-verification-task-map
|
|
path: verification-tasks.txt
|
|
if-no-files-found: error
|
|
# `ci`, not `check`. A leaf's `check` is that leaf's — compile, its tests, Spotless, Checkstyle
|
|
# and Error Prone — and the repository-wide gates are named tasks of their own:
|
|
# ci = every leaf check + architectureCheck + qualityCheck
|
|
# A leaf's `check` includes its API surface verification (owner decision 20). The main-branch
|
|
# stage (`mainCheck`: environment contract, full-boot qualification, public-path baseline,
|
|
# transport and messaging lanes, document-contract lanes) runs in integration-main.yml.
|
|
- name: Run the pull-request gate
|
|
working-directory: src
|
|
run: ./gradlew :ci :verifyDependencyLocks --warning-mode=fail --stacktrace
|
|
# Plans every stage (`--dry-run`: nothing executes) and fails when a strict lane is in no stage
|
|
# a workflow executes, or a stage is executed by no workflow (review 2026-11-01 08-01). A new
|
|
# lane fails here, on its own pull request, instead of running nowhere after it merges.
|
|
- name: Require every strict lane to be in an executed stage
|
|
working-directory: src
|
|
run: ./gradlew :verifyStrictLaneStages --dry-run --stacktrace
|
|
- name: Verify Compose profile contracts render exactly as declared
|
|
run: bash scripts/verify-compose-profile-contracts.sh
|
|
|
|
sample-portfolio:
|
|
# The sample is excluded from production architecture/runtime membership policy, but it is still
|
|
# the reference implementation adopters copy. Compile/test/OpenAPI drift must therefore block PRs.
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Verify the standalone sample application
|
|
working-directory: src
|
|
run: ./gradlew :sample-portfolio:check --stacktrace
|
|
|
|
optional-platforms:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Verify the optional gRPC platform build
|
|
working-directory: src
|
|
run: ./gradlew -p optional-platforms ci --stacktrace
|
|
|
|
# gRPC schema policy (owner decision 18). protoc compiles src/grpc/grpc-contract inside the
|
|
# optional-platforms build above; lint and breaking-change policy belong to Buf, configured by
|
|
# buf.yaml next to the schema. Buf is a native binary rather than a Maven artifact, so it runs here
|
|
# and not inside Gradle — and nothing in the repository re-implements its rules.
|
|
grpc-proto-buf:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
with:
|
|
# buf breaking reads the baseline schema from Git history.
|
|
fetch-depth: 0
|
|
- uses: bufbuild/buf-action@85aebf73123b5c15fd5528aaecbf9129cddf7fa7 # bufbuild/buf-action@v1.6.0
|
|
with:
|
|
version: 1.73.0
|
|
setup_only: true
|
|
- name: Lint the gRPC schema
|
|
working-directory: src/grpc/grpc-contract
|
|
run: buf lint
|
|
- name: Refuse a breaking change to the gRPC schema
|
|
working-directory: src/grpc/grpc-contract
|
|
env:
|
|
# Pull request: the target branch. Push: the commit this push replaced.
|
|
BASELINE: ${{ github.event_name == 'pull_request' && format('origin/{0}', github.base_ref) || github.event.before }}
|
|
run: |
|
|
set -euo pipefail
|
|
baseline_commit="$(git rev-parse --verify --quiet "${BASELINE}^{commit}" || true)"
|
|
if [[ -z "${baseline_commit}" ]] \
|
|
|| ! git cat-file -e "${baseline_commit}:src/grpc/grpc-contract/buf.yaml" 2>/dev/null; then
|
|
# The first change that introduces the module has nothing to be compatible with.
|
|
echo "::notice::grpc-proto-buf: baseline ${BASELINE} has no src/grpc/grpc-contract/buf.yaml; breaking check skipped."
|
|
exit 0
|
|
fi
|
|
buf breaking --against "../../../.git#ref=${baseline_commit},subdir=src/grpc/grpc-contract"
|
|
|
|
release-gate:
|
|
needs:
|
|
- quality-gates
|
|
- sample-portfolio
|
|
- optional-platforms
|
|
- grpc-proto-buf
|
|
if: always()
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Require every current blocking job to succeed
|
|
env:
|
|
QUALITY_RESULT: ${{ needs.quality-gates.result }}
|
|
SAMPLE_RESULT: ${{ needs.sample-portfolio.result }}
|
|
OPTIONAL_PLATFORMS_RESULT: ${{ needs.optional-platforms.result }}
|
|
GRPC_PROTO_BUF_RESULT: ${{ needs.grpc-proto-buf.result }}
|
|
run: |
|
|
set -euo pipefail
|
|
for result in \
|
|
"${QUALITY_RESULT}" \
|
|
"${SAMPLE_RESULT}" \
|
|
"${OPTIONAL_PLATFORMS_RESULT}" \
|
|
"${GRPC_PROTO_BUF_RESULT}"; do
|
|
if [[ "${result}" != "success" ]]; then
|
|
echo "::error::release-gate: required job result was ${result}"
|
|
exit 1
|
|
fi
|
|
done
|
|
echo "release-gate: all current blocking quality jobs succeeded."
|