Files
clean-architecture-backend-…/CLAUDE.md
T
DongHyeonka 6e992970ca fix!: r9 확인 리뷰가 찾은 결함 25건을 고친다
문제: r9 커밋(45d2a478)을 영역 4개로 다시 리뷰해 결함 25건을 찾았다
(Important 2, Minor 23, round6/01~04). Important 둘: r9가 @Configuration을
사용자 전송에서 통째로 빼서 설정 안의 RouterFunction·DataFetcher가
@SystemCaller를 불러도 잡히지 않는 회귀, 그리고 가이드대로 만든
CREATE INDEX CONCURRENTLY 마이그레이션이 Flyway 기본 트랜잭션 잠금과 서로
기다려 끝나지 않는 것(이전부터). 그 밖에 시작을 거절당한 같은 attempt가
기록 만료까지 503을 받는 것, gRPC 취소 판정과 raw status 설명의 로그 유출,
STOMP의 IAE ERROR 기록, 아무것도 잡지 못하던 shared-contract 패키지 규칙,
workflow 판독기의 거짓 통과 모양(-v·조건부 exit·Windows 기본 셸·요청형
trigger 등).

방법: 영역별 4묶음이 실패 테스트를 먼저 확인하고 고쳤다(재리뷰 README 17절).
- 설정과 그 중첩 클래스는 요청 처리기 타입에 의존하면 사용자 전송으로 센다.
- Flyway PostgreSQL 잠금을 세션 수준으로(transactional-lock=false), 직접
  만드는 Flyway는 FlywaySchemaPolicy 하나로. 버린 대안: CIC를 마이그레이션에서
  금지하고 운영 절차로.
- 같은 attempt로 다시 claim하면 lease가 지난 claim을 넘겨받는다. 옛 revision의
  늦은 시작이 ALREADY를 받아 이중 실행되던 것도 막았다.
- 네 전송이 IAE를 ServerFailureLog의 같은 WARN 한 줄로 남긴다.
- workflow 판독기가 세지 않는 이유를 셋으로 나누고 문서 5곳을 같은 말로.

위험·한계: Flyway 세션 잠금은 transaction-mode PgBouncer 뒤에서 깨진다
(Hikari 직접 연결 전제, 가이드에 적음). 배포 마이그레이션 도구도 같은 값을
써야 한다(업그레이드 안내). 같은 attempt를 두 호출이 동시에 쓰는 것은
저장소가 가려내지 않는다(호출자 계약으로 문서화).

검증: 묶음별 RED·GREEN은 로컬(노트북 빌드 금지 지시 전)에서, 지시 뒤에
바뀐 01 A5 fixture의 RED와 02 늦은 시작 revision 검사의 RED, 03 동시 인덱스
검사기 GREEN은 desktop에서 확인했다. 합친 트리를 desktop에서 돌려 모두 첫
실행 통과: :ci :verifyDependencyLocks --warning-mode=fail, sample check,
두 빌드 verifyStrictLaneStages --dry-run, :mainCheck, :integrationCheck,
-p optional-platforms ci integrationCheck performanceCheck, :performanceCheck,
:releaseCheck, compose 18 lane, -p build-logic check javadoc(README 17.2절).

Refs: docs/reviews/2026-11-03-rereview/README.md 17절
BREAKING CHANGE: Flyway PostgreSQL 잠금이 세션 수준이 되어 배포 도구에도
flyway.postgresql.transactional.lock=false가 필요하다. GraphQL·gRPC가 IAE를
WARN 한 줄로 남긴다. shared-contract 패키지 규칙이 실제로 검사한다.
2026-11-05 21:26:50 +09:00

12 KiB
Raw Blame History

CLAUDE.md

Repository guidance for the Java 21 + Spring Boot 4.0.8 Clean Architecture template.

Prime Directive

Preserve architecture before optimizing for speed. The following seven HARD-STOP conditions are a synchronized summary of the canonical local policy in AGENTS.md:

  1. domain-core gains framework, transport, database, or cloud dependencies.
  2. A controller directly uses a repository, Spring Data interface, or persistence entity.
  3. An inbound DTO leaks into application-core or domain-core.
  4. Business rules move into mappers, filters, configuration, settings, or controllers.
  5. Project dependencies violate src/config/architecture/modules.json or the Gradle dependency gate.
  6. Completion is claimed without the relevant verification or a named reason it could not run.
  7. A repository/corpus conclusion is made without evidence proportional to its scope and risk.

If this summary drifts from AGENTS.md, AGENTS.md wins and this summary must be resynchronized.

Gradle policy authorities

  • src/config/architecture/modules.json: every registered leaf identity, repository-relative source paths, Gradle paths and allowed production project dependency edges. There is no runtime membership list: what a composition root may take is its allowed_dependencies, and the direction gate refuses any other edge. The registry owns the leaf list and its size; no document restates the count, because a number written in prose drifts the moment a leaf is added.
  • src/settings.gradle: fail-closed registry validation, project inclusion, and directory mapping.
  • src/build-logic/: the architecture core (registry, direction and purity tasks), the conventions, and one test-lane mechanism (strictTestLanes). Feature-specific checks are the owning leaf's tests; a test that reads repository files declares them as that leaf's test inputs, and a test that compares a leaf with repository documents is a mainStage() lane (tag document-contract) in that leaf's mainCheck; a merge-blocking contract over non-document repository files is a pull-request lane whose inputs are exactly those files (app-bootstrap repository-contract). TEST/ARCHITECTURE lanes are cacheable; INTEGRATION/SYSTEM/PERFORMANCE and main-stage lanes rerun every time.
  • verifyEnvKeys stays an app-bootstrap task (owner decision 4); its implementation is build-logic's ca.config-contract. The src/build-tools/ included build was emptied and removed.
  • src/build.gradle: the root lifecycle (ci, mainCheck, integrationCheck, performanceCheck, releaseCheck and the named repository-wide gates). verifyStrictLaneStages --dry-run (pull request; the main build and, as -p optional-platforms, the optional build each run their own) fails when a non-explicitOnly strict lane is in no stage a workflow executes — a lane the command removes with -x (abbreviations matched as Gradle does) is not covered; a command after which Gradle runs no task (--dry-run, -v, --help, --status, --stop, …, bundles such as -qm included), a short-option bundle Gradle rejects (-mx) and a command for another build do not count, nor does one that does not gate for one of three reasons: (1) its failure may not fail its step (an || other than || exit <non-zero>, a pipe without pipefail, an if condition, after set +e or an exit 0 trap, continue-on-error, …); (2) it may not run (inside if/for/case or a function, after a top-level or conditional exit 0, exec or set -n, under a non-status if:, in a workflow only a request starts or a workflow_call one no counted job calls, in a job that needs a conditional job, …); (3) the check does not read it although its failure would fail the step (|| exit 1, inside { }, ( ), $( ) or bash -c, after a cd it cannot follow, a shell: other than bash or sh, a runner that may be Windows with its pwsh default, …) — the failure names each command's reason and says to put the stage command on a line of its own; the build a command runs is its working-directory, then the cd <relative path> the same shell surely ran before it, joined with -p — or a folded workflow run: block splits an option off its command.

Commit policy is human-only: agents do not stage, commit, amend, or push implementation changes.

Proportional workflow

  • Low risk: work in the owning leaf, follow its nearest guidance, and run the focused check.
  • Medium risk: use the relevant Superpowers design, planning, TDD, debugging, and review workflows in proportion to the affected boundaries.
  • High risk: make architecture and behavior decisions explicit, use staged architecture/spec/quality review, and run architecture-wide verification authorized by the task.

Risk comes from change surface and runtime, security, data, or public-contract impact, not file count.

Module families

src/config/architecture/modules.json owns the complete leaf list. Root guidance summarizes families; the nearest src/**/CLAUDE.md owns local rules. No task enforces this any more: verifyDocumentedLeafCount was deleted along with the other documentation-drift parsers. A stated count that disagrees with the registry is a defect, not a build failure — so do not state one.

Family Responsibility Stable dependency direction
domain-core Pure domain model, invariants, events, ports Java stdlib and registered value-only contracts
application-core Commands, use cases, application policies, transaction ports domain-core, shared-contract
adapter:inbound:* HTTP, gRPC, GraphQL, WebSocket transport boundaries application/domain/shared contracts
adapter:outbound:persistence-* JPA/PostgreSQL and MongoDB persistence adapters application/domain/shared contracts as registered
adapter:outbound:* support, messaging, cache, notification, storage, file, HTTP client, identifier capabilities application/domain/shared and registered support edge
shared-contract Skeleton-wide operational contracts Java stdlib only
messaging:* Vendored messaging platform: a product with its own API, SPI, adapters and composition boundary, not a layer of this application messaging:* only — it depends on no domain-core, application-core, or shared-contract type
sample-portfolio Fixture/reference consumer registered runtime leaves; never a production dependency
app-bootstrap Spring Boot entrypoint and composition root registered runtime leaves

The messaging:* family is the one entry that is not a Clean Architecture layer, and it is listed so that the exception is stated rather than inferred from a directory. It is a vendored library — its own *-api leaves are its ports, its broker leaves are its adapters, its starter is its composition root — and the messaging module review (docs/reviews/2026-08-14-messaging-module-code-review.md MSG-023 §6.2) chose that layout deliberately over folding it into adapter:outbound:*. This application reaches it through the application-owned anti-corruption bridge in adapter:outbound:messaging (MSG-015). The canonical bridge is the only path: the legacy outbox append port and the legacy Kafka publishing seam were deleted (owner decision 7).

Never infer an individual leaf's Gradle path, allowed dependency, or test command from this table. Read its gradle_path and allowed_dependencies from src/config/architecture/modules.json; runtime composition is established by actual Gradle dependencies/auto-configuration, not a registry runtime_memberships field that does not exist.

Layer workflow

For a full use case, work in this order:

domain-core
  -> application-core
  -> adapter:outbound:* (or persistence/identifier)
  -> adapter:inbound:*
  -> app-bootstrap wiring

Layer-only work stays inside that registered leaf plus its tests. If a required fix crosses a layer or writable scope, stop and request context rather than expanding silently.

Testing

  • domain-core: pure JUnit unit tests.
  • application-core: use-case tests with hand-rolled fakes; no web or persistence context.
  • inbound adapters: focused transport slice/contract tests.
  • persistence adapters: mapping/port contract tests; use a real datastore only when vendor semantics require it.
  • other outbound adapters: port contract tests with fake external systems; no real network.
  • identifier: pure deterministic unit tests.
  • bootstrap/settings: binding, validation, wiring, and architecture tests.

From src/, read the owning leaf's gradle_path from config/architecture/modules.json and run ./gradlew <gradle-path>:test --console=plain. Architecture-wide commands:

./gradlew architectureCheck --console=plain
./gradlew :app-bootstrap:architectureTest --console=plain
./gradlew verifyPublicPathSnapshot --console=plain
./gradlew :app-bootstrap:verifyEnvKeys --console=plain

A leaf's check covers that leaf only — compile, its tests, Spotless, Checkstyle, Error Prone. Repository-wide questions have their own names: architectureCheck (dependency direction, purity of domain-core/shared-contract/application-*, Git-carryable sources, ArchUnit), qualityCheck (SpotBugs, FindSecBugs over production code), testQualityCheck (the same over every test source set, against config/spotbugs/exclude-test.xml), configContractCheck (the environment contract), integrationCheck (the declared strict integration lanes; a lane that needs an input the build was not given is left out and named), performanceCheck (the declared performance lanes; main and nightly). ci (pull request) is leaf checks (API surfaces included, owner decision 20) + architectureCheck + qualityCheck, and the workflow also runs verifyStrictLaneStages --dry-run; mainCheck (main branch) is configContractCheck + qualificationCheck (which includes testQualityCheck) + the sample web contract + the sample full boot (:sample-portfolio:systemTest)

  • the public-path snapshot + the transport and messaging qualification lanes + the feature generator round trip (verifyFeatureScaffold) + every leaf's mainCheck (document-contract lanes and any lane the leaf adds). releaseCheck is the tag-only checks: release provenance and the public-path snapshot.

Test-writing rules (behavior-sentence names that assert what they promise, @DisplayName in Korean only when the name cannot say it (owner decision 5), given/when/then comments, one // when, one fake per port in the port owner's testFixtures, fake and adapter sharing one abstract contract test) are canonical in AGENTS.md.

Use public-path and env-key checks only when their surfaces changed. Full test, check or ci requires the controller's workflow authorization.

Capability modules

Optional features (JPA, Redis, Kafka, notification, Mongo, object storage, HTTP client, GraphQL, WebSocket, gRPC, file server) are modules that turn on when present and disappear when removed. A service selects them with one runtimeOnly line each in app-bootstrap/build.gradle; the template's default composition is the web inbound adapter, observability, the cores, and support/identifier. The seven completion criteria for a capability module are canonical in AGENTS.md.

Advisory and reporting

Use dependency-DAG/topological reasoning and 3–5 materially distinct alternatives when that many exist; use fewer when the option set is smaller. Judgment findings include falsifiable assumptions and counterarguments. Deterministic compile, dependency, secret, or failed-test findings use Rule → Evidence → Fix without manufactured debate.

Citation verification is profile-based: none for review-lite, blocking citations for review-standard, and all material citations for audit-deep/regulated. Durable reports are triggered by high risk, at least 3 blocking findings, an architecture decision, explicit user request, or the regulated profile. Otherwise a concise result is allowed.