Files
clean-architecture-backend-…/config/spotbugs/exclude.xml
T
DongHyeonka 154cb4b795 fix(outbound)!: 발행 대기·SMTP 발송·캐시 시간 상한을 지킨다
outbox 발행 대기가 publish()가 돌아온 뒤부터 재서, 호출을 붙잡은
publisher는 longestAttempt를 넘겨도 relay를 묶는다. SMTP 발송 pool은
대기열이 찰 때까지 thread 하나로 돌고, profile들의 max-concurrency가 pool이
담는 수를 넘어도 기동한다. 넘친 발송은 결과 불명으로 남는다. SMTP
profile timeout은 명령 하나만 묶어, 느린 relay에서 발송이 lease를 넘으면
lease 복구가 아직 도는 발송을 운영자 확인으로 넘긴다. Redis 캐시
command-timeout에 lane 대기 2초가 더해지고, 값 크기 상한은 설정할 길이
없다.

고른 방법: 발행 대기 마감은 publish() 전에 잡고 남은 시간만 기다린다.
기다리는 중 interrupt는 결과 불명, 이미 interrupt된 thread와 0 이하
longestAttempt는 보내지 않고 REJECTED_RETRYABLE로 돌려준다. SMTP pool은
dispatch-concurrency개 thread와 그 네 배 대기열로 고정한다. 한 family의
켜진 profile 전체를 보는 ProviderRuntimeAssembler.requireTogether를 두고,
SMTP는 max-concurrency 합이 pool보다 크거나 lease가 timeout 두 배 이하면
조립을 실패시킨다. profile timeout은 발송 한 번을 두 번 묶는다:
pool 대기가 넘으면 보내지 않고 재시도, 발송이 넘으면 PROVIDER_RESPONSE_LOST
로 남겨 다시 보내지 않는다. 두 시한은 completeOnTimeout이라 취소된다.
기본 timeout은 10초에서 30초로, socket timeout 합보다 길어야 한다.
Redis 연산 전체를 command-timeout 하나로 묶고
app.capabilities.cache.maximum-value-bytes를 다시 묶는다(1..16 MiB).
버린 대안: 발송 timeout에 재시도(같은 메일을 두 번 보낼 수 있다), 캐시
상한을 상수로 두기(큰 값을 쓰는 서비스가 바꿀 길이 없다), assembler가
assemble마다 합을 누적하기(조립 순서에 상태가 남는다).

위험·한계: 기동 조건이 늘었다(SMTP max-concurrency 합, lease와 SMTP
timeout, 캐시 값 상한 범위). 대기 시한이 돌려주는 stage는 일부러 버린다
(Error Prone 규칙대로 `unused`에 받고, SpotBugs DLS는 config/spotbugs/
exclude.xml에 그 메서드만 제외한다. Jetty abortAtDeadline 선례). send pool을 바꿔 끼운 배포는 부른 thread에서
돌리지 않는 executor여야 한다. outbox 새 거절 코드의 runbook 줄은 runbook
묶음에 넘긴다. claim·fence 커밋 위에 쌓았다.

검증: desktop RED(고치기 전 트리 + 새 시험, pr2-red2) 새 시험 실패.
GREEN은 PR 본문의 verify.sh pr 결과.

Refs: RR9-01-05, RR9-01-15, RR9-01-16, RR9-01-17, RR9-01-18
BREAKING CHANGE: SMTP profile들의 max-concurrency 합이 send pool(thread와 대기열)을 넘거나 dispatch.lease-duration이 SMTP timeout의 두 배 이하면 기동이 실패한다. SMTP 기본 timeout이 30초이고, 넘은 발송은 결과 불명이 된다. SmtpNotificationProviderAdapter 생성자가 timeout을 받는다. Redis 캐시 값이 maximum-value-bytes(기본 1 MiB)를 넘으면 기록하지 않는다. docs/upgrade/2026-11-round9-outbound.md
2026-11-13 16:21:16 +09:00

385 lines
26 KiB
XML

<?xml version="1.0" encoding="UTF-8"?>
<!--
feature-static-analysis-quality-contract D3/D4 — SpotBugs + FindSecBugs exclude filter.
SpotBugs (D3) and FindSecBugs (D4, via spotbugsPlugins) analyse bytecode. Inter-procedural
taint analysis has known limits (FindSecBugs false positives) and generated code carries
patterns the source author never wrote. Add ONLY confirmed false positives here, each as a
narrowly-scoped <Match> — never a blanket bug-pattern exclusion across all sources.
Reference: https://github.com/spotbugs/spotbugs / https://find-sec-bugs.github.io/
-->
<FindBugsFilter>
<!-- Generated sources (MapStruct / annotation processors): exclude from analysis. -->
<Match>
<Source name="~.*[\\/]generated[\\/].*"/>
</Match>
<!-- SPRING_CSRF_PROTECTION_DISABLED on the two production chains is intentional: the API chain
and the actuator chain authenticate a stateless JWT bearer token (no session cookies, no
ambient credential a browser would attach), so CSRF protection has nothing to protect.
FindSecBugs flags it for classic cookie-session web apps; it is a false positive here.
Named classes, not `~.*SecurityConfig`: that pattern would also match an HTTP Basic chain,
for which this reason is false — a browser re-sends Basic credentials on its own — and would
hide a Basic chain's CSRF exposure (review 2026-11-03 RR-07-05). -->
<Match>
<Bug pattern="SPRING_CSRF_PROTECTION_DISABLED"/>
<Or>
<Class name="dev.caskeleton.adapter.inbound.web.auth.SecurityConfig"/>
<Class name="dev.caskeleton.composition.runtime.management.security.ManagementSecurityConfig"/>
</Or>
</Match>
<!-- Test-only real-HTTP GraphQL qualification uses explicit Authorization headers and disables
CSRF only inside its nested test application so it can isolate auth/CORS/error-boundary
behavior. It is not imported or component-scanned by production. Keep the exception exact
to the nested fixture class; any other CSRF disable remains reportable. -->
<Match>
<Bug pattern="SPRING_CSRF_PROTECTION_DISABLED"/>
<Class name="dev.caskeleton.adapter.inbound.graphql.GraphqlHttpBoundaryQualificationTest$TestSecurityConfiguration"/>
</Match>
<!-- Provider notification callbacks are inbound webhooks: an external provider POSTs to
/internal/notification/callbacks/**, so it can never carry a CSRF token, and the chain is
SESSION-STATELESS with no ambient cookie auth for CSRF to protect. Authenticity comes from
the provider signature the callback package verifies (a failure raises
CallbackValidationException -> 400), not from permitAll(). Scoped to this exact
configuration class; any other CSRF disable remains reportable. -->
<Match>
<Bug pattern="SPRING_CSRF_PROTECTION_DISABLED"/>
<Class name="dev.caskeleton.adapter.inbound.web.notification.platform.callback.CallbackMvcSecurityConfiguration"/>
</Match>
<!-- Test-only violation fixture intentionally calls unsafe Jackson default typing so
architecture tests can prove the boundary rule catches it. Production and non-fixture
test classes remain covered by SECUJDES. -->
<Match>
<Bug code="SECUJDES"/>
<Source name="DefaultTypingFixture.java"/>
</Match>
<!-- =========================================================================================
Confidence MEDIUM (review 2026-11-01 08-07). Everything below was added when the report
level went from HIGH to MEDIUM. Each entry was judged against the code it names; defects
were fixed in the code instead of listed here. Counts are in QualityConventionsPlugin.
========================================================================================= -->
<!-- EI_EXPOSE_REP / EI_EXPOSE_REP2, pattern 1 of 4 — references that are not values.
SpotBugs calls any field "mutable" whose type has a set/add/remove/delete/write-shaped
method, and asks for a copy whenever one is stored from a parameter or returned. For a
field that holds a collaborator (a port, a repository, an EntityManager, a MeterRegistry,
an executor, a template, a settings bean), a handle (a channel, a future, a reflected
Method, an exception kept as a cause) or a nested setter-bound settings object, sharing the
reference is the design: constructor injection stores collaborators, and a copy would be a
different collaborator. The check stays on for the types where a copy IS the remedy —
collections, arrays, Date, ByteBuffer and JSON trees — so a value type that keeps a
caller's list or array is still reported. SpotBugs field types are exact names, not
patterns: an array of any other element type is not re-checked by this list. -->
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
<Not>
<Or>
<Field type="java.util.Collection"/>
<Field type="java.util.List"/>
<Field type="java.util.Set"/>
<Field type="java.util.SortedSet"/>
<Field type="java.util.NavigableSet"/>
<Field type="java.util.Queue"/>
<Field type="java.util.Deque"/>
<Field type="java.util.Map"/>
<Field type="java.util.SortedMap"/>
<Field type="java.util.NavigableMap"/>
<Field type="java.util.ArrayList"/>
<Field type="java.util.LinkedList"/>
<Field type="java.util.HashSet"/>
<Field type="java.util.LinkedHashSet"/>
<Field type="java.util.TreeSet"/>
<Field type="java.util.EnumSet"/>
<Field type="java.util.HashMap"/>
<Field type="java.util.LinkedHashMap"/>
<Field type="java.util.TreeMap"/>
<Field type="java.util.EnumMap"/>
<Field type="java.util.Date"/>
<Field type="java.nio.ByteBuffer"/>
<Field type="byte[]"/>
<Field type="char[]"/>
<Field type="short[]"/>
<Field type="int[]"/>
<Field type="long[]"/>
<Field type="float[]"/>
<Field type="double[]"/>
<Field type="boolean[]"/>
<Field type="java.lang.Object[]"/>
<Field type="java.lang.String[]"/>
<Field type="tools.jackson.databind.JsonNode"/>
<Field type="tools.jackson.databind.node.ObjectNode"/>
<Field type="tools.jackson.databind.node.ArrayNode"/>
<Field type="com.fasterxml.jackson.databind.JsonNode"/>
<Field type="com.fasterxml.jackson.databind.node.ObjectNode"/>
<Field type="com.fasterxml.jackson.databind.node.ArrayNode"/>
</Or>
</Not>
</Match>
<!-- EI pattern 2 of 4 — transport DTOs. A request or response body under adapter.inbound is
built per request by Jackson (or by a mapper for the response), handed to one mapper or one
serializer, and dropped; the command or domain type it maps to owns the copy and the
invariants (AGENTS.md: inbound DTOs never cross into the cores), so no instance outlives
the request. BulkEnvelope is the shared response envelope with the same lifetime. -->
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
<Or>
<Class name="~dev\.caskeleton\.(.*\.)?adapter\.inbound\..*(Request|Response)"/>
<Class name="dev.caskeleton.shared.response.BulkEnvelope"/>
</Or>
</Match>
<!-- EI pattern 3 of 4 — settings binding carriers. Setter-bound @ConfigurationProperties
JavaBeans are mutable by contract (a public setter opens more than the getter does), and
the constructor-bound records listed here have no invariant of their own: each is read
once at startup by the factory that compiles it into the runtime type, and that factory
copies (HttpClientProfileFactory and DynamicTargetAutoConfiguration Set.copyOf every list;
RedisRuntimeAutoConfiguration validates and maps; FileserverStartupValidator reads the
ancestors once). A settings record that validates a collection in its own constructor
copies it there instead (FileserverPlatformSettings.Security). -->
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
<Or>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.capability.RedisCapabilitySettings$Cache"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.capability.RedisCapabilitySettings$RateLimit"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.runtime.config.RedisRuntimeSettings"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.runtime.config.RedisRuntimeSettings$Sentinel"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientPlatformSettings$ClientSettings"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientPlatformSettings$DynamicTargetSettings"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientPlatformSettings$Response"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientPlatformSettings$Authentication"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientPlatformSettings$Tls"/>
<Class name="dev.caskeleton.adapter.outbound.fileserver.platform.autoconfigure.FileserverPlatformSettings$Storage"/>
</Or>
</Match>
<!-- EI pattern 4 of 4 — the collection is already an unmodifiable copy. Each field below is
assigned an unmodifiable collection at construction (List/Set/Map.copyOf,
Collectors.toUnmodifiable*, Stream.toList, Collections.unmodifiable* over a fresh copy),
but through a branch, a stream or a private constructor fed by a copying factory, which
SpotBugs does not follow; it recognises only a field assigned straight from copyOf. Listed
by class and field, so another collection added to the same class is still reported. -->
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
<Or>
<And><Class name="dev.caskeleton.adapter.inbound.graphql.pagination.GraphQlCursorPayload"/><Field name="keyset"/></And>
<And><Class name="dev.caskeleton.adapter.inbound.graphql.runtime.GraphQlExecutionRequest"/><Field name="variables"/></And>
<And><Class name="dev.caskeleton.adapter.inbound.web.authz.RolePermissionPolicy"/><Field name="rolePermissions"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.httpclient.api.operation.HttpOperation"/><Field name="headers"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.httpclient.profile.ResponseLimits"/><Field name="allowedContentTypes"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.notification.platform.autoconfigure.NotificationPlatformSecretsConfig$NotificationSecretsSettings"/><Field name="historicalKeys"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.notification.platform.callback.ProviderCallbackVerificationRequest"/><Field name="headers"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.objectstorage.config.ObjectStorageCapabilitySettings"/><Field name="~providers|destinations"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.postgresql.PostgreSqlSqlStateErrorMapping"/><Field name="~MAPPINGS|COMMIT_OUTCOME_UNKNOWN"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.security.DatabaseRolePolicy"/><Field name="allowedRoles"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.security.SearchPathPolicy"/><Field name="allowedSchemas"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.mongo.query.MongoQueryPolicy"/><Field name="fields"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.mongo.schema.manifest.MongoManifestRegistry"/><Field name="byCollection"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.cache.redis.sdk.api.RedisCapabilities"/><Field name="available"/></And>
<And><Class name="dev.caskeleton.application.security.AuthorizationPrincipal"/><Field name="roles"/></And>
<And><Class name="dev.caskeleton.application.objectstorage.request.ObjectPublishRequest"/><Field name="capabilityRequirements"/></And>
<And><Class name="dev.caskeleton.application.objectstorage.request.ObjectStageRequest"/><Field name="capabilityRequirements"/></And>
</Or>
</Match>
<!-- EI, single sites with an array. RawProtocolKeyword implements Lettuce's ProtocolKeyword,
whose getBytes() Lettuce calls once per encoded command and only reads (Lettuce's own
CommandType returns its array the same way); a clone per command would allocate on the
hot path for nothing. -->
<Match>
<Bug pattern="EI_EXPOSE_REP"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.sdk.lettuce.operations.LettuceRedisCommandGateway$RawProtocolKeyword"/>
<Method name="getBytes"/>
</Match>
<!-- CT_CONSTRUCTOR_THROW (finalizer attack: a subclass's finalize() keeps a half-built object).
A final class cannot be attacked this way, and every class that could be made final was.
These three groups must stay subclassable. -->
<!-- CT group 1 — CGLIB proxies. @RequiresPermission is enforced by a method-security advisor,
and Spring Boot proxies with CGLIB, which subclasses the bean
(RequiresPermissionProxyabilityTest fails the build if such a class is final). The
Annotation matcher covers every class annotated at class level, including ones added
later. A class that annotates only some methods is proxied all the same but is not matched
here; name it when one appears. A @Configuration class is CGLIB-subclassed for its @Bean
methods for the same reason. -->
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
<Or>
<Annotation name="dev.caskeleton.application.security.RequiresPermission"/>
<Annotation name="org.springframework.context.annotation.Configuration"/>
</Or>
</Match>
<!-- CT group 2 — designed for extension. Exception hierarchy roots (HttpClientException,
JpaPersistenceException, RedisOperationException and FileserverException each have
subclasses), ClientRuntime (BlockingClientRuntime extends it) and the abstract
JpaRepositoryFragmentSupport, which service repository fragments extend. -->
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
<Or>
<Class name="dev.caskeleton.adapter.outbound.httpclient.api.error.HttpClientException"/>
<Class name="dev.caskeleton.adapter.outbound.persistence.api.error.JpaPersistenceException"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.sdk.api.error.RedisOperationException"/>
<Class name="dev.caskeleton.application.fileserver.api.error.FileserverException"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.profile.ClientRuntime"/>
<Class name="dev.caskeleton.adapter.outbound.persistence.springdata.JpaRepositoryFragmentSupport"/>
</Or>
</Match>
<!-- FindSecBugs REDOS, one Match per constructor or static initialiser. Every pattern flagged
is "segment (separator segment)*" where the separator is a character the segment class
cannot contain ('.', '-', ';', or a class of those), so each input splits exactly one way
and backtracking is linear, not exponential. The application-core values
also check the length (at most 64-256 characters) before the pattern runs; JsonPathName and SafeSortField
match developer-declared paths; the SNS host comes from a URI host. -->
<Match>
<Bug pattern="REDOS"/>
<Or>
<And><Class name="dev.caskeleton.adapter.outbound.notification.platform.provider.ses.SnsSignatureVerifier"/><Method name="&lt;clinit&gt;"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.postgresql.json.JsonPathName"/><Method name="&lt;clinit&gt;"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.springdata.SafeSortField"/><Method name="&lt;clinit&gt;"/></And>
<And><Class name="dev.caskeleton.application.messaging.contract.ContractDescriptor"/><Method name="&lt;init&gt;"/></And>
<And><Class name="dev.caskeleton.application.messaging.contract.ContractId"/><Method name="&lt;init&gt;"/></And>
<And><Class name="dev.caskeleton.application.messaging.contract.LogicalDestinationId"/><Method name="&lt;init&gt;"/></And>
<And><Class name="dev.caskeleton.application.messaging.contract.SchemaResourceId"/><Method name="&lt;init&gt;"/></And>
<And><Class name="dev.caskeleton.application.messaging.event.AggregateIdentity"/><Method name="&lt;init&gt;"/></And>
</Or>
</Match>
<!-- FindSecBugs UNSAFE_HASH_EQUALS asks for a constant-time compare so that timing cannot leak a
secret digest. None of these digests is a secret: content SHA-256 the uploader supplied or
can compute (ContentPublishVerification, MetadataPointerContentPublisher,
FinalizeUploadApplicationUseCase), an integrity digest of the record's own policy snapshot
(ObjectOperationRecord), idempotency request/response digests the caller's own replay
produces (PostgreSqlIdempotencyStore), and a configured worker identity used as a lease
owner (PosterImageUploadIntent). A comparison that leaks what the caller already knows leaks nothing. -->
<Match>
<Bug pattern="UNSAFE_HASH_EQUALS"/>
<Or>
<And><Class name="dev.caskeleton.adapter.outbound.fileserver.platform.local.ContentPublishVerification"/><Method name="verifyStaged"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.fileserver.platform.local.MetadataPointerContentPublisher"/><Method name="publish"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.objectstorage.control.ObjectOperationRecord"/><Method name="&lt;init&gt;"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.idempotency.postgresql.PostgreSqlIdempotencyStore"/><Method name="~complete|replayVerdict"/></And>
<And><Class name="dev.caskeleton.application.fileserver.upload.FinalizeUploadApplicationUseCase"/><Method name="requireClientDigestMatches"/></And>
</Or>
</Match>
<!-- SQL_INJECTION_SPRING_JDBC: the query is PostgreSqlIdempotencyStore.ACTIVE_CAPABILITY_SQL, a
constant handed to the guard's package-private constructor; nothing else constructs it. -->
<Match>
<Bug pattern="SQL_INJECTION_SPRING_JDBC"/>
<Class name="dev.caskeleton.adapter.outbound.persistence.idempotency.postgresql.IdempotencyCapabilityGuard"/>
<Method name="requireActiveCapability"/>
</Match>
<!-- XSS_SERVLET: reject() writes a fixed JSON body built from a constant message and an enum
code, as application/json; nothing from the request reaches it (the comment there says the
refused body is exactly what must not be echoed). -->
<Match>
<Bug pattern="XSS_SERVLET"/>
<Class name="dev.caskeleton.adapter.inbound.graphql.runtime.servlet.GraphQlRequestBodyLimitFilter"/>
<Method name="reject"/>
</Match>
<!-- WEAK_MESSAGE_DIGEST_SHA1: an opaque compare-and-set token, not an integrity check. It must
equal what Redis computes inside Lua (redis.sha1hex) so that compare + replace stays one
atomic script; any other digest would break the comparison. -->
<Match>
<Bug pattern="WEAK_MESSAGE_DIGEST_SHA1"/>
<Class name="dev.caskeleton.adapter.outbound.cache.redis.cache.RedisCacheRegionAdapter"/>
<Method name="observationOf"/>
</Match>
<!-- PREDICTABLE_RANDOM: log sampling (SamplingTurboFilter.decide) and retry jitter
(HttpClientProfileAutoConfiguration.jitterRandom) only
need spread, not unpredictability; nothing security-relevant is derived from any of these
values. Knowing the next jitter tells a caller when a retry lands, which the retry policy
already bounds. SecureRandom would read as a security requirement that is not there. -->
<Match>
<Bug pattern="PREDICTABLE_RANDOM"/>
<Or>
<And><Class name="dev.caskeleton.adapter.outbound.httpclient.autoconfigure.HttpClientProfileAutoConfiguration"/><Method name="jitterRandom"/></And>
<And><Class name="dev.caskeleton.bootstrap.logging.SamplingTurboFilter"/><Method name="decide"/></And>
</Or>
</Match>
<!-- NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE where the null cannot happen at this call site.
The four activation post-processors call BindResult.orElse(List.of()): Spring annotates the
return @Nullable because it returns the argument, and the argument here is never null.
LocalOrphanScan calls Path.getParent() on paths it built as children of the storage root
(content root, quarantine path), which always have a parent. The two double reads of a
nullable getter that did exist (GlobalExceptionHandler and
WebSocketInboundAuthorizationInterceptor) were changed to read once instead. -->
<Match>
<Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
<Or>
<And><Class name="dev.caskeleton.adapter.inbound.graphql.autoconfigure.GraphQlActivationEnvironmentPostProcessor"/><Method name="excludeTheFrameworkAutoConfigurations"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.notification.platform.autoconfigure.NotificationActivationEnvironmentPostProcessor"/><Method name="postProcessEnvironment"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.persistence.startup.JpaActivationEnvironmentPostProcessor"/><Method name="postProcessEnvironment"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.mongo.MongoDefaultsEnvironmentPostProcessor"/><Method name="postProcessEnvironment"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.fileserver.platform.local.LocalOrphanScan"/><Method name="~contentPath|quarantinePath|retireToQuarantine"/></And>
</Or>
</Match>
<!-- RV_RETURN_VALUE_IGNORED_BAD_PRACTICE on BlockingQueue.offer. TransferBufferPool.release
drops a buffer when the pool is already full: borrow() allocates past capacity rather than
block, so the surplus is meant to be garbage. BodySubscriber.onError has already recorded
the failure through fail(), which wakes the consumer; END is a courtesy that a full queue
can safely refuse. -->
<Match>
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
<Or>
<And><Class name="dev.caskeleton.adapter.outbound.fileserver.platform.local.TransferBufferPool"/><Method name="release"/></And>
<And><Class name="dev.caskeleton.adapter.outbound.objectstorage.s3.S3AsyncResponseBodyBridge$BodySubscriber"/><Method name="onError"/></And>
</Or>
</Match>
<!-- MS_EXPOSE_REP on a static that is already immutable: a Jackson 3 ObjectMapper cannot be
reconfigured after build() (NotificationJsonMapper). -->
<Match>
<Bug pattern="MS_EXPOSE_REP"/>
<Or>
<And><Class name="dev.caskeleton.adapter.outbound.notification.platform.template.NotificationJsonMapper"/><Method name="mapper"/></And>
</Or>
</Match>
<!-- DLS_DEAD_LOCAL_STORE: `Future<Boolean> unused = request.abort(...)` is Error Prone's
documented way to discard a Future on purpose (FutureReturnValueIgnored); the two tools
disagree and the code satisfies the one that fails the compile. -->
<Match>
<Bug pattern="DLS_DEAD_LOCAL_STORE"/>
<Class name="dev.caskeleton.adapter.outbound.httpclient.http3.JettyHttp3TransportProvider"/>
<Method name="abortAtDeadline"/>
</Match>
<!-- DLS_DEAD_LOCAL_STORE, the same disagreement: the SMTP send's queue deadline discards the
stage `thenRun` returns into `unused`, because an abandoned send reports through its own
result, not through that stage. -->
<Match>
<Bug pattern="DLS_DEAD_LOCAL_STORE"/>
<Class name="dev.caskeleton.adapter.outbound.notification.platform.provider.smtp.SmtpNotificationProviderAdapter$PooledSend"/>
<Method name="armQueueDeadline"/>
</Match>
<!-- The servlet error-dispatch controller (re-review 2026-11-03 RR-02-02) must answer for any
HTTP method: the original request's method is whatever failed, and the container forwards it
unchanged to /error. CSRF protection guards a state change made with ambient credentials;
this method makes none — it writes a fixed failure envelope, with nothing from the request in
it. A direct request to /error is answered as an unknown route and still goes through the
authentication chain (a token under the JWT chain, which keeps CSRF off because it carries
no ambient credential). Exact to the one method (review 2026-11-04 RR2-04-06). -->
<Match>
<Bug pattern="SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING"/>
<Class name="dev.caskeleton.adapter.inbound.web.error.EnvelopeErrorController"/>
<Method name="error"/>
</Match>
</FindBugsFilter>