문제: src/ 아래 계층이 아닌 폴더가 2026-07-24의 둘에서 두 달 사이
여덟으로 늘었고, 루트에는 compose 파일과 infra/가 쌓였다. 어느 커밋도
최상위 모양을 묻지 않았고 리뷰 기준에도 그 칸이 없었다.
고른 방법(소유자 결정 2026-11-07, 설계 10.3절): scripts/check-repo-layout.py
- 저장소 루트와 src/ 바로 아래의 추적 항목이 허용 목록 안에 있는가
- registry source_path가 허용된 src/ 폴더 아래인가
- (경고) compose·스크립트·compose 보조 파일을 아무 추적 파일도 가리키지
않는가
를 본다. ci-quality-gates.yml quality-gates job에 한 단계로 붙인다.
Gradle 밖 스크립트다(문서·배치를 파싱하는 Gradle 검사를 두지 않는 정책).
버린 대안: registry에서 허용 폴더를 파생하기. 새 vendored 폴더를 registry
에 등록하는 것만으로 통과해, 막으려는 drift를 막지 못한다.
위험·한계: 참조 0 경고는 경로를 변수로 조립하는 workflow를 따라가지
못해 경고로만 둔다. 리뷰 기준·playbook 문장은 매뉴얼 보강 작업이 넣는다.
검증:
- 노트북·desktop: python3 scripts/check-repo-layout.py rc=0, 경고 0
- 일부러 infra/, src/messaging/, 고아 compose/orphan.sh를 둔 임시 저장소:
rc=1, 실패 3건과 경고 1건
- desktop(트리 c7cacf54): :app-bootstrap:repositoryContractTest
:app-bootstrap:documentContractTest rc=0, :verifyStrictLaneStages --dry-run rc=0
- check-work-docs.py rc=0
- 업그레이드 안내 B-50~B-52의 근거 칸을 커밋 해시로 채운다
Refs: design-docs repo-structure/README.md 3.1, repo-structure/01-backend-layout.md 10.3
BREAKING CHANGE: 저장소 루트나 src/에 허용 목록 밖의 최상위 폴더를 둔 파생 서비스는 PR 게이트가 실패한다. docs/upgrade/2026-11-maturity-review.md B-53.
151 lines
7.1 KiB
YAML
151 lines
7.1 KiB
YAML
name: ci-quality-gates
|
|
|
|
# The pull-request gate. Everything here blocks a merge.
|
|
#
|
|
# The job list used to include `gate-matrix-lint`, which ran .github/scripts/verify-gate-matrix.sh
|
|
# against .github/ci-gate-matrix.yml: a 1,025-line register of all 107 CI controls, checked for
|
|
# consistency against the Gradle task graph and this workflow by a 568-line shell script, which was
|
|
# itself checked by contract tests in :app-bootstrap. Adding one check meant editing Gradle, a
|
|
# workflow, the matrix, the verifier's expectations and a Java test. The information was already in
|
|
# the task graph and the job graph; the matrix was a third copy that had to be kept equal to both.
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches: ["main"]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
TESTCONTAINERS_REUSE_ENABLE: "false"
|
|
|
|
jobs:
|
|
quality-gates:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Export the live Gradle verification task map
|
|
working-directory: src
|
|
run: ./gradlew tasks --group verification --console=plain > ../verification-tasks.txt
|
|
- name: Upload the Gradle verification task map
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # actions/upload-artifact@v7.0.1
|
|
with:
|
|
name: gradle-verification-task-map
|
|
path: verification-tasks.txt
|
|
if-no-files-found: error
|
|
# `ci`, not `check`. A leaf's `check` is that leaf's — compile, its tests, Spotless, Checkstyle
|
|
# and Error Prone — and the repository-wide gates are named tasks of their own:
|
|
# ci = every leaf check + architectureCheck + qualityCheck
|
|
# A leaf's `check` includes its API surface verification (owner decision 20). The main-branch
|
|
# stage (`mainCheck`: environment contract, full-boot qualification, public-path baseline,
|
|
# transport and messaging lanes, document-contract lanes) runs in integration-main.yml.
|
|
- name: Run the pull-request gate
|
|
working-directory: src
|
|
run: ./gradlew :ci :verifyDependencyLocks --warning-mode=fail --stacktrace
|
|
# Plans every stage (`--dry-run`: nothing executes) and fails when a strict lane is in no stage
|
|
# a workflow executes, or a stage is executed by no workflow (review 2026-11-01 08-01). A new
|
|
# lane fails here, on its own pull request, instead of running nowhere after it merges.
|
|
- name: Require every strict lane to be in an executed stage
|
|
working-directory: src
|
|
run: ./gradlew :verifyStrictLaneStages --dry-run --stacktrace
|
|
- name: Verify Compose profile contracts render exactly as declared
|
|
run: bash scripts/verify-compose-profile-contracts.sh
|
|
# The repository root and src/ hold only the entries on the allow list (owner decision
|
|
# 2026-11-07): a new top-level folder is a decision, not a side effect of a feature commit.
|
|
- name: Refuse a top-level folder outside the allow list
|
|
run: python3 scripts/check-repo-layout.py
|
|
|
|
optional-platforms:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
- uses: ./.github/actions/setup-gradle-java
|
|
- name: Verify the optional gRPC platform build
|
|
working-directory: src
|
|
run: ./gradlew -p platforms/optional-build ci --stacktrace
|
|
# The optional build's own lane-reachability check: the main build's cannot see these lanes
|
|
# (review 2026-11-03 RR-06-03).
|
|
- name: Require every optional-platform strict lane to be in an executed stage
|
|
working-directory: src
|
|
run: ./gradlew -p platforms/optional-build :verifyStrictLaneStages --dry-run --stacktrace
|
|
|
|
# gRPC schema policy (owner decision 18). protoc compiles src/platforms/grpc/grpc-contract inside
|
|
# the optional-platforms build above; lint and breaking-change policy belong to Buf, configured by
|
|
# buf.yaml next to the schema. Buf is a native binary rather than a Maven artifact, so it runs here
|
|
# and not inside Gradle — and nothing in the repository re-implements its rules.
|
|
grpc-proto-buf:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
|
with:
|
|
# buf breaking reads the baseline schema from Git history.
|
|
fetch-depth: 0
|
|
- uses: bufbuild/buf-action@85aebf73123b5c15fd5528aaecbf9129cddf7fa7 # bufbuild/buf-action@v1.6.0
|
|
with:
|
|
version: 1.73.0
|
|
setup_only: true
|
|
- name: Lint the gRPC schema
|
|
working-directory: src/platforms/grpc/grpc-contract
|
|
run: buf lint
|
|
- name: Refuse a breaking change to the gRPC schema
|
|
working-directory: src/platforms/grpc/grpc-contract
|
|
env:
|
|
# Pull request: the target branch. Push: the commit this push replaced.
|
|
BASELINE: ${{ github.event_name == 'pull_request' && format('origin/{0}', github.base_ref) || github.event.before }}
|
|
run: |
|
|
set -euo pipefail
|
|
baseline_commit="$(git rev-parse --verify --quiet "${BASELINE}^{commit}" || true)"
|
|
# The module moved from src/grpc to src/platforms/grpc on 2026-11-07. A baseline from
|
|
# before the move holds it at the old path, and comparing against that path keeps the
|
|
# breaking check running across the move instead of skipping it once.
|
|
baseline_dir=""
|
|
if [[ -n "${baseline_commit}" ]]; then
|
|
for candidate in src/platforms/grpc/grpc-contract src/grpc/grpc-contract; do
|
|
if git cat-file -e "${baseline_commit}:${candidate}/buf.yaml" 2>/dev/null; then
|
|
baseline_dir="${candidate}"
|
|
break
|
|
fi
|
|
done
|
|
fi
|
|
if [[ -z "${baseline_dir}" ]]; then
|
|
# The first change that introduces the module has nothing to be compatible with.
|
|
echo "::notice::grpc-proto-buf: baseline ${BASELINE} has no grpc-contract/buf.yaml; breaking check skipped."
|
|
exit 0
|
|
fi
|
|
buf breaking --against "../../../../.git#ref=${baseline_commit},subdir=${baseline_dir}"
|
|
|
|
release-gate:
|
|
needs:
|
|
- quality-gates
|
|
- optional-platforms
|
|
- grpc-proto-buf
|
|
if: always()
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Require every current blocking job to succeed
|
|
env:
|
|
QUALITY_RESULT: ${{ needs.quality-gates.result }}
|
|
OPTIONAL_PLATFORMS_RESULT: ${{ needs.optional-platforms.result }}
|
|
GRPC_PROTO_BUF_RESULT: ${{ needs.grpc-proto-buf.result }}
|
|
run: |
|
|
set -euo pipefail
|
|
for result in \
|
|
"${QUALITY_RESULT}" \
|
|
"${OPTIONAL_PLATFORMS_RESULT}" \
|
|
"${GRPC_PROTO_BUF_RESULT}"; do
|
|
if [[ "${result}" != "success" ]]; then
|
|
echo "::error::release-gate: required job result was ${result}"
|
|
exit 1
|
|
fi
|
|
done
|
|
echo "release-gate: all current blocking quality jobs succeeded."
|