pr / done (pull_request) Successful in 11m34s
round9 확인 리뷰가 CI 파일의 설명이 실제와 다른 곳을 짚었다. - verify.sh 머리 표: PR 단계 job 이름이 `gradle`이다. 실제는 `done`. - build.gradle: JMH가 「세 leaf」에 있다고 하지만 지금은 플러그인을 쓰는 leaf가 정한다. verifyFeatureScaffold는 「leaf 다섯 중첩 빌드」라고 하지만 그 안의 architectureCheck가 모든 leaf의 architecture lane을 부른다. - release.yml: `release` job 주석은 「ci를 다시 돌리지 않는다」인데 뒤의 job들은 ci가 이미 돈 시험 일부를 다시 돈다. 그 이유(문서가 job id로 부르는 릴리스 증거이고, 이미지 job이 모두를 needs로 받아 같은 run·같은 커밋에서 통과한 뒤 publish한다)를 적었다. job은 그대로다. - gates.md 2절: redis-topology 줄을 desktop에서 그대로 돌리라고 하지만 스크립트 안 ./gradlew는 daemon을 남긴다. desktop에서는 GRADLE_OPTS=-Dorg.gradle.daemon=false를 붙이라고 적었다. 스크립트에 --no-daemon을 넣지 않은 이유: CI는 한 job의 step 11개가 daemon을 다시 쓴다. - redis-sdk compose README: cache-redis 칸에 필수 클래스가 둘뿐이다. build.gradle의 standalone·cluster 목록 다섯으로 맞췄다. - template-vs-consumer.md: object-storage-aws를 nightly job으로 적었다. 실제는 손으로 실행하고 입력 run_protected_aws를 켤 때만 돈다. 최상위 항목을 더하면 「AGENTS.md 지도를 함께 고친다」고 했지만 지도는 루트 목록을 두지 않고 check-repo-layout.py를 가리킨다. src/ 최상위 폴더일 때만 지도의 src/ 줄을 고친다고 적었다. 동작 변경 없음: workflow는 주석만, 스크립트는 머리 주석만 바꿨다. 검증: scripts/verify.sh docs(노트북) rc=0. Refs: round9 확인 리뷰(r9-be wave1-r4 「넘길 것」)
288 lines
16 KiB
Groovy
288 lines
16 KiB
Groovy
plugins {
|
|
// Spring Boot stays on the root build script classpath because a leaf applies it by id
|
|
// (`app-bootstrap`) and a leaf resolves plugin classes from the root.
|
|
//
|
|
// Spotless, SpotBugs, Error Prone and Spring's dependency-management are NOT here any more. They
|
|
// were declared `apply false` for a `configure(subprojects)` block that applied them to every
|
|
// leaf; build-logic's `ca.quality-conventions` and `ca.java-conventions` apply them now, and a
|
|
// plugin reachable from two classpaths is two versions waiting to differ. Their versions are the
|
|
// same catalog entries either way — build-logic/settings.gradle reads gradle/libs.versions.toml.
|
|
alias(libs.plugins.spring.boot) apply false
|
|
// JMH benchmarks in the leaves that apply this plugin (`./gradlew :<leaf>:jmh`); never part of a gate.
|
|
alias(libs.plugins.jmh) apply false
|
|
|
|
// Convention plugin from the included build, applied to the ROOT because the rules it owns are
|
|
// about the repository: the architecture gates. The release version/revision is each leaf's
|
|
// `ca.java-conventions` (ca.release-provenance was removed, BUILD-O3-5). The public-path
|
|
// baseline is app-bootstrap's approval test, the local start-up is scripts/bootstrap-local.sh,
|
|
// and archive hygiene is gone with the revision it cleaned out of every leaf's jar name (review
|
|
// 2026-09-24 BUILD-O3-5).
|
|
id 'ca.architecture'
|
|
// Every strict lane belongs to a stage, and each stage's workflow job runs it (review
|
|
// 2026-11-01 08-01).
|
|
id 'ca.strict-lane-stages'
|
|
}
|
|
|
|
group = 'dev.caskeleton'
|
|
|
|
// A release archive has to name the commit that produced it. The revision rule is the one every
|
|
// leaf's version uses (JavaConventionsPlugin.sourceRevision, tested in build-logic), read here so
|
|
// the tag-only gate and the jars cannot disagree about what counts as a commit id.
|
|
tasks.register('verifyReleaseProvenance') {
|
|
group = 'verification'
|
|
description = 'Fails when the build cannot name the source revision it was produced from.'
|
|
String revision = dev.caskeleton.buildlogic.java.JavaConventionsPlugin.sourceRevision(providers)
|
|
boolean traceable = revision != dev.caskeleton.buildlogic.java.JavaConventionsPlugin.UNKNOWN_REVISION
|
|
outputs.upToDateWhen { false }
|
|
doLast { task ->
|
|
if (!traceable) {
|
|
throw new GradleException('verifyReleaseProvenance: no source revision. A release archive has to name the '
|
|
+ 'commit that produced it; supply -PgitRevision=<sha>, GIT_SHA or GITHUB_SHA.')
|
|
}
|
|
task.logger.lifecycle("verifyReleaseProvenance: OK — revision ${revision}")
|
|
}
|
|
}
|
|
|
|
// One explicit command regenerates every module's Gradle-default lockfile.
|
|
tasks.register('resolveAndLockAll') {
|
|
group = 'build setup'
|
|
description = 'Regenerates dependency locks for all subprojects (requires --write-locks).'
|
|
dependsOn subprojects.findAll { it.childProjects.isEmpty() }.collect { "${it.path}:resolveAndLockAll" }
|
|
}
|
|
|
|
tasks.register('verifyDependencyLocks') {
|
|
group = 'verification'
|
|
description = 'Verifies strict dependency lock state for production CI subprojects.'
|
|
dependsOn subprojects.findAll { it.childProjects.isEmpty() }.collect { "${it.path}:verifyDependencyLocks" }
|
|
}
|
|
|
|
// feature-developer-experience-contract D3 — the ordered local bootstrap lifecycle is
|
|
// scripts/bootstrap-local.sh (compile, Docker preflight, dependency wait, migrate-and-start, smoke).
|
|
|
|
// ---------------------------------------------------------------------------------------------
|
|
// Lifecycle.
|
|
//
|
|
// :<leaf>:check that leaf — compile, its tests, Spotless, Checkstyle, Error Prone
|
|
// check every leaf's check (Gradle matches the name across projects)
|
|
// architectureCheck dependency direction + purity + app-bootstrap whole-repository ArchUnit
|
|
// qualityCheck SpotBugs + FindSecBugs across every leaf (ca.quality-conventions)
|
|
// ci leaf checks + architectureCheck + qualityCheck
|
|
// prCheck the pull-request stage: ci + dependency locks + the Compose render, the
|
|
// repository layout and the document checks (scripts outside Gradle)
|
|
// mainCheck the main-branch stage: environment contract, full-boot qualification,
|
|
// public-path baseline, transport and messaging qualification lanes, each
|
|
// leaf's document-contract lanes, and the feature generator round trip
|
|
// (verifyFeatureScaffold)
|
|
// integrationCheck the declared strict integration lanes (several need a container runtime)
|
|
// performanceCheck the declared strict performance lanes (load, shutdown, pool and resource
|
|
// bounds; real servers and containers)
|
|
// releaseCheck the tag-only checks: release provenance + public path snapshot (not `ci`
|
|
// again — a tag is cut from a main commit the PR and main stages ran on)
|
|
//
|
|
// A leaf's check is that leaf's; a repository question gets a repository task named after it.
|
|
// Task PATHS, not TaskProviders: a leaf's tasks are created by convention plugins after the root is
|
|
// evaluated, and a path is resolved when the task graph is built.
|
|
// ---------------------------------------------------------------------------------------------
|
|
List<String> leafPaths = subprojects.findAll { it.childProjects.isEmpty() }.collect { it.path }.toSorted()
|
|
|
|
tasks.register('qualityCheck') {
|
|
group = 'verification'
|
|
description = 'Runs SpotBugs and FindSecBugs across every production CI leaf.'
|
|
dependsOn leafPaths.collect { "${it}:qualityCheck" }
|
|
}
|
|
|
|
tasks.register('configContractCheck') {
|
|
group = 'verification'
|
|
description = 'Runs the environment contract owned by the composition root.'
|
|
dependsOn ':app-bootstrap:verifyEnvKeys'
|
|
}
|
|
|
|
// A lane that needs an input this build was not given (the Redis topology coordinates, the protected
|
|
// AWS sandbox authority) is explicit-only: the aggregate leaves it out and names it when it runs
|
|
// (review NEW-16).
|
|
tasks.register('integrationCheck') {
|
|
group = 'verification'
|
|
description = "Runs every production CI leaf's integration-category test lanes. Several need a container runtime."
|
|
dependsOn leafPaths.collect { "${it}:integrationTestLaneCheck" }
|
|
}
|
|
|
|
// Performance lanes are not the pull request's or the main stage's: their bounds need a machine that
|
|
// is not compiling something else. main.yml runs this aggregate nightly, after its other jobs.
|
|
tasks.register('performanceCheck') {
|
|
group = 'verification'
|
|
description = "Runs every production CI leaf's performance-category test lanes. Several need a container runtime."
|
|
dependsOn leafPaths.collect { "${it}:performanceTestLaneCheck" }
|
|
}
|
|
|
|
tasks.named('architectureCheck') {
|
|
dependsOn leafPaths.collect { "${it}:architectureTestLaneCheck" }
|
|
}
|
|
|
|
// app-bootstrap is left out: its `check` already runs its full-boot lane in the pull-request gate,
|
|
// and the main stage ran the same lane a second time on every main push (review 2026-11-01 08-02).
|
|
// The lane stays merge-blocking, because a composition that does not boot must not merge.
|
|
tasks.register('systemTestCheck') {
|
|
group = 'verification'
|
|
description = "Runs every production CI leaf's full application/system test lanes that `ci` does not already run."
|
|
dependsOn leafPaths.findAll { it != ':app-bootstrap' }.collect { "${it}:systemTestLaneCheck" }
|
|
}
|
|
|
|
tasks.register('qualificationCheck') {
|
|
group = 'verification'
|
|
description = 'Runs repository/build-behavior qualification that is intentionally outside local leaf checks.'
|
|
dependsOn tasks.named('systemTestCheck')
|
|
dependsOn leafPaths.collect { "${it}:auxiliaryStyleCheck" }
|
|
dependsOn tasks.named('testQualityCheck')
|
|
}
|
|
|
|
// SpotBugs + FindSecBugs over every leaf's test source sets, against config/spotbugs/exclude-test.xml.
|
|
// Main stage, not `ci`: test code does not ship, and the full run is about as long as `ci` itself.
|
|
// It ran in no stage until 2026-11-04, and 53 of these tasks had been failing unseen.
|
|
tasks.register('testQualityCheck') {
|
|
group = 'verification'
|
|
description = 'Runs SpotBugs and FindSecBugs over every leaf\'s test source sets.'
|
|
dependsOn leafPaths.collect { "${it}:testQualityCheck" }
|
|
}
|
|
|
|
// The feature generator's round trip (review 2026-11-01 개선 순서 4): scripts/new-feature.sh writes
|
|
// two features into a throwaway copy of the working tree and that copy's own Gradle runs the checks
|
|
// of the five leaves they touch plus architectureCheck, which runs every leaf's architecture lane. A
|
|
// nested build that long belongs to the main stage, not the pull request. The script is the whole
|
|
// check; this task only gives it a stage.
|
|
tasks.register('verifyFeatureScaffold', Exec) {
|
|
group = 'verification'
|
|
description = 'Generates features with scripts/new-feature.sh in a scratch copy and runs the gates they must pass.'
|
|
workingDir = rootProject.projectDir
|
|
commandLine 'bash', 'scripts/verify-feature-scaffold.sh'
|
|
}
|
|
|
|
// Each lane below names its tests and rejects skips; these two only aggregate them.
|
|
tasks.register('conditionalTransportQualification') {
|
|
group = 'verification'
|
|
description = 'Runs the no-skip GraphQL, gRPC and WebSocket transport lanes and the opt-in classpath contract.'
|
|
dependsOn ':adapter:inbound:graphql:graphqlTransportQualificationTest',
|
|
':adapter:inbound:grpc:grpcTransportQualificationTest',
|
|
':adapter:inbound:websocket:websocketTransportQualificationTest',
|
|
':app-bootstrap:conditionalTransportBuildContractTest'
|
|
}
|
|
|
|
tasks.register('verifyMessagingContracts') {
|
|
group = 'verification'
|
|
description = 'Qualifies the application integration-event contract and the shared envelope schema.'
|
|
dependsOn ':application-core:messagingApplicationContractQualificationTest',
|
|
':shared-contract:messagingSharedSchemaQualificationTest'
|
|
}
|
|
|
|
tasks.register('ci') {
|
|
group = 'verification'
|
|
description = 'The pull-request gate: every production CI leaf check plus the architecture and quality gates.'
|
|
dependsOn leafPaths.collect { "${it}:check" }
|
|
dependsOn tasks.named('architectureCheck')
|
|
dependsOn tasks.named('qualityCheck')
|
|
}
|
|
|
|
tasks.register('mainCheck') {
|
|
group = 'verification'
|
|
description = 'The main-branch stage: the gates that are not worth a pull request\'s wait.'
|
|
dependsOn leafPaths.collect { "${it}:mainCheck" }
|
|
dependsOn tasks.named('configContractCheck')
|
|
dependsOn tasks.named('qualificationCheck')
|
|
dependsOn tasks.named('verifyPublicPathSnapshot')
|
|
dependsOn tasks.named('conditionalTransportQualification')
|
|
dependsOn tasks.named('verifyMessagingContracts')
|
|
dependsOn ':adapter:inbound:graphql:graphqlStableTest'
|
|
dependsOn tasks.named('verifyFeatureScaffold')
|
|
}
|
|
|
|
// The checks outside Gradle that the pull-request stage runs. Each is a script with its own tests
|
|
// (scripts/tests); these tasks only give them a stage, so pr.yml and scripts/verify.sh run the same
|
|
// one line. Repository root as working directory: that is where the scripts expect to start.
|
|
def repositoryRoot = rootProject.projectDir
|
|
tasks.register('verifyComposeProfiles', Exec) {
|
|
group = 'verification'
|
|
description = 'Renders every Compose lane and checks it renders exactly what it declares.'
|
|
workingDir = repositoryRoot
|
|
commandLine 'bash', 'scripts/verify-compose-profile-contracts.sh'
|
|
}
|
|
tasks.register('verifyRepositoryLayout', Exec) {
|
|
group = 'verification'
|
|
description = 'Refuses a top-level entry of the repository or src/ outside the allow list.'
|
|
workingDir = repositoryRoot
|
|
commandLine 'python3', 'scripts/check-repo-layout.py'
|
|
}
|
|
tasks.register('verifyWorkDocs', Exec) {
|
|
group = 'verification'
|
|
description = 'Checks the work manual: size limits, no history IDs, playbook skeleton, relative links.'
|
|
workingDir = repositoryRoot
|
|
commandLine 'python3', 'scripts/check-work-docs.py'
|
|
}
|
|
tasks.register('testDocumentChecks', Exec) {
|
|
group = 'verification'
|
|
description = 'Runs the tests of the scripts outside Gradle (document checker, hooks, ledger).'
|
|
workingDir = repositoryRoot
|
|
commandLine 'python3', '-m', 'unittest', 'discover', '-s', 'scripts/tests'
|
|
}
|
|
tasks.register('documentCheck', Exec) {
|
|
group = 'verification'
|
|
description = 'Checks living documents: language, head blocks, references, numbers, links, style.'
|
|
workingDir = repositoryRoot
|
|
commandLine 'python3', 'scripts/check-docs.py'
|
|
dependsOn tasks.named('testDocumentChecks')
|
|
}
|
|
|
|
tasks.register('prCheck') {
|
|
group = 'verification'
|
|
description = 'The pull-request stage: ci, dependency locks, the Compose render, the layout, the work manual and the documents.'
|
|
dependsOn tasks.named('ci')
|
|
dependsOn tasks.named('verifyDependencyLocks')
|
|
dependsOn tasks.named('verifyComposeProfiles')
|
|
dependsOn tasks.named('verifyRepositoryLayout')
|
|
dependsOn tasks.named('verifyWorkDocs')
|
|
dependsOn tasks.named('documentCheck')
|
|
}
|
|
|
|
// The stages a strict lane may belong to, and the one workflow job that runs each.
|
|
// `verifyStrictLaneStages --dry-run` (pull-request stage) fails when a strict lane that is not
|
|
// `explicitOnly` is in the plan of none of them — the gap that left fourteen lanes running nowhere
|
|
// while each one failed closed (review 2026-11-01 08-01) — or when a stage job is not the line
|
|
// `./gradlew <stage> <options>` under the declared event and condition. A new lane joins a stage
|
|
// through its category aggregate; no workflow line names it. The performance lane runs only
|
|
// nightly, after the other heavy jobs, on a runner nothing else is using (owner decision 2026-11-07).
|
|
strictLaneStages {
|
|
workflowDirectory = layout.projectDirectory.dir('.gitea/workflows')
|
|
stage ':prCheck', workflow: 'pr.yml', event: 'pull_request', job: 'done'
|
|
// One job and one Gradle run for both main-branch stages: it compiles once, and the
|
|
// main stage's analysis and the feature generator's nested build run while the integration
|
|
// lanes take turns on the one real-server slot. Two jobs spent about 34 runner minutes on a push
|
|
// (run 79), two of them compiling the same modules twice.
|
|
// integrationCheck comes first on the line because Gradle starts ready work in the order of
|
|
// the requested tasks: the integration lanes' compiles go first and the slot is busy from the
|
|
// first minute. Second on the line, the lanes waited about ten minutes behind the main stage's
|
|
// analysis and then ran one at a time on an idle machine (desktop 1,760 s, first on the line
|
|
// 1,484 s, same commit range).
|
|
stage ':mainCheck', workflow: 'main.yml', event: 'push', filter: 'branches: [main]', job: 'main',
|
|
options: '--continue', line: ':integrationCheck :mainCheck'
|
|
stage ':integrationCheck', workflow: 'main.yml', event: 'push', filter: 'branches: [main]', job: 'main',
|
|
options: '--continue', line: ':integrationCheck :mainCheck'
|
|
stage ':performanceCheck', workflow: 'main.yml', event: 'schedule', job: 'performance', options: '--continue',
|
|
condition: '${{ github.event_name != \'push\' }}'
|
|
stage ':releaseCheck', workflow: 'release.yml', event: 'push', filter: 'tags: ["v*"]', job: 'release'
|
|
}
|
|
|
|
// The deny-by-default public path baseline: app-bootstrap's approval-test lane under its old name.
|
|
// `-PapprovePublicPathChange` rewrites the baseline after review.
|
|
tasks.register('verifyPublicPathSnapshot') {
|
|
group = 'verification'
|
|
description = 'Fails when the shipped public path default drifts from docs/security/public-paths-snapshot.txt.'
|
|
dependsOn ':app-bootstrap:publicPathSnapshotTest'
|
|
}
|
|
|
|
// The checks that only matter for a release artifact. Not `ci` again: a release tag is cut from a
|
|
// main commit that the pull-request gate and the main stage already ran on (review BUILD-중복-6).
|
|
tasks.register('releaseCheck') {
|
|
group = 'verification'
|
|
description = 'The tag-only checks: release provenance and the public path baseline.'
|
|
dependsOn tasks.named('verifyReleaseProvenance')
|
|
dependsOn tasks.named('verifyPublicPathSnapshot')
|
|
}
|