From 1497e64c657ac807ea11a021f25b848919e36ed0 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Wed, 4 Nov 2026 22:28:30 +0900 Subject: [PATCH] =?UTF-8?q?test(deps):=20pnpm=20=EC=84=A4=EC=B9=98=20?= =?UTF-8?q?=EC=A0=95=EC=B1=85=20=ED=82=A4=EA=B0=80=20=EB=B9=A0=EC=A7=80?= =?UTF-8?q?=EA=B1=B0=EB=82=98=20=EC=95=BD=ED=95=B4=EC=A7=80=EB=A9=B4=20?= =?UTF-8?q?=EC=8B=A4=ED=8C=A8=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제: pnpm 11은 설치 정책을 pnpm-workspace.yaml에서 읽는다(13-09가 .npmrc에서 옮겼다). engineStrict·saveExact가 빠지거나 minimumReleaseAge를 기본값(1440분)보다 짧게 줄여도 실패하는 검사가 없었다(0929/13-08, 세 라운드 남음). 지원하지 않는 Node로 설치되거나, 새 의존성이 ^ 범위로 저장되거나, 방금 나온 버전이 설치될 수 있다. 고른 방법: unit 테스트가 pnpm-workspace.yaml의 engineStrict: true, saveExact: true를 확인하고, minimumReleaseAge를 적었다면 1440 이상인지 본다. minimumReleaseAgeExclude 항목은 정확한 버전만 허용한다. 버린 대안: `pnpm config get`을 부르는 테스트. 자식 프로세스 비용이 들고 같은 파일을 읽는다. 위험·한계: 파일 텍스트를 정규식으로 읽는다. 키를 다른 YAML 형식(인라인 맵 등)으로 바꾸면 테스트가 실패하므로 놓치는 쪽으로는 틀리지 않는다. 검증: 2건 통과. saveExact: false와 minimumReleaseAge: 60으로 바꾸면 실패하고 되돌리면 통과한다. Refs: docs/reviews/2026-11-03-maturity-review/13-build-release-supply-chain.md 0929/13-08 --- tests/unit/pnpm-install-policy.test.ts | 37 ++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 tests/unit/pnpm-install-policy.test.ts diff --git a/tests/unit/pnpm-install-policy.test.ts b/tests/unit/pnpm-install-policy.test.ts new file mode 100644 index 00000000..ee45d517 --- /dev/null +++ b/tests/unit/pnpm-install-policy.test.ts @@ -0,0 +1,37 @@ +import { readFile } from "node:fs/promises"; + +import { describe, expect, it } from "vitest"; + +/** + * 0929/13-08. pnpm 11 reads its install policy from pnpm-workspace.yaml + * (13-09 moved it out of .npmrc, which pnpm 11 ignores). Nothing failed when a + * key was dropped or the release-age delay was shortened, so an unsupported + * Node version could install again, a new dependency could be saved with a ^ + * range, or a version published minutes ago could be installed. + */ +const PNPM_DEFAULT_MINIMUM_RELEASE_AGE_MINUTES = 1_440; + +describe("pnpm install policy (0929/13-08)", () => { + it("keeps engineStrict, exact saves and at least the default release-age delay", async () => { + const workspace = await readFile("pnpm-workspace.yaml", "utf8"); + const setting = (key: string) => + new RegExp(`^${key}:\\s*(\\S+)\\s*$`, "mu").exec(workspace)?.[1]; + + expect(setting("engineStrict")).toBe("true"); + expect(setting("saveExact")).toBe("true"); + const minimumReleaseAge = setting("minimumReleaseAge"); + if (minimumReleaseAge !== undefined) { + expect(Number(minimumReleaseAge)).toBeGreaterThanOrEqual(PNPM_DEFAULT_MINIMUM_RELEASE_AGE_MINUTES); + } + }); + + it("excludes only exact versions from the release-age delay", async () => { + const workspace = await readFile("pnpm-workspace.yaml", "utf8"); + const block = /^minimumReleaseAgeExclude:\n((?:\s+-\s+.+\n?)*)/mu.exec(workspace)?.[1] ?? ""; + const entries = block + .split("\n") + .map((line) => line.replace(/^\s+-\s+/u, "").replaceAll("'", "").trim()) + .filter(Boolean); + for (const entry of entries) expect(entry).toMatch(/^(?:@[^/@]+\/)?[^/@]+@\d+\.\d+\.\d+$/u); + }); +});