fix: stop test fixtures from deleting the repository's dependencies

Four fixtures linked the installed dependencies into a throwaway root with a
single directory symlink at <fixture>/node_modules, then ran pnpm inside that
root. pnpm does not recognise the modules directory it finds there and purges
it; with CI=true it does so without a prompt. The purge followed the symlink and
deleted the repository's own node_modules mid-run, so a test suite uninstalled
the workspace it was running in. That is what produced the cascading,
file-unrelated failures a full test:unit run reported, and it happened twice
while running the suites for the adapter re-review.

scripts/lib/fixture-node-modules.ts replaces all four sites: node_modules is a
real directory whose entries are individual symlinks, so a recursive delete
unlinks the fixture's own links instead of walking through one link into the
shared tree. Resolution is unchanged.

tests/unit/fixture-node-modules.test.ts performs the exact recursive delete pnpm
performs and asserts the source tree survives, and check:adapter-inventory now
fails on any reintroduction of the directory-symlink form — verified by putting
the old line back and watching the gate reject it.

A full tests/unit + tests/integration run now leaves the dependencies intact.
removal-fixture, supply-chain and security-followup-archive, the three suites
that had to be excluded before, pass in that run.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

scripts/check-adapter-inventory.ts

@@ -91,6 +91,38 @@ async function main(): Promise<void> {
     }
   }
 
+  // A fixture that links the repository's node_modules with a single directory
+  // symlink is destructive: pnpm running inside that fixture purges the modules
+  // directory it does not recognise, follows the link, and deletes the real
+  // dependencies mid-run. `linkFixtureNodeModules` is the only sanctioned form.
+  const sources = spawnSync(
+    "git",
+    ["grep", "-n", "-e", 'symlink(', "--", "scripts", "tests"],
+    { encoding: "utf8" },
+  );
+  if (sources.status === 0) {
+    for (const line of sources.stdout.split("\n").filter(Boolean)) {
+      if (!line.includes("node_modules")) continue;
+      if (line.startsWith("scripts/lib/fixture-node-modules.ts:")) continue;
+      problems.push(
+        `fixture node_modules: use linkFixtureNodeModules instead — ${line}`,
+      );
+    }
+  }
+  const linkedFixtures = spawnSync(
+    "git",
+    ["grep", "-l", "linkFixtureNodeModules", "--", "scripts", "tests"],
+    { encoding: "utf8" },
+  );
+  if (
+    linkedFixtures.status !== 0 ||
+    linkedFixtures.stdout.split("\n").filter(Boolean).length < 2
+  ) {
+    problems.push(
+      "fixture node_modules: the shared linker has no callers, so it is not the sanctioned path",
+    );
+  }
+
   if (problems.length > 0) {
     for (const problem of problems) console.error(problem);
     process.exitCode = 1;
@@ -100,7 +132,8 @@ async function main(): Promise<void> {
     `Adapter inventory: ${tracked.length} files PASS; ` +
       `service worker asset table: ${
         Object.keys(CACHEABLE_ASSET_CONTENT_TYPES).length
-      } shared extensions PASS`,
+      } shared extensions PASS; ` +
+      `fixture node_modules linking PASS`,
   );
 }
 

scripts/check-supply-chain-provider-fixtures.ts

@@ -12,7 +12,6 @@ import {
   readFile,
   readdir,
   rm,
-  symlink,
   writeFile,
 } from "node:fs/promises";
 import { tmpdir } from "node:os";
@@ -42,6 +41,7 @@ import {
   releaseCandidateManifestSchema,
 } from "./lib/release-candidate.ts";
 import { writeValidatedJsonArtifact } from "./lib/validated-json-artifact.ts";
+import { linkFixtureNodeModules } from "./lib/fixture-node-modules.ts";
 
 const repositoryRoot = process.cwd();
 const fixtureRoot = await mkdtemp(path.join(tmpdir(), "provider-exact-five-fixture-"));
@@ -59,7 +59,7 @@ try {
     recursive: true,
   });
   await rm(path.join(fixtureRoot, "artifacts/release"), { recursive: true, force: true });
-  await symlink(path.join(repositoryRoot, "node_modules"), path.join(fixtureRoot, "node_modules"), "dir");
+  await linkFixtureNodeModules(fixtureRoot, repositoryRoot);
   const git = spawnSync("git", ["show", "-s", "--format=%H%n%ct", "HEAD"], {
     cwd: repositoryRoot,
     encoding: "utf8",

scripts/lib/fixture-node-modules.ts

@@ -0,0 +1,31 @@
+import { lstat, mkdir, readdir, symlink } from "node:fs/promises";
+import path from "node:path";
+
+/**
+ * Links the repository's installed dependencies into a throwaway fixture root.
+ *
+ * The obvious form — one directory symlink at `<fixture>/node_modules` — is
+ * destructive. A fixture runs `pnpm` inside itself, pnpm does not recognise the
+ * modules directory it finds there, and its purge follows the symlink and
+ * deletes the *repository's* real dependencies mid-run. With `CI=true` that
+ * happens without a prompt, so a test suite silently uninstalls the workspace
+ * it is running in.
+ *
+ * `node_modules` is therefore a real directory here, and every entry inside it
+ * is an individual symlink. Package resolution is unchanged, but a recursive
+ * delete unlinks the fixture's own symlinks instead of walking through one link
+ * into the shared tree.
+ */
+export async function linkFixtureNodeModules(
+  fixtureRoot: string,
+  sourceRoot: string = process.cwd(),
+): Promise<void> {
+  const source = path.join(sourceRoot, "node_modules");
+  const target = path.join(fixtureRoot, "node_modules");
+  await mkdir(target, { recursive: true });
+  for (const entry of await readdir(source)) {
+    const from = path.join(source, entry);
+    const stats = await lstat(from);
+    await symlink(from, path.join(target, entry), stats.isDirectory() ? "dir" : "file");
+  }
+}

scripts/lib/removal-fixture.ts

@@ -5,7 +5,6 @@ import {
   readFile,
   readdir,
   rm,
-  symlink,
   writeFile,
 } from "node:fs/promises";
 import path from "node:path";
@@ -14,6 +13,7 @@ import {
   loadCiGateContract,
   parseCiGateContract,
 } from "../contracts/ci-gates.ts";
+import { linkFixtureNodeModules } from "./fixture-node-modules.ts";
 import { generateCiWorkflow } from "../generate-ci-workflow.ts";
 
 export const REMOVAL_FIXTURE_COPY_TARGETS = Object.freeze([
@@ -42,7 +42,7 @@ export async function prepareRemovalFixture(
   for (const target of copyTargets) {
     await cp(target, path.join(root, target), { recursive: true });
   }
-  await symlink(path.resolve("node_modules"), path.join(root, "node_modules"), "dir");
+  await linkFixtureNodeModules(root);
 }
 
 export function runRemovalFixturePnpm(