fix(architecture): stop running dependency-cruiser, which checked zero modules (12-05)
dependency-cruiser 18 cannot parse TypeScript 7, so it cruised no module, passed, and its report and the docs claimed it checked the layers. The import graph is the only checker; .dependency-cruiser.json stays as its rule file (D-11). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
7f2a1607f3
commit
39b9fbffb7
@@ -53,7 +53,6 @@ type GraphFixtureResult = Readonly<{
|
||||
failures: string[];
|
||||
}>;
|
||||
type DependencyResolution = Readonly<{ path?: string; reason: string }>;
|
||||
type DependencyCruiserReport = Record<string, unknown>;
|
||||
type TypeScriptOnlyPolicy = Readonly<{
|
||||
checkedRoots: readonly string[];
|
||||
exceptionsAllowed: false;
|
||||
@@ -111,27 +110,15 @@ function runPnpm(arguments_: string[]) {
|
||||
});
|
||||
}
|
||||
|
||||
// Keep dependency-cruiser's report and checks. The second graph is authoritative
|
||||
// for TypeScript 7 coverage because dependency-cruiser 18 cannot parse TS 7 yet.
|
||||
const dependencyCruiser = runPnpm([
|
||||
"exec",
|
||||
"depcruise",
|
||||
"src",
|
||||
"--config",
|
||||
".dependency-cruiser.json",
|
||||
"--output-type",
|
||||
"json",
|
||||
]);
|
||||
// 12-05 (D-11): this graph is the only architecture checker. dependency-cruiser
|
||||
// 18 cannot parse TypeScript 7, so it cruised zero modules and still passed.
|
||||
// .dependency-cruiser.json keeps its name and is read here as the rule file.
|
||||
const sourceGraph = await analyzeSourceGraph(sourceRoot, "src");
|
||||
const typeScriptOnlyPolicy = await inspectTypeScriptOnlyPolicy();
|
||||
const graphFixtureResult = await runGraphFixtureChecks();
|
||||
const dependencyReport = parseDependencyCruiserReport(dependencyCruiser.stdout);
|
||||
const graphErrors = blockingViolations(sourceGraph);
|
||||
const dependencyCruiserReportValid = !(
|
||||
"dependencyCruiserOutput" in dependencyReport
|
||||
);
|
||||
|
||||
dependencyReport.staticImportGraph = {
|
||||
const staticImportGraph = {
|
||||
analyzer: "babel-parser-node-resolver",
|
||||
modules: sourceGraph.modules,
|
||||
dependencies: sourceGraph.dependencies,
|
||||
@@ -162,25 +149,11 @@ dependencyReport.staticImportGraph = {
|
||||
await writeValidatedJsonArtifact({
|
||||
path: qualityArtifact,
|
||||
schema: architectureDependencyReportArtifactSchema,
|
||||
value: dependencyReport,
|
||||
value: { staticImportGraph },
|
||||
});
|
||||
|
||||
let architectureFailed = false;
|
||||
|
||||
if (!dependencyCruiserReportValid) {
|
||||
architectureFailed = true;
|
||||
process.stderr.write("dependency-cruiser returned an invalid JSON report\n");
|
||||
}
|
||||
|
||||
if (dependencyCruiser.status !== 0) {
|
||||
architectureFailed = true;
|
||||
process.stderr.write(
|
||||
(dependencyCruiser.error?.message ?? dependencyCruiser.stderr) ||
|
||||
dependencyCruiser.stdout ||
|
||||
"dependency-cruiser failed\n",
|
||||
);
|
||||
}
|
||||
|
||||
for (const failure of sourceGraph.parseFailures) {
|
||||
architectureFailed = true;
|
||||
process.stderr.write(
|
||||
@@ -1186,17 +1159,3 @@ function isPathRule(value: unknown, allowCircular: boolean): value is PathRule {
|
||||
function isRecord(value: unknown): value is Record<string, unknown> {
|
||||
return Boolean(value && typeof value === "object" && !Array.isArray(value));
|
||||
}
|
||||
|
||||
function parseDependencyCruiserReport(
|
||||
output: string,
|
||||
): DependencyCruiserReport {
|
||||
try {
|
||||
const report: unknown = JSON.parse(output);
|
||||
if (!report || typeof report !== "object" || Array.isArray(report)) {
|
||||
throw new Error("dependency-cruiser report must be a JSON object");
|
||||
}
|
||||
return report as DependencyCruiserReport;
|
||||
} catch {
|
||||
return { summary: { errors: 1 }, dependencyCruiserOutput: output };
|
||||
}
|
||||
}
|
||||
|
||||
@@ -979,33 +979,11 @@ const staticImportGraphSchema = z
|
||||
context.addIssue({ code: "custom", path: ["typeScriptOnlySourcePolicy", "passed"], message: "must agree with violations and summary" });
|
||||
}
|
||||
});
|
||||
const dependencyCruiserSummarySchema = z
|
||||
.object({
|
||||
violations: z.array(jsonObject),
|
||||
error: z.int().nonnegative(),
|
||||
warn: z.int().nonnegative(),
|
||||
info: z.int().nonnegative(),
|
||||
ignore: z.int().nonnegative(),
|
||||
totalCruised: z.int().nonnegative(),
|
||||
totalDependenciesCruised: z.int().nonnegative(),
|
||||
})
|
||||
.catchall(z.json());
|
||||
export const architectureDependencyReportArtifactSchema = z.union([
|
||||
z
|
||||
.object({
|
||||
modules: z.array(jsonObject),
|
||||
summary: dependencyCruiserSummarySchema,
|
||||
staticImportGraph: staticImportGraphSchema,
|
||||
})
|
||||
.strict(),
|
||||
z
|
||||
.object({
|
||||
summary: z.object({ errors: z.literal(1) }).strict(),
|
||||
dependencyCruiserOutput: z.string(),
|
||||
staticImportGraph: staticImportGraphSchema,
|
||||
})
|
||||
.strict(),
|
||||
]);
|
||||
// 12-05 (D-11): dependency-cruiser checked zero modules under TypeScript 7 and
|
||||
// no longer runs; the report carries the import graph that enforces the rules.
|
||||
export const architectureDependencyReportArtifactSchema = z
|
||||
.object({ staticImportGraph: staticImportGraphSchema })
|
||||
.strict();
|
||||
|
||||
export const designSystemReportArtifactSchema = z
|
||||
.object({
|
||||
|
||||
Reference in New Issue
Block a user