chore(review): 1103 기능 생성기·기능 패턴 조치 브랜치를 합친다
Refs: docs/reviews/2026-11-03-maturity-review/README.md 03-07 09-06 16-01 16-04~16-07 # Conflicts: # docs/manual/01-add-a-feature.md # docs/manual/reference/create-feature.md # docs/manual/reference/patterns.md # scripts/create-feature.ts # scripts/test-feature-scaffold.ts
This commit is contained in:
File diff suppressed because it is too large
Load Diff
+490
-161
File diff suppressed because it is too large
Load Diff
@@ -21,7 +21,8 @@ import {
|
||||
/**
|
||||
* U7. A feature from `create:feature` passes the merge gates without an edit
|
||||
* and breaks no other test. A copy of the repository, sample feature
|
||||
* included, gets one generated feature and then runs the merge stage of its
|
||||
* included, gets a default feature and a `--with-create --keyed` one, then
|
||||
* runs the merge stage of its
|
||||
* config/ci/gates.json: every command except those
|
||||
* SCAFFOLD_DRILL_EXCLUDED_SCRIPTS names with a reason (the browser gates,
|
||||
* test:system, the install check and the removal drills). 1103/12-02: this
|
||||
@@ -35,6 +36,8 @@ import {
|
||||
* (decision 4), which proves the command needs nothing from it.
|
||||
*/
|
||||
const FEATURE_ID = "scaffold-feature";
|
||||
/** 1103/09-06. The `--with-create --keyed` slice, in its own context. */
|
||||
const WRITE_FEATURE_ID = "scaffold-write-feature";
|
||||
const REPORT = "artifacts/tests/feature-scaffold.xml";
|
||||
|
||||
const pnpmCli = requireRemovalFixtureEnvironment("npm_execpath");
|
||||
@@ -57,8 +60,13 @@ try {
|
||||
...REMOVAL_FIXTURE_DOCUMENT_TARGETS,
|
||||
]);
|
||||
const created = check("create-feature", "create:feature", [FEATURE_ID]);
|
||||
const checks: RemovalCheck[] = [created];
|
||||
if (created.passed) {
|
||||
const createdWrite = check("create-feature-write", "create:feature", [
|
||||
WRITE_FEATURE_ID,
|
||||
"--with-create",
|
||||
"--keyed",
|
||||
]);
|
||||
const checks: RemovalCheck[] = [created, createdWrite];
|
||||
if (created.passed && createdWrite.passed) {
|
||||
// Commits the copy with the feature, as a project would: git-based
|
||||
// checks (git grep, git ls-files) then see the feature's files.
|
||||
sealRemovalFixtureRepository(fixtureRoot);
|
||||
|
||||
@@ -465,8 +465,11 @@ try {
|
||||
// from create:feature and runs the same gates again: the command and the
|
||||
// feature it writes need nothing from the sample.
|
||||
if (isSample) {
|
||||
// 1103/09-06. With the write slice (NEVER), which needs nothing from
|
||||
// the sample either.
|
||||
const created = check("scaffold-create-feature", "create:feature", [
|
||||
"scaffold-feature",
|
||||
"--with-create",
|
||||
]);
|
||||
checks.push(created);
|
||||
if (created.passed) {
|
||||
|
||||
Reference in New Issue
Block a user