fix(test): 템플릿 시험이 사본에 만드는 기능 ID를 예약 접두어로 옮긴다
frontend-quality-gates / merge / static checks (pull_request) Successful in 2m50s
frontend-quality-gates / merge / tests (pull_request) Failing after 14m15s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 10m29s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
frontend-quality-gates / main / checker self-tests (pull_request) Skipped

템플릿 시험과 드릴이 저장소 사본에 고정 ID로 기능을 만든다. 매뉴얼
코드 조각 시험은 매뉴얼 예시 invoice-feature를(FE-GATE-005), 생성 기능
e2e·청크 복구·부팅 실패 spec은 order-feature를(FE-GATE-008), scaffold
드릴은 scaffold-feature를(FE-GATE-020) 쓴다. 사본에는 제품 기능이 들어
있고 create:feature는 같은 ID나 같은 접두어를 거부한다. 그래서 매뉴얼
1단계 예시대로 invoice-feature를 만든 제품은 기능 코드와 상관없이 merge
게이트에서 막힌다.

고른 방법: 사본에 만드는 기능 ID를 모두 이미 정한 예약 접두어
typecheck-probe-로 옮기고 scripts/lib/template-probe-features.ts 한 곳에
둔다. 매뉴얼 조각은 invoice-feature 기준 그대로 두고, 시험이 조각과
검사 파일의 이름(INVOICE_, Invoice, invoice-, invoice)을 예약 기능의
이름으로 바꿔 넣는다(renameFeatureText). 생성 기능 e2e는 메시지 키와
계약 이름을 ID에서 만든다. 버린 대안: 사본에서 제품의 같은 이름
기능을 먼저 지우기(등록·조립 파일까지 지워야 해 사본이 제품과 달라진다),
create:feature가 흔한 이름을 거부하기(제품 이름을 막는다).

위험·한계: 이름 바꾸기는 낱말 단위 치환이라 조각의 영어 문장 속
invoice도 바뀐다(조각과 검사가 함께 바뀌어 결과는 같다). 제품이
typecheck-probe-로 시작하는 기능을 만들면 다시 부딪친다. 매뉴얼과
create-feature 참조에 쓰지 말라고 적었고 생성 명령이 막지는 않는다.
measure-feature-shape-growth의 s000-feature 꼴 ID는 그대로 뒀다.

검증: desktop에서 RED(이 커밋의 시험을 기준 커밋에 얹음)와 GREEN,
제품 상태(invoice-feature·order-feature를 만든 사본)의 FE-GATE-005·008
재현은 PR 본문에 적는다.

Refs: 1112/08-02
This commit is contained in:
DongHyeonka
2026-11-12 22:32:09 +09:00
parent 5250ff950e
commit 4ab35c4a05
15 changed files with 239 additions and 43 deletions
+1 -1
View File
@@ -139,7 +139,7 @@ function baseOf(id: string): string {
: id;
}
function namesOf(id: string) {
export function namesOf(id: string) {
const base = baseOf(id);
const pascal = base
.split("-")
+27 -13
View File
@@ -5,9 +5,11 @@ import { tmpdir } from "node:os";
import path from "node:path";
import { pathToFileURL } from "node:url";
import { namesOf } from "../create-feature.ts";
import { localBuildEnvironment } from "./build-environment.ts";
import { linkFixtureNodeModules } from "./fixture-node-modules.ts";
import { REMOVAL_FIXTURE_COPY_TARGETS } from "./removal-fixture.ts";
import { TEMPLATE_PROBE_PREFIX } from "./template-probe-features.ts";
/**
* 2026-11-07. The template ships no feature. What needs one in a real build
@@ -19,8 +21,19 @@ import { REMOVAL_FIXTURE_COPY_TARGETS } from "./removal-fixture.ts";
* (scripts/scale/browser-soak.ts, `buildWithGeneratedFeature`). A change of
* the generator's output fails there. The `--keyed` write slice is the widest
* one the command makes.
*
* 1112/08-02. The id begins with the reserved probe prefix: the copy holds
* the product's own features, and a product that had built `order-feature`
* made create:feature refuse this one.
*/
export const GENERATED_FEATURE_ID = "order-feature";
export const GENERATED_FEATURE_ID = `${TEMPLATE_PROBE_PREFIX}order-feature`;
const NAMES = namesOf(GENERATED_FEATURE_ID);
/** The key of one of the feature's words (`<camel>.list.title`). */
export function generatedMessageKey(suffix: string): string {
return `${NAMES.camel}.${suffix}`;
}
export type GeneratedRoute = Readonly<{
routeId: string;
@@ -48,7 +61,7 @@ function node(root: string, args: readonly string[]): string {
return result.stdout;
}
/** The edit of a fixture build: `corepack pnpm create:feature order-feature --with-create --keyed`. */
/** The edit of a fixture build: `corepack pnpm create:feature <GENERATED_FEATURE_ID> --with-create --keyed`. */
export async function addGeneratedFeature(root: string): Promise<void> {
node(root, ["scripts/generate-product-feature-index.ts"]);
node(root, ["scripts/create-feature.ts", GENERATED_FEATURE_ID, "--with-create", "--keyed"]);
@@ -62,23 +75,24 @@ export async function addGeneratedFeature(root: string): Promise<void> {
export function generatedFeature(root: string): GeneratedFeature {
const feature = path.join(root, "src/features", GENERATED_FEATURE_ID);
const module = (file: string) => JSON.stringify(pathToFileURL(path.join(feature, file)).href);
const { base, upper } = NAMES;
const source = `
const { ORDER_FEATURE_CONTRACT } = await import(${module("contracts/order-feature-contract.ts")});
const { ORDER_MESSAGE_CATALOGS } = await import(${module("contracts/order-message-catalog.ts")});
const { ORDER_LIST_ITEMS_CONTRACT } = await import(${module("contracts/order-contract-contribution.ts")});
const { ${upper}_FEATURE_CONTRACT: CONTRACT } = await import(${module(`contracts/${GENERATED_FEATURE_ID}-contract.ts`)});
const { ${upper}_MESSAGE_CATALOGS: CATALOGS } = await import(${module(`contracts/${base}-message-catalog.ts`)});
const { ${upper}_LIST_ITEMS_CONTRACT: LIST_ITEMS } = await import(${module(`contracts/${base}-contract-contribution.ts`)});
const { API_BASE_URL } = JSON.parse(await (await import("node:fs/promises")).readFile("config/runtime/local.json", "utf8"));
const route = (id) => ({
routeId: id,
path: ORDER_FEATURE_CONTRACT.routes[id].path,
chunkId: ORDER_FEATURE_CONTRACT.routes[id].chunkId,
moduleId: ORDER_FEATURE_CONTRACT.routeRuntimeContracts[id].moduleId,
path: CONTRACT.routes[id].path,
chunkId: CONTRACT.routes[id].chunkId,
moduleId: CONTRACT.routeRuntimeContracts[id].moduleId,
});
process.stdout.write(JSON.stringify({
list: route("ORDER_LIST"),
detail: route("ORDER_DETAIL"),
create: route("ORDER_CREATE"),
messages: ORDER_MESSAGE_CATALOGS,
api: new URL(ORDER_LIST_ITEMS_CONTRACT.contract.pathTemplate.slice(1), API_BASE_URL).href,
list: route("${upper}_LIST"),
detail: route("${upper}_DETAIL"),
create: route("${upper}_CREATE"),
messages: CATALOGS,
api: new URL(LIST_ITEMS.contract.pathTemplate.slice(1), API_BASE_URL).href,
}));
`;
return JSON.parse(node(root, ["--input-type=module", "-e", source])) as GeneratedFeature;
+49
View File
@@ -0,0 +1,49 @@
import { namesOf } from "../create-feature.ts";
/**
* 1112/08-02. Feature ids the template's own tests and drills create in a
* copy of the repository. The copy holds the product's features, and
* create:feature refuses an id a feature there already has, or one with the
* same prefix. A template test that used the manual's example
* (`invoice-feature`) or a plain business word (`order-feature`) therefore
* failed FE-GATE-005 and FE-GATE-008 in every product that had built a
* feature by that name. Each id here begins with the prefix the template
* reserves for its probes; docs/manual/reference/create-feature.md tells a
* product not to use it.
*/
export const TEMPLATE_PROBE_PREFIX = "typecheck-probe-";
/** The feature the manual's code blocks are written for (docs/manual/01-add-a-feature.md). */
export const MANUAL_EXAMPLE_FEATURE_ID = "invoice-feature";
/** What tests/unit/manual-code-blocks.test.ts creates and renames the blocks to. */
export const MANUAL_PROBE_FEATURE_ID = `${TEMPLATE_PROBE_PREFIX}${MANUAL_EXAMPLE_FEATURE_ID}`;
/** The sample tests/unit/template-feature-removal-documents.test.ts lists and deletes. */
export const LISTED_SAMPLE_PROBE_FEATURE_ID = `${TEMPLATE_PROBE_PREFIX}listed-sample-feature`;
/** What FE-GATE-020's scaffold drill (scripts/test-feature-scaffold.ts, test:sample-removal) creates. */
export const SCAFFOLD_PROBE_FEATURE_ID = `${TEMPLATE_PROBE_PREFIX}scaffold-feature`;
/** The scaffold drill's `--with-create --keyed` feature. */
export const SCAFFOLD_WRITE_PROBE_FEATURE_ID = `${TEMPLATE_PROBE_PREFIX}scaffold-write-feature`;
function escape(text: string): string {
return text.replace(/[.*+?^${}()|[\]\\]/gu, "\\$&");
}
/**
* `text` written for feature `fromId`, with every spelling create:feature
* derives from an id (`INVOICE_`, `Invoice`, `invoice-`, `invoice`) moved to
* the spelling it derives from `toId`. Prose that uses the word moves too;
* what matters is that the names a block defines and the names it imports
* from the generated feature move together.
*/
export function renameFeatureText(text: string, fromId: string, toId: string): string {
const from = namesOf(fromId);
const to = namesOf(toId);
const spellings = new Map<string, string>([
[from.upper, to.upper],
[from.pascal, to.pascal],
[`${from.base}-`, `${to.base}-`],
[from.camel, to.camel],
]);
const pattern = new RegExp([...spellings.keys()].map(escape).join("|"), "gu");
return text.replace(pattern, (match) => spellings.get(match) ?? match);
}
+7 -2
View File
@@ -4,6 +4,10 @@ import { mkdir, rm, writeFile } from "node:fs/promises";
import path from "node:path";
import { loadCiGateContract } from "./contracts/ci-gates.ts";
import {
SCAFFOLD_PROBE_FEATURE_ID,
SCAFFOLD_WRITE_PROBE_FEATURE_ID,
} from "./lib/template-probe-features.ts";
import {
runScaffoldDrillCommand,
scaffoldDrillCommands,
@@ -37,9 +41,10 @@ import {
* test:sample-removal repeats the generation after deleting the sample
* (decision 4), which proves the command needs nothing from it.
*/
const FEATURE_ID = "scaffold-feature";
/** 1112/08-02. Reserved probe ids: the copy holds the product's own features. */
const FEATURE_ID = SCAFFOLD_PROBE_FEATURE_ID;
/** 1103/09-06. The `--with-create --keyed` slice, in its own context. */
const WRITE_FEATURE_ID = "scaffold-write-feature";
const WRITE_FEATURE_ID = SCAFFOLD_WRITE_PROBE_FEATURE_ID;
const REPORT = "artifacts/tests/feature-scaffold.xml";
const pnpmCli = requireRemovalFixtureEnvironment("npm_execpath");
+2 -1
View File
@@ -32,6 +32,7 @@ import {
type RemovalCheck,
} from "./lib/removal-fixture.ts";
import { REMOVABLE_TEMPLATE_FEATURES } from "./lib/removable-template-features.ts";
import { SCAFFOLD_PROBE_FEATURE_ID } from "./lib/template-probe-features.ts";
/**
* 09-07 (D-10). Removes one installed feature, `--feature=<id>`, from a copy
@@ -528,7 +529,7 @@ try {
// 1103/09-06. With the write slice (NEVER), which needs nothing from
// the sample either.
const created = check("scaffold-create-feature", "create:feature", [
"scaffold-feature",
SCAFFOLD_PROBE_FEATURE_ID,
"--with-create",
]);
checks.push(created);