diff --git a/docs/architecture/decisions/VD-23-api-transport-selection-and-rest-execution.md b/docs/architecture/decisions/VD-23-api-transport-selection-and-rest-execution.md index f9c7fd60..0e1e2fa6 100644 --- a/docs/architecture/decisions/VD-23-api-transport-selection-and-rest-execution.md +++ b/docs/architecture/decisions/VD-23-api-transport-selection-and-rest-execution.md @@ -303,7 +303,7 @@ allowed/required credential header 집합을 독립적으로 재검증한다. `AUTH_MODE=demo`는 profile을 약화시키지 않는다. `createDemoSessionAdapter`가 고정된 비밀 아닌 `DEMO_AUTHORIZATION_MARKER` proof header를 제공하여 strict -`REFERENCE_EXTERNAL_BEARER`를 그대로 만족시킨다. 진짜 anonymous backend는 별도 +`EXTERNAL_BEARER`(16-03 전 이름 `REFERENCE_EXTERNAL_BEARER`)를 그대로 만족시킨다. 진짜 anonymous backend는 별도 anonymous contract/profile을 composition에서 선택해야 한다. credential collaborator는 `AuthOperationContext { signal, deadlineAtMonotonicMs }`를 diff --git a/scripts/scale/measure-feature-shape-growth.ts b/scripts/scale/measure-feature-shape-growth.ts index 4ba1824c..6ff8b8b3 100644 --- a/scripts/scale/measure-feature-shape-growth.ts +++ b/scripts/scale/measure-feature-shape-growth.ts @@ -46,7 +46,6 @@ const BUILD_INPUTS = [ ] as const; // Platform-owned names that only happen to contain "reference". const PLATFORM_TOKENS = [ - "REFERENCE_EXTERNAL_BEARER", "REFERENCE_FEATURE_V1", "supportReference", ] as const; diff --git a/src/adapters/auth/external-session-adapter.ts b/src/adapters/auth/external-session-adapter.ts index 67adb93b..4ae2efc9 100644 --- a/src/adapters/auth/external-session-adapter.ts +++ b/src/adapters/auth/external-session-adapter.ts @@ -101,7 +101,7 @@ export type DemoSessionAdapter = AuthSessionPort & /** * §7.7. `AUTH_MODE=demo` still runs against the strict - * `REFERENCE_EXTERNAL_BEARER` profile, so the demo owner must supply a real + * `EXTERNAL_BEARER` profile, so the demo owner must supply a real * proof header. This marker is a fixed, non-secret placeholder: it exists so * the demo path satisfies the bearer contract instead of weakening it. */ diff --git a/src/contracts/rest-profiles.ts b/src/contracts/rest-profiles.ts index 1c4c9b0d..796eb39a 100644 --- a/src/contracts/rest-profiles.ts +++ b/src/contracts/rest-profiles.ts @@ -57,14 +57,23 @@ export type RestCsrfProfile = Readonly<{ headerName: "x-csrf-token" | null; }>; +const EXTERNAL_BEARER = Object.freeze({ + authProfileId: "EXTERNAL_BEARER", + transport: "BEARER_HEADER", + credentials: "omit", + allowedCredentialHeaders: Object.freeze(["authorization"] as const), + requiredCredentialHeaders: Object.freeze(["authorization"] as const), +}); + export const REST_AUTH_PROFILES = Object.freeze({ - REFERENCE_EXTERNAL_BEARER: Object.freeze({ - authProfileId: "REFERENCE_EXTERNAL_BEARER", - transport: "BEARER_HEADER", - credentials: "omit", - allowedCredentialHeaders: Object.freeze(["authorization"] as const), - requiredCredentialHeaders: Object.freeze(["authorization"] as const), - }), + EXTERNAL_BEARER, + /** + * @deprecated 16-03: use `EXTERNAL_BEARER`. Same transport and headers under + * the sample's old name, kept for one release so a downstream operation that + * still names it resolves. Remove it in the next minor release with a + * CHANGELOG [계약] entry (owner: frontend-platform). + */ + REFERENCE_EXTERNAL_BEARER: Object.freeze({ ...EXTERNAL_BEARER, authProfileId: "REFERENCE_EXTERNAL_BEARER" }), ANONYMOUS: Object.freeze({ authProfileId: "ANONYMOUS", transport: "ANONYMOUS", diff --git a/src/features/reference-feature/contracts/reference-api-contract.ts b/src/features/reference-feature/contracts/reference-api-contract.ts index b22f6bc9..55e6afb1 100644 --- a/src/features/reference-feature/contracts/reference-api-contract.ts +++ b/src/features/reference-feature/contracts/reference-api-contract.ts @@ -89,7 +89,7 @@ export const REFERENCE_API_CONTRACT = Object.freeze({ responseMediaTypes: ["application/json"], maxResponseBytes: 262_144, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "NoRequest", pathParameterNames: [], @@ -117,7 +117,7 @@ export const REFERENCE_API_CONTRACT = Object.freeze({ responseMediaTypes: ["application/json"], maxResponseBytes: 32_768, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "NoRequest", pathParameterNames: [], @@ -145,7 +145,7 @@ export const REFERENCE_API_CONTRACT = Object.freeze({ responseMediaTypes: ["application/json"], maxResponseBytes: 32_768, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "ReferenceResourceParams", pathParameterNames: ["resourceId"], diff --git a/src/features/reference-feature/contracts/reference-feature-contract-contribution.ts b/src/features/reference-feature/contracts/reference-feature-contract-contribution.ts index 47b77fa6..fb5daae5 100644 --- a/src/features/reference-feature/contracts/reference-feature-contract-contribution.ts +++ b/src/features/reference-feature/contracts/reference-feature-contract-contribution.ts @@ -108,7 +108,7 @@ export const LIST_REFERENCE_RESOURCES_CONTRACT = Object.freeze({ responseByteLimit: 262_144, totalDeadlineMs: 10_000, retryBudget: 2 as const, - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", diagnosticsOperation: "reference.list", traffic: Object.freeze({ maxPhysicalRequests: 3, @@ -158,7 +158,7 @@ export const GET_REFERENCE_RESOURCE_CONTRACT = Object.freeze({ responseByteLimit: 32_768, totalDeadlineMs: 10_000, retryBudget: 2 as const, - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", diagnosticsOperation: "reference.detail", traffic: Object.freeze({ maxPhysicalRequests: 3, @@ -216,7 +216,7 @@ export const CREATE_REFERENCE_RESOURCE_CONTRACT = Object.freeze({ * than relying on a runtime special case. */ retryBudget: 0 as const, - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", diagnosticsOperation: "reference.create", traffic: Object.freeze({ maxPhysicalRequests: 1, diff --git a/tests/features/reference-feature/reference-contract.test.ts b/tests/features/reference-feature/reference-contract.test.ts index fb7bebcc..029eaf36 100644 --- a/tests/features/reference-feature/reference-contract.test.ts +++ b/tests/features/reference-feature/reference-contract.test.ts @@ -135,7 +135,7 @@ describe("reference feature boundary contracts", () => { pathSchema: "ReferenceResourceParams", pathParameterNames: ["resourceId"], providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", }); }); diff --git a/tests/integration/http-execution-v3-auth-profile.test.ts b/tests/integration/http-execution-v3-auth-profile.test.ts index 0c8b49bd..e7264718 100644 --- a/tests/integration/http-execution-v3-auth-profile.test.ts +++ b/tests/integration/http-execution-v3-auth-profile.test.ts @@ -279,7 +279,7 @@ describe("V3 installed auth profile authority", () => { }); it("keeps the shipped bearer profile strict", () => { - expect(REST_AUTH_PROFILES.REFERENCE_EXTERNAL_BEARER).toMatchObject({ + expect(REST_AUTH_PROFILES.EXTERNAL_BEARER).toMatchObject({ transport: "BEARER_HEADER", credentials: "omit", requiredCredentialHeaders: ["authorization"], diff --git a/tests/integration/http-scenario-catalog.test.ts b/tests/integration/http-scenario-catalog.test.ts index 84461f19..0c719b3d 100644 --- a/tests/integration/http-scenario-catalog.test.ts +++ b/tests/integration/http-scenario-catalog.test.ts @@ -231,7 +231,7 @@ async function executeScenario( const executor = createContractHttpExecutor({ baseUrl: "https://api.test", maxRetryAttempts: 2, - // The reference contribution declares REFERENCE_EXTERNAL_BEARER, so the + // The reference contribution declares EXTERNAL_BEARER, so the // credential owner must supply the required proof header before dispatch. attachCredentials: () => ({ kind: "READY", diff --git a/tests/integration/legacy-http-credential-authority.test.ts b/tests/integration/legacy-http-credential-authority.test.ts index 0ee7200f..7f407fb7 100644 --- a/tests/integration/legacy-http-credential-authority.test.ts +++ b/tests/integration/legacy-http-credential-authority.test.ts @@ -35,7 +35,7 @@ const BEARER_LIST = defineRestOperation({ responseMediaTypes: ["application/json"], maxResponseBytes: 32_768, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "NoRequest", pathParameterNames: [], diff --git a/tests/unit/api-operation-v2.test.ts b/tests/unit/api-operation-v2.test.ts index 86552fd7..3e04d094 100644 --- a/tests/unit/api-operation-v2.test.ts +++ b/tests/unit/api-operation-v2.test.ts @@ -29,7 +29,7 @@ function operation(operationId = "GET_RESOURCE") { responseMediaTypes: ["application/json"], maxResponseBytes: 32_768, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "ResourceParams", pathParameterNames: ["resourceId"], diff --git a/tests/unit/browser-rpc/fixture.ts b/tests/unit/browser-rpc/fixture.ts index e5691ca7..c2578c9a 100644 --- a/tests/unit/browser-rpc/fixture.ts +++ b/tests/unit/browser-rpc/fixture.ts @@ -36,7 +36,7 @@ export function unaryProfile( descriptorArtifactId: "buf.example.resource.v1", descriptorDigest: DESCRIPTOR_DIGEST, allowedProcedures: ["example.resource.v1.ResourceService/GetResource"], - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", corsProfileId: "SAME_ORIGIN_RPC", errorProfileId: "CONNECT_ERROR_V1", @@ -81,7 +81,7 @@ export function unaryOperation( responseSchemaId: "RpcResourceResponse", requestEncoderId: "RpcResourceRequestEncoder", mapperId: "RpcResourceMapper", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", errorProfileId: "CONNECT_ERROR_V1", deadlineProfileId: "RPC_TOTAL_5S", diff --git a/tests/unit/contract-registry-immutability.test.ts b/tests/unit/contract-registry-immutability.test.ts index a248b2b9..259f13a6 100644 --- a/tests/unit/contract-registry-immutability.test.ts +++ b/tests/unit/contract-registry-immutability.test.ts @@ -70,7 +70,7 @@ describe("LIVE-02 installed REST auth profile registry", () => { expect(registry.size).toBe(before); expect(registry.get("ANONYMOUS")).toBe(identity); - expect(registry.get("REFERENCE_EXTERNAL_BEARER")?.credentials).toBe("omit"); + expect(registry.get("EXTERNAL_BEARER")?.credentials).toBe("omit"); }); it("does not observe a post-installation mutation of the source record", () => { @@ -94,6 +94,7 @@ describe("LIVE-02 installed REST auth profile registry", () => { expect(registry.has("NO_SUCH_PROFILE")).toBe(false); expect([...registry.keys()].sort()).toEqual([ "ANONYMOUS", + "EXTERNAL_BEARER", "REFERENCE_EXTERNAL_BEARER", ]); expect([...registry.entries()].length).toBe(registry.size); diff --git a/tests/unit/contract-snapshot-bypass.test.ts b/tests/unit/contract-snapshot-bypass.test.ts index 79304b44..6d938b92 100644 --- a/tests/unit/contract-snapshot-bypass.test.ts +++ b/tests/unit/contract-snapshot-bypass.test.ts @@ -246,8 +246,8 @@ describe("REST auth profile registry", () => { let installed: ReturnType | undefined; try { installed = installRestAuthProfileRegistry({ - REFERENCE_EXTERNAL_BEARER: { - ...REST_AUTH_PROFILES.REFERENCE_EXTERNAL_BEARER, + EXTERNAL_BEARER: { + ...REST_AUTH_PROFILES.EXTERNAL_BEARER, allowedCredentialHeaders: allowed as never, }, }); @@ -255,7 +255,7 @@ describe("REST auth profile registry", () => { return; } expect( - installed.get("REFERENCE_EXTERNAL_BEARER")?.allowedCredentialHeaders, + installed.get("EXTERNAL_BEARER")?.allowedCredentialHeaders, ).toEqual(["authorization"]); }); }); diff --git a/tests/unit/feature-shape-growth.test.ts b/tests/unit/feature-shape-growth.test.ts index daaf6fc1..c97d6422 100644 --- a/tests/unit/feature-shape-growth.test.ts +++ b/tests/unit/feature-shape-growth.test.ts @@ -78,7 +78,7 @@ describe("feature-shape growth measurement (11-04)", () => { it("keeps platform-owned names that only contain the word", () => { const source = - "REFERENCE_EXTERNAL_BEARER REFERENCE_FEATURE_V1 supportReference"; + "REFERENCE_FEATURE_V1 supportReference"; expect(renameReferenceFeature(source, "s001", context)).toBe(source); }); diff --git a/tests/unit/rest-profile-contract.test.ts b/tests/unit/rest-profile-contract.test.ts index 629f69d9..d64627a5 100644 --- a/tests/unit/rest-profile-contract.test.ts +++ b/tests/unit/rest-profile-contract.test.ts @@ -1,3 +1,6 @@ +import { readdir, readFile } from "node:fs/promises"; +import path from "node:path"; + import { describe, expect, it } from "vitest"; import { defineRestOperation } from "../../src/contracts/api-operations.ts"; @@ -42,7 +45,7 @@ const SAMPLE_COMMAND = defineRestOperation({ responseMediaTypes: ["application/json"], maxResponseBytes: 32_768, providerId: "PRIMARY_API", - authProfileId: "REFERENCE_EXTERNAL_BEARER", + authProfileId: "EXTERNAL_BEARER", csrfProfileId: "NO_CSRF_BEARER", pathSchema: "NoRequest", pathParameterNames: [], @@ -125,7 +128,7 @@ describe("REST provider/auth/CSRF profiles", () => { expect(() => validateRestProfileBindings(publicWithBearer, { PRIMARY_API: ["omit"] }), ).toThrow( - /CREATE_SAMPLE_RESOURCE.*auth "none" needs an ANONYMOUS profile.*REFERENCE_EXTERNAL_BEARER is BEARER_HEADER/, + /CREATE_SAMPLE_RESOURCE.*auth "none" needs an ANONYMOUS profile.*EXTERNAL_BEARER is BEARER_HEADER/, ); }); }); @@ -143,8 +146,8 @@ describe("one installed REST auth profile registry", () => { it("rejects a raw profile record that installation would refuse", () => { const incoherent = { - REFERENCE_EXTERNAL_BEARER: { - ...REST_AUTH_PROFILES.REFERENCE_EXTERNAL_BEARER, + EXTERNAL_BEARER: { + ...REST_AUTH_PROFILES.EXTERNAL_BEARER, credentials: "same-origin" as const, }, }; @@ -160,7 +163,7 @@ describe("one installed REST auth profile registry", () => { provider, INSTALLED_REST_AUTH_PROFILES, ).auth, - ).toBe(INSTALLED_REST_AUTH_PROFILES.get("REFERENCE_EXTERNAL_BEARER")); + ).toBe(INSTALLED_REST_AUTH_PROFILES.get("EXTERNAL_BEARER")); }); it("does not resolve an inherited profile id", () => { @@ -177,7 +180,7 @@ describe("one installed REST auth profile registry", () => { const registry = installRestAuthProfileRegistry({ ...REST_AUTH_PROFILES, CUSTOM_BEARER: { - ...REST_AUTH_PROFILES.REFERENCE_EXTERNAL_BEARER, + ...REST_AUTH_PROFILES.EXTERNAL_BEARER, authProfileId: "CUSTOM_BEARER", }, }); @@ -197,3 +200,38 @@ describe("one installed REST auth profile registry", () => { ).toBe(1); }); }); + +/** + * 1101/16-03. The only bearer profile is the platform's, not the sample's: + * `EXTERNAL_BEARER`. The old name stays for one release as a deprecated alias + * that resolves to the same transport and headers. + */ +describe("EXTERNAL_BEARER and its deprecated alias (16-03)", () => { + it("resolves the alias exactly like EXTERNAL_BEARER but for its id", () => { + expect(INSTALLED_REST_AUTH_PROFILES.get("EXTERNAL_BEARER")).toMatchObject({ + transport: "BEARER_HEADER", + requiredCredentialHeaders: ["authorization"], + }); + expect({ + ...INSTALLED_REST_AUTH_PROFILES.get("REFERENCE_EXTERNAL_BEARER"), + authProfileId: "EXTERNAL_BEARER", + }).toEqual(INSTALLED_REST_AUTH_PROFILES.get("EXTERNAL_BEARER")); + }); + + it("keeps the old name in src only on the alias line", async () => { + const files = (await readdir("src", { recursive: true })) + .filter((file) => /\.tsx?$/u.test(file)) + .map((file) => path.join("src", file)); + const lines: string[] = []; + for (const file of files) { + for (const line of (await readFile(file, "utf8")).split("\n")) { + if (line.includes("REFERENCE_EXTERNAL_BEARER")) { + lines.push(`${file}: ${line.trim()}`); + } + } + } + expect(lines).toEqual([ + 'src/contracts/rest-profiles.ts: REFERENCE_EXTERNAL_BEARER: Object.freeze({ ...EXTERNAL_BEARER, authProfileId: "REFERENCE_EXTERNAL_BEARER" }),', + ]); + }); +}); diff --git a/tests/unit/runtime-adapters-auth-profile.test.ts b/tests/unit/runtime-adapters-auth-profile.test.ts index 8ae96205..2200b91f 100644 --- a/tests/unit/runtime-adapters-auth-profile.test.ts +++ b/tests/unit/runtime-adapters-auth-profile.test.ts @@ -52,7 +52,7 @@ vi.mock("../../src/features/installed-contract-contributions.ts", async (importO ...TEST_CONTRACT_CONTRIBUTION, http: [ list, - fixture.withProfile(list, "TEST_LIST_ENTITIES_BEARER", "REFERENCE_EXTERNAL_BEARER"), + fixture.withProfile(list, "TEST_LIST_ENTITIES_BEARER", "EXTERNAL_BEARER"), ] as typeof TEST_CONTRACT_CONTRIBUTION.http, }, ]); @@ -132,7 +132,7 @@ const ANONYMOUS_OPERATION = TEST_LIST_HTTP_CONTRACT; const BEARER_OPERATION = fixture.withProfile( TEST_LIST_HTTP_CONTRACT, "TEST_LIST_ENTITIES_BEARER", - "REFERENCE_EXTERNAL_BEARER", + "EXTERNAL_BEARER", ); function externalOwner(