diff --git a/config/ci/ungated-scripts.json b/config/ci/ungated-scripts.json index 62f76209..bb787a51 100644 --- a/config/ci/ungated-scripts.json +++ b/config/ci/ungated-scripts.json @@ -3,7 +3,7 @@ "entries": [ { "script": "check:feature-index", - "reason": "The generated indexes (src/.generated/) are not committed, and every gate script regenerates them first (generate-product-feature-index.ts), so --check can only tell a developer that the local copy is stale." + "reason": "Local check that the generated indexes (src/.generated/, not committed) are current, and the first step of verify:extreme-scale (scripts/verify-extreme-scale.ts), itself a local run. A gate gains nothing from it: every gate script regenerates the indexes first (generate-product-feature-index.ts)." }, { "script": "check:http-scenario-evidence", diff --git a/tests/unit/ungated-scripts.test.ts b/tests/unit/ungated-scripts.test.ts index 2ac5cfef..99387efe 100644 --- a/tests/unit/ungated-scripts.test.ts +++ b/tests/unit/ungated-scripts.test.ts @@ -10,6 +10,7 @@ import { UNGATED_SCRIPTS_PATH, } from "../../scripts/lib/ungated-scripts.ts"; import { gatedTestPaths } from "../../scripts/lib/ungated-tests.ts"; +import { EXTREME_SCALE_GATES } from "../../scripts/verify-extreme-scale.ts"; /** * 12-04. Test files had an orphan check; package scripts did not. A `check:*` @@ -64,6 +65,17 @@ describe("ungated verification scripts", () => { }, ); + // 1101/12-05: the exclusion said only that the check can tell a developer + // the local copy is stale, which read as a reason to delete it. It stays + // because verify:extreme-scale runs it; if that stops, it can go. + it("names verify:extreme-scale as the user of check:feature-index", async () => { + const { exclusions } = await repositoryInputs(); + expect(EXTREME_SCALE_GATES).toContain("check:feature-index"); + expect( + exclusions.find(({ script }) => script === "check:feature-index")?.reason, + ).toContain("verify:extreme-scale"); + }); + it("rejects a check script that no gate reaches", () => { expect(ungatedScriptFailures(fixture)).toEqual([ `verification script is not reached by any CI gate command and is not in ${UNGATED_SCRIPTS_PATH}: check:orphan`,