From 6ceb84740c06aa62293015f42abefb01d0823ace Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Tue, 3 Nov 2026 01:23:02 +0900 Subject: [PATCH] =?UTF-8?q?chore(ci):=20check:feature-index=20=EC=98=88?= =?UTF-8?q?=EC=99=B8=20=EC=9D=B4=EC=9C=A0=EC=97=90=20=EC=8B=A4=EC=A0=9C=20?= =?UTF-8?q?=EC=82=AC=EC=9A=A9=EC=B2=98=EB=A5=BC=20=EC=A0=81=EB=8A=94?= =?UTF-8?q?=EB=8B=A4=20(1101/12-05)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제 config/ci/ungated-scripts.json의 check:feature-index 이유는 "--check는 로컬 사본이 오래됐다는 것만 알려 줄 수 있다"이다. 쓸모없다는 말로 읽혀 리뷰가 지울 후보로 올렸다. 실제로는 scripts/verify-extreme-scale.ts가 EXTREME_SCALE_GATES 첫 단계로 이 script를 부른다. 고른 방법 - 지우지 않는다. 이유 문구를 "로컬에서 생성 인덱스가 오래됐는지 확인, verify:extreme-scale(scripts/verify-extreme-scale.ts)의 첫 단계. 게이트는 인덱스를 먼저 다시 만들어서 얻는 것이 없다"로 고친다. - ungated-scripts 테스트가 EXTREME_SCALE_GATES에 이 script가 있고 이유가 verify:extreme-scale을 적는지 확인한다. verify:extreme-scale이 이 script를 그만 부르면 실패해서 다시 지울 후보가 된다. - 12-05의 나머지(script 4개 삭제, scan: 접두어 검사)는 98b9682가 했다. 버린 대안 - check:feature-index 삭제: verify-extreme-scale.ts의 단계 목록과 tests/scripts/verify-extreme-scale.test.ts를 같이 고쳐야 하고, 로컬에서 생성 인덱스가 오래됐는지 볼 방법이 없어진다. 위험·한계 - 게이트 명령은 바뀌지 않는다. CI 계약 기준선은 그대로다. 검증 - RED: 새 테스트 "names verify:extreme-scale as the user of check:feature-index"가 실패(expected 'The generated indexes (src/.generated…' to contain 'verify:extreme-scale'). - GREEN: ungated-scripts·ungated-tests·verify-extreme-scale 31/31 통과. - check:ci 세 단계를 pnpm 없이 직접 실행: generate-artifact-schemas --check PASS, check-ci-contract.ts PASS(27 gates), generate-ci-workflow --check PASS. 바꾼 테스트 eslint 통과. Refs: docs/reviews/2026-11-01-maturity-review/12-guardrails-ci.md 12-05 --- config/ci/ungated-scripts.json | 2 +- tests/unit/ungated-scripts.test.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/config/ci/ungated-scripts.json b/config/ci/ungated-scripts.json index 62f76209..bb787a51 100644 --- a/config/ci/ungated-scripts.json +++ b/config/ci/ungated-scripts.json @@ -3,7 +3,7 @@ "entries": [ { "script": "check:feature-index", - "reason": "The generated indexes (src/.generated/) are not committed, and every gate script regenerates them first (generate-product-feature-index.ts), so --check can only tell a developer that the local copy is stale." + "reason": "Local check that the generated indexes (src/.generated/, not committed) are current, and the first step of verify:extreme-scale (scripts/verify-extreme-scale.ts), itself a local run. A gate gains nothing from it: every gate script regenerates the indexes first (generate-product-feature-index.ts)." }, { "script": "check:http-scenario-evidence", diff --git a/tests/unit/ungated-scripts.test.ts b/tests/unit/ungated-scripts.test.ts index 2ac5cfef..99387efe 100644 --- a/tests/unit/ungated-scripts.test.ts +++ b/tests/unit/ungated-scripts.test.ts @@ -10,6 +10,7 @@ import { UNGATED_SCRIPTS_PATH, } from "../../scripts/lib/ungated-scripts.ts"; import { gatedTestPaths } from "../../scripts/lib/ungated-tests.ts"; +import { EXTREME_SCALE_GATES } from "../../scripts/verify-extreme-scale.ts"; /** * 12-04. Test files had an orphan check; package scripts did not. A `check:*` @@ -64,6 +65,17 @@ describe("ungated verification scripts", () => { }, ); + // 1101/12-05: the exclusion said only that the check can tell a developer + // the local copy is stale, which read as a reason to delete it. It stays + // because verify:extreme-scale runs it; if that stops, it can go. + it("names verify:extreme-scale as the user of check:feature-index", async () => { + const { exclusions } = await repositoryInputs(); + expect(EXTREME_SCALE_GATES).toContain("check:feature-index"); + expect( + exclusions.find(({ script }) => script === "check:feature-index")?.reason, + ).toContain("verify:extreme-scale"); + }); + it("rejects a check script that no gate reaches", () => { expect(ungatedScriptFailures(fixture)).toEqual([ `verification script is not reached by any CI gate command and is not in ${UNGATED_SCRIPTS_PATH}: check:orphan`,