fix(auth): report only a server 401 to the session owner (R-3.2)
V3 returned the same UNAUTHENTICATED outcome for "no credential, nothing sent" and for a server 401, and the composition root called onUnauthenticated() for both. With the demo owner that overwrote a recovery-pending session with "unauthenticated", and the demo setState notified even when the value did not change, which fed the scope-fence loop. - V3: the server-401 UNAUTHENTICATED outcome now carries its response `metadata` (additive optional field). The pre-dispatch one does not. - runtime-adapters: onUnauthenticated() only when metadata is present. - demo session: setState is a no-op for the current value. RED before fix: reference-runtime-composition.test.ts "does not report a request refused before dispatch as a sign-out" (state became "unauthenticated"), auth-session-adapter.test.ts "does not notify when the demo state is set to its current value" (1 notification), http-execution-v3.test.ts "tells a missing credential apart from a server 401" (no metadata). Pinned: "still signs out when the server answers 401". Gates: check:architecture, check:types:app, check:types:test, lint, test:component, test:integration, test:reference-feature, test:contract pass. test:unit passes except removal-fixture.test.ts (needs generated artifacts/ release evidence absent in a fresh worktree; unrelated). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
a39eed6c11
commit
70158d17c1
@@ -1,5 +1,6 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
import type { DemoSessionAdapter } from "../../../src/adapters/auth/external-session-adapter.ts";
|
||||
import { createRuntimeAdapters } from "../../../src/bootstrap/runtime-adapters.ts";
|
||||
import { createRuntimeIdentityRegistry } from "../../../src/contracts/query-keys.ts";
|
||||
import { bindQuery } from "../../../src/contracts/server-state.ts";
|
||||
@@ -210,4 +211,59 @@ describe("reference feature runtime composition", () => {
|
||||
expect(safeEvidence).not.toContain("private-idempotency-key");
|
||||
adapters.infrastructure.dispose();
|
||||
});
|
||||
|
||||
/**
|
||||
* R-3.2. A request refused before dispatch because no credential exists is
|
||||
* not a session verdict. Reporting it to the owner overwrote a recovering
|
||||
* session and could loop through the scope fence; only a server 401 may.
|
||||
*/
|
||||
it("does not report a request refused before dispatch as a sign-out", async () => {
|
||||
const fetcher = vi.fn(async () => Response.json([]));
|
||||
const adapters = await createRuntimeAdapters({
|
||||
runtime,
|
||||
release,
|
||||
host: {},
|
||||
fetcher,
|
||||
});
|
||||
const session = adapters.outputPorts.session as DemoSessionAdapter;
|
||||
session.setState("recovery-pending");
|
||||
await vi.waitFor(() =>
|
||||
expect(adapters.infrastructure.serverStateScope.getPhase()).toBe("READY"),
|
||||
);
|
||||
const notifications = vi.fn();
|
||||
session.subscribe(notifications);
|
||||
|
||||
await expect(
|
||||
referenceInput(adapters).listResources({ limit: 20 }),
|
||||
).resolves.toMatchObject({ ok: false });
|
||||
|
||||
expect(fetcher).not.toHaveBeenCalled();
|
||||
expect(session.getState()).toBe("recovery-pending");
|
||||
expect(notifications).not.toHaveBeenCalled();
|
||||
adapters.infrastructure.dispose();
|
||||
});
|
||||
|
||||
it("still signs out when the server answers 401", async () => {
|
||||
const fetcher = vi.fn(
|
||||
async () => new Response(null, { status: 401 }),
|
||||
);
|
||||
const adapters = await createRuntimeAdapters({
|
||||
runtime,
|
||||
release,
|
||||
host: {},
|
||||
fetcher,
|
||||
});
|
||||
await adapters.outputPorts.session.beginSignIn();
|
||||
await vi.waitFor(() =>
|
||||
expect(adapters.infrastructure.serverStateScope.getPhase()).toBe("READY"),
|
||||
);
|
||||
|
||||
await expect(
|
||||
referenceInput(adapters).listResources({ limit: 20 }),
|
||||
).resolves.toMatchObject({ ok: false });
|
||||
|
||||
expect(fetcher).toHaveBeenCalledOnce();
|
||||
expect(adapters.outputPorts.session.getState()).toBe("unauthenticated");
|
||||
adapters.infrastructure.dispose();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user