From 70d0ac1ca29a7f001d712996a7e8740fd911e47d Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Tue, 3 Nov 2026 00:55:10 +0900 Subject: [PATCH] =?UTF-8?q?chore(registry):=20=EB=A0=88=EC=A7=80=EC=8A=A4?= =?UTF-8?q?=ED=8A=B8=EB=A6=AC=20=EA=B8=B0=EC=A4=80=EC=84=A0=EC=9D=84=20?= =?UTF-8?q?=EC=9E=AC=EC=8A=B9=EC=9D=B8=ED=95=98=EA=B3=A0=20=EC=98=AE?= =?UTF-8?q?=EA=B8=B4=20source=20=EA=B2=BD=EB=A1=9C=EB=A5=BC=20=EB=B0=94?= =?UTF-8?q?=EB=A1=9C=EC=9E=A1=EB=8A=94=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제 registry-baseline.json의 FE-REG-API·FE-REG-SCHEMA source가 15-01(298201f, 기능 실행부 분리) 뒤에도 src/features/installed-feature-contracts.ts를 가리킨다. 두 레지스트리는 지금 src/features/loaded-feature-runtimes.ts에 있다. 기준선 diff는 contract와 rows만 비교하고 source는 보지 않아서 아무 검사도 이를 잡지 못했다. 또 0929/07-03(FE-REG-ROUTE contract 변경)과 1101/16-03(FE-REG-API authProfileId 3건)이 증거와 diff로만 남아 있다. 고른 방법 - 기준선을 한 번 재승인했다. update:registry-baseline의 node 하위 명령을 직접 실행했다(pnpm은 쓰지 않음): node scripts/generate-product-feature-index.ts node scripts/check-registries.ts --no-baseline \ --artifact artifacts/quality/registry-current-snapshot.json REGISTRY_BASELINE_OWNER=DongHyeonka REGISTRY_BASELINE_REASON=... node scripts/update-registry-baseline.ts owner는 DongHyeonka, reason은 "2026-11-03 사용자가 결정을 위임함: 0929/07-03, 1101/16-03, 15-01 source 경로. 승인 뒤 쌓인 0925/08-13·1101/05-01(증거로 유지), VITE_BUILD_ID 기본값· service-worker.start.failed 행(증거 불필요)도 함께 흡수"다. 사용자가 이 결정을 오케스트레이터에게 위임했고, 재승인은 A8만 한다. - 새 기준선은 지금 스냅샷이라 source 경로가 실제 파일로 바뀌었다. 같은 재승인이 이전 승인(2026-09-25) 뒤 쌓인 변경을 모두 흡수한다: FE-REG-ROUTE allowedValues 축소와 fieldPatterns 추가(0929/07-03), authProfileId 3건(1101/16-03), REFERENCE_RESOURCE_DETAIL.path(0925/08-13), CACHE_INVALIDATION_PULSE backend·valueCodec과 STORAGE backend 허용값 external(1101/05-01), VITE_BUILD_ID defaultValue(13-15), service-worker.start.failed 텔레메트리 행(0925/06-05). - update:registry-baseline이 0929/07-01 (3)대로 증거 5건을 지웠다(위 08-13 1건, 05-01 2건, 07-03 2건). 증거 파일은 빈 목록이다. 지운 행은 git 이력에 있다. - 재발 방지 테스트: 기준선의 source가 governance path와 다르면 registry-governance.test.ts가 레지스트리 id를 나열하며 실패한다. 버린 대안 - source만 손으로 고치기: 승인 digest가 깨진다. 재승인 없이 기준선을 바꾸는 길을 만든다. - 07-03·16-03 커밋마다 재승인: 지시는 한 번의 재승인이다. 그 사이 각 커밋은 증거(07-03)나 behavior-change(16-03)로 게이트를 통과했다. - 기준선 diff가 source도 비교하게 하기: 파일을 옮기는 것은 공개 계약 변경이 아닌데 breaking 분류가 필요해진다. 테스트로 재승인만 요구한다. 위험·한계 - 레지스트리 파일을 옮기면 이제 테스트가 재승인을 요구한다. 재승인은 그 시점까지의 변경을 모두 흡수하므로, 옮기기 전에 남은 breaking 변경이 있으면 그 커밋 본문에 적어야 한다. - 다운스트림은 이 기준선을 템플릿 이력으로 받는다. 자기 기준선을 다시 찍는 절차는 0929/07-04 범위다. 검증 - RED(재승인 전): 새 테스트 "names each registry's governed source in the approved baseline"가 "expected [ 'FE-REG-API', 'FE-REG-SCHEMA' ] to deeply equal []"로 실패. - GREEN: 같은 테스트 통과. check-registries "11 registries PASS; compatibility=none". 승인 digest 3c3702b55ad8849f399833206ea4515808eda6ab6d1fd5c49e90f8579e644170. - 회귀: tests/{unit,integration,features,contract,runtime-schema} 207 파일 2,367건 통과(pnpm·프로세스를 띄우는 6개 제외), 그중 제외했던 deployment-admission은 따로 22/22. compatibility fixtures 11 PASS. verify-documentation-readiness PASS_SCOPED. tsc test rc=0, 바꾼 테스트 eslint rc=0. - 미실행: check:architecture, test:sample-removal(pnpm 필요). Refs: docs/reviews/2026-09-29-maturity-review/07-contracts.md Refs: docs/reviews/2026-11-01-maturity-review/16-structure-patterns.md --- .../contracts/registry-baseline.approval.json | 8 +-- config/contracts/registry-baseline.json | 72 +++++++++++-------- .../contracts/registry-change-evidence.json | 51 +------------ tests/unit/registry-governance.test.ts | 21 ++++++ 4 files changed, 68 insertions(+), 84 deletions(-) diff --git a/config/contracts/registry-baseline.approval.json b/config/contracts/registry-baseline.approval.json index 1c30ebaa..ea584524 100644 --- a/config/contracts/registry-baseline.approval.json +++ b/config/contracts/registry-baseline.approval.json @@ -1,7 +1,7 @@ { "schemaVersion": 1, - "snapshotDigest": "83d11f848b8b2f67bcb657403f112d4baaf05481ab6bcee94ebc6851c32e2159", - "owner": "frontend-platform", - "reason": "07-04: FE-REG-ERROR drops severity, telemetryEvent and redaction, which nothing read", - "approvedAt": "2026-09-25T15:11:58.763Z" + "snapshotDigest": "3c3702b55ad8849f399833206ea4515808eda6ab6d1fd5c49e90f8579e644170", + "owner": "DongHyeonka", + "reason": "2026-11-03 사용자가 결정을 위임함: 0929/07-03, 1101/16-03, 15-01 source 경로. 승인 뒤 쌓인 0925/08-13·1101/05-01(증거로 유지), VITE_BUILD_ID 기본값·service-worker.start.failed 행(증거 불필요)도 함께 흡수", + "approvedAt": "2026-11-02T15:53:54.852Z" } diff --git a/config/contracts/registry-baseline.json b/config/contracts/registry-baseline.json index 46dc3ebb..4294d79f 100644 --- a/config/contracts/registry-baseline.json +++ b/config/contracts/registry-baseline.json @@ -43,24 +43,6 @@ "public", "session-required" ], - "paramsSchema": [ - null, - "NotFoundSplat", - "ReferenceResourceParams" - ], - "searchSchema": [ - null, - "ReferenceResourceListQuery" - ], - "loadingSurface": [ - "app-shell", - "example-page", - "reference-resource-list", - "reference-resource-detail", - "reference-resource-form", - "reference-resource-status", - "none" - ], "errorSurface": [ "route-boundary", "feature-boundary", @@ -92,7 +74,10 @@ "searchSchema", "access", "chunkId" - ] + ], + "fieldPatterns": { + "loadingSurface": "^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$" + } }, "rows": { "APP_HOME": { @@ -181,7 +166,7 @@ "navigationLabel": null, "navigationOrder": null, "paramsSchema": "ReferenceResourceParams", - "path": "/examples/reference-resources/:resourceId", + "path": "/examples/reference-resources/items/:resourceId", "routeId": "REFERENCE_RESOURCE_DETAIL", "searchSchema": null, "title": "Reference detail" @@ -341,7 +326,7 @@ { "registryId": "FE-REG-API", "owner": "feature-frontend-api-client-response-envelope-contract", - "source": "src/features/installed-feature-contracts.ts", + "source": "src/features/loaded-feature-runtimes.ts", "rowCount": 3, "contract": { "requiredFields": [ @@ -427,7 +412,7 @@ "rows": { "CREATE_REFERENCE_RESOURCE": { "auth": "external-session", - "authProfileId": "REFERENCE_EXTERNAL_BEARER", + "authProfileId": "EXTERNAL_BEARER", "contractVersion": 2, "csrfProfileId": "NO_CSRF_BEARER", "idempotency": "keyed", @@ -460,7 +445,7 @@ }, "GET_REFERENCE_RESOURCE": { "auth": "external-session", - "authProfileId": "REFERENCE_EXTERNAL_BEARER", + "authProfileId": "EXTERNAL_BEARER", "contractVersion": 2, "csrfProfileId": "NO_CSRF_BEARER", "idempotency": "safe", @@ -494,7 +479,7 @@ }, "LIST_REFERENCE_RESOURCES": { "auth": "external-session", - "authProfileId": "REFERENCE_EXTERNAL_BEARER", + "authProfileId": "EXTERNAL_BEARER", "contractVersion": 2, "csrfProfileId": "NO_CSRF_BEARER", "idempotency": "safe", @@ -529,7 +514,7 @@ { "registryId": "FE-REG-SCHEMA", "owner": "feature-frontend-contract-schema-registry", - "source": "src/features/installed-feature-contracts.ts", + "source": "src/features/loaded-feature-runtimes.ts", "rowCount": 8, "contract": { "requiredFields": [ @@ -744,7 +729,7 @@ }, "VITE_BUILD_ID": { "classification": "public-metadata", - "defaultValue": null, + "defaultValue": "local-build", "phase": "build", "required": true }, @@ -812,7 +797,8 @@ "sessionStorage", "localStorage", "disabled", - "forbidden" + "forbidden", + "external" ], "classification": [ "public-preference", @@ -860,7 +846,7 @@ "valueCodec": "none" }, "CACHE_INVALIDATION_PULSE": { - "backend": "localStorage", + "backend": "external", "classification": "opaque-cache", "logicalName": "CACHE_INVALIDATION_PULSE", "migration": "discard", @@ -870,7 +856,7 @@ "schemaVersion": 1, "scope": "cache-invalidation", "ttl": null, - "valueCodec": "opaque-string-v1" + "valueCodec": "none" }, "CHUNK_RELOAD_GUARD": { "backend": "sessionStorage", @@ -1327,7 +1313,7 @@ "registryId": "FE-REG-TELEMETRY", "owner": "feature-frontend-diagnostics-telemetry-runtime", "source": "src/contracts/telemetry.ts", - "rowCount": 5, + "rowCount": 6, "contract": { "requiredFields": [ "eventName", @@ -1450,6 +1436,32 @@ "sampling": "all", "trigger": "release tuple mismatch" }, + "service-worker.start.failed": { + "delivery": "best-effort", + "eventName": "service-worker.start.failed", + "forbiddenAttributes": [ + "access_token", + "authorization_header", + "cookie", + "email", + "query_string", + "raw_url", + "raw_user_id", + "refresh_token", + "request_body", + "response_body", + "stack_in_user_message", + "storage_value", + "user_name" + ], + "optionalAttributes": [], + "requiredAttributes": [ + "build_id", + "error_kind" + ], + "sampling": "all", + "trigger": "Service Worker start ended FAILED or INCOMPATIBLE" + }, "telemetry.delivery.dropped": { "delivery": "best-effort", "eventName": "telemetry.delivery.dropped", diff --git a/config/contracts/registry-change-evidence.json b/config/contracts/registry-change-evidence.json index 4e03d4ed..62d2c3c4 100644 --- a/config/contracts/registry-change-evidence.json +++ b/config/contracts/registry-change-evidence.json @@ -1,53 +1,4 @@ { "schemaVersion": 1, - "changes": [ - { - "changeId": "FE-REG-ROUTE:REFERENCE_RESOURCE_DETAIL:path:field-changed", - "after": "/examples/reference-resources/items/:resourceId", - "versionBump": "The reference detail route moves from /examples/reference-resources/:resourceId to /examples/reference-resources/items/:resourceId (maturity review 08-13), so a server id equal to the static segments new or status opens its detail instead of the form or status screen.", - "migration": "The only in-app link (reference-resource-page.tsx) builds the new path from the contract route. The reference feature is a sample; downstream features that copied it keep their own paths.", - "compatibilityWindow": "None for bookmarked sample detail URLs: an old /examples/reference-resources/ URL no longer matches the detail route; new and status keep opening the form and status screens.", - "rollback": "Restore the previous path in src/features/reference-feature/contracts/reference-feature-contract.ts and the link in reference-resource-page.tsx, then drop this entry.", - "owner": "frontend-platform" - }, - { - "changeId": "FE-REG-STORAGE:CACHE_INVALIDATION_PULSE:backend:field-changed", - "after": "external", - "versionBump": "05-01 (maturity review 2026-11-01): the pulse row moves from backend localStorage to the new external backend. The cross-context invalidation adapter owns the value format, so getStorageDefinition refuses the key and StoragePort can no longer delete the raw pulse as a corrupt envelope.", - "migration": "None. Nothing reads or writes this key through StoragePort. The cross-context adapter keeps writing raw wire JSON to the unchanged physical key ca-frontend:cache-invalidation:v1:pulse.", - "compatibilityWindow": "No storage or wire format changes: deployed tabs keep exchanging the same raw pulse on the same key. Only StoragePort read/write/remove on CACHE_INVALIDATION_PULSE now fail instead of discarding or overwriting the pulse.", - "rollback": "Restore backend localStorage and valueCodec opaque-string-v1 on CACHE_INVALIDATION_PULSE in src/contracts/storage-keys.ts, drop the external backend checks there and in registry-governance.json, then drop this entry and its valueCodec sibling.", - "owner": "frontend-platform" - }, - { - "changeId": "FE-REG-STORAGE:CACHE_INVALIDATION_PULSE:valueCodec:field-changed", - "after": "none", - "versionBump": "05-01 (maturity review 2026-11-01): the pulse row drops valueCodec opaque-string-v1 for none. The stored value was never an opaque-string envelope; it is raw cross-context wire JSON.", - "migration": "None. Nothing reads or writes this key through StoragePort. The cross-context adapter keeps writing raw wire JSON to the unchanged physical key ca-frontend:cache-invalidation:v1:pulse.", - "compatibilityWindow": "No storage or wire format changes: deployed tabs keep exchanging the same raw pulse on the same key.", - "rollback": "Revert together with FE-REG-STORAGE:CACHE_INVALIDATION_PULSE:backend:field-changed.", - "owner": "frontend-platform" - }, - { - "changeId": "FE-REG-ROUTE:$contract:allowedValues:contract-field-changed", - "after": { - "access": ["public", "session-required"], - "errorSurface": ["feature-boundary", "not-found", "route-boundary"] - }, - "versionBump": "0929/07-03: FE-REG-ROUTE stops listing paramsSchema, searchSchema and loadingSurface values. A feature route with its own schema or loading surface no longer needs a governance edit.", - "migration": "None for existing routes: every value the lists held is still valid. paramsSchema and searchSchema stay checked against FE-REG-SCHEMA by references; loadingSurface is checked by fieldPatterns. A downstream that added its own values to these lists drops them at the next template sync.", - "compatibilityWindow": "No runtime change: the lists were read only by check:registries. access and errorSurface keep their closed lists.", - "rollback": "Restore the three lists in config/contracts/registry-governance.json, then drop this entry and its fieldPatterns sibling.", - "owner": "frontend-platform" - }, - { - "changeId": "FE-REG-ROUTE:$contract:fieldPatterns:contract-field-added", - "after": { "loadingSurface": "^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$" }, - "versionBump": "0929/07-03: FE-REG-ROUTE checks loadingSurface for a kebab-case name instead of a closed list. The value is only the data-surface attribute of the route loading element.", - "migration": "None: every installed loading surface is already kebab-case.", - "compatibilityWindow": "No runtime change: only check:registries reads the pattern.", - "rollback": "Revert together with FE-REG-ROUTE:$contract:allowedValues:contract-field-changed.", - "owner": "frontend-platform" - } - ] + "changes": [] } diff --git a/tests/unit/registry-governance.test.ts b/tests/unit/registry-governance.test.ts index 5efa4949..3f547496 100644 --- a/tests/unit/registry-governance.test.ts +++ b/tests/unit/registry-governance.test.ts @@ -343,6 +343,27 @@ describe("registry governance manifest", () => { }); }); + // The baseline diff compares contracts and rows, not `source`, so a moved + // registry (15-01 moved FE-REG-API and FE-REG-SCHEMA) left the approved + // baseline naming a file that no longer holds it. Re-approve after a move. + it("names each registry's governed source in the approved baseline", async () => { + const governance = JSON.parse( + await readFile("config/contracts/registry-governance.json", "utf8"), + ) as { registries: Array<{ registryId: string; path: string }> }; + const baseline = JSON.parse( + await readFile("config/contracts/registry-baseline.json", "utf8"), + ) as { registries: Array<{ registryId: string; source: string }> }; + const sources = new Map( + baseline.registries.map(({ registryId, source }) => [registryId, source]), + ); + expect( + governance.registries + .filter(({ registryId, path: source }) => sources.get(registryId) !== source) + .map(({ registryId }) => registryId), + "run update:registry-baseline after moving a registry", + ).toEqual([]); + }); + // 0929/07-01 (3). Re-approval makes the current snapshot the baseline, so it // explains every change the evidence described. Git history keeps the rows. it("deletes the evidence rows the new baseline explains when it re-approves", async () => {