Merge pull request 'fix(a11y): 수동 접근성 기록을 릴리스 태그로 대조하고 WCAG 2.2 칸을 더한다' (#48) from donghyeon.kang/fix/r9-a11y-evidence into main
frontend-quality-gates / merge / tests (push) Successful in 20m10s
frontend-quality-gates / FE-GATE-014 / config-compatibility (push) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (push) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (push) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (push) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (push) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (push) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (push) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (push) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (push) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (push) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (push) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (push) Canceled after 0s
frontend-quality-gates / main / self-tests and removal drills (push) Canceled after 0s
frontend-quality-gates / external-provenance-provider (push) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (push) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (push) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (push) Canceled after 0s
frontend-quality-gates / merge / browser tests (push) Canceled after 3m31s
frontend-quality-gates / merge / static checks (push) Successful in 2m30s
frontend-quality-gates / merge / tests (push) Successful in 20m10s
frontend-quality-gates / FE-GATE-014 / config-compatibility (push) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (push) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (push) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (push) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (push) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (push) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (push) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (push) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (push) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (push) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (push) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (push) Canceled after 0s
frontend-quality-gates / main / self-tests and removal drills (push) Canceled after 0s
frontend-quality-gates / external-provenance-provider (push) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (push) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (push) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (push) Canceled after 0s
frontend-quality-gates / merge / browser tests (push) Canceled after 3m31s
frontend-quality-gates / merge / static checks (push) Successful in 2m30s
This commit was merged in pull request #48.
This commit is contained in:
@@ -1620,6 +1620,8 @@ M4 Modal focus: pending
|
||||
M5 Error association: pending
|
||||
M6 Color signal: pending
|
||||
M7 Reduced motion: pending
|
||||
M8 Focus not obscured: pending
|
||||
M9 Target size: pending
|
||||
Screen reader: pending
|
||||
Notes: Human review pending. ${GENERATED}
|
||||
`;
|
||||
|
||||
@@ -12,6 +12,10 @@ const REVIEW_FIELDS = Object.freeze([
|
||||
"M5 Error association",
|
||||
"M6 Color signal",
|
||||
"M7 Reduced motion",
|
||||
// 1112/05-05. WCAG 2.2 AA criteria axe has no rule for (focus not obscured
|
||||
// 2.4.11) or covers only in part (target size 2.5.8).
|
||||
"M8 Focus not obscured",
|
||||
"M9 Target size",
|
||||
"Screen reader",
|
||||
]);
|
||||
|
||||
@@ -98,3 +102,21 @@ export function validateManualA11yEvidence(content: string) {
|
||||
passed: failures.length === 0,
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* 1112/05-01. A signed record is evidence for one release only: the release
|
||||
* tag the release job is building (`RELEASE_TAG`, e.g. `v1.4.0`). A record
|
||||
* signed for an earlier tag does not pass a later one. With no tag there is
|
||||
* nothing to compare with, so every record fails (fail-closed).
|
||||
*/
|
||||
export function releaseTagFailures(
|
||||
releaseTag: string | undefined,
|
||||
releaseId: string | null | undefined,
|
||||
): string[] {
|
||||
const tag = releaseTag?.trim() ?? "";
|
||||
if (tag === "") return ["no release tag to compare the Release ID with (RELEASE_TAG is empty)"];
|
||||
if (releaseId !== tag) {
|
||||
return [`Release ID ${releaseId ? `"${releaseId}"` : "(empty)"} is not the release tag "${tag}"`];
|
||||
}
|
||||
return [];
|
||||
}
|
||||
|
||||
@@ -3,6 +3,7 @@ import { mkdir, readFile } from "node:fs/promises";
|
||||
import { manualA11yReportArtifactSchema } from "./contracts/release-artifacts.ts";
|
||||
import {
|
||||
MANUAL_A11Y_ROUTE_IDS,
|
||||
releaseTagFailures,
|
||||
validateManualA11yEvidence,
|
||||
validateManualA11yRecordFormat,
|
||||
} from "./lib/manual-a11y-evidence.ts";
|
||||
@@ -39,15 +40,20 @@ if (process.argv.includes("--format-only")) {
|
||||
process.exit(0);
|
||||
}
|
||||
|
||||
// 1112/05-01. The release job passes the tag it is releasing (FE-GATE-028
|
||||
// declares RELEASE_TAG as required, so run-ci-gate refuses a run without it);
|
||||
// every record must be signed for that tag.
|
||||
const releaseTag = process.env.RELEASE_TAG;
|
||||
const results: ManualA11yResult[] = [];
|
||||
for (const routeId of MANUAL_A11Y_ROUTE_IDS) {
|
||||
const path = `docs/accessibility/route-reviews/${routeId}.md`;
|
||||
const evidence = await readFile(path, "utf8");
|
||||
const validation = validateManualA11yEvidence(evidence);
|
||||
const failures =
|
||||
validation.fields["Route ID"] === routeId
|
||||
? validation.failures
|
||||
: Object.freeze([...validation.failures, "Route ID mismatch"]);
|
||||
const failures = Object.freeze([
|
||||
...validation.failures,
|
||||
...(validation.fields["Route ID"] === routeId ? [] : ["Route ID mismatch"]),
|
||||
...releaseTagFailures(releaseTag, validation.fields["Release ID"]),
|
||||
]);
|
||||
results.push({
|
||||
routeId,
|
||||
path,
|
||||
@@ -55,7 +61,7 @@ for (const routeId of MANUAL_A11Y_ROUTE_IDS) {
|
||||
reviewedAt: validation.fields["Reviewed at"] ?? null,
|
||||
releaseId: validation.fields["Release ID"] ?? null,
|
||||
failures,
|
||||
passed: validation.passed && failures.length === 0,
|
||||
passed: failures.length === 0,
|
||||
});
|
||||
}
|
||||
const releaseIds = new Set(
|
||||
|
||||
Reference in New Issue
Block a user