chore(review): 1103 예제 화면·시각·접근성 조치 브랜치를 합친다
Refs: docs/reviews/2026-11-03-maturity-review/README.md 09-04 15-01 12-01 11-01 16-03 11-02 # Conflicts: # docs/architecture/frontend-application-foundation.md # docs/architecture/starter-experience.md # docs/manual/03-outside-feature-folder.md # tests/unit/runtime-adapters.test.ts
This commit is contained in:
@@ -59,8 +59,9 @@ if (!fixtureMode) {
|
||||
// from an ordinary `.message` read. Fixture mode runs the ESLint rule on the
|
||||
// fixture trees too, so this one gate shows the whole i18n contract rejecting
|
||||
// every forbidden file and passing the allowed one.
|
||||
// `src/presentation/examples` is the component gallery and stays out of scope
|
||||
// on purpose.
|
||||
// `src/presentation/examples` (the platform overview) and the example
|
||||
// screens (`src/features/platform-examples-feature/presentation`, 1103/09-04)
|
||||
// are workshop code and stay out of the ESLint rule's scope on purpose.
|
||||
const forbiddenFixtureRoot = "tests/fixtures/i18n/forbidden";
|
||||
const allowedFixtureRoot = "tests/fixtures/i18n/allowed";
|
||||
const sourceRoot = fixtureMode ? forbiddenFixtureRoot : ".";
|
||||
|
||||
@@ -23,6 +23,7 @@ import {
|
||||
assertSafePublishLeaf,
|
||||
ensureSafePublishDirectory,
|
||||
} from "./lib/ci-gate-log.ts";
|
||||
import { VISUAL_TEST_FONT_INSTALL_ARGUMENTS } from "./lib/visual-test-fonts.ts";
|
||||
|
||||
export type GenerateCiWorkflowOptions = Readonly<{
|
||||
root: string;
|
||||
@@ -196,7 +197,12 @@ function renderStep(
|
||||
return [
|
||||
" - name: Install Playwright browsers",
|
||||
...(job.kind === "gate-matrix" ? [" if: ${{ matrix.browser }}"] : []),
|
||||
" run: corepack pnpm exec playwright install --with-deps chromium firefox webkit",
|
||||
" run: |",
|
||||
" corepack pnpm exec playwright install --with-deps chromium firefox webkit",
|
||||
// 1103/11-02. The visual goldens' faces (tests/visual/fonts.conf) are
|
||||
// not among Playwright's dependencies. `--with-deps` has refreshed the
|
||||
// package lists; sudo only where the runner is not root.
|
||||
` $(command -v sudo || true) ${VISUAL_TEST_FONT_INSTALL_ARGUMENTS}`,
|
||||
];
|
||||
case "run-gate": {
|
||||
if (job.kind === "gate-matrix") {
|
||||
|
||||
@@ -0,0 +1,16 @@
|
||||
/**
|
||||
* 1103/11-02. The Debian/Ubuntu packages that hold the four faces the visual
|
||||
* goldens were captured with. `tests/visual/fonts.conf` shows Chromium only
|
||||
* their directories, Playwright's `--with-deps` does not install them, and
|
||||
* `tests/visual/fonts.setup.ts` fails with this list when one is missing. The
|
||||
* CI browser step (`scripts/generate-ci-workflow.ts`) installs the same list,
|
||||
* so the hint and the runner cannot name different packages.
|
||||
*/
|
||||
export const VISUAL_TEST_FONT_PACKAGES = Object.freeze([
|
||||
"fonts-noto-core",
|
||||
"fonts-noto-cjk",
|
||||
"fonts-noto-cjk-extra",
|
||||
"fonts-liberation",
|
||||
] as const);
|
||||
|
||||
export const VISUAL_TEST_FONT_INSTALL_ARGUMENTS = `apt-get install -y ${VISUAL_TEST_FONT_PACKAGES.join(" ")}`;
|
||||
Reference in New Issue
Block a user