fix(fixtures): keep pnpm in a linked fixture from installing (F-4)

pnpm verifies the install before a script, and a fixture running it with
CI=true against an install made without CI saw other settings and installed
through the linked .pnpm and .bin, rewriting the shared lock.yaml and shims.
Every fixture pnpm run now turns that check off; a test pins it for all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
donghyeon-ka
2026-09-27 13:20:12 +09:00
co-authored by Claude Opus 5.5
parent 66aca38179
commit a8520f6dfb
6 changed files with 177 additions and 9 deletions
@@ -41,7 +41,10 @@ import {
releaseCandidateManifestSchema,
} from "./lib/release-candidate.ts";
import { writeValidatedJsonArtifact } from "./lib/validated-json-artifact.ts";
import { linkFixtureNodeModules } from "./lib/fixture-node-modules.ts";
import {
FIXTURE_PNPM_ENVIRONMENT,
linkFixtureNodeModules,
} from "./lib/fixture-node-modules.ts";
const repositoryRoot = process.cwd();
const fixtureRoot = await mkdtemp(path.join(tmpdir(), "provider-exact-five-fixture-"));
@@ -74,6 +77,7 @@ try {
maxBuffer: 32 * 1024 * 1024,
env: {
...process.env,
...FIXTURE_PNPM_ENVIRONMENT,
CI: "true",
VITE_BUILD_ID: "provider-exact-five-fixture",
VITE_COMMIT_SHA: revision,
+14
View File
@@ -27,6 +27,20 @@ import path from "node:path";
* the linked directories. It is rewritten to name the fixture root instead:
* the packages are the repository's own, already validated.
*/
/**
* F-4. The environment for every `pnpm` a linked fixture runs. pnpm verifies
* the install before a script and, when the fixture's copied state disagrees
* with its own settings (for example `CI=true` against an install made
* without it), installs. `.pnpm` and `.bin` are links into the repository's
* node_modules, so that install rewrote the shared `.pnpm/lock.yaml` and bin
* shims. A fixture started through `pnpm <script>` inherits this setting from
* pnpm; one started directly (`node scripts/run-vitest.ts run <file>`) did not.
* The fixture uses the repository's packages as they are; it never installs.
*/
export const FIXTURE_PNPM_ENVIRONMENT = Object.freeze({
pnpm_config_verify_deps_before_run: "false",
});
export async function linkFixtureNodeModules(
fixtureRoot: string,
sourceRoot: string = process.cwd(),
+6 -3
View File
@@ -15,7 +15,10 @@ import {
loadCiGateContract,
parseCiGateContract,
} from "../contracts/ci-gates.ts";
import { linkFixtureNodeModules } from "./fixture-node-modules.ts";
import {
FIXTURE_PNPM_ENVIRONMENT,
linkFixtureNodeModules,
} from "./fixture-node-modules.ts";
import { generateCiWorkflow } from "../generate-ci-workflow.ts";
import { updateCiContractBaseline } from "../update-ci-contract-baseline.ts";
@@ -189,7 +192,7 @@ export function runRemovalFixtureCheck(
const status = spawnSync(process.execPath, [pnpmCli, script, ...extra], {
cwd: root,
stdio: "inherit",
env: process.env,
env: { ...process.env, ...FIXTURE_PNPM_ENVIRONMENT },
}).status;
return status === 0
? { name, passed: true }
@@ -243,7 +246,7 @@ export function runRemovalFixturePnpm(
return spawnSync(process.execPath, [pnpmCli, script, ...extra], {
cwd: root,
stdio: "inherit",
env: { ...process.env, ...env },
env: { ...process.env, ...FIXTURE_PNPM_ENVIRONMENT, ...env },
}).status === 0;
}