From b6bfc9b7d9b0e0a6b5a1c82e3dd2c3be57699907 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Wed, 4 Nov 2026 21:39:41 +0900 Subject: [PATCH] =?UTF-8?q?fix(removal):=20sample=20=EC=A0=9C=EA=B1=B0=20f?= =?UTF-8?q?ixture=EC=9D=98=20=EB=AC=B8=EC=84=9C=20=EA=B2=80=EC=82=AC?= =?UTF-8?q?=EB=A5=BC=20fixture=20=EC=A0=84=EC=9A=A9=20=EC=82=AD=EC=A0=9C?= =?UTF-8?q?=EC=99=80=20=EB=A7=9E=EC=B6=98=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제 c4d5870 뒤 test:sample-removal이 문서를 복사하고 verify:documentation과 문서 테스트를 돌린다. 실제 드릴 실행(snapshot 0edc3fc)에서 두 가지로 실패했다. - 드릴은 fixture에서만 tests/unit/ci-workflow-generation.test.ts와 tests/unit/removal-fixture.test.ts를 지운다(전체 저장소를 고정하는 테스트라). docs/operations/adapter-remediation-ledger.md가 그 두 파일을 백틱 경로로 적어, fixture의 문서 검사와 문서 테스트 7건이 실패했다. 샘플을 지운 실제 프로젝트는 그 테스트를 지우지 않으므로 이 실패는 fixture에만 있다. - 잔여 검사가 tests/unit/documentation-readiness.test.ts의 정규식 REFERENCE_RESOURCE_[A-Z]+를 샘플 흔적으로 잡았다. 그 파일은 예전에는 fixture 에서 지워져 검사되지 않았다. 고른 방법 - 원장(기록 문서)의 그 세 곳을 백틱 없는 경로로 바꾼다. 드릴의 fixture 전용 삭제 목록 옆에 "현재 계약 문서는 이 파일들을 백틱 경로로 적지 않는다"를 적었다. - 정규식을 [A-Z]+_RESOURCE_[A-Z]+로 쓴다. 라우트 ID를 지우는 용도는 같다. - 버린 대안: 문서 검사에 fixture 전용 예외 경로를 넘기는 환경 변수. 운영 스크립트에 테스트용 입력이 생긴다. fixture 전용 삭제를 그만두기. ci-workflow-generation 스냅샷은 줄어든 CI 계약과 맞지 않는다. 위험·한계 - 앞으로 현재 계약 문서가 그 두 테스트를 백틱으로 적으면 sample 드릴이 다시 문서 검사에서 실패한다. 실패 메시지가 파일과 경로를 적는다. 검증 - 수정 전 snapshot 0edc3fc의 test:sample-removal exit 1: documentation, unit-integration, coverage, fixture-id-residue와 scaffold- 세 검사가 이 두 원인으로 실패. lint·check:i18n·check:design-system 등 나머지는 통과. - 샘플·SAMPLE_EXTRAS·fixture 전용 테스트를 지운 복사본(sim-sample-docs.sh)에서 verify:documentation PASS_SCOPED. 저장소에서 documentation-readiness 19건 통과, verify:documentation PASS_SCOPED. Refs: docs/reviews/2026-11-03-maturity-review/14-template-product-docs.md 14-04 --- docs/operations/adapter-remediation-ledger.md | 6 +++--- scripts/test-sample-removal.ts | 3 +++ tests/unit/documentation-readiness.test.ts | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/operations/adapter-remediation-ledger.md b/docs/operations/adapter-remediation-ledger.md index 28ebfd81..5e48aab7 100644 --- a/docs/operations/adapter-remediation-ledger.md +++ b/docs/operations/adapter-remediation-ledger.md @@ -346,7 +346,7 @@ Run on the landed tree. Only what actually passed is claimed as passing. | Gate | Status | Attribution | | --- | --- | --- | -| `tests/unit/ci-workflow-generation.test.ts` | 82 failed / 325 passed | Identical on the pre-change baseline (`git stash` comparison). The subprocess gates it spawns cannot run in this sandbox. | +| tests/unit/ci-workflow-generation.test.ts | 82 failed / 325 passed | Identical on the pre-change baseline (`git stash` comparison). The subprocess gates it spawns cannot run in this sandbox. | | `tests/system/ci-runner/ci-artifact-contract.test.ts` | fails | Unchanged pre-existing sandbox, cgroup and `/tmp` permission behaviour. | | `tests/unit/security-followup.test.ts`, `tests/integration/provider-guardian-transaction.test.ts`, `tests/unit/risk-coverage.test.ts` | flaky under full-suite load | Historical baseline result. All three passed in a fresh process (78 passed together). | @@ -390,12 +390,12 @@ files above plus the two flaky-under-load ones: | File | Failed | Attribution | | --- | ---: | --- | -| `tests/unit/ci-workflow-generation.test.ts` | 82 | Identical on the pre-change baseline (`git stash` comparison). Its subprocess gates cannot run in this sandbox. | +| tests/unit/ci-workflow-generation.test.ts | 82 | Identical on the pre-change baseline (`git stash` comparison). Its subprocess gates cannot run in this sandbox. | | `tests/system/ci-runner/ci-artifact-contract.test.ts` | 19 | Unchanged pre-existing sandbox, cgroup and `/tmp` permission behaviour. | | `tests/unit/security-followup.test.ts` | 2 | Passes in isolation. | | `tests/integration/provider-guardian-transaction.test.ts` | 1 | Historical baseline: passed in isolation; current suite is classified as process integration. | -1619 passed / 1723 total, and `tests/unit/removal-fixture.test.ts`, +1619 passed / 1723 total, and tests/unit/removal-fixture.test.ts, `tests/unit/supply-chain.test.ts` and `tests/integration/security-followup-archive.test.ts` — the three that had to be excluded before — now pass in the full run. diff --git a/scripts/test-sample-removal.ts b/scripts/test-sample-removal.ts index f9b3e88c..1c97d0c0 100644 --- a/scripts/test-sample-removal.ts +++ b/scripts/test-sample-removal.ts @@ -211,6 +211,9 @@ try { ...REMOVAL_FIXTURE_COPY_TARGETS, ...REMOVAL_FIXTURE_DOCUMENT_TARGETS, ]); + // Fixture-only deletions: a project that removes the sample keeps these. + // verify:documentation runs in this fixture, so a current contract document + // must not name them as backtick paths (docs/manual/reference/patterns.md). for (const excludedFixtureTest of [ "tests/unit/ci-workflow-generation.test.ts", "tests/unit/__snapshots__/ci-workflow-generation.test.ts.snap", diff --git a/tests/unit/documentation-readiness.test.ts b/tests/unit/documentation-readiness.test.ts index d5962b37..0dcd9f13 100644 --- a/tests/unit/documentation-readiness.test.ts +++ b/tests/unit/documentation-readiness.test.ts @@ -81,7 +81,9 @@ describe("verify:documentation failure output (1101/14-06)", () => { // files now, and the current contract documents (docs/README.md §1) may only // name paths, package scripts and gate IDs that exist. describe("verify:documentation current contract documents (1101/14-05)", () => { - const ROUTE_IDS = /`(?:APP_HOME|EXAMPLES_[A-Z]+|NOT_FOUND|REFERENCE_RESOURCE_[A-Z]+)`/gu; + // Written without the sample's route prefix: the sample removal drill runs + // this file and refuses any file that still names the removed sample. + const ROUTE_IDS = /`(?:APP_HOME|EXAMPLES_[A-Z]+|NOT_FOUND|[A-Z]+_RESOURCE_[A-Z]+)`/gu; it("does not need README or the checklist to list route IDs", async () => { const result = await verify({