fix(ci): coverage 증거 검사가 summary의 branchesTrue를 받는다

문제
FE-GATE-005의 증거 검사(scripts/lib/ci-artifact-validator.ts)는
coverage-summary.json 항목마다 lines·statements·functions·branches만
허용하는 .strict() schema를 쓴다. istanbul-lib-coverage 3.2.2는 빈
summary에 branchesTrue를 항상 넣으므로 total에 그 키가 있다. 그래서
테스트가 모두 통과해도 증거 단계에서 게이트가 실패한다. 같은 파일을
읽는 risk-coverage 게이트는 이 키를 허용해 두 검사기가 갈라져 있었다.

고른 방법
- 키 목록을 scripts/lib/coverage-summary-metrics.ts 한 곳에 두고 두
  검사기가 같이 쓴다. 평가하는 네 지표와, 보고기가 더할 수 있는 선택
  지표(branchesTrue)를 나눴다. 선택 지표도 counter 형식(pct 정확성
  포함)은 그대로 검사한다.
- 버린 대안: validator schema에만 branchesTrue를 더하기. 지금 고장의
  원인(두 목록)이 그대로 남는다. 상수를 risk-coverage.ts에서
  export하기. validator가 @babel/eslint-parser까지 읽게 된다.

위험·한계
- 다른 미지의 키는 여전히 거절한다(의도). 보고기를 올리면 새 키가 생길
  수 있다.
- ci:gate FE-GATE-005 전체는 이 커밋에서 돌리지 않았다.

검증
- RED: 새 tests/unit/coverage-summary-artifact.test.ts 3건 중 2건 실패
  (Unrecognized key: "branchesTrue").
- 수정 뒤 coverage-summary-artifact·risk-coverage·risk-coverage-files
  44건 통과. check:types 통과, 바꾼 파일 eslint 통과.

Refs: docs/reviews/2026-11-03-maturity-review/README.md 12-09
This commit is contained in:
DongHyeonka
2026-11-04 20:22:13 +09:00
parent 004a205748
commit bca5fc2796
4 changed files with 112 additions and 15 deletions
+11 -6
View File
@@ -9,6 +9,10 @@ import type {
CiGateArtifactSchema,
} from "../contracts/ci-gates.ts";
import { ciContractReportSchema } from "./ci-contract-report.ts";
import {
COVERAGE_SUMMARY_METRICS,
COVERAGE_SUMMARY_OPTIONAL_METRICS,
} from "./coverage-summary-metrics.ts";
import {
architectureDependencyReportArtifactSchema,
automatedA11yArtifactSchema,
@@ -76,16 +80,17 @@ const coverageCounterSchema = z
context.addIssue({ code: "custom", path: ["pct"], message: "coverage pct is not exact" });
}
});
// 1103/12-09. The key list is shared with the risk coverage gate, which reads
// the same file; this schema used to refuse the `branchesTrue` the reporter
// always writes.
const coverageSummarySchema = z
.record(
z.string(),
z
.object({
lines: coverageCounterSchema,
statements: coverageCounterSchema,
functions: coverageCounterSchema,
branches: coverageCounterSchema,
})
.object(Object.fromEntries([
...COVERAGE_SUMMARY_METRICS.map((metric) => [metric, coverageCounterSchema]),
...COVERAGE_SUMMARY_OPTIONAL_METRICS.map((metric) => [metric, coverageCounterSchema.optional()]),
]))
.strict(),
)
.refine((value) => "total" in value, "coverage summary lacks total");
+24
View File
@@ -0,0 +1,24 @@
/**
* The keys of one entry in Vitest's `coverage-summary.json`. Two readers check
* that file: the CI evidence validator (ci-artifact-validator.ts) and the risk
* coverage gate (risk-coverage.ts). They kept separate lists, and the
* validator refused `branchesTrue` while the gate accepted it, so FE-GATE-005
* failed at its evidence step after every test had passed (1103/12-09).
*/
/** The four metrics both readers evaluate. */
export const COVERAGE_SUMMARY_METRICS = Object.freeze([
"lines",
"statements",
"functions",
"branches",
] as const);
/**
* Keys the reporter may add. istanbul-lib-coverage 3.2.2 puts `branchesTrue`
* in every blank summary, so the total always carries it. Each is still
* checked as a counter; neither reader evaluates it.
*/
export const COVERAGE_SUMMARY_OPTIONAL_METRICS = Object.freeze([
"branchesTrue",
] as const);
+11 -9
View File
@@ -8,14 +8,12 @@ import {
import path from "node:path";
import babelParser from "@babel/eslint-parser";
import {
COVERAGE_SUMMARY_METRICS as coverageMetrics,
COVERAGE_SUMMARY_OPTIONAL_METRICS,
} from "./coverage-summary-metrics.ts";
import { normalizeRepositoryRelativePath } from "./repository-file-inventory.ts";
const coverageMetrics = [
"lines",
"statements",
"functions",
"branches",
] as const;
const teamIdPattern = /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/u;
const maximumWaiverDurationMs = 90 * 24 * 60 * 60 * 1_000;
@@ -641,16 +639,20 @@ function parseCoverageCounter(value: unknown, label: string): CoverageCounter {
function parseCoverageMetrics(value: unknown, label: string): CoverageMetrics {
if (!isRecord(value)) throw new TypeError(`${label} must be an object`);
const optionalMetrics: readonly string[] = COVERAGE_SUMMARY_OPTIONAL_METRICS;
const unknownMetrics = Object.keys(value).filter(
(metric) => metric !== "branchesTrue" && !coverageMetrics.includes(metric as CoverageMetric),
(metric) =>
!optionalMetrics.includes(metric) && !coverageMetrics.includes(metric as CoverageMetric),
);
if (unknownMetrics.length > 0) {
throw new TypeError(
`${label} has unknown coverage metric keys: ${unknownMetrics.sort().join(", ")}`,
);
}
if (value.branchesTrue !== undefined) {
parseCoverageCounter(value.branchesTrue, `${label}.branchesTrue`);
for (const metric of optionalMetrics) {
if (value[metric] !== undefined) {
parseCoverageCounter(value[metric], `${label}.${metric}`);
}
}
const parsed = {} as Record<CoverageMetric, CoverageCounter>;
for (const metric of coverageMetrics) {