feat(auth): require readSubject so a token refresh keeps server state
An external owner without readSubject made every authenticated
notification (every token refresh) abort requests and clear the
server-state cache. readSubject is now a required owner method and
getSubject a required SessionGateway method.
- ExternalSessionOwner.readSubject(): required; the host owner check
(EXTERNAL_OWNER_METHODS) rejects an owner without it, so the session
fails closed as integration-failed like any other missing method.
- SessionGateway.getSubject(): required. Anonymous and unavailable
adapters return null; demo already returned its fixed user.
- Scope runtime: same (state, subject) still skips the fence; a state
or subject change still fences. An authenticated session with a
null/empty subject still fences (fail closed) and now records
cache.operation.failed {operation: SCOPE_FENCE, reason:
SUBJECT_MISSING} once per fence. Bootstrap passes diagnostics in.
- Docs: starter-experience external owner section and port comments
describe what readSubject returns, the fail-closed diagnostic and a
migration note.
RED before the change (vitest tests/unit/server-state-scope-runtime.test.ts
tests/unit/runtime-adapters.test.ts): 4 failed | 31 passed
- fails closed when the owner lacks readSubject:
expected 'authenticated' to be 'integration-failed'
- fences and reports SUBJECT_MISSING ... null / empty subject, and the
external owner whose readSubject returns null:
expected [] to deeply equal [[{ level: 'warn', ... }]]
- type level: an owner literal without readSubject compiled (tsc exit
0). The new @ts-expect-error pin fails check:types:test with TS2578
if readSubject becomes optional again.
Pins that stayed green: same-subject token refresh keeps the cache,
subject change fences, sign-out fences, owner missing readState is
rejected.
GREEN: check:architecture, check:types:app, check:types:test, lint,
test:unit (2084), test:component (182), test:reference-feature (59),
test:integration (151), verify:documentation, check:diagnostics,
check:ci all pass.
BREAKING: external auth owners must implement readSubject(); code that
implements AuthSessionPort/SessionGateway directly must implement
getSubject().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
4626b738e1
commit
c6300e9d40
@@ -1,4 +1,5 @@
|
||||
import type { AuthSessionPort } from "../../application/ports/auth-session-port.ts";
|
||||
import type { DiagnosticsPort } from "../../application/ports/diagnostics-port.ts";
|
||||
import type { QueryInvalidationCoordinator } from "../../contracts/query-invalidation.ts";
|
||||
import {
|
||||
createRuntimeIdentityRegistry,
|
||||
@@ -31,6 +32,8 @@ export type ServerStateScopeDependencies = Readonly<{
|
||||
session: Pick<AuthSessionPort, "subscribe"> &
|
||||
Partial<Pick<AuthSessionPort, "getState" | "getSubject">>;
|
||||
queryInvalidation: Pick<QueryInvalidationCoordinator, "resetLocal">;
|
||||
/** Hears about an authenticated session that could not name its subject. */
|
||||
diagnostics?: DiagnosticsPort;
|
||||
tokenFactory?: () => string;
|
||||
participants?: readonly ScopeResetParticipant[];
|
||||
activateNextGeneration?: () => void | Promise<void>;
|
||||
@@ -54,7 +57,7 @@ export function createServerStateScopeRuntime(
|
||||
let phase: ClientScopePhase = "READY";
|
||||
let disposed = false;
|
||||
let resetChain = Promise.resolve();
|
||||
let sessionIdentity = readSessionIdentity(dependencies.session);
|
||||
let sessionIdentity = readSessionIdentity(dependencies.session).identity;
|
||||
|
||||
function createSnapshot(): CacheScopeSnapshot {
|
||||
const capturedGeneration = generation;
|
||||
@@ -98,15 +101,18 @@ export function createServerStateScopeRuntime(
|
||||
// §10.6 is for identity-affecting changes only. A notification that keeps
|
||||
// (state, subject) — a token refresh, a repeated sign-out — must not abort
|
||||
// requests and clear the cache. A FAILED scope still retries its reset.
|
||||
const nextSessionIdentity = readSessionIdentity(dependencies.session);
|
||||
const next = readSessionIdentity(dependencies.session);
|
||||
if (
|
||||
nextSessionIdentity !== null &&
|
||||
nextSessionIdentity === sessionIdentity &&
|
||||
next.identity !== null &&
|
||||
next.identity === sessionIdentity &&
|
||||
phase !== "FAILED"
|
||||
) {
|
||||
return;
|
||||
}
|
||||
sessionIdentity = nextSessionIdentity;
|
||||
// The fence below is correct but costly: an owner that cannot name its
|
||||
// subject clears the cache on every token refresh. Make that visible.
|
||||
if (next.subjectMissing) reportSubjectMissing(dependencies.diagnostics);
|
||||
sessionIdentity = next.identity;
|
||||
const previousIdentities = identities;
|
||||
const previousGeneration = generation;
|
||||
|
||||
@@ -204,24 +210,41 @@ export function createServerStateScopeRuntime(
|
||||
}
|
||||
|
||||
/**
|
||||
* `null` means the identity cannot be proven unchanged: no `getState`, a
|
||||
* throwing owner, or an authenticated session without a non-empty subject.
|
||||
* Those always fence, which keeps an account switch from reusing the previous
|
||||
* cache.
|
||||
* A `null` identity cannot be proven unchanged: no `getState`, a throwing
|
||||
* owner, or an authenticated session without a non-empty subject (the last one
|
||||
* is flagged `subjectMissing`). Those always fence, which keeps an account
|
||||
* switch from reusing the previous cache.
|
||||
*/
|
||||
function readSessionIdentity(
|
||||
session: ServerStateScopeDependencies["session"],
|
||||
): string | null {
|
||||
): Readonly<{ identity: string | null; subjectMissing: boolean }> {
|
||||
try {
|
||||
const state = session.getState?.();
|
||||
if (state === undefined) return null;
|
||||
if (state === undefined) return { identity: null, subjectMissing: false };
|
||||
const subject = session.getSubject?.();
|
||||
const knownSubject =
|
||||
typeof subject === "string" && subject !== "" ? subject : null;
|
||||
if (state === "authenticated" && knownSubject === null) return null;
|
||||
return JSON.stringify([state, knownSubject]);
|
||||
if (state === "authenticated" && knownSubject === null) {
|
||||
return { identity: null, subjectMissing: true };
|
||||
}
|
||||
return {
|
||||
identity: JSON.stringify([state, knownSubject]),
|
||||
subjectMissing: false,
|
||||
};
|
||||
} catch {
|
||||
return null;
|
||||
return { identity: null, subjectMissing: false };
|
||||
}
|
||||
}
|
||||
|
||||
function reportSubjectMissing(diagnostics: DiagnosticsPort | undefined): void {
|
||||
try {
|
||||
diagnostics?.record({
|
||||
level: "warn",
|
||||
eventId: "cache.operation.failed",
|
||||
context: { operation: "SCOPE_FENCE", reason: "SUBJECT_MISSING" },
|
||||
});
|
||||
} catch {
|
||||
// The fence must run whether or not diagnostics works.
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user