diff --git a/recipes/frontend-capabilities/browser-file-session-capability.ts b/recipes/frontend-capabilities/browser-file-session-capability.ts index 04d95996..66c84b71 100644 --- a/recipes/frontend-capabilities/browser-file-session-capability.ts +++ b/recipes/frontend-capabilities/browser-file-session-capability.ts @@ -20,8 +20,17 @@ export type SessionBrowserFiles = Readonly<{ * * file-transfer is an opt-in recipe (`productionComposition: false`), so the * template does not build this. A product that installs a feature using it - * augments `FeaturePlatformCapabilities` with `files: SessionBrowserFiles` and - * returns both halves from `src/bootstrap/product-composition.ts`: + * types the capability in `src/features/product-capabilities.ts`, as + * `docs/manual/03-outside-feature-folder.md` says: + * + * export interface ProductFeaturePlatformCapabilities { + * readonly files: SessionBrowserFiles; + * } + * + * not with a `declare module` augmentation of `FeaturePlatformCapabilities`, + * whose key `check:types:node` does not see (1105/02-03). The feature lists + * `files` in `needs`, and the product returns both halves from + * `src/bootstrap/product-composition.ts`: * * const browserFiles = createSessionBrowserFileCapability(() => * createBrowserFileRuntime({ input, policies, limits, download }), diff --git a/tests/recipes/browser-file-session-capability.test.ts b/tests/recipes/browser-file-session-capability.test.ts index 1be69edd..568d0f14 100644 --- a/tests/recipes/browser-file-session-capability.test.ts +++ b/tests/recipes/browser-file-session-capability.test.ts @@ -9,7 +9,10 @@ import { type BrowserFilePolicyProfile, } from "../../src/adapters/browser-files/index.ts"; import { createRuntimeAdapters } from "../../src/bootstrap/runtime-adapters.ts"; -import { createSessionBrowserFileCapability } from "../../recipes/frontend-capabilities/browser-file-session-capability.ts"; +import { + createSessionBrowserFileCapability, + type SessionBrowserFiles, +} from "../../recipes/frontend-capabilities/browser-file-session-capability.ts"; import { testRuntimeConfig } from "../helpers/runtime-config.ts"; /** @@ -17,7 +20,9 @@ import { testRuntimeConfig } from "../helpers/runtime-config.ts"; * filling only its own `product-composition.ts`: the recipe capability goes to * features, its scope participant to the template. The real * `createRuntimeAdapters` runs; only the product-owned file is replaced, with - * what a product would write in it. + * what a product would write in it. 1105/02-03. The test drives the runtime + * through the capability the template hands the feature loaders, so dropping + * `files` from the composition's `capabilities` fails it. */ const selectPolicy = browserFilePolicyReference("session-file", "select-text"); @@ -57,6 +62,8 @@ const fixture = vi.hoisted(() => ({ files: undefined as | ReturnType["files"] | undefined, + /** What the template hands the installed features' loaders. */ + featureCapabilities: undefined as Readonly> | undefined, inputs: [] as HTMLInputElement[], handoffs: 0, owner: undefined as @@ -139,19 +146,37 @@ vi.mock("../../src/bootstrap/product-composition.ts", () => ({ ); fixture.files = browserFiles.files; return { - capabilities: {}, + capabilities: { files: browserFiles.files }, credentialProviders: {}, scopeParticipants: [browserFiles.scopeParticipant], }; }, })); +/** Records the capabilities features receive; the loaders run unchanged. */ +vi.mock("../../src/features/installed-feature-adapters.ts", async (importOriginal) => { + const original = + await importOriginal(); + return { + ...original, + createInstalledFeatureLoaders( + ...args: Parameters + ) { + fixture.featureCapabilities = args[0] as unknown as Readonly< + Record + >; + return original.createInstalledFeatureLoaders(...args); + }, + }; +}); + let current: Awaited> | undefined; afterEach(() => { current?.infrastructure.dispose(); current = undefined; for (const input of fixture.inputs.splice(0)) input.remove(); fixture.files = undefined; + fixture.featureCapabilities = undefined; fixture.handoffs = 0; }); @@ -202,9 +227,15 @@ async function compose() { }, host: {}, }); - const files = fixture.files; const owner = fixture.owner; - if (!files || !owner) throw new Error("The product composition did not run"); + if (!fixture.files || !owner) { + throw new Error("The product composition did not run"); + } + // What a feature that lists `files` in `needs` is given. + const files = fixture.featureCapabilities?.files as + | SessionBrowserFiles + | undefined; + if (!files) throw new Error("Features did not receive the files capability"); return { adapters: current, files, owner }; }