From d76653bfcdc3452ee2de0bab9b629d589e2998b8 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Sat, 26 Sep 2026 00:20:17 +0900 Subject: [PATCH] fix(browser-files): observe dismissals as DISMISSED instead of SUCCEEDED (02-06) A cancelled save dialog and a browser handoff were both recorded as DOWNLOAD SUCCEEDED, so the cancel rate hid inside the handoff success rate. BrowserDataObservation.outcome gains DISMISSED (additive). Co-Authored-By: Claude Opus 5.5 --- src/adapters/browser-files/file-observer.ts | 6 ++- .../ports/browser-file-storage/shared.ts | 3 +- tests/unit/browser-file-download.test.ts | 40 +++++++++++++++++++ 3 files changed, 46 insertions(+), 3 deletions(-) diff --git a/src/adapters/browser-files/file-observer.ts b/src/adapters/browser-files/file-observer.ts index e2026aa0..0e8de07d 100644 --- a/src/adapters/browser-files/file-observer.ts +++ b/src/adapters/browser-files/file-observer.ts @@ -17,7 +17,9 @@ type BrowserFileObservation = Readonly<{ /** * File adapters use the platform BrowserDataObserver as the telemetry SSOT. - * The helper below is the sole mapper from file-local dismissal semantics. + * The helper below is the sole mapper from file-local outcomes. A dismissal + * stays `DISMISSED` (02-06): folded into `SUCCEEDED` it hid the save-dialog + * cancel rate inside the browser handoff success rate. */ export type BrowserFileObserver = BrowserDataObserver; @@ -30,7 +32,7 @@ export function observeBrowserFile( Object.freeze({ operation: observation.operation, outcome: - observation.outcome === "FAILED" ? "FAILED" : "SUCCEEDED", + observation.outcome === "SUCCESS" ? "SUCCEEDED" : observation.outcome, ...(observation.failureCode ? { failureCode: observation.failureCode } : {}), diff --git a/src/application/ports/browser-file-storage/shared.ts b/src/application/ports/browser-file-storage/shared.ts index 0a83b2b7..53036420 100644 --- a/src/application/ports/browser-file-storage/shared.ts +++ b/src/application/ports/browser-file-storage/shared.ts @@ -96,7 +96,8 @@ export type BrowserDataResult = Result; export type BrowserDataObservation = Readonly<{ operation: BrowserDataOperation; - outcome: "SUCCEEDED" | "FAILED" | "DEGRADED"; + /** `DISMISSED`: the user closed a picker or save dialog; not a failure. */ + outcome: "SUCCEEDED" | "FAILED" | "DEGRADED" | "DISMISSED"; failureCode?: BrowserDataFailureCode; durationBucket?: "LT100MS" | "100_TO_499MS" | "500_TO_1999MS" | "GTE2000MS"; byteBucket?: "ZERO" | "LT1MIB" | "1_TO_9MIB" | "10_TO_99MIB" | "GTE100MIB"; diff --git a/tests/unit/browser-file-download.test.ts b/tests/unit/browser-file-download.test.ts index 933bb36b..db3782bf 100644 --- a/tests/unit/browser-file-download.test.ts +++ b/tests/unit/browser-file-download.test.ts @@ -605,6 +605,46 @@ describe("browser download delivery", () => { expect(events).toEqual(["hash", "write:2", "abort"]); }); + it("records a save-picker dismissal apart from a browser handoff (02-06)", async () => { + const records: unknown[] = []; + const adapter = createDownloadDeliveryAdapter({ + ...HARD_LIMITS, + policies, + host: { handoff: vi.fn() }, + browserManagedCapabilities: capabilityResolver( + (resourceId) => `/downloads/${resourceId}`, + ), + showSaveFilePicker: async () => { + throw new DOMException("dismissed", "AbortError"); + }, + baseOrigin: "https://app.example", + userActivation: { isActive: true }, + observer: { record: (observation) => records.push(observation) }, + }); + + await adapter.deliver( + deliveryInput( + { + kind: "BROWSER_MANAGED_RESOURCE", + resourceId: "artifact-1", + capabilityReceipt, + }, + "BROWSER_MANAGED", + ), + ); + await adapter.deliver( + deliveryInput( + { kind: "GENERATED", bytes: byteSource([new Uint8Array([1])]) }, + "PROMPT_AND_STREAM", + ), + ); + + expect(records).toEqual([ + { operation: "DOWNLOAD", outcome: "SUCCEEDED" }, + { operation: "DOWNLOAD", outcome: "DISMISSED" }, + ]); + }); + it("distinguishes save-picker dismissal from active cancellation", async () => { const dismissed = createDownloadDeliveryAdapter({ ...HARD_LIMITS,