fix: retain uncertain optimistic mutations

This commit is contained in:
DongHyeonka
2026-08-02 02:42:56 +09:00
parent 15645541b7
commit d9afccdd60
15 changed files with 2172 additions and 124 deletions
+1
View File
@@ -18,6 +18,7 @@ export type FormResultState =
| "success"
| "validation-error"
| "conflict"
| "effect-unknown"
| "unavailable";
export type MappedValidationFailure<Values extends FormValues> = Readonly<{
+28 -10
View File
@@ -135,6 +135,26 @@ export function useAppForm<
[defaultValues],
);
const settleSuccessfulValues = useCallback(
(settledValues: Values) => {
setFieldErrors({} as FieldErrors<Values>);
setFormErrors([]);
setResult("success");
if (resetOnSuccess) {
setValues(defaultValues);
setInitialValues(defaultValues);
setTouched(new Set());
} else {
setInitialValues(settledValues);
}
},
[defaultValues, resetOnSuccess],
);
const settleApplied = useCallback(() => {
settleSuccessfulValues(values);
}, [settleSuccessfulValues, values]);
const submitForm = useCallback(
async (event?: FormEvent<HTMLFormElement>): Promise<FormResult<Output> | null> => {
event?.preventDefault();
@@ -170,14 +190,7 @@ export function useAppForm<
try {
const outcome = await execution;
if (outcome.ok) {
setResult("success");
if (resetOnSuccess) {
setValues(defaultValues);
setInitialValues(defaultValues);
setTouched(new Set());
} else {
setInitialValues(parsed.data);
}
settleSuccessfulValues(parsed.data);
return outcome;
}
if (outcome.error.kind === "VALIDATION_REJECTED") {
@@ -190,6 +203,11 @@ export function useAppForm<
setFormErrors(mapped.formErrors);
setResult("validation-error");
focusFirstError(mapped.fieldErrors);
} else if (outcome.error.effect === "MAYBE_APPLIED") {
setFormErrors([]);
setResult("effect-unknown");
} else if (outcome.error.effect === "APPLIED_CONFIRMED") {
settleSuccessfulValues(parsed.data);
} else if (outcome.error.kind === "CONFLICT") {
setFormErrors([
message("form.conflict"),
@@ -207,12 +225,11 @@ export function useAppForm<
},
[
allowedServerFields,
defaultValues,
focusFirstError,
mapToCommand,
message,
resetOnSuccess,
schema,
settleSuccessfulValues,
submit,
values,
],
@@ -233,6 +250,7 @@ export function useAppForm<
setValue,
submitForm,
reset,
settleApplied,
});
}