fix: retain uncertain optimistic mutations
This commit is contained in:
@@ -71,6 +71,71 @@ describe("revision-safe optimistic layer runtime", () => {
|
||||
expect(client.getQueryData(key)).toEqual(["server", "pending"]);
|
||||
});
|
||||
|
||||
it("keeps later committed layers projected while an earlier effect is uncertain", () => {
|
||||
const client = new QueryClient();
|
||||
const key = ["query", "resources"];
|
||||
client.setQueryData(key, ["base"]);
|
||||
const selectedScope = scope();
|
||||
const runtime = createOptimisticLayerRuntime(client);
|
||||
const append = (previous: unknown, input: string) => [
|
||||
...(previous as string[]),
|
||||
input,
|
||||
];
|
||||
const first = runtime.begin(
|
||||
key,
|
||||
"first",
|
||||
append,
|
||||
selectedScope.snapshot,
|
||||
);
|
||||
const second = runtime.begin(
|
||||
key,
|
||||
"second",
|
||||
append,
|
||||
selectedScope.snapshot,
|
||||
);
|
||||
|
||||
first?.markUncertain();
|
||||
first?.commit();
|
||||
first?.rollback();
|
||||
second?.commit();
|
||||
expect(client.getQueryData(key)).toEqual(["base", "first", "second"]);
|
||||
|
||||
first?.reconcile("NOT_APPLIED");
|
||||
expect(client.getQueryData(key)).toEqual(["base", "second"]);
|
||||
});
|
||||
|
||||
it("collapses uncertain and later committed layers in order when reconciled as applied", () => {
|
||||
const client = new QueryClient();
|
||||
const key = ["query", "resources"];
|
||||
client.setQueryData(key, ["base"]);
|
||||
const selectedScope = scope();
|
||||
const runtime = createOptimisticLayerRuntime(client);
|
||||
const append = (previous: unknown, input: string) => [
|
||||
...(previous as string[]),
|
||||
input,
|
||||
];
|
||||
const first = runtime.begin(
|
||||
key,
|
||||
"first",
|
||||
append,
|
||||
selectedScope.snapshot,
|
||||
);
|
||||
const second = runtime.begin(
|
||||
key,
|
||||
"second",
|
||||
append,
|
||||
selectedScope.snapshot,
|
||||
);
|
||||
|
||||
first?.markUncertain();
|
||||
second?.commit();
|
||||
first?.reconcile("APPLIED");
|
||||
expect(client.getQueryData(key)).toEqual(["base", "first", "second"]);
|
||||
|
||||
first?.reconcile("NOT_APPLIED");
|
||||
expect(client.getQueryData(key)).toEqual(["base", "first", "second"]);
|
||||
});
|
||||
|
||||
it("removes scoped data instead of restoring it after scope expiry", () => {
|
||||
const client = new QueryClient();
|
||||
const key = ["query", "resources"];
|
||||
@@ -87,4 +152,24 @@ describe("revision-safe optimistic layer runtime", () => {
|
||||
layer?.rollback();
|
||||
expect(client.getQueryData(key)).toBeUndefined();
|
||||
});
|
||||
|
||||
it("does not restore an uncertain layer after its scope expires", () => {
|
||||
const client = new QueryClient();
|
||||
const key = ["query", "resources"];
|
||||
client.setQueryData(key, ["base"]);
|
||||
const selectedScope = scope();
|
||||
const runtime = createOptimisticLayerRuntime(client);
|
||||
const layer = runtime.begin(
|
||||
key,
|
||||
"uncertain",
|
||||
(previous, input) => [...(previous as string[]), input],
|
||||
selectedScope.snapshot,
|
||||
);
|
||||
layer?.markUncertain();
|
||||
|
||||
selectedScope.expire();
|
||||
layer?.reconcile("APPLIED");
|
||||
|
||||
expect(client.getQueryData(key)).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user