From dddf6353e0aa4a5f0d63de1cc263a4fe0d31a609 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Sun, 1 Nov 2026 21:57:42 +0900 Subject: [PATCH] =?UTF-8?q?test(contracts):=20=EC=9D=B4=EB=B2=A4=ED=8A=B8?= =?UTF-8?q?=20=EA=B3=84=EC=95=BD=20=EA=B2=80=EC=A6=9D=EC=9D=84=20=EC=8B=A4?= =?UTF-8?q?=EC=A0=9C=20=EC=9D=B4=EB=B2=A4=ED=8A=B8=20=ED=96=89=EC=9C=BC?= =?UTF-8?q?=EB=A1=9C=20=EA=B3=A0=EC=A0=95=ED=95=9C=EB=8B=A4=20(10-01)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제: "정확하지 않은 이벤트 계약을 거부한다" 테스트는 공용 fixture의 events가 빈 배열이라 첫 줄 `if (events.length === 0) return;`에서 끝난다. 단언이 하나도 실행되지 않는다. 그래서 composeContractContributions의 이벤트 snapshot(M17)이나 assertEventContract 호출(M18)을 빼도 관련 테스트가 모두 통과한다. 템플릿 안에는 이벤트를 기여하는 계약이 없어서 이 경로를 지키는 테스트가 따로 없다. 고른 방법: - tests/helpers/external-contract-fixture.ts에 TEST_EVENT_CONTRACT를 추가한다. 공용 TEST_CONTRACT_CONTRIBUTION의 events는 그대로 비워 둔다. 이 fixture를 쓰는 다른 테스트 20여 파일의 전제를 바꾸지 않기 위해서다. - 빈 배열이면 return하던 테스트를 지우고 "event contracts" 묶음을 둔다. 정상 행이 snapshot으로 설치되는지(같은 내용, 다른 객체, frozen) 먼저 확인해서 아래 거부 경우가 다른 이유로 throw하는 것이 아님을 보인다. 거부 경우는 HTTP 쪽 hostileRows처럼 모양(추가 필드, 다른 prototype, accessor)과 내용(빈 eventType, 공백, C1 제어문자, 160바이트 초과, validator 없음, 빈 schemaId), 중복 eventType이다. ContractContributionError로 던지는지까지 본다. 버린 대안: tests/setup.ts에 전역 expect.hasAssertions()를 두는 방법. 같은 종류의 빈 테스트를 모두 막지만 모든 vitest 프로젝트의 테스트 계약을 바꾸고, 리뷰는 빠른 계층 8개 폴더에서만 확인했다. 이 발견의 범위를 넘는다. 위험·한계: 템플릿 안에서 eventByType을 읽는 코드는 여전히 없다. 이 테스트는 composition 단계의 검증만 고정한다. 검증: - RED(변경 전 테스트 파일과 새 파일을 함께, 변이 적용): M17(snapshotEventContract가 입력을 그대로 반환) — 옛 파일 16개 통과, 새 파일 4개 실패("installs a well-formed event contract as its own snapshot", extra own field, custom prototype, accessor eventType). M18(assertEventContract 호출 제거) — 옛 파일 16개 통과, 새 파일 6개 실패(빈·공백·제어문자·160바이트 초과 eventType, validator 2종). - GREEN: node scripts/run-vitest.ts run tests/unit/contract-registry-immutability.test.ts — 26 passed. - related tests/helpers/external-contract-fixture.ts src/contracts/external-contract-runtime.ts — 97파일 796 passed. - tsc -p tsconfig.test.json, eslint(바꾼 2파일) 통과. Refs: docs/reviews/2026-11-01-maturity-review/10-tests-fast-layers.md 10-01 --- tests/helpers/external-contract-fixture.ts | 18 +++ .../contract-registry-immutability.test.ts | 107 +++++++++++++++--- 2 files changed, 111 insertions(+), 14 deletions(-) diff --git a/tests/helpers/external-contract-fixture.ts b/tests/helpers/external-contract-fixture.ts index b483e0b4..9c8ec981 100644 --- a/tests/helpers/external-contract-fixture.ts +++ b/tests/helpers/external-contract-fixture.ts @@ -3,6 +3,7 @@ import { z } from "zod"; import type { CommandEffectDescriptor, InstalledContractContribution, + InstalledEventContract, InstalledHttpContract, RuntimeValidator, } from "../../src/contracts/external-contract-runtime.ts"; @@ -197,6 +198,23 @@ export const TEST_CREATE_HTTP_CONTRACT: InstalledHttpContract< }), }); +/** + * An event contract an external package could install. The shared + * contribution below keeps `events` empty, so tests that check event + * composition put this row into a copy of it. + */ +export const TEST_EVENT_CONTRACT: InstalledEventContract< + Readonly<{ type: string; payload: unknown }>, + z.output +> = Object.freeze({ + eventType: "test.entity.changed", + envelopeValidator: zodValidator( + "TestEventEnvelope", + z.object({ type: z.string().min(1), payload: z.unknown() }).strip(), + ), + payloadValidator: zodValidator("TestEntity", entitySchema), +}); + export const TEST_CONTRACT_CONTRIBUTION: InstalledContractContribution = Object.freeze({ contributionId: "test-http-v1", diff --git a/tests/unit/contract-registry-immutability.test.ts b/tests/unit/contract-registry-immutability.test.ts index f62746c0..a248b2b9 100644 --- a/tests/unit/contract-registry-immutability.test.ts +++ b/tests/unit/contract-registry-immutability.test.ts @@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest"; import { composeContractContributions, + ContractContributionError, type ComposedContractContributions, } from "../../src/contracts/external-contract-runtime.ts"; import { @@ -9,7 +10,10 @@ import { INSTALLED_REST_AUTH_PROFILES, REST_AUTH_PROFILES, } from "../../src/contracts/rest-profiles.ts"; -import { TEST_CONTRACT_CONTRIBUTION } from "../helpers/external-contract-fixture.ts"; +import { + TEST_CONTRACT_CONTRIBUTION, + TEST_EVENT_CONTRACT, +} from "../helpers/external-contract-fixture.ts"; /** * LIVE-02 / LIVE-03. `Object.freeze(new Map(...))` freezes the wrapper object, @@ -318,20 +322,95 @@ describe("LIVE-03 composed contract registry", () => { ).toThrow(); } }); + }); - it("refuses an event contract whose own shape is not exact", () => { - const events = TEST_CONTRACT_CONTRIBUTION.events; - if (events.length === 0) return; - for (const event of [ - { ...events[0]!, injected: true }, - Object.assign(Object.create({ injected: true }), { ...events[0]! }), - ]) { - expect(() => - composeContractContributions([ - { ...TEST_CONTRACT_CONTRIBUTION, events: [event] }, - ] as never), - ).toThrow(); - } + describe("event contracts", () => { + // 10-01. The shared contribution has no events, so every case here puts + // TEST_EVENT_CONTRACT (or a broken copy of it) into a copy of it. + const withEvents = (...events: unknown[]) => + [{ ...TEST_CONTRACT_CONTRIBUTION, events }] as never; + + it("installs a well-formed event contract as its own snapshot", () => { + const composed = composeContractContributions( + withEvents(TEST_EVENT_CONTRACT), + ); + const installed = composed.eventByType.get(TEST_EVENT_CONTRACT.eventType); + expect(installed).toEqual(TEST_EVENT_CONTRACT); + expect(installed).not.toBe(TEST_EVENT_CONTRACT); + expect(Object.isFrozen(installed)).toBe(true); + expect(composed.contributions[0]!.events).toEqual([installed]); + }); + + const hostileEvents = [ + { + label: "an extra own field", + event: () => ({ ...TEST_EVENT_CONTRACT, injected: true }), + }, + { + label: "a custom prototype", + event: () => + Object.assign(Object.create({ injected: true }), { + ...TEST_EVENT_CONTRACT, + }), + }, + { + label: "an accessor eventType", + event: () => + Object.defineProperty({ ...TEST_EVENT_CONTRACT }, "eventType", { + enumerable: true, + get: () => TEST_EVENT_CONTRACT.eventType, + }), + }, + { + label: "an empty eventType", + event: () => ({ ...TEST_EVENT_CONTRACT, eventType: "" }), + }, + { + label: "an eventType with a space", + event: () => ({ ...TEST_EVENT_CONTRACT, eventType: "test entity" }), + }, + { + label: "an eventType with a control character", + event: () => ({ + ...TEST_EVENT_CONTRACT, + eventType: "test\u0085entity", + }), + }, + { + label: "an eventType over 160 UTF-8 bytes", + // 54 three-byte characters = 162 bytes in 54 UTF-16 units. + event: () => ({ ...TEST_EVENT_CONTRACT, eventType: "가".repeat(54) }), + }, + { + label: "a missing envelope validator", + event: () => ({ ...TEST_EVENT_CONTRACT, envelopeValidator: null }), + }, + { + label: "a payload validator without a schemaId", + event: () => ({ + ...TEST_EVENT_CONTRACT, + payloadValidator: { + ...TEST_EVENT_CONTRACT.payloadValidator, + schemaId: "", + }, + }), + }, + ]; + + for (const { label, event } of hostileEvents) { + it(`refuses an event contract with ${label}`, () => { + expect(() => composeContractContributions(withEvents(event()))).toThrow( + ContractContributionError, + ); + }); + } + + it("refuses two event contracts with the same eventType", () => { + expect(() => + composeContractContributions( + withEvents(TEST_EVENT_CONTRACT, { ...TEST_EVENT_CONTRACT }), + ), + ).toThrow(ContractContributionError); }); }); });