diff --git a/src/features/reference-feature/README.md b/src/features/reference-feature/README.md index 3fc8d7b0..392fffea 100644 --- a/src/features/reference-feature/README.md +++ b/src/features/reference-feature/README.md @@ -42,6 +42,15 @@ route codec과 URL builder는 `src/presentation/routes/route-codecs.ts`, route t 않는다. page는 HTTP client, storage, auth owner, output port나 TanStack API를 직접 import하지 않는다. +page는 경로 문자열을 적지 않는다. 경로는 계약의 `path` 한 곳에만 있다. +`presentation/reference-routes.ts`가 다음 helper를 둔다. 이 기능의 route codec은 +`presentation/reference-route-codecs.ts`에 있다. + +- 링크: `referenceRouteUrl(routeId, { params, search })`. 위 `buildRouteUrl`에 + 이 기능의 codec을 넘긴다. +- route 입력: `useReferenceListFilters()`, `useReferenceResourceId()`. 이미 + 통과한 codec으로 다시 읽어 cast 없이 타입을 얻는다. + ## 설치 지점 feature가 실제 contribution을 소유한다. diff --git a/src/features/reference-feature/context-routes.ts b/src/features/reference-feature/context-routes.ts index a36d5220..d5a214df 100644 --- a/src/features/reference-feature/context-routes.ts +++ b/src/features/reference-feature/context-routes.ts @@ -1,10 +1,8 @@ import type { RouteObject } from "react-router-dom"; import { REFERENCE_FEATURE_CONTRACT } from "./contracts/reference-feature-contract.ts"; -import { - REFERENCE_FEATURE_ROUTE_CODECS, - REFERENCE_FEATURE_ROUTE_RUNTIME, -} from "./presentation/reference-feature-runtime.ts"; +import { REFERENCE_FEATURE_ROUTE_RUNTIME } from "./presentation/reference-feature-runtime.ts"; +import { REFERENCE_FEATURE_ROUTE_CODECS } from "./presentation/reference-route-codecs.ts"; export const FEATURE_CONTEXT_ROUTES: readonly RouteObject[] = Object.freeze( Object.values(REFERENCE_FEATURE_CONTRACT.routes).map((definition) => { diff --git a/src/features/reference-feature/presentation/reference-feature-runtime.ts b/src/features/reference-feature/presentation/reference-feature-runtime.ts index 8d33baeb..133683eb 100644 --- a/src/features/reference-feature/presentation/reference-feature-runtime.ts +++ b/src/features/reference-feature/presentation/reference-feature-runtime.ts @@ -1,21 +1,9 @@ import { lazy } from "react"; import { REFERENCE_FEATURE_ID } from "../contracts/reference-feature-contract.ts"; -import { - referenceResourceListQuerySchema, - referenceResourceParamsSchema, -} from "../contracts/reference-schemas.ts"; - -/** - * 15-01. Route codecs travel with the context routes (`context-routes.ts` puts - * them on each route handle), not with the boot-time feature module: zod - * schemas are executable and the shell needs none of them before a reference - * route is entered. - */ -export const REFERENCE_FEATURE_ROUTE_CODECS = { - ReferenceResourceListQuery: referenceResourceListQuerySchema, - ReferenceResourceParams: referenceResourceParamsSchema, -} as const; +// 16-04. The codecs have their own file: the pages' link helpers need them and +// this file lazy-loads the pages, so a page importing it would close a cycle. +import { REFERENCE_FEATURE_ROUTE_CODECS } from "./reference-route-codecs.ts"; export const REFERENCE_FEATURE_ROUTE_RUNTIME = { REFERENCE_RESOURCE_LIST: Object.freeze({ diff --git a/src/features/reference-feature/presentation/reference-resource-detail-page.tsx b/src/features/reference-feature/presentation/reference-resource-detail-page.tsx index 29d6e9b3..20e1f551 100644 --- a/src/features/reference-feature/presentation/reference-resource-detail-page.tsx +++ b/src/features/reference-feature/presentation/reference-resource-detail-page.tsx @@ -4,15 +4,17 @@ import { AsyncSurface, DetailPage, } from "../../../presentation/design-system/index.ts"; -import { useRouteInput } from "../../../presentation/routes/route-input.tsx"; import { useLocale } from "../../../presentation/i18n/index.ts"; +import { + referenceRouteUrl, + useReferenceResourceId, +} from "./reference-routes.ts"; import { useReferenceFailureAction } from "./use-reference-failure-action.ts"; import { useReferenceDetail } from "./use-reference-feature.ts"; export default function ReferenceResourceDetailPage() { const { date, message } = useLocale(); - const route = useRouteInput(); - const resourceId = String(route.params.resourceId); + const resourceId = useReferenceResourceId(); const { query } = useReferenceDetail(resourceId); const resource = query.data; const failureAction = useReferenceFailureAction(query.state.failure); @@ -21,7 +23,7 @@ export default function ReferenceResourceDetailPage() { + {message("reference.list.resources")} } diff --git a/src/features/reference-feature/presentation/reference-resource-form-page.tsx b/src/features/reference-feature/presentation/reference-resource-form-page.tsx index 13d796d4..5661e415 100644 --- a/src/features/reference-feature/presentation/reference-resource-form-page.tsx +++ b/src/features/reference-feature/presentation/reference-resource-form-page.tsx @@ -23,6 +23,7 @@ import { toCreateReferenceCommand, type ReferenceResourceFormValues, } from "./reference-resource-form.ts"; +import { referenceRouteUrl } from "./reference-routes.ts"; import { useReferenceFailureAction } from "./use-reference-failure-action.ts"; import { useReferenceCreate } from "./use-reference-feature.ts"; @@ -71,7 +72,7 @@ export default function ReferenceResourceFormPage() { @@ -111,7 +112,7 @@ export default function ReferenceResourceFormPage() {